Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1935522444 > @weizhouapache, sorry for the late response! Unfortunately, I don't have an environment with shared mount point but the code LGTM thanks @slavkap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache merged PR #8481: URL: https://github.com/apache/cloudstack/pull/8481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1934380340 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1934245979 @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1934241947 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
DaanHoogland commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1919272620 > I don´t know, I didn't test it @GutoVeronezi sorry, I didn't read very well and answered hastely. Yes @GutoVeronezi, clgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1919143444 > Aside from the third-party testing, do we still need anything else on this one? > > cc: @DaanHoogland @weizhouapache @GutoVeronezi code looks ok to me. @slavkap can you please review and test it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
DaanHoogland commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1919107302 I don´t know, I didn't test it @GutoVeronezi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1919084553 Aside from the third-party testing, do we still need anything else on this one? cc: @DaanHoogland @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1886726914 > > Yes @GutoVeronezi, there are global settings to (1) notify users, or (2) disable new volume allocation, if allocated capacity or actual used capacity reaches a threshold. > > The thresholds are around 75% or 85%, so users have enough time to get more storage or clean the storage. > > ok, I thought only overprovisioned threshold would be signalled. I don't know of an extra guard on the actual threshold , but then again we would expect operators to do their due diligence. Sorry for the over-paranoia. no worries @DaanHoogland I think this is a frequently asked question for many users. ``` mysql> select name,default_value,description from configuration where name like "cluster.storage%" or name like "pool.storage%"; +--+---+--+ | name | default_value | description | +--+---+--+ | cluster.storage.allocated.capacity.notificationthreshold | 0.75 | Percentage (as a value between 0 and 1) of allocated storage utilization above which alerts will be sent about low storage available. | | cluster.storage.capacity.notificationthreshold | 0.75 | Percentage (as a value between 0 and 1) of storage utilization above which alerts will be sent about low storage available. | | cluster.storage.operations.exclude | false | Exclude cluster from storage operations | | pool.storage.allocated.capacity.disablethreshold | 0.85 | Percentage (as a value between 0 and 1) of allocated storage utilization above which allocators will disable using the pool for low allocated storage available. | | pool.storage.capacity.disablethreshold | 0.85 | Percentage (as a value between 0 and 1) of storage utilization above which allocators will disable using the pool for low storage available. | +--+---+--+ 5 rows in set (0.00 sec) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
DaanHoogland commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1886654348 > > > @GutoVeronezi could you target 4.18.2? > > > > > > @JoaoJandre, done. > > > code looks good. I have a worry though. overprovisioning on storage in general is a dangerous thing. On cpu and memory any errors due to overprovisioning are likely to not be fatal, but on storage these can easily lead to data loss. when storage is allocated but not used we can apply overprovisioning but when parts of it get used these should not be considered in overprovisioning. I don't think our model supports such behaviour. any ideas @GutoVeronezi @sureshanaparti (sorry, i don't know what wisdom is in respect to this) > > > > > > @DaanHoogland > > Sure, dealing with over-provisioning without caution can be harmful. Before changing the overprovisioning configurations, operators should understand how the environment is being consumed. Furthermore, it is important to have active monitoring over the environment; this way, it is possible to take actions, like the one @weizhouapache mentioned in [#8481 (comment)](https://github.com/apache/cloudstack/pull/8481#issuecomment-1884729728), to avoid problems. > > The configuration `cluster.storage.capacity.notificationthreshold` makes ACS notify the operators when the storage reaches the capacity threshold (for memory and CPU we have similar configurations). I am not sure if we have much more to do from the ACS perspective, but we can think about ways to improve this feature. > > Yes @GutoVeronezi, there are global settings to (1) notify users, or (2) disable new volume allocation, if allocated capacity or actual used capacity reaches a threshold. > > The thresholds are around 75% or 85%, so users have enough time to get more storage or clean the storage. ok, I thought only overprovisioned threshold would be signalled. I don't know of an extra guard on the actual threshold , but then again we would expect operators to do their due diligence. Sorry for the over-paranoia. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1885744384 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1885689032 > > @GutoVeronezi could you target 4.18.2? > > @JoaoJandre, done. > > > > code looks good. I have a worry though. overprovisioning on storage in general is a dangerous thing. On cpu and memory any errors due to overprovisioning are likely to not be fatal, but on storage these can easily lead to data loss. when storage is allocated but not used we can apply overprovisioning but when parts of it get used these should not be considered in overprovisioning. I don't think our model supports such behaviour. any ideas @GutoVeronezi @sureshanaparti (sorry, i don't know what wisdom is in respect to this) > > @DaanHoogland > Sure, dealing with over-provisioning without caution can be harmful. Before changing the overprovisioning configurations, operators should understand how the environment is being consumed. Furthermore, it is important to have active monitoring over the environment; this way, it is possible to take actions, like the one @weizhouapache mentioned in https://github.com/apache/cloudstack/pull/8481#issuecomment-1884729728, to avoid problems. > > The configuration `cluster.storage.capacity.notificationthreshold` makes ACS notify the operators when the storage reaches the capacity threshold (for memory and CPU we have similar configurations). I am not sure if we have much more to do from the ACS perspective, but we can think about ways to improve this feature. > > > Yes @GutoVeronezi, there are global settings to (1) notify users, or (2) disable new volume allocation, if allocated capacity or actual used capacity reaches a threshold. The thresholds are around 75% or 85%, so users have enough time to get more storage or clean the storage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1885643612 @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1885619281 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1885617851 > @GutoVeronezi could you target 4.18.2? @JoaoJandre, done. > code looks good. I have a worry though. overprovisioning on storage in general is a dangerous thing. On cpu and memory any errors due to overprovisioning are likely to not be fatal, but on storage these can easily lead to data loss. when storage is allocated but not used we can apply overprovisioning but when parts of it get used these should not be considered in overprovisioning. I don't think our model supports such behaviour. any ideas @GutoVeronezi @sureshanaparti (sorry, i don't know what wisdom is in respect to this) Sure, dealing with over-provisioning without caution can be harmful. Before changing the overprovisioning configurations, operators should understand how the environment is being consumed. Furthermore, it is important to have active monitoring over the environment; this way, it is possible to take actions, like the one @weizhouapache mentioned in https://github.com/apache/cloudstack/pull/8481#issuecomment-1884729728, to avoid problems. The configuration `cluster.storage.capacity.notificationthreshold` makes ACS notify the operators when the storage reaches the capacity threshold (for memory and CPU we have similar configurations). I am not sure if we have much more to do from the ACS perspective, but we can think about ways to improve this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
weizhouapache commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1884729728 > code looks good. I have a worry though. overprovisioning on storage in general is a dangerous thing. On cpu and memory any errors due to overprovisioning are likely to not be fatal, but on storage these can easily lead to data loss. when storage is allocated but not used we can apply overprovisioning but when parts of it get used these should not be considered in overprovisioning. I don't think our model supports such behaviour. any ideas @GutoVeronezi @sureshanaparti (sorry, i don't know what wisdom is in respect to this) @DaanHoogland I believe most cloudstack users use thin provisioning and storage overprovisioning. It was never a critical issue, there was no data loss either. If the storage is almost occupied, users should consider adding more storage before reaching full disk space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
JoaoJandre commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1884665993 @GutoVeronezi could you target 4.18.2? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
DaanHoogland commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1884424844 code looks good. I have a worry though. overprovisioning on storage in general is a dangerous thing. On cpu and memory any errors due to overprovisioning are likely to not be fatal, but on storage these can easily lead to data loss. when storage is allocated but not used we can apply overprovisioning but when parts of it get used these should not be considered in overprovisioning. I don't think our model supports such behaviour. any ideas @GutoVeronezi @sureshanaparti (sorry, i don't know what wisdom is in respect to this) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1883821515 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
codecov[bot] commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1883743790 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8481?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`d6ac91f`)](https://app.codecov.io/gh/apache/cloudstack/commit/d6ac91f2df0903737028f882f121edc8fe19b215?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.74% compared to head [(`8981243`)](https://app.codecov.io/gh/apache/cloudstack/pull/8481?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8481 +/- ## - Coverage 30.74% 4.39% -26.36% Files 5341 361 -4980 Lines374918 28622 -346296 Branches 545344993-49541 - Hits 1152861258 -114028 + Misses 244374 27225 -217149 + Partials 15258 139-15119 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8481/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8481/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8481/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8481/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8481?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
blueorangutan commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1883727927 @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi commented on PR #8481: URL: https://github.com/apache/cloudstack/pull/8481#issuecomment-1883725377 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Enable over provisioning for SharedMountPoint primary storages [cloudstack]
GutoVeronezi opened a new pull request, #8481:
URL: https://github.com/apache/cloudstack/pull/8481
### Description
ACS does not allow operators to set the configuration
`storage.overprovisioning.factor` for `SharedMountPoint` primary storages,
presenting the following message when one tries to change it:
Also, the global setting does not impact `SharedMoundPoint` primary
storages, which means that the over-provisioning is not applied properly for
this storage type.
Furthermore, the metric presents that the `SharedMountPoint` has the global
over-provisioning applied; however, in a scenario where the over-provision
factor is 2, the allocation threshold is 80%, and the metrics show that storage
has 40% allocated, one cannot allocate to it anymore.
This PR intends to enable over-provisioning for `SharedMountPoint` primary
storages.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
In an environment where the global over-provision factor was 1, the
allocation threshold was 80%, and the `SharedMountPoint` primary storage had
80% allocated, I was able to change the over-provisioning factor of the
`SharedMountPoint` primary storage and allocate a new volume on it, as, with
the over-provisioning, ACS considered it as having 40% allocated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
