Re: [PR] Fix error message for checkVolume command [cloudstack]
rohityadavcloud merged PR #8842: URL: https://github.com/apache/cloudstack/pull/8842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2033615284 [SF] Trillian test result (tid-9670) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 57606 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8842-t9670-kvm-alma9.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_list_system_vms_metrics_history | `Failure` | 0.27 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 3662.61 | test_metrics_api.py test_02_trigger_shutdown | `Failure` | 341.72 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2032019287 @vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
vishesh92 commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2032015553 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2027960232 [SF] Trillian test result (tid-9628) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 58677 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8842-t9628-kvm-alma9.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_08_arping_in_ssvm | `Failure` | 5.25 | test_diagnostics.py test_list_system_vms_metrics_history | `Failure` | 0.24 | test_metrics_api.py test_list_vms_metrics_admin | `Error` | 11.27 | test_metrics_api.py test_list_vms_metrics_history | `Error` | 5.83 | test_metrics_api.py test_list_vms_metrics_user | `Error` | 3657.75 | test_metrics_api.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
DaanHoogland commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-202736 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2027369482 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2025061400 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
blueorangutan commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2024950372 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
vishesh92 commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2024948069 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix error message for checkVolume command [cloudstack]
codecov[bot] commented on PR #8842: URL: https://github.com/apache/cloudstack/pull/8842#issuecomment-2024906252 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8842?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 4.38%. Comparing base [(`6c6023b`)](https://app.codecov.io/gh/apache/cloudstack/commit/6c6023b790c87f1b37f78bfacaababe202ef93bf?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`9782404`)](https://app.codecov.io/gh/apache/cloudstack/pull/8842?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8842 +/- ## - Coverage 30.13% 4.38% -25.76% Files 5355 361 -4994 Lines376690 28666 -348024 Branches 548155000-49815 - Hits 1135331258 -112275 + Misses 248185 27269 -220916 + Partials 14972 139-14833 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8842/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8842/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8842/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.38% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8842/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8842?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Fix error message for checkVolume command [cloudstack]
vishesh92 opened a new pull request, #8842:
URL: https://github.com/apache/cloudstack/pull/8842
### Description
This PR fixes the error message shown when the `checkVolume` command fails.
Before:
```json
{
"accountid": "f7a7493c-ecd7-11ee-a883-1e00a700045b",
"cmd":
"org.apache.cloudstack.api.command.user.volume.CheckAndRepairVolumeCmd",
"completed": "2024-03-28T10:34:49+",
"created": "2024-03-28T10:34:47+",
"jobid": "6f452658-b61d-4983-9528-87fd4b2f9f29",
"jobinstanceid": "2090adf0-5889-4299-95ea-e104074d9e9a",
"jobinstancetype": "Volume",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 530,
"errortext": "Unexpected exception"
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "f7a84e5a-ecd7-11ee-a883-1e00a700045b"
}
```
After:
```json
{
"accountid": "f7a7493c-ecd7-11ee-a883-1e00a700045b",
"cmd":
"org.apache.cloudstack.api.command.user.volume.CheckAndRepairVolumeCmd",
"completed": "2024-03-28T10:34:49+",
"created": "2024-03-28T10:34:47+",
"jobid": "6f452658-b61d-4983-9528-87fd4b2f9f29",
"jobinstanceid": "2090adf0-5889-4299-95ea-e104074d9e9a",
"jobinstancetype": "Volume",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 530,
"errortext": "Unexpected exception: Unable to find Up hosts to run the
check volume command"
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "f7a84e5a-ecd7-11ee-a883-1e00a700045b"
}
```
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
1. Disable all hosts
2. Run `checkVolume` command on a volume
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
