Re: [PR] NSX: Support ACL Rules re-ordering in NSX [cloudstack]
Pearl1594 closed pull request #8618: NSX: Support ACL Rules re-ordering in NSX URL: https://github.com/apache/cloudstack/pull/8618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: Support ACL Rules re-ordering in NSX [cloudstack]
Pearl1594 commented on PR #8618: URL: https://github.com/apache/cloudstack/pull/8618#issuecomment-2150506275 Already present in #7919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: Support ACL Rules re-ordering in NSX [cloudstack]
github-actions[bot] commented on PR #8618: URL: https://github.com/apache/cloudstack/pull/8618#issuecomment-1931313734 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NSX: Support ACL Rules re-ordering in NSX [cloudstack]
codecov[bot] commented on PR #8618: URL: https://github.com/apache/cloudstack/pull/8618#issuecomment-1930568969 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8618?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`09636cf`)](https://app.codecov.io/gh/apache/cloudstack/commit/09636cfcc878e17418f8c9925f1659a1c3403c04?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 15.86% compared to head [(`79b1490`)](https://app.codecov.io/gh/apache/cloudstack/pull/8618?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.36%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## nsx-integration #8618 +/- ## = - Coverage 15.86% 4.36% -11.51% = Files 5155 361 -4794 Lines 363466 28872 -334594 Branches 531925060-48132 = - Hits 576581259-56399 + Misses299000 27473 -271527 + Partials6808 140 -6668 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8618/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8618/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.36% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8618/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8618?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NSX: Support ACL Rules re-ordering in NSX [cloudstack]
Pearl1594 opened a new pull request, #8618:
URL: https://github.com/apache/cloudstack/pull/8618
### Description
This PR...
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
