Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-22 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2125931703

   [SF] Trillian test result (tid-10248)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 50810 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t10248-kvm-centos7.zip
   Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 421.49 | test_events_resource.py
   test_02_trigger_shutdown | `Failure` | 351.78 | test_safe_shutdown.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 446.44 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-22 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2124200287

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-22 Thread via GitHub


DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2124195491

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-21 Thread via GitHub


JoaoJandre commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2122423535

   @DaanHoogland could we try again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-20 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2120403581

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-20 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2120286034

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-20 Thread via GitHub


JoaoJandre commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2120284230

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-18 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2118678747

   [SF] Trillian Build Failed (tid-10208)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-18 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2118672446

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-18 Thread via GitHub


DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2118672091

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-16 Thread via GitHub


JoaoJandre commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2115826244

   @DaanHoogland could we rerun the CI here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-05-16 Thread via GitHub


JoaoJandre commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2115826519

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-17 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061276423

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9292


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-17 Thread via GitHub


JoaoJandre commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061121408

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-17 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2061123541

   @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2058102245

   [SF] Trillian test result (tid-9838)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 52231 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9838-kvm-centos7.zip
   Smoke tests completed. 126 look OK, 3 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 306.31 | test_events_resource.py
   test_01_events_resource | `Error` | 306.32 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 90.42 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.36 | 
test_network_permissions.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 439.87 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2058080569

   [SF] Trillian test result (tid-9839)
   Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
   Total time taken: 50419 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9839-kvm-alma9.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 323.90 | test_events_resource.py
   test_01_events_resource | `Error` | 323.91 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 90.35 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.48 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2057985912

   [SF] Trillian test result (tid-9835)
   Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
   Total time taken: 47181 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8908-t9835-kvm-rocky8.zip
   Smoke tests completed. 127 look OK, 2 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_events_resource | `Error` | 310.81 | test_events_resource.py
   test_01_events_resource | `Error` | 310.82 | test_events_resource.py
   test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 88.69 
| test_network_permissions.py
   ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | 
test_network_permissions.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056563022

   @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056562148

   @blueorangutan test alma9 kvm-alma9


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056464085

   [SF] Trillian Build Failed (tid-9831)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056420805

   @DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056419457

   @blueorangutan test rocky8 kvm-rocky8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056409514

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


DaanHoogland commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056407571

   @blueorangutan test 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2056114448

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


blueorangutan commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2055770305

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-15 Thread via GitHub


sureshanaparti commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2055759996

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-12 Thread via GitHub


codecov-commenter commented on PR #8908:
URL: https://github.com/apache/cloudstack/pull/8908#issuecomment-2052350103

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8908?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   Attention: Patch coverage is `0%` with `2 lines` in your changes are missing 
coverage. Please review.
   > Project coverage is 17.12%. Comparing base 
[(`a5508ac`)](https://app.codecov.io/gh/apache/cloudstack/commit/a5508acc54d1638ba469f4d7ce9898b81b5209d0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`42aea70`)](https://app.codecov.io/gh/apache/cloudstack/pull/8908?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 561 commits behind head on main.
   
   | 
[Files](https://app.codecov.io/gh/apache/cloudstack/pull/8908?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8908?src=pr=tree=engine%2Forchestration%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FVirtualMachineManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh)
 | 0.00% | [2 Missing :warning: 
](https://app.codecov.io/gh/apache/cloudstack/pull/8908?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 |
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main#8908  +/-   ##
   
   + Coverage 13.17%   17.12%   +3.95% 
   - Complexity 921415262+6048 
   
 Files  2725 4880+2155 
 Lines258235   327081   +68846 
 Branches  4024946227+5978 
   
   + Hits  3401356027   +22014 
   - Misses   219913   262982   +43069 
   - Partials   4309 8072+3763 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8908/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8908/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `17.12% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8908?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] Removed unnecessary migration of `ROOT` volumes with KVM [cloudstack]

2024-04-12 Thread via GitHub


JoaoJandre opened a new pull request, #8908:
URL: https://github.com/apache/cloudstack/pull/8908

   ### Description
   
   Using KVM as a hypervisor, when performing a live migration of a VM with its 
datadisks, the ROOT volume is also migrated, even if the user has not requested 
this action. Since this migration of the root volume is unnecessary and causes 
greater latency for the live migrate process, this behavior has been changed. 
Now, when migrating a VM and its datadisks, only the volumes selected for 
migration will actually be migrated.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   ### Description of tests
   
   A new VM was created with a root and a data volume for testing; Several live 
migration scenarios were tested. The cases are described below.
   
   The following migrations occurred successfully, in each case, when only the 
datadisk was moved, a dump of the VM XML was performed to verify that the ROOT 
volume had not been moved.
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | iSCSI2 |
   | DATA1 | iSCSI1 | --- |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | --- |
   | DATA1 | iSCSI1 | iSCSI2 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | iSCSI2 |
   | DATA1 | iSCSI1 | iSCSI2 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | Local |
   | DATA1 | iSCSI1 | Local |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | Local | iSCSI1 |
   | DATA1 | Local | iSCSI1 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | NFS1 |
   | DATA1 | iSCSI1 | NFS1 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | NFS1 |
   | DATA1 | iSCSI1 | --- |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | iSCSI1 | --- |
   | DATA1 | iSCSI1 | NFS1 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | NFS2 |
   | DATA1 | NFS1 | NFS2 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | Local |
   | DATA1 | NFS1 | Local |
   
   The following migrations ended in error. However, the error is expected, 
because, as described in #8907, when migrating the VM + volume and not 
migrating all NFS volumes, an error occurs. This error will be fixed in another 
PR.
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | Local |
   | DATA1 | NFS1 | --- |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | --- |
   | DATA1 | NFS1 | Local |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | NFS2 |
   | DATA1 | NFS1 | --- |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | NFS2 |
   | DATA1 | NFS1 | --- |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | ISCSI1 | --- |
   | DATA1 | NFS1 | ISCSI1 |
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | NFS1 | --- |
   | DATA1 | ISCSI1 | NFS1 |
   
   The following migration ended in error; however, this case is due to another 
bug that was also described in #8907: when migrating to an NFS storage, ACS 
will validate if the destination host has access to the source storage. This 
causes an issue when migrating from local storage to NFS storage, as the 
destination host will never have direct access to the source host's local 
storage. This bug will be fixed in another PR.
   
   | Volume | Origin | Destination |
   | -- | -- | -- |
   | ROOT | Local | NFS1 |
   | DATA1 | Local | NFS1 |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org