Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
andrijapanicsb commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1896545334 (For what is worth it - I've been told by a RH engineer (in 2019) that memory auto-ballooning is an abandoned project - so be careful with the feature) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
weizhouapache commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1896069953 > BTW: using the value 0 makes the monitoring stop working in KVM. worth to mention that I have faced an issue caused by it in the past . https://github.com/apache/cloudstack/issues/8453#issuecomment-1880956758 although @shaerul said it worked well in his testing, I think it would be better to enable/disable memory ballooning and statistics at vm level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
weizhouapache commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895976343 > The value of this configuration was originally proposed with `60` to avoid misunderstandings as the one that are happening with operators. However, this value has been modified, and there is no information regarding this change communicated clearly for operators. As a result, numerous users may be experiencing the same issue reported in #8453. It might be a good idea to follow the steps taken with this other configurations https://github.com/apache/cloudstack/pull/6803/commits/6c9e8a041bb20364d6ad4ee0e6f25e5a03e438f4, where the value of `vm.stats.max.retention.time` configuration was changed from `0` to `720` for the sake of simplicity for users/operators. Therefore, I suggest doing the same here, and if operators wish, they can modify the value to `0`. > > BTW: using the value 0 makes the monitoring stop working in KVM. we are free to change the default value in a PR, or before official release. Once the configuration is included in a official release, we should be careful to change the default value.@RodrigoDLopez -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
RodrigoDLopez commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895942157 The value of this configuration was originally proposed with `60` to avoid misunderstandings as the one that are happening with operators. However, this value has been modified, and there is no information regarding this change communicated clearly for operators. As a result, numerous users may be experiencing the same issue reported in #8453. It might be a good idea to follow the steps taken with this other configurations https://github.com/apache/cloudstack/pull/6803/commits/6c9e8a041bb20364d6ad4ee0e6f25e5a03e438f4, where the value of `vm.stats.max.retention.time` configuration was changed from `0` to `720` for the sake of simplicity for users/operators. Therefore, I suggest doing the same here, and if operators wish, they can modify the value to `0`. BTW: using the value 0 makes the monitoring stop working in KVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
andrijapanicsb commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895686704 many of the global settings are set to a certain value, many of them to 0 - and can be easily changed (like most of the other global settings). I prefer to keep it as it is, and allow operator to decide what to change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
weizhouapache commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895509170 this value can be set manually, or by ansible/chef/puppet. I prefer to leave users to decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
DaanHoogland commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895395130 @andrijapanicsb @alexandremattioli any ideas on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
codecov[bot] commented on PR #8520: URL: https://github.com/apache/cloudstack/pull/8520#issuecomment-1895393860 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8520?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`c3b77cb`)](https://app.codecov.io/gh/apache/cloudstack/commit/c3b77cb7b82bfe8e94b024e81e1721532da51a9c?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 18.28% compared to head [(`7a02a65`)](https://app.codecov.io/gh/apache/cloudstack/pull/8520?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8520 +/- ## - Coverage 18.28% 4.39% -13.89% Files 4848 361 -4487 Lines324301 28624 -295677 Branches 455614993-40568 - Hits 592901258-58032 + Misses 256437 27227 -229210 + Partials 8574 139 -8435 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8520/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8520/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8520/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8520?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Restores value of config vm_memballoon_stats_period back to 60 [cloudstack]
RodrigoDLopez opened a new pull request, #8520:
URL: https://github.com/apache/cloudstack/pull/8520
### Description
Currently, the default value for the `vm_memballoon_stats_period`
configuration is set to `0`. As a result, out of the box in ACS, memory metrics
for Windows instances (with virtio drivers correctly installed and configured)
is compromised when using KVM hypervisor. This pull request aims to propose
setting the `vm_memballoon_stats_period` configuration value to `60`. This
correction addresses situations such as the one reported through the issue:
https://github.com/apache/cloudstack/issues/8453.
- fixes: 8453
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
- Before changes:
- After changes:
### How Has This Been Tested?
A Windows VM was created, and it was confirmed that the VirtIO drivers were
correctly installed. However, upon inspecting the metrics collected by ACS, it
was observed that they did not align with the actual consumption of the VM.
Subsequently, after changing the configuration value from `0` to `60`, the
metrics collected by ACS matched the consumption values reported by the VM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
