Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
blueorangutan commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1875277512 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1875277140 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1875276964 @shwstppr I've also added a fix for #8432 on this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez commented on code in PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#discussion_r1440358496 ## ui/src/views/tools/ImportUnmanagedInstance.vue: ## @@ -111,7 +111,7 @@ - + Review Comment: Sorry this is not the same condition, we always want to display if for VMware but for KVM only if `!selectedVmwareVcenter && !isDiskImport && !isExternalImport` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
DaanHoogland commented on code in PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#discussion_r1440155528 ## ui/src/views/tools/ImportUnmanagedInstance.vue: ## @@ -111,7 +111,7 @@ - + Review Comment: this can be some kind of `[].contains()` structure, right? ```suggestion ``` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
blueorangutan commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1874311426 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8429 (QA-JID-249) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
blueorangutan commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1874292897 @nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1874291786 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
codecov[bot] commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1874009480 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8429?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`9d4f071`)](https://app.codecov.io/gh/apache/cloudstack/commit/9d4f0715d434c8ee1e064f8681093133241e34e2?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 30.80% compared to head [(`e9c82c6`)](https://app.codecov.io/gh/apache/cloudstack/pull/8429?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8429 +/- ## - Coverage 30.80% 4.39% -26.42% Files 5341 361 -4980 Lines374864 28622 -346242 Branches 545184992-49526 - Hits 1154851258 -114227 + Misses 244114 27225 -216889 + Partials 15265 139-15126 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8429/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8429/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8429/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8429/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8429?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez opened a new pull request, #8429:
URL: https://github.com/apache/cloudstack/pull/8429
### Description
This PR fixes the template selection regression for VMware Ingestion in the
UI on 4.19.0 RC1
Fixes: #8428
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Unmanage VM -> Import VM
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] UI: Fix VMware VM ingestion template selection [cloudstack]
nvazquez commented on PR #8429: URL: https://github.com/apache/cloudstack/pull/8429#issuecomment-1874001165 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
