Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-25 Thread via GitHub


DaanHoogland merged PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-08 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2043742589

   [SF] Trillian test result (tid-9747)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46102 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8883-t9747-kvm-centos7.zip
   Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-08 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2042251065

   @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) 
has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-08 Thread via GitHub


DaanHoogland commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2042250025

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-05 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2039918939

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-05 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2039759531

   @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It 
will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep 
you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-05 Thread via GitHub


sureshanaparti commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2039758075

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


gpordeus commented on code in PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#discussion_r1552206130


##
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##
@@ -4204,7 +4204,7 @@ public boolean deleteServiceOffering(final 
DeleteServiceOfferingCmd cmd) {
 }
 
 if (offering.getDefaultUse()) {
-throw new InvalidParameterValueException("Default service 
offerings cannot be deleted");
+throw new InvalidParameterValueException(String.format("The system 
service offerings [%s], is marked for default use and cannot be deleted", 
offering.getDisplayText()));

Review Comment:
   ```suggestion
   throw new InvalidParameterValueException(String.format("The 
system service offering [%s] is marked for default use and cannot be deleted", 
offering.getDisplayText()));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2037628236

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


blueorangutan commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2037477628

   @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


vishesh92 commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2037475271

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


vishesh92 commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2037473459

   @DaanHoogland I have changed the base to 4.18 according to the milestone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


codecov-commenter commented on PR #8883:
URL: https://github.com/apache/cloudstack/pull/8883#issuecomment-2037390436

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8883?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 4.32%. Comparing base 
[(`7a9985b`)](https://app.codecov.io/gh/apache/cloudstack/commit/7a9985b42bfdf43efb1a47f02ab58466936472ac?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 to head 
[(`4adb16c`)](https://app.codecov.io/gh/apache/cloudstack/pull/8883?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   > Report is 549 commits behind head on main.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main   #8883   +/-   ##
   
   - Coverage 13.17%   4.32%-8.85% 
   
 Files  2725 361 -2364 
 Lines258215   29121   -229094 
 Branches  402475108-35139 
   
   - Hits  340171260-32757 
   + Misses   219885   27719   -192166 
   + Partials   4313 142 -4171 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8883/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8883/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.32% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8883?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] explanatory error message on delete attempt of default system offering [cloudstack]

2024-04-04 Thread via GitHub


DaanHoogland opened a new pull request, #8883:
URL: https://github.com/apache/cloudstack/pull/8883

   
   ### Description
   
   This PR...
   
   
   
   
   
   
   
   Fixes: #8882 
   
   
   
   
   
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
    Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
    Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   
   
   
   
    How did you try to break this feature and the system with this change?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org