Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2079363901 [SF] Trillian test result (tid-10040) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51459 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8922-t10040-vmware-70u3.zip Smoke tests completed. 129 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 335.27 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2078063086 @weizhouapache a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
weizhouapache commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2078062164 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
weizhouapache commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077343937 test kvm-alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077319597 [SF] Trillian Build Failed (tid-10029) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2077087742 [SF] Trillian Build Failed (tid-10023) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076917654 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-80u1) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076914793 @blueorangutan test alma9 vmware-80u1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076896993 @DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076895886 @blueorangutan test kvm-alma9 vmware-80u1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076883478 @DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2076882492 @blueorangutan test kvm-alma9 vmware-80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2074738071 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2074734899 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on code in PR #8922:
URL: https://github.com/apache/cloudstack/pull/8922#discussion_r1570324614
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##
@@ -284,6 +285,7 @@ private void connectClientToVNCServer(String tunnelUrl,
String tunnelSession, St
try {
if (StringUtils.isNotBlank(websocketUrl)) {
s_logger.info(String.format("Connect to VNC over websocket
URL: %s", websocketUrl));
+ConsoleProxy.ensureRoute(NetUtils.extractHost(websocketUrl));
Review Comment:
I checked but UriUtils only deals with the class URI. I can move it though,
I don't think it matters much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
weizhouapache commented on code in PR #8922:
URL: https://github.com/apache/cloudstack/pull/8922#discussion_r1570278928
##
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVncClient.java:
##
@@ -284,6 +285,7 @@ private void connectClientToVNCServer(String tunnelUrl,
String tunnelSession, St
try {
if (StringUtils.isNotBlank(websocketUrl)) {
s_logger.info(String.format("Connect to VNC over websocket
URL: %s", websocketUrl));
+ConsoleProxy.ensureRoute(NetUtils.extractHost(websocketUrl));
Review Comment:
@DaanHoogland
`UriUtils` seems more suitable than `NetUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2058921244 @DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + vmware-80u1) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2058918530 @blueorangutan test rocky8 vmware-80u1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2058891083 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
blueorangutan commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2058773059 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] extract host from websocket to add route [cloudstack]
DaanHoogland commented on PR #8922: URL: https://github.com/apache/cloudstack/pull/8922#issuecomment-2058769878 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] extract host from websocket to add route [cloudstack]
DaanHoogland opened a new pull request, #8922:
URL: https://github.com/apache/cloudstack/pull/8922
### Description
This PR...
Fixes: #8921
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [x] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
