Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
DaanHoogland merged PR #8933: URL: https://github.com/apache/cloudstack/pull/8933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2071215122 [SF] Trillian test result (tid-9951) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51237 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8933-t9951-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 290.88 | test_events_resource.py test_01_events_resource | `Error` | 290.89 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 87.79 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.40 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069044029 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
DaanHoogland commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069041543 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2069028392 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2068891923 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
DaanHoogland commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2068889988 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on code in PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#discussion_r1574208574
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -306,12 +306,12 @@ protected void createTemplateWithinZones(TemplateProfile
profile, VMTemplateVO t
zonesIds =
_dcDao.listAllZones().stream().map(DataCenterVO::getId).collect(Collectors.toList());
}
-List imageStores =
getImageStoresThrowsExceptionIfNotFound(zonesIds, profile);
for (long zoneId : zonesIds) {
DataStore imageStore = verifyHeuristicRulesForZone(template,
zoneId);
if (imageStore == null) {
+List imageStores =
getImageStoresThrowsExceptionIfNotFound(List.of(zoneId), profile);
Review Comment:
@BryanMLima
yes, thanks. PR is updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
BryanMLima commented on code in PR #8933:
URL: https://github.com/apache/cloudstack/pull/8933#discussion_r1571419319
##
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##
@@ -306,12 +306,12 @@ protected void createTemplateWithinZones(TemplateProfile
profile, VMTemplateVO t
zonesIds =
_dcDao.listAllZones().stream().map(DataCenterVO::getId).collect(Collectors.toList());
}
-List imageStores =
getImageStoresThrowsExceptionIfNotFound(zonesIds, profile);
for (long zoneId : zonesIds) {
DataStore imageStore = verifyHeuristicRulesForZone(template,
zoneId);
if (imageStore == null) {
+List imageStores =
getImageStoresThrowsExceptionIfNotFound(List.of(zoneId), profile);
Review Comment:
@weizhouapache, just one remark, with these changes the method
`getImageStoresThrowsExceptionIfNotFound` does not need to receive a List,
could you refactor to receive only the zone ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2063407002 [SF] Trillian test result (tid-9887) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46469 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8933-t9887-kvm-rocky8.zip Smoke tests completed. 126 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 299.22 | test_events_resource.py test_01_events_resource | `Error` | 299.23 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 90.14 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.49 | test_network_permissions.py test_02_list_cpvm_vm | `Failure` | 0.05 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.05 | test_ssvm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2062092996 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2062089592 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061987889 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
blueorangutan commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061858935 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache closed pull request #8933: server: fix duplicated records for templates if there are multiple zones URL: https://github.com/apache/cloudstack/pull/8933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061852765 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache opened a new pull request, #8933:
URL: https://github.com/apache/cloudstack/pull/8933
### Description
This PR fixes #8928
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
How did you try to break this feature and the system with this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] server: fix duplicated records for templates if there are multiple zones [cloudstack]
weizhouapache commented on PR #8933: URL: https://github.com/apache/cloudstack/pull/8933#issuecomment-2061441566 This fixes a bug in #7659 cc @BryanMLima -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
