Re: [PR] Allow listing of inactive offerings [cloudstack]
DaanHoogland commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2036962708 for the error message issue see #8882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
DaanHoogland merged PR #8821: URL: https://github.com/apache/cloudstack/pull/8821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
vishesh92 commented on code in PR #8821:
URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1545318677
##
ui/src/config/section/offering.js:
##
@@ -89,15 +90,33 @@ export default {
dataView: true,
popup: true,
component: shallowRef(defineAsyncComponent(() =>
import('@/views/offering/UpdateOfferingAccess.vue')))
+ },
+ {
+api: 'updateServiceOffering',
+icon: 'play-circle-outlined',
+label: 'label.action.enable.service.offering',
+message: 'message.action.enable.service.offering',
+dataView: true,
+args: ['state'],
+mapping: {
+ state: {
+value: (record) => { return 'Active' }
+ }
+},
+groupAction: true,
+popup: true,
+show: (record) => { return record.state !== 'Active' },
+groupMap: (selection) => { return selection.map(x => { return { id: x,
state: 'Active' } }) }
}, {
api: 'deleteServiceOffering',
-icon: 'delete-outlined',
-label: 'label.action.delete.service.offering',
-message: 'message.action.delete.service.offering',
+icon: 'pause-circle-outlined',
Review Comment:
Because it's not actually deleting the service offering. Just changing the
state to inactive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
DaanHoogland commented on code in PR #8821:
URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1544650804
##
ui/src/config/section/offering.js:
##
@@ -89,15 +90,33 @@ export default {
dataView: true,
popup: true,
component: shallowRef(defineAsyncComponent(() =>
import('@/views/offering/UpdateOfferingAccess.vue')))
+ },
+ {
+api: 'updateServiceOffering',
+icon: 'play-circle-outlined',
+label: 'label.action.enable.service.offering',
+message: 'message.action.enable.service.offering',
+dataView: true,
+args: ['state'],
+mapping: {
+ state: {
+value: (record) => { return 'Active' }
+ }
+},
+groupAction: true,
+popup: true,
+show: (record) => { return record.state !== 'Active' },
+groupMap: (selection) => { return selection.map(x => { return { id: x,
state: 'Active' } }) }
}, {
api: 'deleteServiceOffering',
-icon: 'delete-outlined',
-label: 'label.action.delete.service.offering',
-message: 'message.action.delete.service.offering',
+icon: 'pause-circle-outlined',
Review Comment:
why would you want to change the icon for delete, @vishesh92 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
sureshanaparti commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2024632032 > > @vishesh92 Please add the view changes in upgrade path, Rest changes LGTM. > > The current listing behavior (with 'Active' state) is maintained in API / UI ? > > Views are now updated from their individual view sql files @sureshanaparti . These are processed during upgrade. Thanks for confirming @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
DaanHoogland commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2024627668 > @vishesh92 Please add the view changes in upgrade path, Rest changes LGTM. > > The current listing behavior (with 'Active' state) is maintained in API / UI ? Views are now updated from their individual view sql files @sureshanaparti . These are processed during upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
sureshanaparti commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1537564155 ## engine/schema/src/main/resources/META-INF/db/views/cloud.disk_offering_view.sql: ## @@ -76,7 +76,5 @@ FROM LEFT JOIN `cloud`.`disk_offering_details` AS `vsphere_storage_policy` ON `vsphere_storage_policy`.`offering_id` = `disk_offering`.`id` AND `vsphere_storage_policy`.`name` = 'storagepolicy' -WHERE -`disk_offering`.`state`='Active' Review Comment: add view changes in upgrade path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
sureshanaparti commented on code in PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#discussion_r1537563463 ## engine/schema/src/main/resources/META-INF/db/views/cloud.service_offering_view.sql: ## @@ -108,7 +109,5 @@ FROM LEFT JOIN `cloud`.`service_offering_details` AS `vsphere_storage_policy` ON `vsphere_storage_policy`.`service_offering_id` = `service_offering`.`id` AND `vsphere_storage_policy`.`name` = 'storagepolicy' -WHERE -`service_offering`.`state`='Active' Review Comment: add this view changes in upgrade path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2016312457 [SF] Trillian test result (tid-9561) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45672 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8821-t9561-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015090613 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
vishesh92 commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015089550 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2015045488 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
codecov[bot] commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014930265 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8821?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `17 lines` in your changes are missing coverage. Please review. > Project coverage is 4.39%. Comparing base [(`88017ad`)](https://app.codecov.io/gh/apache/cloudstack/commit/88017ad45e374b85cc8bab9c10b0c2658ef41cb0?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`6c28382`)](https://app.codecov.io/gh/apache/cloudstack/pull/8821?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8821?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [ui/src/config/section/offering.js](https://app.codecov.io/gh/apache/cloudstack/pull/8821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL2NvbmZpZy9zZWN0aW9uL29mZmVyaW5nLmpz) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [ui/src/views/AutogenView.vue](https://app.codecov.io/gh/apache/cloudstack/pull/8821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-dWkvc3JjL3ZpZXdzL0F1dG9nZW5WaWV3LnZ1ZQ==) | 0.00% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8821?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19 #8821 +/- ## - Coverage 30.89% 4.39% -26.51% Files 5355 361 -4994 Lines376649 28640 -348009 Branches 548084995-49813 - Hits 1163801258 -115122 + Misses 244951 27241 -217710 + Partials 15318 141-15177 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8821/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8821/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8821/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <0.00%> (-0.01%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8821/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8821?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
blueorangutan commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014922676 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow listing of inactive offerings [cloudstack]
vishesh92 commented on PR #8821: URL: https://github.com/apache/cloudstack/pull/8821#issuecomment-2014920600 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
