Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
rohityadavcloud merged PR #8800: URL: https://github.com/apache/cloudstack/pull/8800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2044120539 [SF] Trillian test result (tid-9759) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47374 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9759-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 292.22 | test_events_resource.py test_01_events_resource | `Error` | 292.23 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 89.92 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.38 | test_network_permissions.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042935753 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042928711 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042518073 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042399497 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042397099 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042338425 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042225152 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
sureshanaparti commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2042221613 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2041049279 [SF] Trillian test result (tid-9740) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47010 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9740-kvm-centos7.zip Smoke tests completed. 125 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 288.71 | test_events_resource.py test_01_events_resource | `Error` | 288.72 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 87.23 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.36 | test_network_permissions.py test_create_pvlan_network | `Error` | 0.07 | test_pvlan.py test_01_redundant_vpc_site2site_vpn | `Failure` | 397.83 | test_vpc_vpn.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040656168 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040654016 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040627062 [SF] Trillian test result (tid-9720) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 50313 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9720-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 412.26 | test_events_resource.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040528705 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040428705 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2040425363 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2039061318 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2039059912 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2039056132 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2038987673 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2038985434 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2038910500 [SF] Trillian test result (tid-9710) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46733 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9710-kvm-centos7.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 410.31 | test_events_resource.py test_01_reset_vm_on_reboot | `Error` | 7.24 | test_reset_vm_on_reboot.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2037486632 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2037485395 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036990697 [SF] Trillian Build Failed (tid-9697) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036737625 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036732900 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036586489 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036443957 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036440890 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2036417978 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2033041153 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032886851 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032883218 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032714569 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032712895 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032201514 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
codecov-commenter commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032066152 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8800?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `57.14286%` with `18 lines` in your changes are missing coverage. Please review. > Project coverage is 30.90%. Comparing base [(`0043540`)](https://app.codecov.io/gh/apache/cloudstack/commit/0043540fa301d2d817bcb30e2130f13ed85d797d?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`ec0790c`)](https://app.codecov.io/gh/apache/cloudstack/pull/8800?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 14 commits behind head on 4.19. > :exclamation: Current head ec0790c differs from pull request most recent head 60cb874. Consider uploading reports for the commit 60cb874 to get more accurate results | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8800?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FUserVmManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | 44.44% | [9 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...e/cloudstack/api/command/user/vm/RestoreVMCmd.java](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree=api%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Fapi%2Fcommand%2Fuser%2Fvm%2FRestoreVMCmd.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9jb21tYW5kL3VzZXIvdm0vUmVzdG9yZVZNQ21kLmphdmE=) | 33.33% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | | [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree=engine%2Forchestration%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FVirtualMachineManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8800?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8800 +/- ## - Coverage 30.99% 30.90% -0.10% + Complexity3436934272 -97 Files 5355 5355 Lines376630 376715 +85 Branches 5480754822 +15 - Hits 116741 116412 -329 - Misses 244535 244947 +412 - Partials 1535415356 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8800/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8800/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `24.72% <52.38%> (-0.14%)` | :arrow_down: | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8800/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.38% <ø> (-0.01%)` | :arrow_down: | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8800/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `16.57% <11.90%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032065773 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2032061052 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
DaanHoogland commented on code in PR #8800:
URL: https://github.com/apache/cloudstack/pull/8800#discussion_r1544657504
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -7642,27 +7644,52 @@ public UserVm restoreVM(RestoreVMCmd cmd) throws
InsufficientCapacityException,
long vmId = cmd.getVmId();
Long newTemplateId = cmd.getTemplateId();
+Long rootDiskOfferingId = cmd.getRootDiskOfferingId();
+Long rootDiskSize = cmd.getRootDiskSize();
+boolean expunge = cmd.getExpungeRootDisk();
+
+if (rootDiskSize != null && rootDiskSize < 0) {
+throw new InvalidParameterValueException("Invalid disk size " +
rootDiskSize);
+}
UserVmVO vm = _vmDao.findById(vmId);
if (vm == null) {
InvalidParameterValueException ex = new
InvalidParameterValueException("Cannot find VM with ID " + vmId);
ex.addProxyObject(String.valueOf(vmId), "vmId");
throw ex;
}
-
_accountMgr.checkAccess(caller, null, true, vm);
+DiskOffering diskOffering;
+if (rootDiskOfferingId != null) {
+diskOffering = _diskOfferingDao.findById(rootDiskOfferingId);
+if (diskOffering == null) {
+throw new InvalidParameterValueException("Cannot find disk
offering with ID " + rootDiskOfferingId);
+}
+DataCenterVO zone = dataCenterDao.findById(vm.getDataCenterId());
+_accountMgr.checkAccess(caller, diskOffering, zone);
+ServiceOfferingVO serviceOffering =
serviceOfferingDao.findById(vm.getServiceOfferingId());
+if (serviceOffering.getDiskOfferingStrictness() &&
!serviceOffering.getDiskOfferingId().equals(rootDiskOfferingId)) {
+throw new InvalidParameterValueException("VM's service
offering has a strict disk offering requirement, and the specified disk
offering does not match");
+}
+}
Review Comment:
can this go in a new method?
##
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##
@@ -7797,15 +7826,22 @@ public Pair doInTransaction(final
TransactionStatus status) th
} else {
newVol = volumeMgr.allocateDuplicateVolume(root,
null);
}
-newVols.add(newVol);
+
+VolumeVO resizedVolume = (VolumeVO) newVol;
if (userVmDetailsDao.findDetail(userVm.getId(),
VmDetailConstants.ROOT_DISK_SIZE) == null &&
!newVol.getSize().equals(template.getSize())) {
-VolumeVO resizedVolume = (VolumeVO) newVol;
if (template.getSize() != null) {
resizedVolume.setSize(template.getSize());
-_volsDao.update(resizedVolume.getId(),
resizedVolume);
}
}
+if (diskOffering != null) {
+
resizedVolume.setDiskOfferingId(diskOffering.getId());
+resizedVolume.setSize(diskOffering.getDiskSize());
+}
+if (rootDiskSize != null) {
+resizedVolume.setSize(rootDiskSize);
+}
+_volsDao.update(resizedVolume.getId(), resizedVolume);
Review Comment:
can these bits go in new methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2026122959 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2026014971 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2026013638 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2026013089 > Hi, @vishesh92, good change! > > Could you describe your tests? Have you tried it with a compute offering with `Disk offering strictness`? What about expunge permissions? I tested with compute only disk offering & with another disk offering. I didn't check/test with disk offering strictness. I have done a few changes to add the check for disk offering strictness & expunge permissions. Let me the test the changes again. I have changed the PR to draft for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
gpordeus commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2025825751 Hi, @vishesh92, good change! Could you describe your tests? Have you tried it with a compute offering with `Disk offering strictness`? What about expunge permissions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2021695878 [SF] Trillian test result (tid-9585) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47382 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8800-t9585-kvm-centos7.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_trigger_shutdown | `Failure` | 336.76 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2020088727 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
vishesh92 commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2020081989 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Allow overriding root disk offering & size, and expunge old root disk while restoring a VM [cloudstack]
blueorangutan commented on PR #8800: URL: https://github.com/apache/cloudstack/pull/8800#issuecomment-2020080032 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
