Re: [PR] Fix restore VM with allocated root disk [cloudstack]
rohityadavcloud merged PR #8977: URL: https://github.com/apache/cloudstack/pull/8977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080335049 [SF] Trillian test result (tid-10054) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 48698 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8977-t10054-kvm-rocky8.zip Smoke tests completed. 128 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 420.15 | test_events_resource.py test_01_restore_vm | `Error` | 0.28 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.20 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.32 | test_restore_vm.py test_02_trigger_shutdown | `Failure` | 346.99 | test_safe_shutdown.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2080246212 [SF] Trillian test result (tid-10050) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45290 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8977-t10050-kvm-centos7.zip Smoke tests completed. 129 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 415.40 | test_events_resource.py test_01_restore_vm | `Error` | 0.25 | test_restore_vm.py test_02_restore_vm_allocated_root | `Error` | 0.18 | test_restore_vm.py ContextSuite context=TestRestoreVM>:teardown | `Error` | 1.28 | test_restore_vm.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079323373 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079320521 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079221418 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079155754 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
sureshanaparti commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079153429 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079133328 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
borisstoyanov commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079104980 Thanks @vishesh92, let's wait the smoketests to come out and merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079101196 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2079099122 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078987029 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078986149 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078978369 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078835575 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2078834393 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
sureshanaparti commented on code in PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#discussion_r1580544655 ## server/src/main/java/com/cloud/vm/UserVmManagerImpl.java: ## @@ -7909,7 +7909,7 @@ public Pair doInTransaction(final TransactionStatus status) th // Detach, destroy and create the usage event for the old root volume. _volsDao.detachVolume(root.getId()); -_volumeService.destroyVolume(root.getId(), caller, expunge, false); +_volumeService.destroyVolume(root.getId(), caller, root.getState() == Volume.State.Allocated || expunge, false); Review Comment: ```suggestion _volumeService.destroyVolume(root.getId(), caller, Volume.State.Allocated.equals(root.getState()) || expunge, false); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077498151 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
codecov-commenter commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077347864 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review. > Project coverage is 15.67%. Comparing base [(`e409c6d`)](https://app.codecov.io/gh/apache/cloudstack/commit/e409c6d870a49762fb4e730ad118a3a836715cc5?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`fb496dc`)](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/8977?src=pr=tree=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fvm%2FUserVmManagerImpl.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8977?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8977 +/- ## + Coverage 14.96% 15.67% +0.70% - Complexity1099510997 +2 Files 5373 5010 -363 Lines468989 439818 -29171 Branches 6100955977-5032 - Hits 7019168945-1246 + Misses 391019 363230 -27789 + Partials 7779 7643 -136 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `?` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/8977/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `15.67% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8977?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
weizhouapache commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077268490 code looks good @vishesh92 Can you add 1-2 lines to one of the existing integration tests to cover this test case (restore vm twice)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
vishesh92 commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077233309 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix restore VM with allocated root disk [cloudstack]
blueorangutan commented on PR #8977: URL: https://github.com/apache/cloudstack/pull/8977#issuecomment-2077234570 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
