Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-12 Thread via GitHub


shwstppr merged PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-12 Thread via GitHub


shwstppr commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1888667345

   Merging based on manual testing and trillain results from backend,
   
   ```
   [SF] Trillian test result (tid-8811)
   
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
   
   Total time taken: 48240 seconds
   
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8492-t8811-vmware-67u3.zip
   
   Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
   
   Only failed and skipped tests results shown below:
   
   
   
   
   
   Test | Result | Time (s) | Test File
   
   --- | --- | --- | ---
   
   test_02_balanced_drs_algorithm | `Failure` | 138.23 | test_cluster_drs.py
   
   
   
   [SF] Trillian test result (tid-8810)
   
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   
   Total time taken: 43357 seconds
   
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8492-t8810-xenserver-71.zip
   
   Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
   
   Only failed and skipped tests results shown below:
   
   
   
   
   
   Test | Result | Time (s) | Test File
   
   --- | --- | --- | ---
   
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 308.71 | 
test_host_maintenance.py
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887572689

   @shwstppr a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, 
rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run 
smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


shwstppr commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887570213

   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887518374

   [SF] Trillian test result (tid-8786)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 56656 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8492-t8786-kvm-centos7.zip
   Smoke tests completed. 120 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 3621.31 | 
test_kubernetes_clusters.py
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | 
test_kubernetes_clusters.py
   test_10_vpc_tier_kubernetes_cluster | `Failure` | 55.98 | 
test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 116.55 | 
test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887372556

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887184736

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887182833

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887099172

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


shwstppr commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1887036684

   @nvazquez @DaanHoogland I retested case#9 from 
https://github.com/apache/cloudstack/pull/8492#issuecomment-1886874307 and it 
is failing as expected, therefore it all looks good on VMware side
   
   ```
   (localcloud)  > list vlanipranges id=3f69aecb-1aae-4f7e-b559-1e5c9eeac568 
   {
 "count": 1,
 "vlaniprange": [
   {
 "account": "system",
 "cidr": "10.8.0.0/24",
 "domain": "ROOT",
 "domainid": "a2138f1e-af98-11ee-847d-1e0058000a5d",
 "endip": "10.8.0.200",
 "forsystemvms": false,
 "forvirtualnetwork": false,
 "gateway": "10.8.0.1",
 "id": "3f69aecb-1aae-4f7e-b559-1e5c9eeac568",
 "netmask": "255.255.255.0",
 "networkid": "587d654e-fee0-49ab-a736-925e24d684c9",
 "physicalnetworkid": "c654f1ef-6047-4cd8-882b-f407dc604c4c",
 "startip": "10.8.0.101",
 "vlan": "2121",
 "zoneid": "b4a732bb-e837-4682-bbb9-b845b04a17dd"
   }
 ]
   }
   (localcloud)  > list unmanagedinstances 
clusterid=e3087b2f-8be7-4832-b8ef-61d7e25b27cf name=i-2-30-VM
   {
 "count": 1,
 "unmanagedinstance": [
   {
 "clusterid": "e3087b2f-8be7-4832-b8ef-61d7e25b27cf",
 "clustername": "p1-c1",
 "cpucorepersocket": 1,
 "cpunumber": 1,
 "cpuspeed": 0,
 "disk": [
   {
 "capacity": 52428800,
 "controller": "lsilogic",
 "controllerunit": 0,
 "datastorehost": "10.1.32.4",
 "datastorename": "5b2964142196369d96d6b95b6ad5e170",
 "datastorepath": 
"/acs/primary/ref-trl-5272-v-Mr8-abhishek-kumar/ref-trl-5272-v-Mr8-abhishek-kumar-esxi-pri1",
 "datastoretype": "NFS",
 "id": "15-2000",
 "imagepath": "[5b2964142196369d96d6b95b6ad5e170] 
i-2-30-VM/ROOT-30.vmdk",
 "label": "Hard disk 1",
 "position": 0
   }
 ],
 "hostid": "d178e42e-1c2e-452b-a572-eac1fd2fb11c",
 "hostname": "10.1.32.206",
 "memory": 512,
 "name": "i-2-30-VM",
 "nic": [
   {
 "adaptertype": "E1000",
 "id": "Network adapter 1",
 "macaddress": "02:01:00:cc:00:0d",
 "networkname": "cloud.guest.1747.200.1-vSwitch1",
 "vlanid": 1747
   }
 ],
 "osdisplayname": "Other Linux (64-bit)",
 "osid": "otherLinux64Guest",
 "powerstate": "PowerOn"
   }
 ]
   }
   (localcloud)  > import unmanagedinstance name=i-2-30-VM 
clusterid=e3087b2f-8be7-4832-b8ef-61d7e25b27cf displayname=erwewr 
zoneid=b4a732bb-e837-4682-bbb9-b845b04a17dd importsource=unmanaged 
hypervisor=vmware serviceofferingid=cec984be-1c57-468b-b1b1-94ea3cef705e 
nicnetworklist[0].nic=Network adapter 1 
nicnetworklist[0].network=51978449-5557-41f7-8642-35739fcc90ae 
nicipaddresslist[0].nic="Network adapter 1" 
nicipaddresslist[0].ip4Address=10.8.0.52
   {
 "account": "admin",
 "accountid": "c77ca2f3-af98-11ee-847d-1e0058000a5d",
 "cmd": 
"org.apache.cloudstack.api.command.admin.vm.ImportUnmanagedInstanceCmd",
 "completed": "2024-01-11T12:13:36+",
 "created": "2024-01-11T12:13:36+",
 "domainid": "a2138f1e-af98-11ee-847d-1e0058000a5d",
 "domainpath": "ROOT",
 "jobid": "2c50b7a2-fe40-4705-8fbd-be08eba1bf54",
 "jobprocstatus": 0,
 "jobresult": {
   "errorcode": 530,
   "errortext": "IP address 10.8.0.52 for NIC(ID: Network adapter 1) is not 
available in network(ID: 51978449-5557-41f7-8642-35739fcc90ae)"
 },
 "jobresultcode": 530,
 "jobresulttype": "object",
 "jobstatus": 2,
 "userid": "c77dbaa7-af98-11ee-847d-1e0058000a5d"
   }
    Error: async API failed for job 2c50b7a2-fe40-4705-8fbd-be08eba1bf54
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1886962842

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


DaanHoogland commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1886961239

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


shwstppr commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1886874307

   Tested the following cases for VMware VM import in an advanced zone:
   
   1. Import VM with single L2 network NIC - OK
   2. Import VM with single Isolated network NIC with auto IP assignment - OK
   3. Import VM with single Isolated network NIC with user-provided IP 
assignment - OK
   4. Import VM with single Isolated network NIC with user-provided already 
taken IP assignment - OK (Fails)
   5. Import VM with single Isolated network NIC with user-provided outside 
range IP assignment - OK (Fails)
   6. Import VM with single Shared network NIC with auto IP assignment - OK
   7. Import VM with single Shared network NIC with user-provided IP assignment 
- OK
   8. Import VM with single Shared network NIC with user-provided already taken 
IP assignment - OK (Fails)
   9. Import VM with single Shared network NIC with user-provided outside range 
IP assignment - OK? (Not sure if this should work)
   10. Import VM with a L2 network NIC and a shared network NIC with auto IP 
assignment - OK
   11. Import VM with an isolated network NIC and a shared network NIC with 
auto IP assignment - OK
   
   I guess we also allow VM deployment similar to case#9 (IP outside range)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-11 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1886868256

   @shwstppr I think we can have this fix without reverting the basic zone 
support, I have already verified basic and advanced KVM import in automatic and 
manual cases, will need to double check Vmware imports


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


shwstppr commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1886564071

   Lot many changes to core NIC import logic. This would need testing for both 
KVM and VMware for different scenarios - advanced/basic zone, with/without user 
provided IP, different network types.
   
   @nvazquez cc @DaanHoogland would it make sense to revert #8465 and document 
basic zone support as a limitation at this point? Common code for both KVM and 
VMware seems to be causing new regressions each day :smile: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885965965

   @nvazquez a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885947992

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885257968

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8278


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885150579

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885138017

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1885115760

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884940551

   Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 8275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884854940

   @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be 
bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


nvazquez commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884851987

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


codecov[bot] commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884825736

   ## 
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8492?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base 
[(`b8d3e34`)](https://app.codecov.io/gh/apache/cloudstack/commit/b8d3e342be2134cfe61a654ce2826ad0c1bc9b3e?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 30.67% compared to head 
[(`1548c5e`)](https://app.codecov.io/gh/apache/cloudstack/pull/8492?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 4.39%.
   > Report is 2 commits behind head on main.
   
   
   Additional details and impacted files
   
   
   ```diff
   @@ Coverage Diff  @@
   ##   main   #8492   +/-   ##
   
   - Coverage 30.67%   4.39%   -26.28% 
   
 Files  5341 361 -4980 
 Lines374940   28622   -346318 
 Branches  545384993-49545 
   
   - Hits 1150001258   -113742 
   + Misses   244716   27225   -217491 
   + Partials  15224 139-15085 
   ```
   
   | 
[Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8492/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | Coverage Δ | |
   |---|---|---|
   | 
[simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8492/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   | 
[uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8492/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `4.39% <ø> (ø)` | |
   | 
[unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8492/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
 | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8492?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


blueorangutan commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884823462

   @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will 
be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you 
posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Fixes for KVM unmanaged instances import on advanced network and VNC password [cloudstack]

2024-01-10 Thread via GitHub


DaanHoogland commented on PR #8492:
URL: https://github.com/apache/cloudstack/pull/8492#issuecomment-1884822906

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org