Re: [PR] field enlarged and db upgrade [cloudstack]
sureshanaparti commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2071618891 Merging this based on LGTMs / tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
sureshanaparti merged PR #8675: URL: https://github.com/apache/cloudstack/pull/8675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2071249259 [SF] Trillian test result (tid-9949) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52880 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9949-kvm-centos7.zip Smoke tests completed. 125 look OK, 4 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_events_resource | `Error` | 293.82 | test_events_resource.py test_01_events_resource | `Error` | 293.83 | test_events_resource.py test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 84.65 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.46 | test_network_permissions.py test_01_secure_vm_migration | `Error` | 133.78 | test_vm_life_cycle.py test_01_secure_vm_migration | `Error` | 133.79 | test_vm_life_cycle.py test_02_unsecure_vm_migration | `Error` | 0.02 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 0.02 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 0.02 | test_vm_life_cycle.py test_02_redundant_VPC_default_routes | `Failure` | 1900.56 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Failure` | 715.11 | test_vpc_redundant.py test_05_rvpc_multi_tiers | `Error` | 715.13 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2069036281 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2069031924 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2068959917 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2068831470 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2068829934 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on code in PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1574363696
##
engine/schema/src/main/resources/META-INF/db/schema-41900to41910.sql:
##
@@ -44,4 +48,4 @@ CREATE TABLE IF NOT EXISTS `cloud_usage`.`usage_vpc` (
PRIMARY KEY (`id`)
) ENGINE=InnoDB CHARSET=utf8;
-CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage', 'state',
'VARCHAR(100) DEFAULT NULL');
+CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage', 'state',
'VARCHAR(100) DEFAULT NULL');
Review Comment:
```suggestion
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage',
'state', 'VARCHAR(100) DEFAULT NULL');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on code in PR #8675:
URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1574363696
##
engine/schema/src/main/resources/META-INF/db/schema-41900to41910.sql:
##
@@ -44,4 +48,4 @@ CREATE TABLE IF NOT EXISTS `cloud_usage`.`usage_vpc` (
PRIMARY KEY (`id`)
) ENGINE=InnoDB CHARSET=utf8;
-CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage', 'state',
'VARCHAR(100) DEFAULT NULL');
+CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage', 'state',
'VARCHAR(100) DEFAULT NULL');
Review Comment:
```suggestion
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.cloud_usage',
'state', 'VARCHAR(100) DEFAULT NULL');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
github-actions[bot] commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2068743637 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2035842690 [SF] Trillian test result (tid-9683) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 51110 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9683-kvm-alma9.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
codecov-commenter commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2034056646 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8675?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `0%` with `2 lines` in your changes are missing coverage. Please review. > Project coverage is 31.00%. Comparing base [(`6c6023b`)](https://app.codecov.io/gh/apache/cloudstack/commit/6c6023b790c87f1b37f78bfacaababe202ef93bf?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`839331e`)](https://app.codecov.io/gh/apache/cloudstack/pull/8675?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 2 commits behind head on 4.19. | [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8675?dropdown=coverage=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...ava/com/cloud/upgrade/dao/Upgrade41900to41910.java](https://app.codecov.io/gh/apache/cloudstack/pull/8675?src=pr=tree=engine%2Fschema%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fupgrade%2Fdao%2FUpgrade41900to41910.java_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDE5MDB0bzQxOTEwLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/8675?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.19#8675 +/- ## + Coverage 30.13% 31.00% +0.86% - Complexity3307234391+1319 Files 5355 5355 Lines376690 376691 +1 Branches 5481554815 + Hits 113533 116788+3255 + Misses 248185 244552-3633 - Partials 1497215351 +379 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [simulator-marvin-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `24.86% <0.00%> (+1.18%)` | :arrow_up: | | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.38% <ø> (ø)` | | | [unit-tests](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `16.58% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8675?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2034053436 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2034045963 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2034024308 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2033878610 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2033876102 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2033371267 [SF] Trillian test result (tid-9653) Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9 Total time taken: 54753 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9653-kvm-alma9.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_redundant_VPC_default_routes | `Failure` | 445.00 | test_vpc_redundant.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
weizhouapache commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2032569396 > > @DaanHoogland > > > > ``` > > final String scriptFile = "META-INF/db/schema-41900to41910.sql"; > > ``` > > yes? The new file in this PR is engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql Not 41900 "to" 41910 @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2032410152 > @DaanHoogland > > ``` > final String scriptFile = "META-INF/db/schema-41900to41910.sql"; > ``` yes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
weizhouapache commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2031610362 @DaanHoogland ``` final String scriptFile = "META-INF/db/schema-41900to41910.sql"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2031521832 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2031520533 @blueorangutan test alma9 kvm-alma9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2027532172 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2027456089 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2027455271 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2024672227 Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 9070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2024580766 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2024578185 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2014296561 [SF] Trillian test result (tid-9548) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9 Total time taken: 54108 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9548-vmware-70u3.zip Smoke tests completed. 128 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_02_upgrade_kubernetes_cluster | `Failure` | 134.62 | test_kubernetes_clusters.py test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 174.34 | test_kubernetes_clusters.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2012113121 @DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2012108978 @blueorangutan test alma9 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2001702809 [SF] Trillian test result (tid-9500) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 56750 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9500-vmware-67u3.zip Smoke tests completed. 127 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_deploy_vm_for_other_user_and_test_vm_operations | `Failure` | 71.16 | test_network_permissions.py ContextSuite context=TestNetworkPermissions>:teardown | `Error` | 1.44 | test_network_permissions.py test_01_single_VPC_iptables_policies | `Error` | 307.19 | test_routers_iptables_default_policy.py -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2001331735 [SF] Trillian test result (tid-9501) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49081 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9501-kvm-centos7.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-2001299128 [SF] Trillian test result (tid-9499) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48653 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8675-t9499-xenserver-71.zip Smoke tests completed. 129 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1999612409 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1999610781 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1988786459 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
blueorangutan commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1988642983 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1988637526 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
github-actions[bot] commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1981363459 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1954217114 @weizhouapache there is another PR out that also adds the 4.19.0 to 4.19.1 upgrade path #8591 so I was waiting for that to be merged, but it has an error in a library: https://github.com/apache/cloudstack/actions/runs/7971971809/job/21762739407?pr=8591#step:10:9596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on code in PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1495817753 ## engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql: ## @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, +-- software distributed under the License is distributed on an +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +-- KIND, either express or implied. See the License for the +-- specific language governing permissions and limitations +-- under the License. + +--; +-- Schema upgrade from 4.19.0.0 to 4.19.1.0 +--; + +ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; Review Comment: ```suggestion ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
DaanHoogland commented on code in PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1495817753 ## engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql: ## @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, +-- software distributed under the License is distributed on an +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +-- KIND, either express or implied. See the License for the +-- specific language governing permissions and limitations +-- under the License. + +--; +-- Schema upgrade from 4.19.0.0 to 4.19.1.0 +--; + +ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; Review Comment: ```suggestion ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
weizhouapache commented on code in PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1495617364 ## engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql: ## @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, +-- software distributed under the License is distributed on an +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +-- KIND, either express or implied. See the License for the +-- specific language governing permissions and limitations +-- under the License. + +--; +-- Schema upgrade from 4.19.0.0 to 4.19.1.0 +--; + +ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; Review Comment: EOF need to be fixed other than it, all else looks good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
weizhouapache commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1952595551 @DaanHoogland there are several `UnusedImports` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
codecov[bot] commented on PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#issuecomment-1952417397 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8675?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Comparison is base [(`1a11311`)](https://app.codecov.io/gh/apache/cloudstack/commit/1a1131154ef27e0f5491ceb249eded7fd810c021?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39% compared to head [(`b96ac6b`)](https://app.codecov.io/gh/apache/cloudstack/pull/8675?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) 4.39%. Additional details and impacted files ```diff @@ Coverage Diff @@ ##4.19 #8675 +/- ## = Coverage 4.39% 4.39% = Files361 361 Lines 28634 28634 Branches49964996 = Hits12581258 Misses 27237 27237 Partials 139 139 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flags_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/8675/flags?src=pr=flag_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | `4.39% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8675?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] field enlarged and db upgrade [cloudstack]
weizhouapache commented on code in PR #8675: URL: https://github.com/apache/cloudstack/pull/8675#discussion_r1494225126 ## engine/schema/src/main/resources/META-INF/db/schema-41900-41910.sql: ## @@ -0,0 +1,22 @@ +-- Licensed to the Apache Software Foundation (ASF) under one +-- or more contributor license agreements. See the NOTICE file +-- distributed with this work for additional information +-- regarding copyright ownership. The ASF licenses this file +-- to you under the Apache License, Version 2.0 (the +-- "License"); you may not use this file except in compliance +-- with the License. You may obtain a copy of the License at +-- +-- http://www.apache.org/licenses/LICENSE-2.0 +-- +-- Unless required by applicable law or agreed to in writing, +-- software distributed under the License is distributed on an +-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +-- KIND, either express or implied. See the License for the +-- specific language governing permissions and limitations +-- under the License. + +--; +-- Schema upgrade from 4.19.0.0 to 4.19.1.0 +--; + +ALTER TABLE cloud.vm_template MODIFY COLUMN url VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; Review Comment: ```suggestion ALTER TABLE `cloud`.`vm_template` MODIFY COLUMN `url` VARCHAR(1024) DEFAULT NULL COMMENT 'the url where the template exists externally'; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
