date:20170524

[GitHub] jayapalu commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

jayapalu commented on issue #2116: CLOUDSTACK-8959: Option to attach the config 
drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303679962
 
 
   Failed tests are not related to this PR.
   Can some one please review this PR.
   @borisstoyanov  Can you also trigger the Trillian.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: 
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118237379
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/StopVMCmd.java
 ##
 @@ -54,7 +54,7 @@
 private Long id;
 
 @Parameter(name = ApiConstants.FORCED, type = CommandType.BOOLEAN, 
required = false, description = "Force stop the VM "
-+ "(vm is marked as Stopped even when command fails to be send to the 
backend).  The caller knows the VM is stopped.")
++ "(vm is marked as Stopped even when command fails to be send to the 
backend, otherwise a force poweroff is attempted).  The caller knows the VM is 
stopped.")
 
 Review comment:
   Most users (implicitly) assume that the forced parameter will cause a forced 
stop (hard shutdown or power off). The currently behaviour marks the VM as 
stopped in the DB when provided (if shutdown operations fails due to host down 
etc). Backward compatibility is still maintained as during the forced VM stop, 
VM may still be marked as stopped in case the operations fails to reach the 
host.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

2017-05-24 Thread git

koushik-das commented on a change in pull request #2088: CLOUDSTACK-9892: 
Primary storage resource check is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#discussion_r118207107
 
 

 ##
 File path: 
plugins/hypervisors/simulator/src/com/cloud/resource/SimulatorStorageProcessor.java
 ##
 @@ -86,9 +86,17 @@ public Answer copyTemplateToPrimaryStorage(CopyCommand cmd) 
{
 
 @Override
 public Answer cloneVolumeFromBaseTemplate(CopyCommand cmd) {
+long size = 100;
 
 Review comment:
   This was existing code, didn't want to change that.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2105: Vyos router plugin

2017-05-24 Thread git

blueorangutan commented on issue #2105: Vyos router plugin
URL: https://github.com/apache/cloudstack/pull/2105#issuecomment-303679093
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-741
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: 
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118237454
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -3150,7 +3150,9 @@ protected Answer execute(StopCommand cmd) {
 
vmMo.setCustomFieldValue(CustomFieldConstants.CLOUD_VM_INTERNAL_NAME, 
cmd.getVmName());
 
 if (getVmPowerState(vmMo) != PowerState.PowerOff) {
-if (vmMo.safePowerOff(_shutdownWaitMs)) {
+if (cmd.isForceStop() && vmMo.powerOff()) {
+return new StopAnswer(cmd, "Force stopped VM " + 
cmd.getVmName() + " Succeed", true);
 
 Review comment:
   I can fix that.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: 
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118237605
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final 
Connection conn) {
 return null;
 }
 
-public void shutdownVM(final Connection conn, final VM vm, final String 
vmName) throws XmlRpcException {
+public void shutdownVM(final Connection conn, final VM vm, final String 
vmName, final boolean forcedStop) throws XmlRpcException {
 Task task = null;
 try {
-task = vm.cleanShutdownAsync(conn);
+if (forcedStop) {
 
 Review comment:
   @koushik-das the stopVM command will have the forced-flag, using that one 
can investigate whether a clean shutdown was attempted or a forced/hard 
shutdown.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] PaulAngus commented on issue #2105: Vyos router plugin

2017-05-24 Thread git

PaulAngus commented on issue #2105: Vyos router plugin
URL: https://github.com/apache/cloudstack/pull/2105#issuecomment-303673457
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2105: Vyos router plugin

2017-05-24 Thread git

blueorangutan commented on issue #2105: Vyos router plugin
URL: https://github.com/apache/cloudstack/pull/2105#issuecomment-303673559
 
 
   @PaulAngus a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi commented on issue #2098: Fix for CLOUDSTACK-9660

2017-05-24 Thread git

karuturi commented on issue #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098#issuecomment-303679670
 
 
   failures werent reported in this run. merging this now. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303679921
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2098 from mike-tutkowski/CLOUDSTACK-9917

2017-05-24 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit 0b989236796b33e7d4fd21a0056d66c6655b72ef
Merge: e25a444 0506fe6
Author: Rajani Karuturi 
AuthorDate: Wed May 24 15:41:58 2017 +0530

Merge pull request #2098 from mike-tutkowski/CLOUDSTACK-9917

Fix for CLOUDSTACK-9660

 engine/schema/src/com/cloud/storage/dao/VolumeDao.java | 2 +-
 engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java | 4 +---
 server/src/com/cloud/storage/StorageManagerImpl.java   | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[GitHub] borisstoyanov commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

borisstoyanov commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303679843
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi closed pull request #2098: Fix for CLOUDSTACK-9660

2017-05-24 Thread git

karuturi closed pull request #2098: Fix for CLOUDSTACK-9660
URL: https://github.com/apache/cloudstack/pull/2098
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] branch master updated (e25a444 -> 0b98923)

2017-05-24 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.

  from  e25a444   Merge pull request #2121 from bvbharatk/CLOUDSTACK-9641
  adds  0506fe6   Fix for CLOUDSTACK-9660
   new  0b98923   Merge pull request #2098 from 
mike-tutkowski/CLOUDSTACK-9917

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 engine/schema/src/com/cloud/storage/dao/VolumeDao.java | 2 +-
 engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java | 4 +---
 server/src/com/cloud/storage/StorageManagerImpl.java   | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-05-24 Thread git

jayapalu commented on issue #1996: CLOUDSTACK-9099: SecretKey is returned from 
the APIs
URL: https://github.com/apache/cloudstack/pull/1996#issuecomment-303681202
 
 
   I have made the changes changes suggested @rhtyd . 
   Waited and pinged for the reviewer for 6 days. No response from the 
reviewer, marking merge ready. Let me know if any comments are there on the 
code.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303686285
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

borisstoyanov commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303686215
 
 
   @blueorangutan test 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password service on ilb systemvm

2017-05-24 Thread git

cloudmonger commented on issue #1912: [4.8] CLOUDSTACK-9749: Disable password 
service on ilb systemvm
URL: https://github.com/apache/cloudstack/pull/1912#issuecomment-303695489
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 744
Hypervisor xenserver
NetworkType Advanced
Passed=111
Failed=1
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_routers_network_ops.py
   
* test_03_RVR_Network_check_router_state Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303685765
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-742
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303688640
 
 
   @rhtyd Please add some integration tests for hard shutdown scenario. Also 
consider the case of restoring a VM after hard shutdown.
   
   The CS documentation should be updated to point to the relevant HV specific 
hard shutdown pros and cons.

   PS: A similar thing was done in Cloudplatform but for the Destroy VM API. 
See if you would like to include that scenario as well in this PR or want it to 
be done separately.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayapalu commented on issue #2089: vRouters fixes & performance improvement

2017-05-24 Thread git

jayapalu commented on issue #2089: vRouters fixes & performance improvement
URL: https://github.com/apache/cloudstack/pull/2089#issuecomment-303691884
 
 
   @The-Loeki  Can you please add the bug id in the commit description.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sureshanaparti commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

sureshanaparti commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303691847
 
 
   @borisstoyanov Resolved the merge conflicts. Please run the tests. Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

koushik-das commented on a change in pull request #2108: [4.9+] 
CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118213044
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final 
Connection conn) {
 return null;
 }
 
-public void shutdownVM(final Connection conn, final VM vm, final String 
vmName) throws XmlRpcException {
+public void shutdownVM(final Connection conn, final VM vm, final String 
vmName, final boolean forcedStop) throws XmlRpcException {
 Task task = null;
 try {
-task = vm.cleanShutdownAsync(conn);
+if (forcedStop) {
 
 Review comment:
   @rhtyd Can you put some relevant logging to indicate hard or clean shutdown? 
This will help in debugging, relevant for all HV handlers.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

koushik-das commented on a change in pull request #2108: [4.9+] 
CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118217749
 
 

 ##
 File path: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##
 @@ -3150,7 +3150,9 @@ protected Answer execute(StopCommand cmd) {
 
vmMo.setCustomFieldValue(CustomFieldConstants.CLOUD_VM_INTERNAL_NAME, 
cmd.getVmName());
 
 if (getVmPowerState(vmMo) != PowerState.PowerOff) {
-if (vmMo.safePowerOff(_shutdownWaitMs)) {
+if (cmd.isForceStop() && vmMo.powerOff()) {
+return new StopAnswer(cmd, "Force stopped VM " + 
cmd.getVmName() + " Succeed", true);
 
 Review comment:
   Better to keep the response (StopAnswer message) similar for all the HVs. 
The same should be done for XS and KVM as well.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

koushik-das commented on a change in pull request #2108: [4.9+] 
CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118213766
 
 

 ##
 File path: api/src/org/apache/cloudstack/api/command/user/vm/StopVMCmd.java
 ##
 @@ -54,7 +54,7 @@
 private Long id;
 
 @Parameter(name = ApiConstants.FORCED, type = CommandType.BOOLEAN, 
required = false, description = "Force stop the VM "
-+ "(vm is marked as Stopped even when command fails to be send to the 
backend).  The caller knows the VM is stopped.")
++ "(vm is marked as Stopped even when command fails to be send to the 
backend, otherwise a force poweroff is attempted).  The caller knows the VM is 
stopped.")
 
 Review comment:
   This will be a change in behaviour. Although this is cleaner not sure if it 
better to add a new flag for hard shutdown in order to maintain backward 
compatibility?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on a change in pull request #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

2017-05-24 Thread git

koushik-das commented on a change in pull request #2088: CLOUDSTACK-9892: 
Primary storage resource check is broken when using ?
URL: https://github.com/apache/cloudstack/pull/2088#discussion_r118208408
 
 

 ##
 File path: test/integration/smoke/test_deploy_vm_root_resize.py
 ##
 @@ -212,35 +212,29 @@ def test_00_deploy_vm_root_resize(self):
 # 3. Rejects non-supported hypervisor types
 
 Review comment:
   I will try to add some tests for these, in 
test/integration/component/test_resource_limits.py didn't see any PS resource 
limit tests.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

koushik-das commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303688640
 
 
   @rhtyd Please add some integration tests for hard shutdown scenario. Also 
consider the case of restoring a VM after hard shutdown.
   
   The CS documentation should be updated to point to the relevant HV specific 
hard shutdown pros and cons.

   PS: A similar thing was done in Cloudplatform but for the Destroy VM API. 
See if you would like to include that scenario as well in this PR or want it to 
be done separately.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swill commented on a change in pull request #2089: vRouters fixes & performance improvement

2017-05-24 Thread git

swill commented on a change in pull request #2089: vRouters fixes & performance 
improvement
URL: https://github.com/apache/cloudstack/pull/2089#discussion_r118254705
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh
 ##
 @@ -27,39 +27,29 @@ log_it() {
 echo "$(date) : $*" >> $log
 }
 
-while getopts 'c:' OPTION
-do
-  case $OPTION in
-  c) cfg="$OPTARG"
-  ;;
-  esac
-done
+while getopts 'c:' OPTION; do
+case $OPTION in
+c) cfg="$OPTARG" ;;
+esac; done
 
-while read line
-do
+export DEFER_CONFIG=YESPLZ
 
 Review comment:
   I agree with @rhtyd, a TRUE/FALSE value here makes more sense.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] swill commented on a change in pull request #2089: vRouters fixes & performance improvement

2017-05-24 Thread git

swill commented on a change in pull request #2089: vRouters fixes & performance 
improvement
URL: https://github.com/apache/cloudstack/pull/2089#discussion_r118255110
 
 

 ##
 File path: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh
 ##
 @@ -27,39 +27,29 @@ log_it() {
 echo "$(date) : $*" >> $log
 }
 
-while getopts 'c:' OPTION
-do
-  case $OPTION in
-  c) cfg="$OPTARG"
-  ;;
-  esac
-done
+while getopts 'c:' OPTION; do
+case $OPTION in
+c) cfg="$OPTARG" ;;
+esac; done
 
-while read line
-do
+export DEFER_CONFIG=YESPLZ
 
 Review comment:
   Also, maybe I am missing something, but I don't ever see this being used.  
Why is it being set and how is it used?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-05-24 Thread git

cloudmonger commented on issue #905: BUG-ID: CLOUDSTACK-8922:  Unable to delete 
IP tag
URL: https://github.com/apache/cloudstack/pull/905#issuecomment-303777117
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 745
Hypervisor xenserver
NetworkType Advanced
Passed=105
Failed=2
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   * test_list_ids_parameter.py
   
* ContextSuite context=TestListIdsParams>:setup Failing since 19 runs
   
   * test_nic.py
   
* test_01_nic Failed
   
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

rhtyd commented on issue #2127: packaging: Improve post-upgrade processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303796261
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303778108
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303786036
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when 
force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303785983
 
 
   @blueorangutan test centos7 vmware-55u3
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when 
force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303777837
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

blueorangutan commented on issue #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303796309
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

blueorangutan commented on issue #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303804132
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-744
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

borisstoyanov commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303807036
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

rhtyd commented on issue #2127: packaging: Improve post-upgrade processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303825139
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

borisstoyanov commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303807218
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303807279
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303807287
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303815301
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-746
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

blueorangutan commented on issue #2082: CLOUDSTACK-9017 : VPC VR DHCP broken 
for multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082#issuecomment-303828319
 
 
   Trillian test result (tid-1127)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 32108 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2082-t1127-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Test completed. 50 look ok, 1 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 406.22 | 
test_privategw_acl.py
   test_01_vpc_site2site_vpn | Success | 190.53 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 81.25 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 306.31 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 265.52 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 585.62 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 528.27 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1332.45 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 584.93 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 776.52 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1333.03 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.66 | test_volumes.py
   test_08_resize_volume | Success | 156.66 | test_volumes.py
   test_07_resize_fail | Success | 161.63 | test_volumes.py
   test_06_download_detached_volume | Success | 156.49 | test_volumes.py
   test_05_detach_volume | Success | 150.82 | test_volumes.py
   test_04_delete_attached_volume | Success | 151.28 | test_volumes.py
   test_03_download_attached_volume | Success | 156.45 | test_volumes.py
   test_02_attach_volume | Success | 89.33 | test_volumes.py
   test_01_create_volume | Success | 703.37 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.19 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.84 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 168.87 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 308.04 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 31.82 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 31.00 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 125.91 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.97 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 40.37 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 131.04 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.05 | test_templates.py
   test_04_extract_template | Success | 5.14 | test_templates.py
   test_03_delete_template | Success | 5.14 | test_templates.py
   test_02_edit_template | Success | 90.19 | test_templates.py
   test_01_create_template | Success | 75.66 | test_templates.py
   test_10_destroy_cpvm | Success | 161.78 | test_ssvm.py
   test_09_destroy_ssvm | Success | 163.79 | test_ssvm.py
   test_08_reboot_cpvm | Success | 131.69 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.80 | test_ssvm.py
   test_06_stop_cpvm | Success | 161.82 | test_ssvm.py
   test_05_stop_ssvm | Success | 138.89 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.27 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.44 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.98 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 16.31 | test_snapshots.py
   test_04_change_offering_small | Success | 209.63 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
   test_02_sys_template_ready | Success | 0.16 | test_secondary_storage.py
   test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
   test_09_reboot_router | Success | 40.36 | test_routers.py
   test_08_start_router | Success | 35.34 | test_routers.py
   test_07_stop_router | Success | 10.17 | test_routers.py

[GitHub] blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303815058
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-745
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

blueorangutan commented on issue #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303825279
 
 
   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayapalu commented on issue #2080: Changing vlan to None since network offering being used has Specify Vlan set to False

2017-05-24 Thread git

jayapalu commented on issue #2080: Changing vlan to None since network offering 
being used has Specify Vlan set to False
URL: https://github.com/apache/cloudstack/pull/2080#issuecomment-303919986
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] karuturi closed pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

2017-05-24 Thread git

karuturi closed pull request #2082: CLOUDSTACK-9017 : VPC VR DHCP broken for 
multihomed guest VMs
URL: https://github.com/apache/cloudstack/pull/2082
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[cloudstack] 01/01: Merge pull request #2082 from Accelerite/CS-51003

2017-05-24 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit eac2d85076aa4708fa7d02ef97f8c8f93178964e
Merge: 0b98923 10b25ad
Author: Rajani Karuturi 
AuthorDate: Thu May 25 09:41:07 2017 +0530

Merge pull request #2082 from Accelerite/CS-51003

CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest VMs

 systemvm/patches/debian/config/etc/vpcdnsmasq.conf  |  2 ++
 systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py | 15 ---
 2 files changed, 2 insertions(+), 15 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
"commits@cloudstack.apache.org" .

[cloudstack] branch master updated (0b98923 -> eac2d85)

2017-05-24 Thread rajani

This is an automated email from the ASF dual-hosted git repository.

rajani pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.

  from  0b98923   Merge pull request #2098 from 
mike-tutkowski/CLOUDSTACK-9917
  adds  10b25ad   CLOUDSTACK-9017 : VPC VR DHCP broken for multihomed guest 
VMs
   new  eac2d85   Merge pull request #2082 from Accelerite/CS-51003

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "adds" were already present in the repository and have only
been added to this reference.


Summary of changes:
 systemvm/patches/debian/config/etc/vpcdnsmasq.conf  |  2 ++
 systemvm/patches/debian/config/opt/cloud/bin/cs_dhcp.py | 15 ---
 2 files changed, 2 insertions(+), 15 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
['"commits@cloudstack.apache.org" '].

[GitHub] yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag

2017-05-24 Thread git

yvsubhash commented on a change in pull request #905: BUG-ID: CLOUDSTACK-8922:  
Unable to delete IP tag
URL: https://github.com/apache/cloudstack/pull/905#discussion_r118416264
 
 

 ##
 File path: test/integration/component/test_tags.py
 ##
 @@ -2543,3 +2543,248 @@ def test_24_public_IP_tag(self):
 "List tags should return empty response"
 )
 return
+@attr(tags=["advanced"], required_hardware="false")
 
 Review comment:
   @DaanHoogland  this test can be moved to smoke tests.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303927144
 
 
   Trillian test result (tid-1128)
   Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45568 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2108-t1128-vmware-55u3.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Test completed. 47 look ok, 2 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 1029.96 | 
test_privategw_acl.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 131.16 | 
test_snapshots.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 136.24 | 
test_snapshots.py
   test_01_vpc_site2site_vpn | Success | 461.84 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 186.84 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 673.22 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 571.00 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 867.93 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 794.01 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1665.02 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 867.67 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 785.84 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1451.45 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 35.93 | test_volumes.py
   test_06_download_detached_volume | Success | 95.77 | test_volumes.py
   test_05_detach_volume | Success | 110.32 | test_volumes.py
   test_04_delete_attached_volume | Success | 20.26 | test_volumes.py
   test_03_download_attached_volume | Success | 25.36 | test_volumes.py
   test_02_attach_volume | Success | 58.87 | test_volumes.py
   test_01_create_volume | Success | 520.70 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 280.31 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 205.01 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 161.77 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 302.90 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.85 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.23 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 81.21 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.10 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 5.17 | test_vm_life_cycle.py
   test_02_start_vm | Success | 25.26 | test_vm_life_cycle.py
   test_01_stop_vm_forced | Success | 5.14 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 377.36 | test_templates.py
   test_08_list_system_templates | Success | 0.03 | test_templates.py
   test_07_list_public_templates | Success | 0.04 | test_templates.py
   test_05_template_permissions | Success | 0.05 | test_templates.py
   test_04_extract_template | Success | 25.38 | test_templates.py
   test_03_delete_template | Success | 5.11 | test_templates.py
   test_02_edit_template | Success | 90.14 | test_templates.py
   test_01_create_template | Success | 196.28 | test_templates.py
   test_10_destroy_cpvm | Success | 241.81 | test_ssvm.py
   test_09_destroy_ssvm | Success | 268.86 | test_ssvm.py
   test_08_reboot_cpvm | Success | 156.54 | test_ssvm.py
   test_07_reboot_ssvm | Success | 158.51 | test_ssvm.py
   test_06_stop_cpvm | Success | 206.94 | test_ssvm.py
   test_05_stop_ssvm | Success | 178.76 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.91 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.11 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
   test_01_snapshot_root_disk | Success | 31.28 | test_snapshots.py
   test_04_change_offering_small | Success | 101.96 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
   test_01_create_service_offering | Success | 0.19 | test_service_offerings.py
   test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
   test_01_sys_vm_start | Success | 0.17 |

[GitHub] borisstoyanov commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

borisstoyanov commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303928379
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jayapalu commented on issue #1969: CLOUDSTACK-9667 Enable resourcecount.check.interval by default

2017-05-24 Thread git

jayapalu commented on issue #1969: CLOUDSTACK-9667 Enable 
resourcecount.check.interval by default
URL: https://github.com/apache/cloudstack/pull/1969#issuecomment-303922863
 
 
   LGTM
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple physical networks at cluster level for guest traffic over VMware deployments.

2017-05-24 Thread git

blueorangutan commented on issue #862: CLOUDSTACK-7151: Support multiple 
physical networks at cluster level for guest traffic over VMware deployments.
URL: https://github.com/apache/cloudstack/pull/862#issuecomment-303928513
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] bvbharatk commented on issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Rou?

2017-05-24 Thread git

bvbharatk commented on issue #1965: CLOUDSTACK-9727 Password reset discrepancy 
in RVR when one of the Rou?
URL: https://github.com/apache/cloudstack/pull/1965#issuecomment-303928491
 
 
   @ustcweizhou 
   Hi, 
   I have made the suggested changes, Can you please review?.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

borisstoyanov commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303928722
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the config drive

2017-05-24 Thread git

blueorangutan commented on issue #2116: CLOUDSTACK-8959: Option to attach the 
config drive
URL: https://github.com/apache/cloudstack/pull/2116#issuecomment-303928779
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cloudmonger commented on issue #1919: CLOUDSTACK-9763: set ssh public key when creating vm data

2017-05-24 Thread git

cloudmonger commented on issue #1919: CLOUDSTACK-9763: set ssh public key when 
creating vm data
URL: https://github.com/apache/cloudstack/pull/1919#issuecomment-303869657
 
 
   ### ACS CI BVT Run
**Sumarry:**
Build Number 746
Hypervisor xenserver
NetworkType Advanced
Passed=112
Failed=0
Skipped=12
   
   _Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0
   
   **Failed tests:**
   
   **Skipped tests:**
   test_vm_nic_adapter_vmxnet3
   test_01_verify_libvirt
   test_02_verify_libvirt_after_restart
   test_03_verify_libvirt_attach_disk
   test_04_verify_guest_lspci
   test_05_change_vm_ostype_restart
   test_06_verify_guest_lspci_again
   test_static_role_account_acls
   test_11_ss_nfs_version_on_ssvm
   test_nested_virtualization_vmware
   test_3d_gpu_support
   test_deploy_vgpu_enabled_vm
   
   **Passed test suits:**
   test_deploy_vm_with_userdata.py
   test_affinity_groups_projects.py
   test_portable_publicip.py
   test_vm_snapshots.py
   test_over_provisioning.py
   test_global_settings.py
   test_scale_vm.py
   test_service_offerings.py
   test_routers_iptables_default_policy.py
   test_loadbalance.py
   test_routers.py
   test_reset_vm_on_reboot.py
   test_deploy_vms_with_varied_deploymentplanners.py
   test_network.py
   test_router_dns.py
   test_non_contigiousvlan.py
   test_login.py
   test_deploy_vm_iso.py
   test_list_ids_parameter.py
   test_public_ip_range.py
   test_multipleips_per_nic.py
   test_metrics_api.py
   test_regions.py
   test_affinity_groups.py
   test_network_acl.py
   test_pvlan.py
   test_volumes.py
   test_nic.py
   test_deploy_vm_root_resize.py
   test_resource_detail.py
   test_secondary_storage.py
   test_vm_life_cycle.py
   test_routers_network_ops.py
   test_disk_offerings.py
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when 
force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303653265
 
 
   Test results LGTM, I don't see any new regressions. Some of the failing 
tests are known intermittent failures around rvpcs, snapshot/disk (snapshot 
failures/tests are fixed on master, backported to 4.9 here: #2052 ) etc.

   Pinging - @DaanHoogland @abhinandanprateek @ustcweizhou  - please review and 
see if this is okay?
   /cc @karuturi 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] DaanHoogland commented on issue #2122: CLOUDSTACK-9909: Logrotate config for tomcat needs to be updated for ?

2017-05-24 Thread git

DaanHoogland commented on issue #2122: CLOUDSTACK-9909: Logrotate config for 
tomcat needs to be updated for ?
URL: https://github.com/apache/cloudstack/pull/2122#issuecomment-303653798
 
 
   @jayakarteek did you test this (or verify the behaviour in some way)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] abhinandanprateek commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

abhinandanprateek commented on a change in pull request #2108: [4.9+] 
CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118192523
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final 
Connection conn) {
 return null;
 }
 
-public void shutdownVM(final Connection conn, final VM vm, final String 
vmName) throws XmlRpcException {
+public void shutdownVM(final Connection conn, final VM vm, final String 
vmName, final boolean forcedStop) throws XmlRpcException {
 Task task = null;
 try {
-task = vm.cleanShutdownAsync(conn);
+if (forcedStop) {
+task = vm.hardShutdownAsync(conn);
+} else {
+task = vm.cleanShutdownAsync(conn);
+}
+
 
 Review comment:
   The method as it was tried to do a graceful shutdown and upon failure will 
be followed by a hard shutdown, so in a way, the shutdownVM was taking care of 
the scenario in which the VM may not stop gracefully. This method does not 
really need a forcedStop param.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd opened a new pull request #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

rhtyd opened a new pull request #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127
 
 
   $1 is "2" during package upgrade in %post section, this fixes the
   handling of $1 as per https://fedoraproject.org/wiki/Packaging:Scriptlets
   
   This improves handling of $1 during %post upgrade step. Some of the
   command/code are idempotent such as enabling and starting a service
   and can be run without any $1 checks.
   
   Pinging for review - @wido @DaanHoogland @abhinandanprateek @DagSonstebo and 
others
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

blueorangutan commented on issue #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303656098
 
 
   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted 
as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: 
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118193132
 
 

 ##
 File path: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ##
 @@ -2725,14 +2725,14 @@ public String rebootVM(final Connect conn, final 
String vmName) {
 return msg;
 }
 
-public String stopVM(final Connect conn, final String vmName) {
+public String stopVM(final Connect conn, final String vmName, final 
boolean forceStop) {
 DomainState state = null;
 Domain dm = null;
 
 s_logger.debug("Try to stop the vm at first");
-String ret = stopVM(conn, vmName, false);
+String ret = stopVMInternal(conn, vmName, forceStop);
 
 Review comment:
   Sure @ustcweizhou 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

rhtyd commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: 
Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118193709
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final 
Connection conn) {
 return null;
 }
 
-public void shutdownVM(final Connection conn, final VM vm, final String 
vmName) throws XmlRpcException {
+public void shutdownVM(final Connection conn, final VM vm, final String 
vmName, final boolean forcedStop) throws XmlRpcException {
 Task task = null;
 try {
-task = vm.cleanShutdownAsync(conn);
+if (forcedStop) {
+task = vm.hardShutdownAsync(conn);
+} else {
+task = vm.cleanShutdownAsync(conn);
+}
+
 
 Review comment:
   @abhinandanprateek when stopVM api is executed with the forced=true, then 
forceStop will be true and having this param will enable a power-off operation 
as requested via `stopVM force=true` request
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-05-24 Thread git

rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow 
ingress traffic between guest VMs via snat IPs
URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-303658099
 
 
   Running tests again
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303658148
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow ingress traffic between guest VMs via snat IPs

2017-05-24 Thread git

rhtyd commented on issue #2034: [4.9+][network blocker] CLOUDSTACK-9838: Allow 
ingress traffic between guest VMs via snat IPs
URL: https://github.com/apache/cloudstack/pull/2034#issuecomment-301397085
 
 
   @blueorangutan package
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303658302
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] abhinandanprateek commented on a change in pull request #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

abhinandanprateek commented on a change in pull request #2108: [4.9+] 
CLOUDSTACK-9860: Power off VMs when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#discussion_r118198317
 
 

 ##
 File path: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ##
 @@ -4862,10 +4862,15 @@ public synchronized Network setupvSwitchNetwork(final 
Connection conn) {
 return null;
 }
 
-public void shutdownVM(final Connection conn, final VM vm, final String 
vmName) throws XmlRpcException {
+public void shutdownVM(final Connection conn, final VM vm, final String 
vmName, final boolean forcedStop) throws XmlRpcException {
 Task task = null;
 try {
-task = vm.cleanShutdownAsync(conn);
+if (forcedStop) {
+task = vm.hardShutdownAsync(conn);
+} else {
+task = vm.cleanShutdownAsync(conn);
+}
+
 
 Review comment:
   @rhtyd thanks for the clarification, I am LGTM on this.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2127: packaging: Improve post-upgrade processing

2017-05-24 Thread git

blueorangutan commented on issue #2127: packaging: Improve post-upgrade 
processing
URL: https://github.com/apache/cloudstack/pull/2127#issuecomment-303662856
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-739
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-24 Thread git

koushik-das commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-303663868
 
 
   @rhtyd See my responses below
   
   >> Host-HA is disabled by default, it needs explicit configuration and to be 
enabled in order to be used.
   These are relevant once the need for the new HA framework is justified. Lets 
keep these things aside for now.
   
   >> The new agnostic HA framework also has resource life cycle management 
using bounded ephemeral queues for managing very large environments (10k+ hosts)
   Is there any data/bug suggesting that the existing framework is not able to 
scale for 10k+ hosts? Currently also there is a host based bounded queue for 
monitoring commands ().
   
   >> Pluggability of the framework was another reason, it cleanly allows for 
large scale users to implement their own algorithms/logic to carry out various 
operations such as investigate/activity-checks/degrade/recover/fence etc.
   The same is possible with the existing framework as well. A new 
investigator/fencer can be easily added.
   
   >> Due to several reasons and requirements, oobm could not been simply put 
in existing KVM specific VM-HA.
   Can you provide more details as to why this cannot be done?
   
   The last paragraph is again irrelevant at this point. I understand that you 
have put in a considerable amount of effort but based on the discussion so far, 
I don't see any strong justification regarding the need for a new framework.
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] koushik-das commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider

2017-05-24 Thread git

koushik-das commented on issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA 
and KVM HA provider
URL: https://github.com/apache/cloudstack/pull/1960#issuecomment-303663868
 
 
   @rhtyd See my responses below
   
   >> Host-HA is disabled by default, it needs explicit configuration and to be 
enabled in order to be used.
   These are relevant once the need for the new HA framework is justified. Lets 
keep these things aside for now.
   
   >> The new agnostic HA framework also has resource life cycle management 
using bounded ephemeral queues for managing very large environments (10k+ hosts)
   Is there any data/bug suggesting that the existing framework is not able to 
scale for 10k+ hosts? Currently also there is a host based bounded queue for 
monitoring commands ().
   
   >> Pluggability of the framework was another reason, it cleanly allows for 
large scale users to implement their own algorithms/logic to carry out various 
operations such as investigate/activity-checks/degrade/recover/fence etc.
   The same is possible with the existing framework as well. A new 
investigator/fencer can be easily added.
   
   >> Due to several reasons and requirements, oobm could not been simply put 
in existing KVM specific VM-HA.
   Can you provide more details as to why this cannot be done?
   
   The last paragraph is again irrelevant at this point. I understand that you 
have put in a considerable amount of effort but based on the discussion so far, 
I don't see any strong justification regarding the need for a new framework.
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303664772
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-740
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

borisstoyanov commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303667286
 
 
   @blueorangutan test
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303667554
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage metrics

2017-05-24 Thread git

blueorangutan commented on issue #2035: CLOUDSTACK-9867:VM snapshot on primary 
storage usage metrics
URL: https://github.com/apache/cloudstack/pull/2035#issuecomment-303853426
 
 
   Trillian test result (tid-1125)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 42784 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2035-t1125-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Test completed. 48 look ok, 4 have error(s)
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_rvpc_privategw_static_routes | `Failure` | 406.42 | 
test_privategw_acl.py
   ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | 
test_internal_lb.py
   ContextSuite context=TestDeployVirtioSCSIVM>:teardown | `Error` | 78.89 | 
test_deploy_virtio_scsi_vm.py
   test_01_vpc_site2site_vpn | Success | 175.85 | test_vpc_vpn.py
   test_01_vpc_remote_access_vpn | Success | 91.31 | test_vpc_vpn.py
   test_01_redundant_vpc_site2site_vpn | Success | 276.01 | test_vpc_vpn.py
   test_02_VPC_default_routes | Success | 274.48 | test_vpc_router_nics.py
   test_01_VPC_nics_after_destroy | Success | 579.21 | test_vpc_router_nics.py
   test_05_rvpc_multi_tiers | Success | 526.66 | test_vpc_redundant.py
   test_04_rvpc_network_garbage_collector_nics | Success | 1326.27 | 
test_vpc_redundant.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 583.95 | test_vpc_redundant.py
   test_02_redundant_VPC_default_routes | Success | 769.92 | 
test_vpc_redundant.py
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1317.59 | 
test_vpc_redundant.py
   test_09_delete_detached_volume | Success | 156.57 | test_volumes.py
   test_08_resize_volume | Success | 156.47 | test_volumes.py
   test_07_resize_fail | Success | 161.64 | test_volumes.py
   test_06_download_detached_volume | Success | 156.34 | test_volumes.py
   test_05_detach_volume | Success | 150.77 | test_volumes.py
   test_04_delete_attached_volume | Success | 151.32 | test_volumes.py
   test_03_download_attached_volume | Success | 156.44 | test_volumes.py
   test_02_attach_volume | Success | 89.25 | test_volumes.py
   test_01_create_volume | Success | 712.08 | test_volumes.py
   test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
   test_02_revert_vm_snapshots | Success | 100.67 | test_vm_snapshots.py
   test_01_create_vm_snapshots | Success | 168.91 | test_vm_snapshots.py
   test_deploy_vm_multiple | Success | 252.68 | test_vm_life_cycle.py
   test_deploy_vm | Success | 0.06 | test_vm_life_cycle.py
   test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | Success | 26.90 | test_vm_life_cycle.py
   test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
   test_08_migrate_vm | Success | 30.95 | test_vm_life_cycle.py
   test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
   test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
   test_03_reboot_vm | Success | 125.92 | test_vm_life_cycle.py
   test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
   test_01_stop_vm | Success | 35.32 | test_vm_life_cycle.py
   test_CreateTemplateWithDuplicateName | Success | 141.15 | test_templates.py
   test_08_list_system_templates | Success | 0.06 | test_templates.py
   test_07_list_public_templates | Success | 0.07 | test_templates.py
   test_05_template_permissions | Success | 0.09 | test_templates.py
   test_04_extract_template | Success | 5.17 | test_templates.py
   test_03_delete_template | Success | 5.11 | test_templates.py
   test_02_edit_template | Success | 90.15 | test_templates.py
   test_01_create_template | Success | 50.50 | test_templates.py
   test_10_destroy_cpvm | Success | 161.68 | test_ssvm.py
   test_09_destroy_ssvm | Success | 168.86 | test_ssvm.py
   test_08_reboot_cpvm | Success | 131.73 | test_ssvm.py
   test_07_reboot_ssvm | Success | 133.74 | test_ssvm.py
   test_06_stop_cpvm | Success | 131.86 | test_ssvm.py
   test_05_stop_ssvm | Success | 138.89 | test_ssvm.py
   test_04_cpvm_internals | Success | 1.29 | test_ssvm.py
   test_03_ssvm_internals | Success | 3.86 | test_ssvm.py
   test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py
   test_01_list_sec_storage_vm | Success | 0.16 | test_ssvm.py
   test_02_list_snapshots_with_removed_data_store | Success | 86.97 | 
test_snapshots.py
   test_01_snapshot_root_disk | Success | 16.27 | test_snapshots.py
   test_04_change_offering_small | Success | 234.66 | test_service_offerings.py
   test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
   test_02_edit_service_offering | Success | 0.09 |

[GitHub] blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs when force stop is provided

2017-05-24 Thread git

blueorangutan commented on issue #2108: [4.9+] CLOUDSTACK-9860: Power off VMs 
when force stop is provided
URL: https://github.com/apache/cloudstack/pull/2108#issuecomment-303785133
 
 
   Packaging result: ?centos6 ?centos7 ?debian. JID-743
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

79 matches

Mail list logo