[GitHub] blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type”

2018-04-05 Thread GitBox
blueorangutan commented on issue #2404: [CLOUDSTACK-10230] User should not be 
able to use removed “Guest OS type”
URL: https://github.com/apache/cloudstack/pull/2404#issuecomment-379077062
 
 
   Trillian test result (tid-2463)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46315 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2404-t2463-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 45 look OK, 22 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 187.11 | 
test_privategw_acl.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | 
test_reset_vm_on_reboot.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | 
test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | 
test_router_dns.py
   ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.07 | 
test_vm_snapshots.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | 
test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | 
test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.18 | 
test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.17 | 
test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.35 | 
test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | 
test_routers.py
   test_01_sys_vm_start | `Failure` | 0.11 | test_secondary_storage.py
   test_02_sys_template_ready | `Failure` | 0.10 | test_secondary_storage.py
   ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | 
test_service_offerings.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.20 | 
test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | 
test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.04 | test_ssvm.py
   test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_06_stop_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.04 | test_ssvm.py
   test_10_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.55 | 
test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.49 | 
test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.51 | 

[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378879184
 
 
   @DaanHoogland just a hint, if you use the keyword "closes issue" github will 
close the issue after merge of the PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378879184
 
 
   @DaanHoogland just a hint, if you use the keyword "closes " github 
will close the issue after merge of the PR. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-37384
 
 
   target (branch) should be changed to 4.11 before merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] resmo commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
resmo commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-37384
 
 
   target (branch) should be changed to 4.11


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2498: CLOUDSTACK-10327: Do not invalidate 
the session when API command not found
URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378901994
 
 
   @borisstoyanov here we also have that same 
`test_04_restart_network_wo_cleanup` failure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage

2018-04-05 Thread GitBox
blueorangutan commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support 
online migration of a virtual disk from non-managed to managed storage
URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-378910671
 
 
   Trillian test result (tid-2452)
   Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 137537 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2502-t2452-vmware-65.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 59 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_00_deploy_vm_root_resize | `Failure` | 1151.77 | 
test_deploy_vm_root_resize.py
   test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 
2071.44 | test_routers_network_ops.py
   test_04_restart_network_wo_cleanup | `Failure` | 3.06 | test_routers.py
   ContextSuite context=TestCpuCapServiceOfferings>:teardown | `Error` | 0.00 | 
test_service_offerings.py
   test_04_extract_template | `Failure` | 155.37 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_06_download_detached_volume | `Failure` | 188.13 | test_volumes.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 672.53 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378869034
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1873


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
blueorangutan commented on issue #2535: Create an easy way to enable Java 
remote Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378910170
 
 
   @rafaelweingartner a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner opened a new pull request #2535: Create an easy way to enable the Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner opened a new pull request #2535: Create an easy way to enable 
the Java remote Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535
 
 
   ## Description
   
   The idea is to create a property in /etc/defaults/cloudstack-management that 
can be enabled/disabled (uncommented/commented) to control the enabling of Java 
remote debug in CloudStack's JVM.
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [x] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   Locally in my test environment. I applied this PR into my local ACS, and 
then checked if the remote debug using port 8000 would be available by 
uncommenting the 'JAVA_DEBUG' declaration in 
/etc/defaults/cloudstack-management. After uncommenting the variable I needed 
to restart the management server.
   
   
   
   
   
   ## Checklist:
   
   
   - [X] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [X] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [X] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the session when API command not found

2018-04-05 Thread GitBox
blueorangutan commented on issue #2498: CLOUDSTACK-10327: Do not invalidate the 
session when API command not found
URL: https://github.com/apache/cloudstack/pull/2498#issuecomment-378900724
 
 
   Trillian test result (tid-2456)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 95355 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2498-t2456-kvm-centos7.zip
   Intermitten failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermitten failure detected: /marvin/tests/smoke/test_loadbalance.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 4.11 | test_routers.py
   test_04_rvpc_network_garbage_collector_nics | `Failure` | 538.30 | 
test_vpc_redundant.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2511: [CLOUDSTACK-10344] bug when moving 
ACL rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-378890282
 
 
   I looked into it. The test failed because the uptime of the VR is less than 
3 minutes? 
   This looks like a "test" prone to fail due to environment differences. Shall 
we execute the tests again?
   
   ```
   Traceback (most recent call last):
 File "/marvin/tests/smoke/test_routers.py", line 526, in 
test_04_restart_network_wo_cleanup
   "Check uptime is less than 3 mins or not"
   AssertionError: Check uptime is less than 3 mins or not
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

2018-04-05 Thread GitBox
blueorangutan commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851349
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not importing Local storage properly

2018-04-05 Thread GitBox
borisstoyanov commented on issue #2401: [CLOUDSTACK-10226] CloudStack is not 
importing Local storage properly
URL: https://github.com/apache/cloudstack/pull/2401#issuecomment-378851222
 
 
   @blueorangutan test centos7 xenserver-71


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland opened a new pull request #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland opened a new pull request #2534: fix typo c bug in externalId 
feature UI
URL: https://github.com/apache/cloudstack/pull/2534
 
 
   see #2533
   
   ## Description
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] borisstoyanov commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL rules (change order with drag and drop)

2018-04-05 Thread GitBox
borisstoyanov commented on issue #2511: [CLOUDSTACK-10344] bug when moving ACL 
rules (change order with drag and drop)
URL: https://github.com/apache/cloudstack/pull/2511#issuecomment-378851971
 
 
   @rafaelweingartner I think this one is suspicious: 
   ```
   
   test_04_restart_network_wo_cleanup | Failure | 4.38 | test_routers.py
   -- | -- | -- | --
   
   
   ```
   Can you have a look please? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP 
range 10.1.1.0/24
URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-378861480
 
 
   @sgoeminn I fixed the c error but @PaulAngus still has a point about 
documentation. see #2534


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378861363
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378928297
 
 
   simple github rebase won't work


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378928583
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland closed pull request #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland closed pull request #2534: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2534
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2534: fix typo c bug in externalId feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378930603
 
 
   Yeah thanks @rafaelweingartner . I just recreated copying those few lines. 
Won't mess the end result any way.
   see #2536 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

2018-04-05 Thread GitBox
blueorangutan commented on issue #2462: [CLOUDSTACK-10301] Allow updating the 
network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378933821
 
 
   Trillian test result (tid-2461)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 89017 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2462-t2461-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 61 look OK, 6 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.61 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.11 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | 
test_primary_storage.py
   test_04_restart_network_wo_cleanup | `Failure` | 2.82 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.13 | 
test_snapshots.py
   test_08_migrate_vm | `Error` | 34.01 | test_vm_life_cycle.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 3.37 | 
test_host_maintenance.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 2.51 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI 
to 1.11 (JQuery UI 1.8.4 prone to XSS)
URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378927806
 
 
   @rhtyd Changes break or may break? I have tested this. At least all of the 
functions I used are working just fine.
   
   As I said here before, I know that this update can break some code. I 
executed a lot of testing so far, and I believe I caught and fixed most of the 
problems cause by this upgrade. That is why I asked for help, to get different 
eyes testing this.
   
   Deploy VM, create zone, create VPC, create ACLs, create and edit ACL rules, 
create and edit LB rules, create and edit roles, create affinity groups, 
storage (create volume, edit, upload), networks (add l2, add guest, add 
isolated) and so on.
   
   I can use the minified version of jQuery-UI, but bear in mind that our 
jquery.js is not minified. It looks like we have many other libraries that are 
not using minified version. I only used the non-minified version to help during 
debugging.
   
   I will not open a PR against 4.11, as I explained before to @resmo. This is 
a long-standing issue that I decided to address, and I intend to target master 
only.
   
   I will wait for the community feedback on both. 
   * should I use minified version or non-minified ones?
   * is the community ok with me opening this against master only?
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2535: Create an easy way to enable Java 
remote Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378929239
 
 
   Do you guys think that we need to document this somewhere? Or is it ok to 
leave it as is?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2535: Create an easy way to enable Java remote 
Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378936551
 
 
   nice, I would say put it on the wiki in th dev 1o1 tree. We don't have dev 
docs, persé


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2534: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378943642
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1875


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2536: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-378943644
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1876


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland opened a new pull request #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
DaanHoogland opened a new pull request #2536: fix typo c bug in externalId 
feature UI
URL: https://github.com/apache/cloudstack/pull/2536
 
 
   closes issue #2533
   
   ## Description
   
   
   
   
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   
   
   
   
   
   ## Checklist:
   
   
   - [ ] I have read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document.
   - [ ] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [ ] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my 
environment has passed.
   
   
   @blueorangutan package
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2536: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
blueorangutan commented on issue #2536: fix typo c bug in externalId feature 
UI
URL: https://github.com/apache/cloudstack/pull/2536#issuecomment-378930297
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating the network ACL list name and Description

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2462: [CLOUDSTACK-10301] Allow updating 
the network ACL list name and Description
URL: https://github.com/apache/cloudstack/pull/2462#issuecomment-378937724
 
 
   @borisstoyanov these errors do not seem to be caused by changes introduced 
here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI 
to 1.11 (JQuery UI 1.8.4 prone to XSS)
URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-378927806
 
 
   @rhtyd Changes break or may break? I have tested this. At least all of the 
functions I used are working just fine.
   
   As I said here before, I know that this update can break some code. I 
executed a lot of testing so far, and I believe I caught and fixed most of the 
problems caused by this upgrade. That is why I asked for help, to get different 
eyes testing this.
   
   Deploy VM, create zone, create VPC, create ACLs, create and edit ACL rules, 
create and edit LB rules, create and edit roles, create affinity groups, 
storage (create volume, edit, upload), networks (add l2, add guest, add 
isolated) and so on.
   
   I can use the minified version of jQuery-UI, but bear in mind that our 
jquery.js is not minified. It looks like we have many other libraries that are 
not using minified version either. I only used the non-minified version to help 
during debugging.
   
   I will not open a PR against 4.11, as I explained before to @resmo. This is 
a long-standing issue that I decided to address, and I intend to target master 
only.
   
   I will wait for the community feedback on both. 
   * should I use minified version or non-minified ones?
   * is the community ok with me opening this against master only?
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP range 10.1.1.0/24

2018-04-05 Thread GitBox
DaanHoogland commented on issue #2533: Web-UI creates all isolated Nets with IP 
range 10.1.1.0/24
URL: https://github.com/apache/cloudstack/issues/2533#issuecomment-378861480
 
 
   @sgoeminn I fixed the c error but @PaulAngus still has a point about 
documentation. see #2534
   
   reapplied for 4.11 in #2536


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2535: Create an easy way to enable Java 
remote Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378944292
 
 
   Done.
   
   Shall we execute tests before merging?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2535: Create an easy way to enable Java remote Debug for ACS

2018-04-05 Thread GitBox
blueorangutan commented on issue #2535: Create an easy way to enable Java 
remote Debug for ACS
URL: https://github.com/apache/cloudstack/pull/2535#issuecomment-378917314
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1874


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on issue #2534: fix typo c bug in externalId feature UI

2018-04-05 Thread GitBox
rafaelweingartner commented on issue #2534: fix typo c bug in externalId 
feature UI
URL: https://github.com/apache/cloudstack/pull/2534#issuecomment-378930041
 
 
   @DaanHoogland did this before. You will need to do the following:
   * get the branch `DaanHoogland-patch-1`
   * `reset --hard origin/4.11`
   * checrry-pick your commits here to top of 4.11 (conflicts may arise here)
   * execute a `push -f` to this branch
   * change the target branch here to 4.11


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
rafaelweingartner commented on a change in pull request #2499: Updates to 
capacity management
URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179507086
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
 ##
 @@ -1833,67 +1839,88 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
 }
 }
-// A ready state volume is already allocated in a pool. so the 
asking size is zero for it.
-// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed
+
 if (s_logger.isDebugEnabled()) {
-s_logger.debug("pool id for the volume with id: " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
+s_logger.debug("Pool ID for the volume with ID " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
 }
+
+// A ready-state volume is already allocated in a pool, so the 
asking size is zero for it.
+// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed.
 if ((volumeVO.getState() != Volume.State.Ready) || 
(volumeVO.getPoolId() != pool.getId())) {
-if (ScopeType.ZONE.equals(poolVO.getScope()) && 
volumeVO.getTemplateId() != null) {
+totalAskingSize += 
getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, poolVO);
+
+if (poolVO.isManaged() && volumeVO.getTemplateId() != null) {
 VMTemplateVO tmpl = 
_templateDao.findByIdIncludingRemoved(volumeVO.getTemplateId());
 
 if (tmpl != null && 
!ImageFormat.ISO.equals(tmpl.getFormat())) {
-// Storage plug-ins for zone-wide primary storage can 
be designed in such a way as to store a template on the
-// primary storage once and make use of it in 
different clusters (via cloning).
+// Storage plug-ins for managed storage can be 
designed in such a way as to store a template on the
+// primary storage once and make use of it via 
storage-side cloning.
 // This next call leads to CloudStack asking how many 
more bytes it will need for the template (if the template is
 // already stored on the primary storage, then the 
answer is 0).
 
-if (clusterId != null && 
_clusterDao.getSupportsResigning(clusterId)) {
-totalAskingSize += 
getBytesRequiredForTemplate(tmpl, pool);
+if (clusterId != null) {
 
 Review comment:
   Would you mind extracting the block of this IF condition to a method? This 
would allow proper documentation an unit tests.
   
   If the resigning is not supported this new method can return 0 as the value 
to be added to the `totalAskingSize` variable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] ernjvr opened a new issue #2537: Fix configuration file copying bugs during Upgrade from 4.x to 4.11

2018-04-05 Thread GitBox
ernjvr opened a new issue #2537: Fix configuration file copying bugs during 
Upgrade from 4.x to 4.11
URL: https://github.com/apache/cloudstack/issues/2537
 
 
   
   
   # ISSUE TYPE
   
* Bug Report
   
   # COMPONENT NAME
   
   ~~~
   packaging
   ~~~
   
   # CLOUDSTACK VERSION
   
   
   ~~~
   4.11
   master
   ~~~
   
   # CONFIGURATION
   
   N/A
   
   # OS / ENVIRONMENT
   
   N/A
   
   # SUMMARY
   
   
   The packaging/centos7/cloud.spec file line 400 moves the 
%{_sysconfdir}/sysconfig/%{name}-management file to 
%{_sysconfdir}/default/%{name}-management.This is unnecessary because  the file 
contains the deprecated tomcat configurations. Moving it prevents the 4.11 
upgrade from overwriting the old file with the new jetty configurations file. 
Also systemctl daemon-reload command needs to be added to the end of the %post 
management step in order to refresh daemon services so that management server 
can start up seamlessly after the upgrade.
   
   # STEPS TO REPRODUCE
   
   
   To Reproduce: install version 4.6 of cloudstack. 
   Update Systemvm templates. 
http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/4.11.0.0/upgrade/upgrade-4.5.html#update-system-vm-templates
   Stop management server and usage server.
   Do database backup.
   Change the /etc/yum.repos.d/cloudstack.repo file to upgrade to 4.11.
   Do sudo yum upgrade cloudstack-management.
   After upgrade it fails to start the management server because:
   1) the less /etc/default/cloudstack-management file still contains the old 
tomcat configurations and not the new 4.11 Jetty server configurations.
   2) the systemctl daemon-reload needs to be executed to relaod the daemon 
services
   
   
   ~~~
   systemctl stop cloudstack-management
   systemctl stop cloudstack-usage
   mysqldump -u root -p cloud > cloud-backup_`date '+%Y-%m-%d'`.sql
   mysqldump -u root -p cloud_usage > cloud_usage-backup_`date '+%Y-%m-%d'`.sql
   vi /etc/yum.repos.d/cloudstack.repo
   sudo yum upgrade cloudstack-management
   sudo yum upgrade cloudstack-usage
   systemctl start cloudstack-management
   systemctl start cloudstack-usage
   ~~~
   
   
   
   # EXPECTED RESULTS
   
   
   ~~~
   after upgrade:
   less /etc/default/cloudstack-management should show the new jetty server 
environment variables
   management server should start up successfully without manually executing 
systemctl daemon-reload
   able to log in to the UI  
   ~~~
   
   # ACTUAL RESULTS
   
   management server failed to start and returned an error message "Job for 
cloudstack-management.service failed because the control process exited with 
error code. ..."
   
   ~~~
   systemctl start cloudstack-management produced the above error output
   ~~~
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rafaelweingartner commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
rafaelweingartner commented on a change in pull request #2499: Updates to 
capacity management
URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179507086
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
 ##
 @@ -1833,67 +1839,88 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
 }
 }
-// A ready state volume is already allocated in a pool. so the 
asking size is zero for it.
-// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed
+
 if (s_logger.isDebugEnabled()) {
-s_logger.debug("pool id for the volume with id: " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
+s_logger.debug("Pool ID for the volume with ID " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
 }
+
+// A ready-state volume is already allocated in a pool, so the 
asking size is zero for it.
+// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed.
 if ((volumeVO.getState() != Volume.State.Ready) || 
(volumeVO.getPoolId() != pool.getId())) {
-if (ScopeType.ZONE.equals(poolVO.getScope()) && 
volumeVO.getTemplateId() != null) {
+totalAskingSize += 
getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, poolVO);
+
+if (poolVO.isManaged() && volumeVO.getTemplateId() != null) {
 VMTemplateVO tmpl = 
_templateDao.findByIdIncludingRemoved(volumeVO.getTemplateId());
 
 if (tmpl != null && 
!ImageFormat.ISO.equals(tmpl.getFormat())) {
-// Storage plug-ins for zone-wide primary storage can 
be designed in such a way as to store a template on the
-// primary storage once and make use of it in 
different clusters (via cloning).
+// Storage plug-ins for managed storage can be 
designed in such a way as to store a template on the
+// primary storage once and make use of it via 
storage-side cloning.
 // This next call leads to CloudStack asking how many 
more bytes it will need for the template (if the template is
 // already stored on the primary storage, then the 
answer is 0).
 
-if (clusterId != null && 
_clusterDao.getSupportsResigning(clusterId)) {
-totalAskingSize += 
getBytesRequiredForTemplate(tmpl, pool);
+if (clusterId != null) {
 
 Review comment:
   Would you mind extracting the block of this IF condition to a method? This 
would allow proper documentation an unit tests.
   
   If the resigning is not supported this method can return 0 as the value to 
be added to the `totalAskingSize` variable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

2018-04-05 Thread GitBox
rhtyd commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for 
KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-379009668
 
 
   Looks like there is an outstanding/related issue to CA management, I'll have 
a look next week (on holidays now).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM Migration for KVM

2018-04-05 Thread GitBox
blueorangutan commented on issue #2505: CLOUDSTACK-10333: Secure Live VM 
Migration for KVM
URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-379007673
 
 
   Trillian test result (tid-2459)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 107420 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2505-t2459-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 65 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_restart_network_wo_cleanup | `Failure` | 4.14 | test_routers.py
   test_01_secured_vm_migration | `Failure` | 1069.92 | test_vm_life_cycle.py
   test_02_not_secured_vm_migration | `Failure` | 118.28 | test_vm_life_cycle.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mike-tutkowski commented on a change in pull request #2499: Updates to capacity management

2018-04-05 Thread GitBox
mike-tutkowski commented on a change in pull request #2499: Updates to capacity 
management
URL: https://github.com/apache/cloudstack/pull/2499#discussion_r179547128
 
 

 ##
 File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
 ##
 @@ -1833,67 +1839,88 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
 }
 }
-// A ready state volume is already allocated in a pool. so the 
asking size is zero for it.
-// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed
+
 if (s_logger.isDebugEnabled()) {
-s_logger.debug("pool id for the volume with id: " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
+s_logger.debug("Pool ID for the volume with ID " + 
volumeVO.getId() + " is " + volumeVO.getPoolId());
 }
+
+// A ready-state volume is already allocated in a pool, so the 
asking size is zero for it.
+// In case the volume is moving across pools or is not ready yet, 
the asking size has to be computed.
 if ((volumeVO.getState() != Volume.State.Ready) || 
(volumeVO.getPoolId() != pool.getId())) {
-if (ScopeType.ZONE.equals(poolVO.getScope()) && 
volumeVO.getTemplateId() != null) {
+totalAskingSize += 
getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, poolVO);
+
+if (poolVO.isManaged() && volumeVO.getTemplateId() != null) {
 VMTemplateVO tmpl = 
_templateDao.findByIdIncludingRemoved(volumeVO.getTemplateId());
 
 if (tmpl != null && 
!ImageFormat.ISO.equals(tmpl.getFormat())) {
-// Storage plug-ins for zone-wide primary storage can 
be designed in such a way as to store a template on the
-// primary storage once and make use of it in 
different clusters (via cloning).
+// Storage plug-ins for managed storage can be 
designed in such a way as to store a template on the
+// primary storage once and make use of it via 
storage-side cloning.
 // This next call leads to CloudStack asking how many 
more bytes it will need for the template (if the template is
 // already stored on the primary storage, then the 
answer is 0).
 
-if (clusterId != null && 
_clusterDao.getSupportsResigning(clusterId)) {
-totalAskingSize += 
getBytesRequiredForTemplate(tmpl, pool);
+if (clusterId != null) {
 
 Review comment:
   Done


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] blueorangutan commented on issue #2501: Only perform certain actions with managed storage if the VM is s…

2018-04-05 Thread GitBox
blueorangutan commented on issue #2501: Only perform certain actions with 
managed storage if the VM is s…
URL: https://github.com/apache/cloudstack/pull/2501#issuecomment-37900
 
 
   Trillian test result (tid-2457)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 107728 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2501-t2457-kvm-centos7.zip
   Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py
   Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermitten failure detected: /marvin/tests/smoke/test_primary_storage.py
   Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
   Intermitten failure detected: /marvin/tests/smoke/test_routers.py
   Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermitten failure detected: /marvin/tests/smoke/test_templates.py
   Intermitten failure detected: /marvin/tests/smoke/test_usage.py
   Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
   Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 59 look OK, 8 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_add_primary_storage_disabled_host | `Error` | 0.60 | 
test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.22 | 
test_primary_storage.py
   test_04_restart_network_wo_cleanup | `Failure` | 4.00 | test_routers.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | 
test_snapshots.py
   test_04_extract_template | `Failure` | 128.40 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_08_migrate_vm | `Error` | 16.92 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Failure` | 137.58 | test_volumes.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 1.14 | 
test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.34 | 
test_host_maintenance.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services