[GitHub] [cloudstack] blueorangutan commented on issue #3257: server: fix for vm snapshot search (#3208)

2019-04-03 Thread GitBox
blueorangutan commented on issue #3257: server: fix for vm snapshot search 
(#3208)
URL: https://github.com/apache/cloudstack/pull/3257#issuecomment-479401210
 
 
   @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr opened a new pull request #3257: server: fix for vm snapshot search (#3208)

2019-04-03 Thread GitBox
shwstppr opened a new pull request #3257: server: fix for vm snapshot search 
(#3208)
URL: https://github.com/apache/cloudstack/pull/3257
 
 
   ## Description
   Fixes #3208 
   
   Using db column instead of VO variable name was causing issue with SQL 
select statement.
   This PR fixes the problem by using VO variable for adding conditional.
   Additionally in UI **listAll** parameter was being sent twice in the 
listVMSnapshot API call. It is fixed with this PR.
   
   ## Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   Original behavior giving error,
   ![Screenshot from 2019-04-03 
13-06-09](https://user-images.githubusercontent.com/153340/55461272-b6093400-5611-11e9-99bf-6353431f80d1.png)
   
   With changes,
   ![Screenshot from 2019-04-03 
13-09-04](https://user-images.githubusercontent.com/153340/55461317-c9b49a80-5611-11e9-9ce2-69e0174756ea.png)
   ![Screenshot from 2019-04-03 
13-08-18](https://user-images.githubusercontent.com/153340/55461321-cb7e5e00-5611-11e9-92b1-db225d8cc69f.png)
   
   ## How Has This Been Tested?
   From UI and cmk
   
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] shwstppr commented on issue #3208: Error while searching through VM snapshots

2019-04-03 Thread GitBox
shwstppr commented on issue #3208: Error while searching through VM snapshots
URL: https://github.com/apache/cloudstack/issues/3208#issuecomment-479377070
 
 
   > Additionally, per documentation, no parameter is REQUIRED, all are 
optional, which seems to not be the case.
   
   @andrijapanic Not able get the above part, rest should be fixed with my PR 
https://github.com/apache/cloudstack/pull/3257
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3257: server: fix for vm snapshot search (#3208)

2019-04-03 Thread GitBox
andrijapanicsb commented on issue #3257: server: fix for vm snapshot search 
(#3208)
URL: https://github.com/apache/cloudstack/pull/3257#issuecomment-479400865
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3257: server: fix for vm snapshot search (#3208)

2019-04-03 Thread GitBox
blueorangutan commented on issue #3257: server: fix for vm snapshot search 
(#3208)
URL: https://github.com/apache/cloudstack/pull/3257#issuecomment-479408399
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2672


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3208: Error while searching through VM snapshots

2019-04-03 Thread GitBox
andrijapanicsb commented on issue #3208: Error while searching through VM 
snapshots
URL: https://github.com/apache/cloudstack/issues/3208#issuecomment-479431410
 
 
   Ignore that, my bad!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3208: Error while searching through VM snapshots

2019-04-03 Thread GitBox
andrijapanicsb removed a comment on issue #3208: Error while searching through 
VM snapshots
URL: https://github.com/apache/cloudstack/issues/3208#issuecomment-471511535
 
 
   Additionally, per documentation, no parameter is REQUIRED, all are optional, 
which seems to not be the case.
   
   Additionally, when searching for VM snap via GUI, the "listall=true" is sent 
two times  - this is also to be fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-03 Thread GitBox
DaanHoogland commented on a change in pull request #3251: [WIP DO NOT MERGE] 
Add local ISO upload via UI
URL: https://github.com/apache/cloudstack/pull/3251#discussion_r271681430
 
 

 ##
 File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java
 ##
 @@ -284,35 +285,62 @@ public TemplateProfile prepare(RegisterTemplateCmd cmd) 
throws ResourceAllocatio
 
 }
 
-@Override
-public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd) throws 
ResourceAllocationException {
+/**
+ * Prepare upload parameters internal method for templates and ISOs local 
upload
+ */
+private TemplateProfile prepareUploadParamsInternal(boolean isIso, long 
userId, String name, String displayText,
 
 Review comment:
   It is confusing any which way :( also this private method has javadoc which, 
if needed is not ideal.
   I was thinking of putting both cmd in a hierarchy and passing the parent 
here. or derive the iso cmd from the template one.
   anyway not a showstopper, but prone to improvement.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated (af13718 -> a5a4d1f)

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git.


from af13718  Fixed issues 41200 (#35)
 new fcf5aa4  added "Upload from local"
 new a25bdaf  typo fix
 new 68775fc  Update source/adminguide/templates.rst
 new 53aa3b6  Update source/adminguide/templates.rst
 new f33cc51  Update source/adminguide/templates.rst
 new 252b126  Update source/adminguide/templates.rst
 new a5a4d1f  Merge pull request #37 from andrijapanicsb/patch-5

The 68 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 source/adminguide/templates.rst | 12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)



[GitHub] [cloudstack] DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-04-03 Thread GitBox
DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-479451884
 
 
   @nathanejohnson can you give this a test, please? #worksforme 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the computer running the test.

2019-04-03 Thread GitBox
DaanHoogland commented on issue #3173: Mock Scanner, instead of scan the 
computer running the test.
URL: https://github.com/apache/cloudstack/pull/3173#issuecomment-479452181
 
 
   travis test run 7 always seems to fail, lately :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs

2019-04-03 Thread GitBox
blueorangutan commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may 
cause program crash, change mkdir to mkdirs
URL: https://github.com/apache/cloudstack/pull/3249#issuecomment-479431006
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs

2019-04-03 Thread GitBox
DaanHoogland commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may 
cause program crash, change mkdir to mkdirs
URL: https://github.com/apache/cloudstack/pull/3249#issuecomment-479430784
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated: reference 4.11.2 systemvm template

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/master by this push:
 new 3f9a3b6  reference 4.11.2 systemvm template
 new 335230d  Merge pull request #33 from andrijapanicsb/patch-3
3f9a3b6 is described below

commit 3f9a3b6e11d8a230c8f21165fb3a3656b2fae083
Author: Andrija Panic <45762285+andrijapani...@users.noreply.github.com>
AuthorDate: Thu Mar 21 17:16:45 2019 +0100

reference 4.11.2 systemvm template

reference 4.11.2 systemvm template
---
 source/quickinstallationguide/qig.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source/quickinstallationguide/qig.rst 
b/source/quickinstallationguide/qig.rst
index 656ea9e..ffdc8da 100644
--- a/source/quickinstallationguide/qig.rst
+++ b/source/quickinstallationguide/qig.rst
@@ -490,7 +490,7 @@ the system VMs images.
   

/usr/share/cloudstack-common/scripts/storage/secondary/cloud-install-sys-tmplt \
-m /export/secondary \
-   -u 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.1-kvm.qcow2.bz2
 \
+   -u 
http://download.cloudstack.org/systemvm/4.11/systemvmtemplate-4.11.2-kvm.qcow2.bz2
 \
-h kvm -F
 
 



[cloudstack-www] branch asf-site updated: Fix 4.12.0.0 download link pointing to http://www.apache.org/dyn/closer.lua/cloudstack/releases/4.12.0.0/apache-cloudstack-4.12.0.0-src.tar.bz2

2019-04-03 Thread gabriel
This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git


The following commit(s) were added to refs/heads/asf-site by this push:
 new e2ad5be  Fix 4.12.0.0 download link pointing to 
http://www.apache.org/dyn/closer.lua/cloudstack/releases/4.12.0.0/apache-cloudstack-4.12.0.0-src.tar.bz2
e2ad5be is described below

commit e2ad5be188c8ce1223119e2b4ed02352dd661041
Author: GabrielBrascher 
AuthorDate: Wed Apr 3 14:05:07 2019 -0300

Fix 4.12.0.0 download link pointing to

http://www.apache.org/dyn/closer.lua/cloudstack/releases/4.12.0.0/apache-cloudstack-4.12.0.0-src.tar.bz2
---
 content/downloads.html| 4 +++-
 source/downloads.html.erb | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/content/downloads.html b/content/downloads.html
index 0c53647..a649292 100644
--- a/content/downloads.html
+++ b/content/downloads.html
@@ -287,7 +287,7 @@
 This is non-LTS release of CloudStack.
 
 
-https://dist.apache.org/repos/dist/release/cloudstack/releases/4.12.0.0/apache-cloudstack-4.12.0.0-src.tar.bz2;>
+http://www.apache.org/dyn/closer.lua/cloudstack/releases/4.12.0.0/apache-cloudstack-4.12.0.0-src.tar.bz2;>
 
 Get the 4.12.0.0 Source
 
@@ -466,6 +466,8 @@ Additionally, you can verify the MD5 or SHA512 signatures 
on the files.
 You can find links to all the releases of Apache CloudStack on the archives page.
 
 
+
+
 
 Copyright © 2017 The Apache Software Foundation, Licensed 
under the Apache License, Version 2.0. 
 "Apache", "CloudStack", "Apache CloudStack", the Apache 
CloudStack logo, the Apache CloudStack Cloud Monkey logo and the Apache feather 
logos are registered trademarks or trademarks of The Apache Software 
Foundation.
diff --git a/source/downloads.html.erb b/source/downloads.html.erb
index 9901d03..e7e6ed2 100644
--- a/source/downloads.html.erb
+++ b/source/downloads.html.erb
@@ -161,7 +161,7 @@
 <% end %>
 
 
-https://dist.apache.org/repos/dist/release/cloudstack/releases/<%= 
data.cloudstack.versions.main %>/apache-cloudstack-<%= 
data.cloudstack.versions.main %>-src.tar.bz2">
+http://www.apache.org/dyn/closer.lua/cloudstack/releases/<%= 
data.cloudstack.versions.main %>/apache-cloudstack-<%= 
data.cloudstack.versions.main %>-src.tar.bz2">
 
 Get the <%= data.cloudstack.versions.main %> Source
 



[GitHub] [cloudstack] andrijapanicsb commented on issue #3138: StrongSwan with several rightsubnet's - ikev1

2019-04-03 Thread GitBox
andrijapanicsb commented on issue #3138: StrongSwan with several rightsubnet's 
- ikev1
URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-479662577
 
 
   OK, so after thorough testing with remote side being pfsense 2.4.4, with 2 
remote/right subnets (local to pfsense), and IKEv1 (ancient) and IKEv2, here 
are the findings below:
   
   - **default CloudStack 4.11.2 configuration works FINE with IKEv2** (when 
having 2 remote/right subnets) - zero hacks or anything - works perfectly well 
(when configured properly on both sides...)
   - virtually all HW/SW devices SHOULD support IKEv2, since it's almost 15 
years old now !
   - IKEv1 is dead old
   
   StrongSwan that comes with 4.11.2 systemVM template, is versioned 5.5 - it's 
behavior (through CloudStack) is to define "keyexchange=ike" in IPsec 
configuration file for each IPsec tunnel/connection - which (in this 5.5 
version means following):
   
   " Since (version) 5.0.0 both protocols are handled by Charon and connections 
marked with ike will use IKEv2 when initiating, but accept any protocol version 
when responding. " 
   
   This ^^^ is quote from 
https://wiki.strongswan.org/projects/strongswan/wiki/Connsection - and in 
previous versions of StrongSwan there were different defaults, and unless you 
were very explicit with IKE version (which CloudStack is NOT, to be able to 
handle both IKEv1 and IKEv2, for compatibility reasons) - in certain setups on 
remote side (in my example pfsense) the connections might not work.
   
   Example of what I mean:
   - from above quote, if remote side is INITIATING the IPsec tunnel, then 
CloudStack (StrongSwan) will accept both IKEv1 and IKEv2 (per the config 
"keyexchange=ike" and the quote above), whilst if CloudStack is the one 
initiating connections, it will (per the config "keyexchange=ike" and the quote 
from above) initiate connection as IKEv2. 
   - As mentioned above, in some of my testing - thing did fail - i.e. pfsense 
set to IKEv1, but I initiate connection from CloudStack, which by default uses 
IKEv2
   
   So solution for this multiple-right/remote-subnets is to make sure that on 
remote side you explicitly set IKEv2 in Phase1 configs, and also double-check 
other phase1 and phase2 configs which remains the common mistake even today 
(different algorithms, different DH group settings, etc - all these must match 
on both sides).
   
   I would appreciate if someone (confident enough in their IPsec guru skills) 
can test this in their (problematic) production and confirm the 
behavior/solution.
   
   Considering that we transitioned to StrongSwan, which was a needed step, and 
considering the IKEv2 is 15 years old now, I suggest we "encourage" users to 
actually use a newer IKEv2 standard (that is here for last 15 years, give or 
take) - simple as that - no need for workarounds with defining multiple child 
SAs etc. (which, I admit, have not tested myself).
   
   Opinions ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] andrijapanicsb commented on issue #3138: StrongSwan with several rightsubnet's - ikev1

2019-04-03 Thread GitBox
andrijapanicsb commented on issue #3138: StrongSwan with several rightsubnet's 
- ikev1
URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-479667728
 
 
   @pdion891 @ustcweizhou @JnSchl @onitake - can you please take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-03 Thread GitBox
nvazquez commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via 
UI
URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-479631341
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on a change in pull request #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-03 Thread GitBox
nvazquez commented on a change in pull request #3251: [WIP DO NOT MERGE] Add 
local ISO upload via UI
URL: https://github.com/apache/cloudstack/pull/3251#discussion_r271902301
 
 

 ##
 File path: server/src/main/java/com/cloud/template/TemplateAdapterBase.java
 ##
 @@ -284,35 +285,62 @@ public TemplateProfile prepare(RegisterTemplateCmd cmd) 
throws ResourceAllocatio
 
 }
 
-@Override
-public TemplateProfile prepare(GetUploadParamsForTemplateCmd cmd) throws 
ResourceAllocationException {
+/**
+ * Prepare upload parameters internal method for templates and ISOs local 
upload
+ */
+private TemplateProfile prepareUploadParamsInternal(boolean isIso, long 
userId, String name, String displayText,
 
 Review comment:
   Ok, how about now?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] fmaximus commented on issue #3146: RIP Nuage Cloudstack Plugin

2019-04-03 Thread GitBox
fmaximus commented on issue #3146: RIP Nuage Cloudstack Plugin
URL: https://github.com/apache/cloudstack/pull/3146#issuecomment-479656546
 
 
   I've solved the conflict.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs

2019-04-03 Thread GitBox
blueorangutan commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may 
cause program crash, change mkdir to mkdirs
URL: https://github.com/apache/cloudstack/pull/3249#issuecomment-479667261
 
 
   Trillian test result (tid-3464)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 38323 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3249-t3464-kvm-centos7.zip
   Intermittent failure detected: 
/marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
   Smoke tests completed. 67 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_04_verify_guest_lspci | `Error` | 810.69 | test_deploy_virtio_scsi_vm.py
   test_06_verify_guest_lspci_again | `Error` | 810.69 | 
test_deploy_virtio_scsi_vm.py
   test_01_ping_in_vr_success | `Error` | 60.78 | test_diagnostics.py
   test_02_ping_in_vr_failure | `Error` | 60.65 | test_diagnostics.py
   test_07_arping_in_vr | `Failure` | 5.21 | test_diagnostics.py
   test_08_arping_in_ssvm | `Failure` | 5.22 | test_diagnostics.py
   test_09_arping_in_cpvm | `Failure` | 5.21 | test_diagnostics.py
   test_hostha_enable_ha_when_host_disabled | `Error` | 4.66 | 
test_hostha_kvm.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.87 | 
test_hostha_kvm.py
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] fmaximus commented on issue #3152: Refactoring to remove duplicate code.

2019-04-03 Thread GitBox
fmaximus commented on issue #3152: Refactoring to remove duplicate code.
URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-479665169
 
 
   Sorry for the delay. I've resolved the conflicts.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
blueorangutan commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479666497
 
 
   Trillian test result (tid-3465)
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 28942 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3153-t3465-kvm-centos7.zip
   Smoke tests completed. 70 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates

2019-04-03 Thread GitBox
blueorangutan commented on issue #2995: KVM: Improvements on upload direct 
download certificates
URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-479507867
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2674


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] bd2019us commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may cause program crash, change mkdir to mkdirs

2019-04-03 Thread GitBox
bd2019us commented on issue #3249: [CLOUDSTACK-10406] fix bugs that may cause 
program crash, change mkdir to mkdirs
URL: https://github.com/apache/cloudstack/pull/3249#issuecomment-479515847
 
 
   @DaanHoogland Thanks for your information.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated: skip redundant key rpm import (#36)

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/master by this push:
 new ab96867  skip redundant key rpm import (#36)
ab96867 is described below

commit ab96867a5e1534b020c6b0aba205f384903cb891
Author: NuxRo 
AuthorDate: Wed Apr 3 14:47:22 2019 +0100

skip redundant key rpm import (#36)

skip redundant key rpm import, added key in repo file
---
 source/installguide/building_from_source.rst | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/source/installguide/building_from_source.rst 
b/source/installguide/building_from_source.rst
index b490ee2..f62d82a 100644
--- a/source/installguide/building_from_source.rst
+++ b/source/installguide/building_from_source.rst
@@ -225,15 +225,12 @@ Add a new yum repo ``/etc/yum.repos.d/mysql.repo``:
[mysql-community]
name=MySQL Community connectors

baseurl=http://repo.mysql.com/yum/mysql-connectors-community/el/$releasever/$basearch/
+   gpgkey=http://repo.mysql.com/RPM-GPG-KEY-mysql
enabled=1
gpgcheck=1
 
-Import GPG public key from MySQL:
-
 .. parsed-literal::
 
-   rpm --import http://repo.mysql.com/RPM-GPG-KEY-mysql
-
 Install mysql-connector
 
 .. parsed-literal::



[GitHub] [cloudstack] nvazquez commented on issue #2995: KVM: Improvements on upload direct download certificates

2019-04-03 Thread GitBox
nvazquez commented on issue #2995: KVM: Improvements on upload direct download 
certificates
URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-479499628
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #2995: KVM: Improvements on upload direct download certificates

2019-04-03 Thread GitBox
blueorangutan commented on issue #2995: KVM: Improvements on upload direct 
download certificates
URL: https://github.com/apache/cloudstack/pull/2995#issuecomment-47957
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
blueorangutan commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479466642
 
 
   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
nvazquez commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479466380
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
blueorangutan commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479473286
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2673


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch 4.11 updated: added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/4.11 by this push:
 new a70ee39  added updated instructions for ubuntu 18.04 and cloudstack 
4.11 (#24)
a70ee39 is described below

commit a70ee39c10f73ae262c83bf5358d81d8d8941122
Author: skattoju3 <45469763+skatto...@users.noreply.github.com>
AuthorDate: Wed Apr 3 08:53:25 2019 -0400

added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

* added updated instructions for ubuntu 18.04 and cloudstack 4.11

* removed tomcat install step

* removed install tomcat step

* Revert "removed tomcat install step" updated wrong part of doc

This reverts commit 347b4e97d1805f3df20feae49008672c1c2a8709.
---
 source/developersguide/developer_guide.rst | 220 -
 1 file changed, 215 insertions(+), 5 deletions(-)

diff --git a/source/developersguide/developer_guide.rst 
b/source/developersguide/developer_guide.rst
index 78cef01..82c4a90 100644
--- a/source/developersguide/developer_guide.rst
+++ b/source/developersguide/developer_guide.rst
@@ -17,10 +17,11 @@
 CloudStack Installation from GIT repo for Developers
 
 
-This book is aimed at CloudStack developers who need to build the code.
+This guide is aimed at CloudStack developers who need to build the code.
 These instructions are valid on a Ubuntu 12.04 and CentOS 6.4 systems
-and were tested with the 4.2 release of Apache CloudStack, please adapt
-them if you are on a different operating system or using a newer/older
+and were tested with the 4.2 release of Apache CloudStack. Instructions
+adapted for Ubuntu 18.04 and CloudStack 4.11 are also available. Please
+adapt them if you are on a different operating system or using a newer/older
 version of CloudStack. This book is composed of the following sections:
 
 #. Installation of the prerequisites
@@ -122,6 +123,73 @@ Finally install ``mkisofs`` with:
 
apt-get install genisoimage
 
+On Ubuntu 18.04
+~~~
+
+Run apt-get update to fetch the latest package list from the repo
+
+::
+
+   apt-get update
+
+NTP might already be installed, check it with ``service ntp status``. If
+it's not then install NTP to synchronize the clocks:
+
+::
+
+   apt-get install openntpd
+
+Install ``openjdk``. As we're using Linux, OpenJDK is our first choice.
+
+::
+
+   apt-get install openjdk-8-jdk
+
+Next, we'll install MySQL if it's not already present on the system.
+
+::
+
+   apt-get install mysql-server
+
+Remember to set the correct ``mysql`` password in the CloudStack
+properties file. Mysql should be running but you can check it's status
+with:
+
+::
+
+   service mysql status
+
+Developers wanting to build CloudStack from source will want to install
+the following additional packages. If you dont' want to build from
+source just jump to the next section.
+
+Install ``git`` to later clone the CloudStack source code:
+
+::
+
+   apt-get install git
+
+Install ``Maven`` to later build CloudStack
+
+::
+
+   apt-get install maven
+
+This should have installed Maven 3.0, check the version number with
+``mvn --version``
+
+A little bit of Python can be used (e.g simulator), install the Python
+package management tools:
+
+::
+
+   apt-get install python-pip python-setuptools
+
+Finally install ``mkisofs`` with:
+
+::
+
+   apt-get install genisoimage
 
 On CentOS 6.4
 ~
@@ -235,8 +303,8 @@ Finally install ``mkisofs`` with:
yum -y install genisoimage
 
 
-Installing from Source
---
+Installing version 4.8 from Source
+--
 
 CloudStack uses git for source version control, if you know little about
 `git `__ is a good start. Once you have git
@@ -355,6 +423,148 @@ advanced zone replace ``basic.cfg`` with ``advanced.cfg``.
 
 You can now run integration tests, use the API etc...
 
+Installing version 4.11 from Source
+--
+
+CloudStack uses git for source version control, if you know little about
+`git `__ is a good start. Once you have git
+setup on your machine, pull the source with:
+
+::
+
+   git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
+
+To build the latest stable release:
+
+::
+
+   git checkout 4.11
+
+Make sure you are using java 8. On Ubuntu you can run the following commands.
+To list available java installations:
+
+::
+
+   sudo update-java-alternatives -l
+
+To switch to java 8:
+
+::
+
+   sudo update-java-alternatives -s java-1.8.0-openjdk-amd64
+
+
+To compile Apache CloudStack, go to the cloudstack source folder and
+run:
+
+::
+
+   mvn -Pdeveloper,systemvm clean install
+
+If you want to skip the tests add ``-DskipTests`` to the command above.
+Do NOT use 

[GitHub] [cloudstack] nvazquez commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
nvazquez commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479476092
 
 
   @blueorangutan test


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch 4.12 updated: added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch 4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/4.12 by this push:
 new 17daec4  added updated instructions for ubuntu 18.04 and cloudstack 
4.11 (#24)
17daec4 is described below

commit 17daec4f93d1c4495fa13d4b7e0d3280ce265f83
Author: skattoju3 <45469763+skatto...@users.noreply.github.com>
AuthorDate: Wed Apr 3 08:53:25 2019 -0400

added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

* added updated instructions for ubuntu 18.04 and cloudstack 4.11

* removed tomcat install step

* removed install tomcat step

* Revert "removed tomcat install step" updated wrong part of doc

This reverts commit 347b4e97d1805f3df20feae49008672c1c2a8709.
---
 source/developersguide/developer_guide.rst | 220 -
 1 file changed, 215 insertions(+), 5 deletions(-)

diff --git a/source/developersguide/developer_guide.rst 
b/source/developersguide/developer_guide.rst
index 78cef01..82c4a90 100644
--- a/source/developersguide/developer_guide.rst
+++ b/source/developersguide/developer_guide.rst
@@ -17,10 +17,11 @@
 CloudStack Installation from GIT repo for Developers
 
 
-This book is aimed at CloudStack developers who need to build the code.
+This guide is aimed at CloudStack developers who need to build the code.
 These instructions are valid on a Ubuntu 12.04 and CentOS 6.4 systems
-and were tested with the 4.2 release of Apache CloudStack, please adapt
-them if you are on a different operating system or using a newer/older
+and were tested with the 4.2 release of Apache CloudStack. Instructions
+adapted for Ubuntu 18.04 and CloudStack 4.11 are also available. Please
+adapt them if you are on a different operating system or using a newer/older
 version of CloudStack. This book is composed of the following sections:
 
 #. Installation of the prerequisites
@@ -122,6 +123,73 @@ Finally install ``mkisofs`` with:
 
apt-get install genisoimage
 
+On Ubuntu 18.04
+~~~
+
+Run apt-get update to fetch the latest package list from the repo
+
+::
+
+   apt-get update
+
+NTP might already be installed, check it with ``service ntp status``. If
+it's not then install NTP to synchronize the clocks:
+
+::
+
+   apt-get install openntpd
+
+Install ``openjdk``. As we're using Linux, OpenJDK is our first choice.
+
+::
+
+   apt-get install openjdk-8-jdk
+
+Next, we'll install MySQL if it's not already present on the system.
+
+::
+
+   apt-get install mysql-server
+
+Remember to set the correct ``mysql`` password in the CloudStack
+properties file. Mysql should be running but you can check it's status
+with:
+
+::
+
+   service mysql status
+
+Developers wanting to build CloudStack from source will want to install
+the following additional packages. If you dont' want to build from
+source just jump to the next section.
+
+Install ``git`` to later clone the CloudStack source code:
+
+::
+
+   apt-get install git
+
+Install ``Maven`` to later build CloudStack
+
+::
+
+   apt-get install maven
+
+This should have installed Maven 3.0, check the version number with
+``mvn --version``
+
+A little bit of Python can be used (e.g simulator), install the Python
+package management tools:
+
+::
+
+   apt-get install python-pip python-setuptools
+
+Finally install ``mkisofs`` with:
+
+::
+
+   apt-get install genisoimage
 
 On CentOS 6.4
 ~
@@ -235,8 +303,8 @@ Finally install ``mkisofs`` with:
yum -y install genisoimage
 
 
-Installing from Source
---
+Installing version 4.8 from Source
+--
 
 CloudStack uses git for source version control, if you know little about
 `git `__ is a good start. Once you have git
@@ -355,6 +423,148 @@ advanced zone replace ``basic.cfg`` with ``advanced.cfg``.
 
 You can now run integration tests, use the API etc...
 
+Installing version 4.11 from Source
+--
+
+CloudStack uses git for source version control, if you know little about
+`git `__ is a good start. Once you have git
+setup on your machine, pull the source with:
+
+::
+
+   git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
+
+To build the latest stable release:
+
+::
+
+   git checkout 4.11
+
+Make sure you are using java 8. On Ubuntu you can run the following commands.
+To list available java installations:
+
+::
+
+   sudo update-java-alternatives -l
+
+To switch to java 8:
+
+::
+
+   sudo update-java-alternatives -s java-1.8.0-openjdk-amd64
+
+
+To compile Apache CloudStack, go to the cloudstack source folder and
+run:
+
+::
+
+   mvn -Pdeveloper,systemvm clean install
+
+If you want to skip the tests add ``-DskipTests`` to the command above.
+Do NOT use 

[GitHub] [cloudstack] blueorangutan commented on issue #3153: DPDK vHost User mode selection

2019-04-03 Thread GitBox
blueorangutan commented on issue #3153: DPDK vHost User mode selection
URL: https://github.com/apache/cloudstack/pull/3153#issuecomment-479476443
 
 
   @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[cloudstack-documentation] branch master updated: added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

2019-04-03 Thread paul_a
This is an automated email from the ASF dual-hosted git repository.

paul_a pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git


The following commit(s) were added to refs/heads/master by this push:
 new daf64ed  added updated instructions for ubuntu 18.04 and cloudstack 
4.11 (#24)
daf64ed is described below

commit daf64edee9901292b0e5fa156ac35c8373966402
Author: skattoju3 <45469763+skatto...@users.noreply.github.com>
AuthorDate: Wed Apr 3 08:53:25 2019 -0400

added updated instructions for ubuntu 18.04 and cloudstack 4.11 (#24)

* added updated instructions for ubuntu 18.04 and cloudstack 4.11

* removed tomcat install step

* removed install tomcat step

* Revert "removed tomcat install step" updated wrong part of doc

This reverts commit 347b4e97d1805f3df20feae49008672c1c2a8709.
---
 source/developersguide/developer_guide.rst | 220 -
 1 file changed, 215 insertions(+), 5 deletions(-)

diff --git a/source/developersguide/developer_guide.rst 
b/source/developersguide/developer_guide.rst
index 78cef01..82c4a90 100644
--- a/source/developersguide/developer_guide.rst
+++ b/source/developersguide/developer_guide.rst
@@ -17,10 +17,11 @@
 CloudStack Installation from GIT repo for Developers
 
 
-This book is aimed at CloudStack developers who need to build the code.
+This guide is aimed at CloudStack developers who need to build the code.
 These instructions are valid on a Ubuntu 12.04 and CentOS 6.4 systems
-and were tested with the 4.2 release of Apache CloudStack, please adapt
-them if you are on a different operating system or using a newer/older
+and were tested with the 4.2 release of Apache CloudStack. Instructions
+adapted for Ubuntu 18.04 and CloudStack 4.11 are also available. Please
+adapt them if you are on a different operating system or using a newer/older
 version of CloudStack. This book is composed of the following sections:
 
 #. Installation of the prerequisites
@@ -122,6 +123,73 @@ Finally install ``mkisofs`` with:
 
apt-get install genisoimage
 
+On Ubuntu 18.04
+~~~
+
+Run apt-get update to fetch the latest package list from the repo
+
+::
+
+   apt-get update
+
+NTP might already be installed, check it with ``service ntp status``. If
+it's not then install NTP to synchronize the clocks:
+
+::
+
+   apt-get install openntpd
+
+Install ``openjdk``. As we're using Linux, OpenJDK is our first choice.
+
+::
+
+   apt-get install openjdk-8-jdk
+
+Next, we'll install MySQL if it's not already present on the system.
+
+::
+
+   apt-get install mysql-server
+
+Remember to set the correct ``mysql`` password in the CloudStack
+properties file. Mysql should be running but you can check it's status
+with:
+
+::
+
+   service mysql status
+
+Developers wanting to build CloudStack from source will want to install
+the following additional packages. If you dont' want to build from
+source just jump to the next section.
+
+Install ``git`` to later clone the CloudStack source code:
+
+::
+
+   apt-get install git
+
+Install ``Maven`` to later build CloudStack
+
+::
+
+   apt-get install maven
+
+This should have installed Maven 3.0, check the version number with
+``mvn --version``
+
+A little bit of Python can be used (e.g simulator), install the Python
+package management tools:
+
+::
+
+   apt-get install python-pip python-setuptools
+
+Finally install ``mkisofs`` with:
+
+::
+
+   apt-get install genisoimage
 
 On CentOS 6.4
 ~
@@ -235,8 +303,8 @@ Finally install ``mkisofs`` with:
yum -y install genisoimage
 
 
-Installing from Source
---
+Installing version 4.8 from Source
+--
 
 CloudStack uses git for source version control, if you know little about
 `git `__ is a good start. Once you have git
@@ -355,6 +423,148 @@ advanced zone replace ``basic.cfg`` with ``advanced.cfg``.
 
 You can now run integration tests, use the API etc...
 
+Installing version 4.11 from Source
+--
+
+CloudStack uses git for source version control, if you know little about
+`git `__ is a good start. Once you have git
+setup on your machine, pull the source with:
+
+::
+
+   git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
+
+To build the latest stable release:
+
+::
+
+   git checkout 4.11
+
+Make sure you are using java 8. On Ubuntu you can run the following commands.
+To list available java installations:
+
+::
+
+   sudo update-java-alternatives -l
+
+To switch to java 8:
+
+::
+
+   sudo update-java-alternatives -s java-1.8.0-openjdk-amd64
+
+
+To compile Apache CloudStack, go to the cloudstack source folder and
+run:
+
+::
+
+   mvn -Pdeveloper,systemvm clean install
+
+If you want to skip the tests add ``-DskipTests`` to the command above.
+Do NOT use