[GitHub] [cloudstack] weizhouapache commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
weizhouapache commented on issue #3981: Cannot build packages with latest 
master on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601583807
 
 
   @DaanHoogland it might because the PR is huge.
   
   
https://github.com/shapeblue/cloudstack/blob/f753d030033e9b598b179f4c7a1945cfef73b6c3/debian/rules#L144
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3981: Cannot build packages with latest master 
on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601582477
 
 
   @weizhouapache , your link does not point to a line but to the whole diff.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3981: Cannot build packages with latest master 
on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601590648
 
 
   tnx @weizhouapache , can you try with only the last @ removed from that line?
   again, it is strange that the package build would work in the lab but not on 
your env. It might be as simple as that though ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3981: Cannot build packages with latest master 
on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601590901
 
 
   ping @nvazquez , please have a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] weizhouapache commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
weizhouapache commented on issue #3981: Cannot build packages with latest 
master on Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601595479
 
 
   @DaanHoogland I have tried with removing "@" yesterday, did not work
   hence I remove whole "-pcloudstack-rolling-maintenance@", it works


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Spaceman1984 commented on issue #3973: systemd dependency on db

2020-03-20 Thread GitBox
Spaceman1984 commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-601586004
 
 
   I edited the cloudstack-management.service file:
   ```
   [Unit]
   Description=CloudStack Management Server
   After=syslog.target network.target mysqld.service
   Wants=mysqld.service
   ```
   and ran
   
   `systemctl start cloudstack-management`
   
   In this case, mysqld started before cloudstack-management, but after 
executing:
   
   `systemctl stop mysqld`
   
   to see what happens when mysqld is stopped, cloudstack-management didn't 
stop and started throwing errors.
   
   By chaning the cloudstack-management.service file to:
   ```
   [Unit]
   Description=CloudStack Management Server
   After=syslog.target network.target mysqld.service
   Requires=mysqld.service
   ```
   and executing
   
   `systemctl stop mysqld`
   
   cloudstack was stopped first before mysql was stopped.
   
   By my testing, using "Wants", instead of "Requires", mysqld will start 
before cloudstack-management, but will not shut down cloudstack-management 
before mysqld.
   
   I will take a look at a solution


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] nvazquez commented on issue #3981: Cannot build packages with latest master on Ubuntu 18.04

2020-03-20 Thread GitBox
nvazquez commented on issue #3981: Cannot build packages with latest master on 
Ubuntu 18.04
URL: https://github.com/apache/cloudstack/issues/3981#issuecomment-601674731
 
 
   @weizhouapache @DaanHoogland taking a look at it, spinning up an ubuntu 18 
env to try replicating, let me update you soon


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3949: Fix: catch CloudRuntimeException in LibvirtGetVolumeStatsCommandWrapper.java

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3949: Fix: catch CloudRuntimeException in 
LibvirtGetVolumeStatsCommandWrapper.java
URL: https://github.com/apache/cloudstack/pull/3949#issuecomment-601754641
 
 
   @andrijapanicsb pure bug fix, do we include it given blockers are still out?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] Spaceman1984 commented on issue #3949: Fix: catch CloudRuntimeException in LibvirtGetVolumeStatsCommandWrapper.java

2020-03-20 Thread GitBox
Spaceman1984 commented on issue #3949: Fix: catch CloudRuntimeException in 
LibvirtGetVolumeStatsCommandWrapper.java
URL: https://github.com/apache/cloudstack/pull/3949#issuecomment-601742398
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601742495
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
DaanHoogland removed a comment on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-600194661
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601741928
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
blueorangutan removed a comment on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-600195148
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
DaanHoogland commented on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601809257
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] DaanHoogland removed a comment on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
DaanHoogland removed a comment on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601741928
 
 
   @blueorangutan test matrix


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
blueorangutan commented on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601809436
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan removed a comment on issue #3768: [HEALTH][4.13] Health Check Run

2020-03-20 Thread GitBox
blueorangutan removed a comment on issue #3768: [HEALTH][4.13] Health Check Run
URL: https://github.com/apache/cloudstack/pull/3768#issuecomment-601742495
 
 
   @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 
mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3973: systemd dependency on db

2020-03-20 Thread GitBox
rvalle commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-601996284
 
 
   @Spaceman1984 did you remember the daemon-reload after the changes?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3973: systemd dependency on db

2020-03-20 Thread GitBox
rvalle commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-601996318
 
 
   @DaanHoogland I will test this weekend


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle edited a comment on issue #3973: systemd dependency on db

2020-03-20 Thread GitBox
rvalle edited a comment on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-601999862
 
 
   @DaanHoogland I managed to get some testing now...
   @Spaceman1984 you were right adding Wants/After and stopping mysql does 
not stop CSM.
   However adding Requires/After DOES work... which has some other implications.
   
   This seems to imply that Wants/Requires do have semantic differences other 
than the ones we have discussed before... I am back to the Systemd 
documentation... see if I can find the details.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] blueorangutan commented on issue #3976: Enable sending hypervior host name via metadata - VR and Config Drive

2020-03-20 Thread GitBox
blueorangutan commented on issue #3976: Enable sending hypervior host name via 
metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#issuecomment-601987047
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1075


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack] rvalle commented on issue #3973: systemd dependency on db

2020-03-20 Thread GitBox
rvalle commented on issue #3973: systemd dependency on db
URL: https://github.com/apache/cloudstack/pull/3973#issuecomment-601999862
 
 
   @DaanHoogland I managed to get some testing now...
   @Spaceman1984 you were right adding Wants/After and stopping mysql does 
not stop CSM.
   However adding Wants/Requires DOES work... which has some other implications.
   
   This seems to imply that Wants/Requires do have semantic differences other 
than the ones we have discussed before... I am back to the Systemd 
documentation... see if I can find the details.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services