[GitHub] erisu commented on issue #391: CocoaPods Improvement
erisu commented on issue #391: CocoaPods Improvement URL: https://github.com/apache/cordova-ios/issues/391#issuecomment-420521439 ### Pull Requests - https://github.com/apache/cordova-common/pull/48 - https://github.com/apache/cordova-ios/pull/405 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] knight9999 opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml
knight opened a new pull request #405: Cocoapods support improvement, using podspec tag in plugin.xml URL: https://github.com/apache/cordova-ios/pull/405 ### Platforms affected ios ### What does this PR do? - Cocoapods Support Improvement - Support Custom Cocoapods Repository - Added Test Code See https://github.com/apache/cordova-discuss/pull/108 The following PR is needed to be merged first https://github.com/apache/cordova-common/pull/48 ### What testing has been done on this change? - Local Plugin Test (`cordova plugin add` which uses `podspec` tags to local PC) - `npm run test` Because this PR depends on PR (https://github.com/apache/cordova-common/pull/48), the test fails without editing package.json. With modified package.json, both the travis and appveyor tests passes. - (Source) https://github.com/cordova-develop/cordova-ios/commits/dev_improve_cocoapod_support_test - https://ci.appveyor.com/project/knight/cordova-ios/build/1.0.33 - https://travis-ci.org/cordova-develop/cordova-ios/builds/427520541?utm_source=github_status_medium=notification ### Checklist - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] sandeep2244 opened a new issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working
sandeep2244 opened a new issue #494: Change from CordovaWebView to
SystemWebView in latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494
I stuck in my old version Android App based on Codova
I updated My Android App to latest version android@7.0.0
Now where i used CordovaWebView for for Webview in my app as follows
```
```
but it's not present in latest version of Cordova. So I changed to it by
below lines
where i am using WebRtc for my App So I used following method of
SystemWebView Class
```
cwv.setWebChromeClient(new WebChromeClient() {
@Override
public void onPermissionRequest(final PermissionRequest request)
{
javaToJavascript.webrtcCallLog("web.java", "permission asked
is"+Arrays.deepToString(request.getResources()),0); //This logs the type of
permission asked
Log.i("The list of permission asked is ",
Arrays.deepToString(request.getResources())); // this askes for
android.webkit.resource.AUDIO_CAPTURE permission
getActivity().runOnUiThread(new Runnable() {
@TargetApi(Build.VERSION_CODES.LOLLIPOP)
@Override
public void run() {
Log.i("Value Of the permission asked is ", request
.getOrigin().toString());
request.grant(request.getResources());
}
});
}
});
```
Now i got runtime error in my Main java file regarding classCastException
java.lang.RuntimeException: Unable to start activity
ComponentInfo{com.simCard.web/com.simCard.web.WebCall}:
java.lang.ClassCastException: com.simCard.web.WebCall$1 cannot be cast to
org.apache.cordova.engine.SystemWebChromeClient
How to solve This error ? Please any ones help will be grateful
Thank you
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #57: package.json use xcode@1 (1.x.x)
erisu commented on issue #57: package.json use xcode@1 (1.x.x) URL: https://github.com/apache/cordova-osx/pull/57#issuecomment-420512061 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #56: Test framework consistency
erisu commented on issue #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56#issuecomment-420512037 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #55: Upgrade cordova common
erisu commented on issue #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55#issuecomment-420512002 Commits cherry-picked from @brodybits' PR #49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu opened a new pull request #57: package.json use xcode@1 (1.x.x)
erisu opened a new pull request #57: package.json use xcode@1 (1.x.x) URL: https://github.com/apache/cordova-osx/pull/57 ### Platforms affected osx ### What does this PR do? - bumps xcode dependency to `^1.0.0` ### What testing has been done on this change? - `npm test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu opened a new pull request #56: Test framework consistency
erisu opened a new pull request #56: Test framework consistency URL: https://github.com/apache/cordova-osx/pull/56 ### Platforms affected osx ### What does this PR do? Makes the testing framework consistent the testing framework used in our other platform and tooling repos. - Drops jasmine-node dependency - Adds jasmine dependency ### What testing has been done on this change? - `npm test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu opened a new pull request #55: Upgrade cordova common
erisu opened a new pull request #55: Upgrade cordova common URL: https://github.com/apache/cordova-osx/pull/55 ### Platforms affected osx ### What does this PR do? - Bumps cordova-common to ^2.2.5 ### What testing has been done on this change? - `npm test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
svn commit: r1840621 - in /cordova/site/public: docs/en/dev/config_ref/images.html docs/en/dev/reference/cordova-cli/index.html docs/en/dev/reference/cordova-plugin-statusbar/index.html feed.xml
Author: steven Date: Wed Sep 12 02:14:25 2018 New Revision: 1840621 URL: http://svn.apache.org/viewvc?rev=1840621=rev Log: Updated docs Modified: cordova/site/public/docs/en/dev/config_ref/images.html cordova/site/public/docs/en/dev/reference/cordova-cli/index.html cordova/site/public/docs/en/dev/reference/cordova-plugin-statusbar/index.html cordova/site/public/feed.xml Modified: cordova/site/public/docs/en/dev/config_ref/images.html URL: http://svn.apache.org/viewvc/cordova/site/public/docs/en/dev/config_ref/images.html?rev=1840621=1840620=1840621=diff == --- cordova/site/public/docs/en/dev/config_ref/images.html (original) +++ cordova/site/public/docs/en/dev/config_ref/images.html Wed Sep 12 02:14:25 2018 @@ -2478,7 +2478,7 @@ If you do not specify an icon, the Apach src -Required Location of the image file, relative to your project directory +Required Location of the image file, relative to your project directory. platform @@ -2493,10 +2493,6 @@ If you do not specify an icon, the Apach Optional Icon height in pixels -density -Optional Android Specified icon density - - target Optional Windows Destination filename for the image file and all its MRT companions @@ -2510,6 +2506,78 @@ which will be used for all platforms. Android + +On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an Adaptive Icon. + + + +Attributes +Description + + + +background +Required for Adaptive Location of the image (png or vector) relative to your project directory, or color reference + + +foreground +Required for Adaptive Location of the image (png or vector) relative to your project directory, or color reference + + +density +Optional Specified icon density + + + +Adaptive Icons + +To use the adaptive icons the background and foreground attributes must be defined in place of the src attribute. The src attribute is not used for adaptive icons. + +Adaptive Icon with Images: +platform name="android" + icon background="res/icon/android/ldpi-background.png" density="ldpi" foreground="res/icon/android/ldpi-foreground.png" / + icon background="res/icon/android/mdpi-background.png" density="mdpi" foreground="res/icon/android/mdpi-foreground.png" / + icon background="res/icon/android/hdpi-background.png" density="hdpi" foreground="res/icon/android/hdpi-foreground.png" / + icon background="res/icon/android/xhdpi-background.png" density="xhdpi" foreground="res/icon/android/xhdpi-foreground.png" / + icon background="res/icon/android/xxhdpi-background.png" density="xxhdpi" foreground="res/icon/android/xxhdpi-foreground.png" / + icon background="res/icon/android/xxxhdpi-background.png" density="xxxhdpi" foreground="res/icon/android/xxxhdpi-foreground.png" / +/platform + +Note: In this example, the foreground image will also be used as the fallback icon for Android devices that do not support the adaptive icons. The fallback icon can be overridden by setting the src attribute. + +Adaptive Icon with Vectors: +platform name="android" + icon background="res/icon/android/ldpi-background.xml" density="ldpi" foreground="res/icon/android/ldpi-foreground.xml" src="res/android/ldpi.png" / + icon background="res/icon/android/mdpi-background.xml" density="mdpi" foreground="res/icon/android/mdpi-foreground.xml" src="res/android/mdpi.png" / + icon background="res/icon/android/hdpi-background.xml" density="hdpi" foreground="res/icon/android/hdpi-foreground.xml" src="res/android/hdpi.png" / + icon background="res/icon/android/xhdpi-background.xml" density="xhdpi" foreground="res/icon/android/xhdpi-foreground.xml" src="res/android/xhdpi.png" / + icon background="res/icon/android/xxhdpi-background.xml" density="xxhdpi" foreground="res/icon/android/xxhdpi-foreground.xml" src="res/android/xxhdpi.png" / + icon background="res/icon/android/xxxhdpi-background.xml" density="xxxhdpi" foreground="res/icon/android/xxxhdpi-foreground.xml" src="res/android/xxxhdpi.png" / +/platform + +Note: In this example, the src attribute must be defined when then foreground attribute is defined with a vector or color. + +Adaptive Icon with Colors: + +Create a res/values/colors.xml resource file in your project directory to store the apps color definitions. +?xml version="1.0" encoding="utf-8"? +resources +color name="background"#FF/color +/resources + +In the config.xml, we will add resource-file to copy the colors.xml into the approprate location so that the colors are available during build time. +platform name="android" + resource-file src="res/values/colors.xml" target="/app/src/main/res/values/colors.xml" / + + icon background="@color/background" density="ldpi" foreground="res/icon/android/ldpi-foreground.png" / + icon background="@color/background" density="mdpi" foreground="res/icon/android/mdpi-foreground.png" / + icon
[GitHub] knight9999 commented on issue #880: About SwiftSupport
knight commented on issue #880: About SwiftSupport URL: https://github.com/apache/cordova-docs/pull/880#issuecomment-420487453 @janpio Thanks for the advice. I have updated my PR to use ` ==iOS==` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu closed pull request #830: CB-13685 android: Added adaptive icon docs
erisu closed pull request #830: CB-13685 android: Added adaptive icon docs URL: https://github.com/apache/cordova-docs/pull/830 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-docs] branch master updated: CB-13685 android: Added adaptive icon docs (#830)
This is an automated email from the ASF dual-hosted git repository. erisu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-docs.git The following commit(s) were added to refs/heads/master by this push: new d52d998 CB-13685 android: Added adaptive icon docs (#830) d52d998 is described below commit d52d9982ad737ec02e4374e09f6d75f454db60b0 Author: エリス AuthorDate: Wed Sep 12 10:45:12 2018 +0900 CB-13685 android: Added adaptive icon docs (#830) --- www/docs/en/dev/config_ref/images.md | 85 1 file changed, 76 insertions(+), 9 deletions(-) diff --git a/www/docs/en/dev/config_ref/images.md b/www/docs/en/dev/config_ref/images.md index 5520f9d..f499023 100644 --- a/www/docs/en/dev/config_ref/images.md +++ b/www/docs/en/dev/config_ref/images.md @@ -37,11 +37,10 @@ If you do not specify an icon, the Apache Cordova logo is used. Attributes| Description --| -src | *Required* Location of the image file, relative to your project directory +src | *Required* Location of the image file, relative to your project directory. platform | *Optional* Target platform width | *Optional* Icon width in pixels height| *Optional* Icon height in pixels -density | *Optional* ==Android== Specified icon density target| *Optional* ==Windows== Destination filename for the image file and all its' MRT companions @@ -53,7 +52,74 @@ which will be used for all platforms. For each platform, you can also define a pixel-perfect icon set to fit different screen resolutions. -##Android +## Android + +On Android, instead of using a single image for an icon, you can use two images (background and foreground) to create an **Adaptive Icon**. + +Attributes| Description +--| +background| *Required for Adaptive* Location of the image (png or vector) relative to your project directory, or color reference +foreground| *Required for Adaptive* Location of the image (png or vector) relative to your project directory, or color reference +density | *Optional* Specified icon density + +### Adaptive Icons + +To use the adaptive icons the `background` and `foreground` attributes must be defined in place of the `src` attribute. The `src` attribute is not used for adaptive icons. + + Adaptive Icon with Images: +```xml + + + + + + + + +``` + +**Note:** In this example, the foreground image will also be used as the fallback icon for Android devices that do not support the adaptive icons. The fallback icon can be overridden by setting the src attribute. + + Adaptive Icon with Vectors: +```xml + + + + + + + + +``` + +**Note:** In this example, the src attribute must be defined when then foreground attribute is defined with a vector or color. + + Adaptive Icon with Colors: +Create a `res/values/colors.xml` resource file in your project directory to store the app's color definitions. +```xml + + +#FF + +``` + +In the `config.xml`, we will add `resource-file` to copy the `colors.xml` into the approprate location so that the colors are available during build time. + +```xml + + + + + + + + + + +``` + +### Standard Icons + ```xml @@ -114,10 +181,10 @@ Icons are not applicable to the Browser platform. ``` -###See Also +### See Also - [App Icons on iPad and iPhone](https://developer.apple.com/library/content/qa/qa1686/_index.html) -##Windows +## Windows For Windows the recommended approach to define application icons is to use the `target` attribute. @@ -176,7 +243,7 @@ Although it is not recommended, it is also possible to define icons using the `w ``` -###See Also: +### See Also: - [Windows 10 platform guidelines for icons](https://msdn.microsoft.com/en-us/library/windows/apps/mt412102.aspx). - [Windows 8.1 tiles and icons sizes](https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh781198.aspx) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] davidgovea commented on issue #114: Not working on Android devices
davidgovea commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-420480600 Working fine for me on 8.0, and 8.1 devices. However, I am experiencing intermittent timeout issues on **some** devices (which all happen to be Samsungs -- but not every samsung has issues). I suspect that it's a permission/system issue related to Samsung's mangling of android OS. Try opening google maps, acquiring position, and then try again. Obviously, this is not a fix, but I don't think the blame sits with this library. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] ArGaspar commented on issue #114: Not working on Android devices
ArGaspar commented on issue #114: Not working on Android devices URL: https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-420459771 Is this plugin getting updated for android 8.0 or do we have to move on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #198: Remove instructions on how to bundle dependencies
dpogue closed pull request #198: Remove instructions on how to bundle dependencies URL: https://github.com/apache/cordova-coho/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] 01/01: Merge pull request #198 from apache/remove-bundled-dependencies
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit 318cd51ebba1d733d8002be6141915b279965339 Merge: 2eff92c f4ecced Author: Darryl Pogue AuthorDate: Tue Sep 11 15:03:15 2018 -0700 Merge pull request #198 from apache/remove-bundled-dependencies Remove instructions on how to bundle dependencies docs/platforms-release-process.md | 11 --- 1 file changed, 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] branch remove-bundled-dependencies deleted (was f4ecced)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch remove-bundled-dependencies in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. was f4ecced Remove instructions on how to bundle dependencies The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] branch master updated (2eff92c -> 318cd51)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. from 2eff92c Merge pull request #197 from raphinesse/browserify-nomore add f4ecced Remove instructions on how to bundle dependencies new 318cd51 Merge pull request #198 from apache/remove-bundled-dependencies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/platforms-release-process.md | 11 --- 1 file changed, 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue commented on issue #198: Remove instructions on how to bundle dependencies
dpogue commented on issue #198: Remove instructions on how to bundle dependencies URL: https://github.com/apache/cordova-coho/pull/198#issuecomment-420441260 I have no idea what the tests are doing (why are they running 4 times?), but your change isn't testable code anyways, so let's merge it... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-browser] 01/01: Merge pull request #59 from raphinesse/remove-bundled-dependencies
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git commit f23c998241314144b9a0c670094c59ead68e1aef Merge: ffdc001 4e8f62a Author: Darryl Pogue AuthorDate: Tue Sep 11 15:01:57 2018 -0700 Merge pull request #59 from raphinesse/remove-bundled-dependencies Remove bundled dependencies .gitignore | 7 - node_modules/.bin/nopt | 1 - node_modules/.bin/shjs | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |97 - node_modules/accepts/HISTORY.md| 218 - node_modules/accepts/LICENSE |23 - node_modules/accepts/README.md | 143 - node_modules/accepts/index.js | 238 - node_modules/accepts/package.json | 121 - node_modules/ansi-regex/index.js | 4 - node_modules/ansi-regex/license|21 - node_modules/ansi-regex/package.json | 132 - node_modules/ansi-regex/readme.md |39 - node_modules/ansi-styles/index.js |65 - node_modules/ansi-styles/license |21 - node_modules/ansi-styles/package.json | 114 - node_modules/ansi-styles/readme.md |86 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |93 - node_modules/array-flatten/LICENSE |21 - node_modules/array-flatten/README.md |43 - node_modules/array-flatten/array-flatten.js|64 - node_modules/array-flatten/package.json|96 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 112 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 101 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 node_modules/big-integer/BigInteger.js | 1251 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 115 - node_modules/big-integer/tsconfig.json |25 - node_modules/body-parser/HISTORY.md| 568 - node_modules/body-parser/LICENSE |23 - node_modules/body-parser/README.md | 438 - node_modules/body-parser/index.js | 157 - node_modules/body-parser/lib/read.js | 181 - node_modules/body-parser/lib/types/json.js | 232 - node_modules/body-parser/lib/types/raw.js | 101 - node_modules/body-parser/lib/types/text.js | 121 - node_modules/body-parser/lib/types/urlencoded.js | 284 - node_modules/body-parser/package.json | 126 - node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|89 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes
[cordova-browser] branch master updated (ffdc001 -> f23c998)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-browser.git. from ffdc001 CB-14073 browser: Drop Node 4, Added Node 10 add 41176ad Remove bundledDependencies key from package.json add 82531ba Ignore the whole node_modules folder add 4e8f62a Remove bundled node_modules new f23c998 Merge pull request #59 from raphinesse/remove-bundled-dependencies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore | 7 - node_modules/.bin/nopt | 1 - node_modules/.bin/shjs | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |97 - node_modules/accepts/HISTORY.md| 218 - node_modules/accepts/LICENSE |23 - node_modules/accepts/README.md | 143 - node_modules/accepts/index.js | 238 - node_modules/accepts/package.json | 121 - node_modules/ansi-regex/index.js | 4 - node_modules/ansi-regex/license|21 - node_modules/ansi-regex/package.json | 132 - node_modules/ansi-regex/readme.md |39 - node_modules/ansi-styles/index.js |65 - node_modules/ansi-styles/license |21 - node_modules/ansi-styles/package.json | 114 - node_modules/ansi-styles/readme.md |86 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |93 - node_modules/array-flatten/LICENSE |21 - node_modules/array-flatten/README.md |43 - node_modules/array-flatten/array-flatten.js|64 - node_modules/array-flatten/package.json|96 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 112 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 101 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 node_modules/big-integer/BigInteger.js | 1251 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 115 - node_modules/big-integer/tsconfig.json |25 - node_modules/body-parser/HISTORY.md| 568 - node_modules/body-parser/LICENSE |23 - node_modules/body-parser/README.md | 438 - node_modules/body-parser/index.js | 157 - node_modules/body-parser/lib/read.js | 181 - node_modules/body-parser/lib/types/json.js | 232 - node_modules/body-parser/lib/types/raw.js | 101 - node_modules/body-parser/lib/types/text.js | 121 - node_modules/body-parser/lib/types/urlencoded.js | 284 - node_modules/body-parser/package.json | 126 - node_modules/bplist-parser/.npmignore | 8 -
[GitHub] raphinesse commented on issue #162: [CB-14156] Remove browserify - NOT TESTED
raphinesse commented on issue #162: [CB-14156] Remove browserify - NOT TESTED URL: https://github.com/apache/cordova-js/pull/162#issuecomment-420431473 I've taken the liberty to rebase these changes and remove the last traces of browserify that I could find. I also removed the *WIP* in the title, as this is now finished IMHO. @brodybits Could you explain what you mean by "known to fail `npm test`"? The CI tests all passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse closed issue #9: Purge remnants of `fetch` option support
raphinesse closed issue #9: Purge remnants of `fetch` option support URL: https://github.com/apache/cordova/issues/9 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-cli] branch master updated: Remove support for fetch option (#322)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git
The following commit(s) were added to refs/heads/master by this push:
new 20af4ec Remove support for fetch option (#322)
20af4ec is described below
commit 20af4ecfd32a52d3151e95a496b18cd50022e147
Author: Raphael von der Grün
AuthorDate: Tue Sep 11 22:50:40 2018 +0200
Remove support for fetch option (#322)
---
spec/cli.spec.js | 60 ++--
src/cli.js | 3 ---
2 files changed, 6 insertions(+), 57 deletions(-)
diff --git a/spec/cli.spec.js b/spec/cli.spec.js
index 26afc93..fcf9a6c 100644
--- a/spec/cli.spec.js
+++ b/spec/cli.spec.js
@@ -79,37 +79,37 @@ describe('cordova cli', () => {
it('Test#005 : will call command with all arguments passed through',
() => {
return cli(['node', 'cordova', 'build', 'blackberry10', '--',
'-k', 'abcd1234']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { argv: ['-k', 'abcd1234'] }, verbose: false,
silent: false, fetch: true, nohooks: [ ], searchpath: undefined });
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { argv: ['-k', 'abcd1234'] }, verbose: false,
silent: false, nohooks: [ ], searchpath: undefined });
});
}, 6);
it('Test#006 : will consume the first instance of -d', () => {
return cli(['node', 'cordova', '-d', 'build', 'blackberry10',
'--', '-k', 'abcd1234', '-d']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] },
verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined
});
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] },
verbose: true, silent: false, nohooks: [ ], searchpath: undefined });
});
});
it('Test#007 : will consume the first instance of --verbose', () => {
return cli(['node', 'cordova', '--verbose', 'build',
'blackberry10', '--', '-k', 'abcd1234', '--verbose']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234',
'--verbose'] }, verbose: true, silent: false, fetch: true, nohooks: [ ],
searchpath: undefined });
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234',
'--verbose'] }, verbose: true, silent: false, nohooks: [ ], searchpath:
undefined });
});
});
it('Test#008 : will consume the first instance of either --verbose or
-d', () => {
return cli(['node', 'cordova', '--verbose', 'build',
'blackberry10', '--', '-k', 'abcd1234', '-d']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] },
verbose: true, silent: false, fetch: true, nohooks: [ ], searchpath: undefined
});
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234', '-d'] },
verbose: true, silent: false, nohooks: [ ], searchpath: undefined });
});
});
it('Test#009 : will consume the first instance of either --verbose or
-d', () => {
return cli(['node', 'cordova', '-d', 'build', 'blackberry10',
'--', '-k', 'abcd1234', '--verbose']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234',
'--verbose'] }, verbose: true, silent: false, fetch: true, nohooks: [ ],
searchpath: undefined });
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { verbose: true, argv: ['-k', 'abcd1234',
'--verbose'] }, verbose: true, silent: false, nohooks: [ ], searchpath:
undefined });
});
});
it('Test#010 : will consume the first instance of --silent', () => {
return cli(['node', 'cordova', '--silent', 'build',
'blackberry10', '--', '-k', 'abcd1234', '--silent']).then(() => {
-expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { silent: true, argv: ['-k', 'abcd1234', '--silent']
}, verbose: false, silent: true, fetch: true, nohooks: [ ], searchpath:
undefined });
+expect(cordova.build).toHaveBeenCalledWith({ platforms:
['blackberry10'], options: { silent: true, argv: ['-k', 'abcd1234', '--silent']
}, verbose: false, silent: true, nohooks: [ ],
[GitHub] raphinesse opened a new pull request #198: Remove instructions on how to bundle dependencies
raphinesse opened a new pull request #198: Remove instructions on how to bundle dependencies URL: https://github.com/apache/cordova-coho/pull/198 Part of https://github.com/apache/cordova/issues/6. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] branch remove-bundled-dependencies created (now f4ecced)
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch remove-bundled-dependencies in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. at f4ecced Remove instructions on how to bundle dependencies This branch includes the following new commits: new f4ecced Remove instructions on how to bundle dependencies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] 01/01: Remove instructions on how to bundle dependencies
This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch remove-bundled-dependencies in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit f4ecced36a9dfc9bc2e363daa9dc2c2b5493797f Author: Raphael von der Grün AuthorDate: Tue Sep 11 22:46:17 2018 +0200 Remove instructions on how to bundle dependencies --- docs/platforms-release-process.md | 11 --- 1 file changed, 11 deletions(-) diff --git a/docs/platforms-release-process.md b/docs/platforms-release-process.md index 5a6e234..549cad6 100644 --- a/docs/platforms-release-process.md +++ b/docs/platforms-release-process.md @@ -153,17 +153,6 @@ See if any dependencies are outdated Within a new JIRA issue: update any outdated dependencies in the project's `package.json` file. Be sure to run through the test section below for compatibility issues. -Check-in updated modules (use npm 3.10.1+) - -rm -rf node_modules -npm install --production (skips devDependencies) -git add node_modules/* (check-in all modules needed for platform add git url) -git commit -m "$JIRA Updated checked-in node_modules" -npm install (Re-add devDependencies for ability to run tests locally) - -Note: This will commit these changes directly to the `master` branch of the platform you are working on. This is intended. -Alternatively you might do this in a branch and open a PR for updating and pinning the dependencies. - ### License Check Ensure license headers are present everywhere. For reference, see this [background](http://www.apache.org/legal/src-headers.html). Expect some noise in the output, for example some files from test fixtures will show up. - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-ios] branch master updated (004b830 -> ff1bcd0)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git. from 004b830 Merge pull request #398 from erisu/remove-xcconfig-flag add dd01952 CB-14242 package.json remove bundledDependencies add f5afe7e CB-14242 remove committed node_modules add 63f069f CB-14242 .gitignore completely ignore node_modules add 32b079e Merge branch 'master' into cb-14242-remove-bundled-dependencies-and-node-modules new ff1bcd0 Merge pull request #388 from brodybits/cb-14242-remove-bundled-dependencies-and-node-modules The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore | 219 +- node_modules/.bin/ios-sim | 1 - node_modules/.bin/nopt | 1 - node_modules/.bin/pegjs| 1 - node_modules/.bin/semver | 1 - node_modules/.bin/shjs | 1 - node_modules/.bin/uuid | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |99 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |94 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 113 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 102 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2364 node_modules/big-integer/BigInteger.js | 1253 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 116 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-creator/.npmignore | 8 - node_modules/bplist-creator/README.md |64 - node_modules/bplist-creator/bplistCreator.js | 445 - node_modules/bplist-creator/package.json |94 - node_modules/bplist-creator/test/airplay.bplist| Bin 341 -> 0 bytes node_modules/bplist-creator/test/binaryData.bplist | Bin 7150 -> 0 bytes node_modules/bplist-creator/test/creatorTest.js| 197 - .../bplist-creator/test/iTunes-small.bplist| Bin 24433 -> 0 bytes node_modules/bplist-creator/test/sample1.bplist| Bin 631 -> 0 bytes node_modules/bplist-creator/test/sample2.bplist| Bin 384 -> 0 bytes node_modules/bplist-creator/test/uid.bplist| Bin 365 -> 0 bytes node_modules/bplist-creator/test/utf16.bplist | Bin 1273 -> 0 bytes node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|91 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml
[cordova-ios] 01/01: Merge pull request #388 from brodybits/cb-14242-remove-bundled-dependencies-and-node-modules
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-ios.git commit ff1bcd05f419cd0a8a12006c9d512ef5c92b510f Merge: 004b830 32b079e Author: Darryl Pogue AuthorDate: Tue Sep 11 13:36:49 2018 -0700 Merge pull request #388 from brodybits/cb-14242-remove-bundled-dependencies-and-node-modules CB-14242 remove bundledDependencies and committed node_modules .gitignore | 219 +- node_modules/.bin/ios-sim | 1 - node_modules/.bin/nopt | 1 - node_modules/.bin/pegjs| 1 - node_modules/.bin/semver | 1 - node_modules/.bin/shjs | 1 - node_modules/.bin/uuid | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |99 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |94 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 113 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 102 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2364 node_modules/big-integer/BigInteger.js | 1253 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 116 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-creator/.npmignore | 8 - node_modules/bplist-creator/README.md |64 - node_modules/bplist-creator/bplistCreator.js | 445 - node_modules/bplist-creator/package.json |94 - node_modules/bplist-creator/test/airplay.bplist| Bin 341 -> 0 bytes node_modules/bplist-creator/test/binaryData.bplist | Bin 7150 -> 0 bytes node_modules/bplist-creator/test/creatorTest.js| 197 - .../bplist-creator/test/iTunes-small.bplist| Bin 24433 -> 0 bytes node_modules/bplist-creator/test/sample1.bplist| Bin 631 -> 0 bytes node_modules/bplist-creator/test/sample2.bplist| Bin 384 -> 0 bytes node_modules/bplist-creator/test/uid.bplist| Bin 365 -> 0 bytes node_modules/bplist-creator/test/utf16.bplist | Bin 1273 -> 0 bytes node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|91 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml |10 - node_modules/bplist-parser/test/parseTest.js | 159 - node_modules/bplist-parser/test/sample1.bplist | Bin 605 -> 0 bytes node_modules/bplist-parser/test/sample2.bplist | Bin 384 -> 0 bytes node_modules/bplist-parser/test/uid.bplist | Bin 365 -> 0 bytes node_modules/bplist-parser/test/utf16.bplist | Bin 1273 -> 0 bytes .../bplist-parser/test/utf16_chinese.plist
[GitHub] codecov-io edited a comment on issue #388: CB-14242 remove bundledDependencies and committed node_modules
codecov-io edited a comment on issue #388: CB-14242 remove bundledDependencies and committed node_modules URL: https://github.com/apache/cordova-ios/pull/388#issuecomment-409807256 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=h1) Report > Merging [#388](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/004b8300456816cc614d229e85a35a8bc37d363d?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #388 +/- ## === Coverage 74.29% 74.29% === Files 12 12 Lines1564 1564 === Hits 1162 1162 Misses402 402 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=footer). Last update [004b830...32b079e](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io edited a comment on issue #388: CB-14242 remove bundledDependencies and committed node_modules
codecov-io edited a comment on issue #388: CB-14242 remove bundledDependencies and committed node_modules URL: https://github.com/apache/cordova-ios/pull/388#issuecomment-409807256 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=h1) Report > Merging [#388](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/004b8300456816cc614d229e85a35a8bc37d363d?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #388 +/- ## === Coverage 74.29% 74.29% === Files 12 12 Lines1564 1564 === Hits 1162 1162 Misses402 402 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=footer). Last update [004b830...32b079e](https://codecov.io/gh/apache/cordova-ios/pull/388?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-windows] branch master updated (03f482d -> d424e99)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-windows.git. from 03f482d CB-14225 fix sample Namespace Serialize attribute in template/Properties/Default.rd.xml (#286) add d841230 Remove bundledDependencies key from package.json add ce6cbd2 Ignore the whole node_modules folder add 1fc1d96 Remove bundled node_modules new d424e99 Merge pull request #293 from raphinesse/remove-bundled-dependencies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore |78 +- node_modules/abbrev/LICENSE|15 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |62 - node_modules/abbrev/package.json |56 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |58 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |58 - node_modules/balanced-match/package.json |78 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json|69 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 - node_modules/big-integer/BigInteger.js | 1251 - node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json |82 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|61 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml |10 - node_modules/bplist-parser/test/parseTest.js | 159 - node_modules/bplist-parser/test/sample1.bplist | Bin 605 -> 0 bytes node_modules/bplist-parser/test/sample2.bplist | Bin 384 -> 0 bytes node_modules/bplist-parser/test/uid.bplist | Bin 365 -> 0 bytes node_modules/bplist-parser/test/utf16.bplist | Bin 1273 -> 0 bytes .../bplist-parser/test/utf16_chinese.plist | Bin 2362 -> 0 bytes node_modules/brace-expansion/README.md | 122 - node_modules/brace-expansion/index.js | 201 - node_modules/brace-expansion/package.json |76 - node_modules/concat-map/.travis.yml| 4 - node_modules/concat-map/LICENSE|18 - node_modules/concat-map/README.markdown|62 - node_modules/concat-map/example/map.js | 6 - node_modules/concat-map/index.js |13 - node_modules/concat-map/package.json |96 - node_modules/concat-map/test/map.js|39 - node_modules/cordova-common/.eslintignore | 1 - node_modules/cordova-common/.eslintrc.yml |11 - node_modules/cordova-common/.jscs.json |24 - node_modules/cordova-common/.ratignore |
[cordova-windows] 01/01: Merge pull request #293 from raphinesse/remove-bundled-dependencies
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-windows.git commit d424e99af50df4aa13e280b10c79bc2f0d6ec7b3 Merge: 03f482d 1fc1d96 Author: Darryl Pogue AuthorDate: Tue Sep 11 13:31:53 2018 -0700 Merge pull request #293 from raphinesse/remove-bundled-dependencies Remove bundled dependencies .gitignore |78 +- node_modules/abbrev/LICENSE|15 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |62 - node_modules/abbrev/package.json |56 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |58 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |58 - node_modules/balanced-match/package.json |78 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json|69 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 - node_modules/big-integer/BigInteger.js | 1251 - node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json |82 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|61 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml |10 - node_modules/bplist-parser/test/parseTest.js | 159 - node_modules/bplist-parser/test/sample1.bplist | Bin 605 -> 0 bytes node_modules/bplist-parser/test/sample2.bplist | Bin 384 -> 0 bytes node_modules/bplist-parser/test/uid.bplist | Bin 365 -> 0 bytes node_modules/bplist-parser/test/utf16.bplist | Bin 1273 -> 0 bytes .../bplist-parser/test/utf16_chinese.plist | Bin 2362 -> 0 bytes node_modules/brace-expansion/README.md | 122 - node_modules/brace-expansion/index.js | 201 - node_modules/brace-expansion/package.json |76 - node_modules/concat-map/.travis.yml| 4 - node_modules/concat-map/LICENSE|18 - node_modules/concat-map/README.markdown|62 - node_modules/concat-map/example/map.js | 6 - node_modules/concat-map/index.js |13 - node_modules/concat-map/package.json |96 - node_modules/concat-map/test/map.js|39 - node_modules/cordova-common/.eslintignore | 1 - node_modules/cordova-common/.eslintrc.yml |11 - node_modules/cordova-common/.jscs.json |24 - node_modules/cordova-common/.ratignore | 4 - node_modules/cordova-common/.travis.yml|16 - node_modules/cordova-common/README.md | 157 - node_modules/cordova-common/RELEASENOTES.md| 130 - node_modules/cordova-common/appveyor.yml |19 - node_modules/cordova-common/cordova-common.js |47 - .../node_modules/elementtree/.npmignore| 1 -
[GitHub] raphinesse opened a new pull request #54: Remove bundled dependencies
raphinesse opened a new pull request #54: Remove bundled dependencies URL: https://github.com/apache/cordova-osx/pull/54 Part of https://github.com/apache/cordova/issues/6. @brodybits' commits cherry-picked from #49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-android] 01/01: Merge pull request #493 from raphinesse/remove-bundled-dependencies
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit eadcd33e8472cf05c818a62297ea4a89012edd26 Merge: 23b2449 76fe89d Author: Darryl Pogue AuthorDate: Tue Sep 11 13:30:12 2018 -0700 Merge pull request #493 from raphinesse/remove-bundled-dependencies Remove bundled dependencies .gitignore |91 +- node_modules/.bin/nopt | 1 - node_modules/.bin/semver | 1 - node_modules/.bin/shjs | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |97 - node_modules/android-versions/.jshintignore| 8 - node_modules/android-versions/.jshintrc|28 - node_modules/android-versions/.travis.yml | 3 - node_modules/android-versions/README.md|87 - node_modules/android-versions/index.js | 154 - node_modules/android-versions/package.json | 103 - node_modules/android-versions/tests/index.test.js | 118 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |93 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 112 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 101 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 node_modules/big-integer/BigInteger.js | 1251 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 115 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|89 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml |10 - node_modules/bplist-parser/test/parseTest.js | 159 - node_modules/bplist-parser/test/sample1.bplist | Bin 605 -> 0 bytes node_modules/bplist-parser/test/sample2.bplist | Bin 384 -> 0 bytes node_modules/bplist-parser/test/uid.bplist | Bin 365 -> 0 bytes node_modules/bplist-parser/test/utf16.bplist | Bin 1273 -> 0 bytes .../bplist-parser/test/utf16_chinese.plist | Bin 2362 -> 0 bytes node_modules/brace-expansion/LICENSE |21 - node_modules/brace-expansion/README.md | 129 - node_modules/brace-expansion/index.js | 201 - node_modules/brace-expansion/package.json | 117 - node_modules/concat-map/.travis.yml| 4 - node_modules/concat-map/LICENSE|18 - node_modules/concat-map/README.markdown|62 - node_modules/concat-map/index.js |13 - node_modules/concat-map/package.json | 117 - node_modules/concat-map/test/map.js|
[cordova-android] branch master updated (23b2449 -> eadcd33)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 23b2449 Fixes build & run related bugs from builder refactor PR #461 (#490) add c35a46e Remove bundledDependencies key from package.json add 3f487c5 Ignore the whole node_modules folder add 76fe89d Remove bundled node_modules new eadcd33 Merge pull request #493 from raphinesse/remove-bundled-dependencies The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .gitignore |91 +- node_modules/.bin/nopt | 1 - node_modules/.bin/semver | 1 - node_modules/.bin/shjs | 1 - node_modules/abbrev/LICENSE|46 - node_modules/abbrev/README.md |23 - node_modules/abbrev/abbrev.js |61 - node_modules/abbrev/package.json |97 - node_modules/android-versions/.jshintignore| 8 - node_modules/android-versions/.jshintrc|28 - node_modules/android-versions/.travis.yml | 3 - node_modules/android-versions/README.md|87 - node_modules/android-versions/index.js | 154 - node_modules/android-versions/package.json | 103 - node_modules/android-versions/tests/index.test.js | 118 - node_modules/ansi/.jshintrc| 4 - node_modules/ansi/.npmignore | 1 - node_modules/ansi/History.md |23 - node_modules/ansi/LICENSE |24 - node_modules/ansi/README.md|98 - node_modules/ansi/examples/beep/index.js |16 - node_modules/ansi/examples/clear/index.js |15 - node_modules/ansi/examples/cursorPosition.js |32 - node_modules/ansi/examples/progress/index.js |87 - node_modules/ansi/lib/ansi.js | 405 - node_modules/ansi/lib/newlines.js |71 - node_modules/ansi/package.json |93 - node_modules/balanced-match/.npmignore | 5 - node_modules/balanced-match/LICENSE.md |21 - node_modules/balanced-match/README.md |91 - node_modules/balanced-match/index.js |59 - node_modules/balanced-match/package.json | 112 - node_modules/base64-js/.travis.yml | 5 - node_modules/base64-js/LICENSE.MIT |21 - node_modules/base64-js/README.md |31 - node_modules/base64-js/bench/bench.js |19 - node_modules/base64-js/lib/b64.js | 124 - node_modules/base64-js/package.json| 101 - node_modules/base64-js/test/convert.js |51 - node_modules/base64-js/test/url-safe.js|18 - node_modules/big-integer/BigInteger.d.ts | 2369 node_modules/big-integer/BigInteger.js | 1251 -- node_modules/big-integer/BigInteger.min.js | 1 - node_modules/big-integer/LICENSE |24 - node_modules/big-integer/README.md | 520 - node_modules/big-integer/bower.json|29 - node_modules/big-integer/package.json | 115 - node_modules/big-integer/tsconfig.json |25 - node_modules/bplist-parser/.npmignore | 8 - node_modules/bplist-parser/README.md |47 - node_modules/bplist-parser/bplistParser.js | 357 - node_modules/bplist-parser/package.json|89 - node_modules/bplist-parser/test/airplay.bplist | Bin 341 -> 0 bytes .../bplist-parser/test/iTunes-small.bplist | Bin 24433 -> 0 bytes node_modules/bplist-parser/test/int64.bplist | Bin 84 -> 0 bytes node_modules/bplist-parser/test/int64.xml |10 - node_modules/bplist-parser/test/parseTest.js | 159 - node_modules/bplist-parser/test/sample1.bplist | Bin 605 -> 0 bytes node_modules/bplist-parser/test/sample2.bplist | Bin 384 -> 0 bytes node_modules/bplist-parser/test/uid.bplist | Bin 365 -> 0 bytes node_modules/bplist-parser/test/utf16.bplist | Bin 1273 -> 0 bytes .../bplist-parser/test/utf16_chinese.plist | Bin 2362 -> 0 bytes node_modules/brace-expansion/LICENSE |21 - node_modules/brace-expansion/README.md | 129 - node_modules/brace-expansion/index.js | 201 - node_modules/brace-expansion/package.json | 117 -
[GitHub] raphinesse opened a new pull request #293: Remove bundled dependencies
raphinesse opened a new pull request #293: Remove bundled dependencies URL: https://github.com/apache/cordova-windows/pull/293 Part of https://github.com/apache/cordova/issues/6. The only dependency versions that differed from the bundled ones after a normal installation at the time of writing were `cordova-common` which changed from 2.2.1 to 2.2.5 and `semver` which changed from 5.5.0 to 5.5.1. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io edited a comment on issue #493: Remove bundled dependencies
codecov-io edited a comment on issue #493: Remove bundled dependencies URL: https://github.com/apache/cordova-android/pull/493#issuecomment-420405878 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #493 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=footer). Last update [23b2449...76fe89d](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #493: Remove bundled dependencies
codecov-io commented on issue #493: Remove bundled dependencies URL: https://github.com/apache/cordova-android/pull/493#issuecomment-420405878 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #493 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=footer). Last update [23b2449...76fe89d](https://codecov.io/gh/apache/cordova-android/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new pull request #59: Remove bundled dependencies
raphinesse opened a new pull request #59: Remove bundled dependencies URL: https://github.com/apache/cordova-browser/pull/59 Part of https://github.com/apache/cordova/issues/6. The only dependency versions that differed from the bundled ones after a normal installation at the time of writing were `cordova-common` from 2.2.0 to 2.2.5 and `cordova-serve` which changed from 2.0.0 to 2.0.1. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new pull request #493: Remove bundled dependencies
raphinesse opened a new pull request #493: Remove bundled dependencies URL: https://github.com/apache/cordova-android/pull/493 Part of https://github.com/apache/cordova/issues/6. The only dependency version that differed from the bundled one after a normal installation at the time of writing was `cordova-common` which changed from 2.2.0 to 2.2.5. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new issue #169: Uniform build
raphinesse opened a new issue #169: Uniform build URL: https://github.com/apache/cordova-js/issues/169 It would be nice for cordova-js to platform independent. While I have not had a closer look at the how and why of the current build strategy, here's an outline of what I imagine: ### Suggestion - Create a platform-independent build of `cordova-js` before publishing to npm and bundle it in the published package (it's *not* checked into git). My tool of choice for this would be `rollup` at the moment of writing. - Have platforms require `cordova-js` to include the core bundle in the App HTML. Any platform specific JS is handled in the platform but can make use of the provided core functionality ### Positive effects - `cordova-js` can be platform agnostic => easier to add new platforms - switch to modern build tooling (`rollup`) - Releasing a new version of `cordova-js` can be done independently - Updating of `cordova-js` in aplatform requires only `npm i cordova-js@latest` I don't have time to look into this right now, but I'd appreciate any feedback on this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] Thkasis opened a new issue #404: PUBLIC Stack Overflow Tags Users Jobs Teams Q for work Learn More Cordova build iOS error: archive not found at path 'path/to/myApp.xcarchive"
Thkasis opened a new issue #404: PUBLIC Stack Overflow Tags Users Jobs Teams Q for work Learn More Cordova build iOS error: archive not found at path 'path/to/myApp.xcarchive" URL: https://github.com/apache/cordova-ios/issues/404 Cordova -v : 8.0.0 After running cordova platform add ios I see Using cordova-fetch for cordova-ios~4.5.4 But later sais iOS project created with cordova-ios@4.5.5 On macOS High Sierra (10.13.6) and Xcode 10. I have tried removing and adding platforms. Also, reinstalling stuff as well. I follow the commands below but see error below at build: cordova create myApp org.apache.cordova.myApp myApp cd myApp cordova platform add ios cordova build ios I get the error below: Building project: /Users/ben/Desktop/myTest/platforms/ios/myTest.xcworkspace Configuration: Debug Platform: device User defaults from command line: IDEArchivePathOverride = /Users/ben/Desktop/myTest/platforms/ios/myTest.xcarchive Build settings from command line: CONFIGURATION_BUILD_DIR = /Users/ben/Desktop/myTest/platforms/ios/build/device SHARED_PRECOMPS_DIR = /Users/ben/Desktop/myTest/platforms/ios/build/sharedpch Build settings from configuration file '/Users/ben/Desktop/myTest/platforms/ios/cordova/build-debug.xcconfig': CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = YES CODE_SIGN_ENTITLEMENTS = $(PROJECT_DIR)/$(PROJECT_NAME)/Entitlements-$(CONFIGURATION).plist CODE_SIGN_IDENTITY = iPhone Developer ENABLE_BITCODE = NO GCC_PREPROCESSOR_DEFINITIONS = DEBUG=1 HEADER_SEARCH_PATHS = "$(TARGET_BUILD_DIR)/usr/local/lib/include" "$(OBJROOT)/UninstalledProducts/include" "$(OBJROOT)/UninstalledProducts/$(PLATFORM_NAME)/include" "$(BUILT_PRODUCTS_DIR)" OTHER_LDFLAGS = -ObjC SWIFT_OBJC_BRIDGING_HEADER = $(PROJECT_DIR)/$(PROJECT_NAME)/Bridging-Header.h error: archive not found at path '/Users/ben/Desktop/myTest/platforms/ios/myTest.xcarchive' ** EXPORT FAILED ** (node:4984) UnhandledPromiseRejectionWarning: Error code 65 for command: xcodebuild with args: -exportArchive,-archivePath,myTest.xcarchive,-exportOptionsPlist,/Users/ben/Desktop/myTest/platforms/ios/exportOptions.plist,-exportPath,/Users/ben/Desktop/myTest/platforms/ios/build/device (node:4984) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1) (node:4984) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-common] branch master updated: CB-13496: Fix greedy regex in plist-helpers
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-common.git
The following commit(s) were added to refs/heads/master by this push:
new 9c6cda3 CB-13496: Fix greedy regex in plist-helpers
9c6cda3 is described below
commit 9c6cda3db766c3daa87e8e4f8cc65e818a9e6dfc
Author: Darryl Pogue
AuthorDate: Wed Sep 5 23:41:32 2018 -0700
CB-13496: Fix greedy regex in plist-helpers
---
spec/plist-helpers.spec.js | 32
src/util/plist-helpers.js | 2 +-
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/spec/plist-helpers.spec.js b/spec/plist-helpers.spec.js
index 3a6fa02..fc4c923 100644
--- a/spec/plist-helpers.spec.js
+++ b/spec/plist-helpers.spec.js
@@ -58,3 +58,35 @@ describe('prunePLIST', function () {
done();
});
});
+
+describe('plistGraft', function () {
+let doc = {
+'keychain-access-groups': [
+'$(AppIdentifierPrefix)io.cordova.hellocordova',
+'$(AppIdentifierPrefix)com.example.mylib'
+]
+};
+
+let xml = '' +
+
'$(AppIdentifierPrefix)io.cordova.hellocordova' +
+'$(AppIdentifierPrefix)com.example.mylib' +
+ '';
+
+let selector = 'keychain-access-groups';
+
+it('Test 01: should not mangle existing plist entries', function (done) {
+var graftStatus = plistHelpers.graftPLIST(doc, xml, selector);
+
+expect(graftStatus).toBeTruthy();
+expect(doc).toEqual(
+{
+'keychain-access-groups': [
+'$(AppIdentifierPrefix)io.cordova.hellocordova',
+'$(AppIdentifierPrefix)com.example.mylib'
+]
+}
+);
+
+done();
+});
+});
diff --git a/src/util/plist-helpers.js b/src/util/plist-helpers.js
index 5ec4c1d..0b4fdc1 100644
--- a/src/util/plist-helpers.js
+++ b/src/util/plist-helpers.js
@@ -80,7 +80,7 @@ function pruneOBJECT (doc, selector, fragment) {
function nodeEqual (node1, node2) {
if (typeof node1 !== typeof node2) { return false; } else if (typeof node1
=== 'string') {
-node2 = escapeRE(node2).replace(/\\\$\S+/gm, '(.*?)');
+node2 = escapeRE(node2).replace(/\\\$\(\S+\)/gm, '(.*?)');
return new RegExp('^' + node2 + '$').test(node1);
} else {
for (var key in node2) {
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-common] branch master updated: CB-14108: fix incorrect count in config_munge in ios.json and android.json
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-common.git
The following commit(s) were added to refs/heads/master by this push:
new ce3801a CB-14108: fix incorrect count in config_munge in ios.json and
android.json
ce3801a is described below
commit ce3801a184d34cc4c3ea08aeecd159227c6ae9e9
Author: Ken Naito
AuthorDate: Wed Sep 12 02:07:32 2018 +0900
CB-14108: fix incorrect count in config_munge in ios.json and android.json
* Fix to cordova prepare increment count at config_munge in platformJson
* Fix to cordova prepare when remove config-file case
---
spec/ConfigChanges/ConfigChanges.spec.js | 88
spec/CordovaError/CordovaError.spec.js | 41
spec/fixtures/test-configfile0.xml | 14 +++
spec/fixtures/test-configfile1.xml | 29 ++
spec/fixtures/test-configfile2.xml | 34 +++
src/ConfigChanges/ConfigChanges.js | 169 +++
src/ConfigChanges/ConfigFile.js | 6 +-
src/ConfigChanges/munge-util.js | 23 +
src/ConfigParser/ConfigParser.js | 3 +-
9 files changed, 365 insertions(+), 42 deletions(-)
diff --git a/spec/ConfigChanges/ConfigChanges.spec.js
b/spec/ConfigChanges/ConfigChanges.spec.js
index fe83c70..7f792d2 100644
--- a/spec/ConfigChanges/ConfigChanges.spec.js
+++ b/spec/ConfigChanges/ConfigChanges.spec.js
@@ -46,6 +46,9 @@ var ConfigParser =
require('../../src/ConfigParser/ConfigParser');
var xml = path.join(__dirname, '../fixtures/test-config.xml');
var editconfig_xml = path.join(__dirname, '../fixtures/test-editconfig.xml');
var configfile_xml = path.join(__dirname, '../fixtures/test-configfile.xml');
+var configfile0_xml = path.join(__dirname, '../fixtures/test-configfile0.xml');
+var configfile1_xml = path.join(__dirname, '../fixtures/test-configfile1.xml');
+var configfile2_xml = path.join(__dirname, '../fixtures/test-configfile2.xml');
var cfg = new ConfigParser(xml);
// TODO: dont do fs so much
@@ -385,6 +388,32 @@ describe('config-changes module', function () {
expect(sdk.attrib['android:minSdkVersion']).toEqual('5');
expect(sdk.attrib['android:maxSdkVersion']).toBeUndefined();
});
+it('should recover AndroidManifest after removing editconfig',
function () {
+var editconfig_cfg = new ConfigParser(editconfig_xml);
+var platformJson = PlatformJson.load(plugins_dir,
'android');
+var munger = new configChanges.PlatformMunger('android',
temp, platformJson, pluginInfoProvider);
+
+// once add editconfig
+munger.add_config_changes(cfg, true).save_all();
+munger.add_config_changes(editconfig_cfg, true).save_all();
+
+var am_xml = new
et.ElementTree(et.XML(fs.readFileSync(path.join(temp, 'AndroidManifest.xml'),
'utf-8')));
+var sdk = am_xml.find('./uses-sdk');
+expect(sdk).toBeDefined();
+
expect(sdk.attrib['android:targetSdkVersion']).toEqual('23');
+expect(sdk.attrib['android:minSdkVersion']).toEqual('5');
+
expect(sdk.attrib['android:maxSdkVersion']).toBeUndefined();
+
+// should recover
+munger.add_config_changes(cfg, true).save_all();
+am_xml = new
et.ElementTree(et.XML(fs.readFileSync(path.join(temp, 'AndroidManifest.xml'),
'utf-8')));
+sdk = am_xml.find('./uses-sdk');
+expect(sdk).toBeDefined();
+
expect(sdk.attrib['android:targetSdkVersion']).toEqual('24');
+expect(sdk.attrib['android:minSdkVersion']).toEqual('14');
+
expect(sdk.attrib['android:maxSdkVersion']).toBeUndefined();
+
+});
it('should append new children to XML document tree', function
() {
var configfile_cfg = new ConfigParser(configfile_xml);
var platformJson = PlatformJson.load(plugins_dir,
'android');
@@ -404,6 +433,47 @@ describe('config-changes module', function () {
var am_file = fs.readFileSync(path.join(temp,
'AndroidManifest.xml'), 'utf-8');
expect(am_file.indexOf('android:name="zoo"')).toBeLessThan(am_file.indexOf('android:name="com.foo.Bar"'));
});
+// testing removing tag in config.xml
+it('should recover AndroidManifest after removing config-file
tag', function () {
+// add config-file same as previous
+var configfile_cfg = new ConfigParser(configfile_xml);
+var platformJson = PlatformJson.load(plugins_dir,
'android');
+
[cordova-plugman] branch master updated: Remove fetch option
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-plugman.git
The following commit(s) were added to refs/heads/master by this push:
new d71ffb9 Remove fetch option
d71ffb9 is described below
commit d71ffb99b6a753c3b8999aaa7a74ee21843224ac
Author: Raphael von der Grün
AuthorDate: Tue Sep 11 19:00:48 2018 +0200
Remove fetch option
---
main.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/main.js b/main.js
index 247eb5a..3de71a6 100755
--- a/main.js
+++ b/main.js
@@ -45,7 +45,6 @@ const known_opts = {
variable: Array,
www: path,
searchpath: [path, Array],
-fetch: Boolean,
save: Boolean
};
const shortHands = { var: ['--variable'], v: ['--version'], h: ['--help'] };
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-cli] branch master updated: GH-320 Remove support for browserify
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-cli.git The following commit(s) were added to refs/heads/master by this push: new 7fc2707 GH-320 Remove support for browserify 7fc2707 is described below commit 7fc270700bda4ae66913e276df631a8c7d63a657 Author: Raphael von der Grün AuthorDate: Tue Sep 11 12:37:09 2018 +0200 GH-320 Remove support for browserify --- doc/build.txt| 5 + doc/config.txt | 6 -- doc/plugin.txt | 10 -- doc/prepare.txt | 6 +- doc/readme.md| 13 ++--- doc/run.txt | 3 --- spec/cli.spec.js | 12 ++-- src/cli.js | 7 --- 8 files changed, 14 insertions(+), 48 deletions(-) diff --git a/doc/build.txt b/doc/build.txt index f3eb356..3245804 100644 --- a/doc/build.txt +++ b/doc/build.txt @@ -20,12 +20,9 @@ all/the specified platforms. --buildConfig... Use the specified build configuration instead of default build.json ---browserify ... Compile plugin JS at build time using - browserify instead of runtime. - To provide platform specific options, you must include them after `--`. Example cordova-cli build android windows --debug --device cordova-cli build android --release --buildConfig=..\myBuildConfig.json -cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android --alias=mykey \ No newline at end of file +cordova-cli build android --release -- --keystore="..\android.keystore" --storePassword=android --alias=mykey diff --git a/doc/config.txt b/doc/config.txt index 2b0b35f..af116fc 100644 --- a/doc/config.txt +++ b/doc/config.txt @@ -24,11 +24,5 @@ Options Allows the user to set save to true or false when adding platforms or plugins. When false, platforms/plugins are not saved to `config.xml` and `package.json`. - browserify .. default setting = false - Allows the user to use the browserify module to bundle the JavaScript files of - the included plugins at build time versus our traditional run time loading of - those files. - Examples cordova config set autosave false - cordova config set browserify true diff --git a/doc/plugin.txt b/doc/plugin.txt index 0915eea..8262f69 100644 --- a/doc/plugin.txt +++ b/doc/plugin.txt @@ -4,7 +4,7 @@ Synopsis Manage project plugins -add [...] Add specified plugins and save them to +add [...] Add specified plugins and save them to config.xml & package.json. --searchpath ... When looking up plugins by ID, look in this directory and each of its subdirectories before hitting the registry. @@ -15,18 +15,16 @@ Manage project plugins --link . When installing from a local path, creates a symbolic link instead of copying files. The extent to which files are linked varies by platform. Useful for plugin development. ---nosave ... Prevent saving the information for specified plugin +--nosave ... Prevent saving the information for specified plugin into config.xml & package.json. --shrinkwrap ... Used together with --save, saves the installed version numbers to config.xml ---browserify ... Compile plugin JS at build time using - browserify instead of runtime. --force Forces copying source files from the plugin even if the same file already exists in the target directory. - -remove | [...] . Remove plugins with the given IDs/name and + +remove | [...] . Remove plugins with the given IDs/name and removes the information for specified plugin from config.xml & package.json. --nosave ... Prevents removing the information for specified plugin from config.xml & package.json. diff --git a/doc/prepare.txt b/doc/prepare.txt index 984f86a..fee2d56 100644 --- a/doc/prepare.txt +++ b/doc/prepare.txt @@ -5,9 +5,5 @@ Synopsis Copies files for specified platforms, or all platforms, so that the project is ready to build with each SDK. -Options - --browserify .. Compile plugin JS at build time using -
[cordova-plugman] branch master updated (944e8e6 -> 292f7ff)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugman.git. from 944e8e6 CB-14164 Use native Promises instead of Q (#94) add 14a8bb9 Remove browserify option new 292f7ff Merge pull request #95 from raphinesse/browserify-nomore The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: main.js | 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-plugman] 01/01: Merge pull request #95 from raphinesse/browserify-nomore
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugman.git commit 292f7ff904567dd78dd7f4dfdab0cab69c01cb0d Merge: 944e8e6 14a8bb9 Author: Darryl Pogue AuthorDate: Tue Sep 11 09:58:06 2018 -0700 Merge pull request #95 from raphinesse/browserify-nomore Remove browserify option main.js | 1 - 1 file changed, 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] branch master updated (2ae50f2 -> 2eff92c)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git. from 2ae50f2 GH-195: Ensure synchronous operation add 3ca7b93 Remove test instructions for browserify new 2eff92c Merge pull request #197 from raphinesse/browserify-nomore The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: docs/tools-release-process.md | 4 1 file changed, 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-coho] 01/01: Merge pull request #197 from raphinesse/browserify-nomore
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-coho.git commit 2eff92cae0315b8dfcc14f7aab51377e19fd1e97 Merge: 2ae50f2 3ca7b93 Author: Darryl Pogue AuthorDate: Tue Sep 11 09:57:54 2018 -0700 Merge pull request #197 from raphinesse/browserify-nomore Remove test instructions for browserify docs/tools-release-process.md | 4 1 file changed, 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #197: Remove test instructions for browserify
dpogue closed pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docs/tools-release-process.md b/docs/tools-release-process.md index ce0d22d76..95dc46648 100644 --- a/docs/tools-release-process.md +++ b/docs/tools-release-process.md @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios (cd mobilespec && ./cordova build && ./cordova run android) -Ensure that mobilespec creates okay via CLI and browserify: - -(cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) - Ensure uninstall doesn't cause errors: (cd mobilespec && ./cordova plugin remove cordova-plugin-file-transfer) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] tmk1991 opened a new issue #340: FILE URI Not showing in tag - Android
tmk1991 opened a new issue #340: FILE URI Not showing in tag - Android URL: https://github.com/apache/cordova-plugin-camera/issues/340 When selecting an image from the users library, the file URI returns `/storage/emulated/0/Pictures/IMG_20180911_114705.jpg` When taking a picture it returns `file:///storage/emulated/0/Android/data/com.app/cache/1536682152687.jpg` Neither image shows up in the img tag when setting its source to either location. I get the mini broken link icon where the img tag is This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
joshchandler commented on a change in pull request #441: CB-14089: (android)
Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216728546
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
Oh I see.. Ok well then I'll wait until feedback is received on that google
services PR. I'm not familiar enough with gradle to confidently say that
importing into the dependencies scope wouldn't cause any problems.
`cordova.gradle` only consists of helper methods, so I don't see any reason why
it would be an issue though.
If it doesn't cause any issues then this would just be another reason to
pull it in here and the other dependencies scope further below this file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420315544 I think you should try it. But you have to be sure the line is out of the xcode project. So rebuild it after the revert by removing and adding the platform I think. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse edited a comment on issue #7: Drop dependency on Q, use native promises
raphinesse edited a comment on issue #7: Drop dependency on Q, use native promises URL: https://github.com/apache/cordova/issues/7#issuecomment-420308949 I've added a dependency graph to make it easier to determine the correct order of doing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse commented on issue #7: Drop dependency on Q, use native promises
raphinesse commented on issue #7: Drop dependency on Q, use native promises URL: https://github.com/apache/cordova/issues/7#issuecomment-420308949 I've added a full dependency graph to make it easier to determine the correct order of doing this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-42021 So basically if I revert commit `dc5329d`, the mentioned issue would be fixed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420296914 In my app I have next line [tmpWindow setWindowLevel:baseWindowLevel+1]; from https://github.com/apache/cordova-plugin-inappbrowser/commit/dc5329d15757cca1c327e87a309fddbb58e554ed I changed it back again to [tmpWindow setWindowLevel:UIWindowLevelNormal]; the old code and it works. (See line 245 of CDVInAppBrowser.m ) We are using the WebView and not yet the WkWebview. But in your zip file the line is still the old one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu edited a comment on issue #6: Remove committed `node_modules` from platforms
erisu edited a comment on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420295286 It seems https://github.com/apache/cordova-osx/pull/49, covers removing the node_modules and many other smaller tasks. - Could the `node_module` and `bundledDependencies` removal be cherry-picked? - Is it ideal to break down this PR into smaller multiple PRs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu edited a comment on issue #6: Remove committed `node_modules` from platforms
erisu edited a comment on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420295286 It seems https://github.com/apache/cordova-osx/pull/49, covers removing the node_modules and many other smaller tasks. Could the `node_module` and `bundledDependencies` removal be cherry-picked? Is it ideal to break down this PR into smaller multiple PRs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #6: Remove committed `node_modules` from platforms
erisu commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420295286 It seems https://github.com/apache/cordova-osx/pull/49, covers removing the node_modules and many other smaller tasks. Could the node_module and bundled packages removal be cherry-picked? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420295354 At first I was using a fork of this which I created myself for development purposes, mostly dealing with the iPhone X's status bar not being handled as gracefully as desired by the plugin. And that's where I stumbled upon this issue. However, I reverted back to version 3.0.0 and saw that this behavior is present in it too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420293651 I am currently using a fork of the plugin, so it is possibly related to a development commit. You seem to be using the version 3.0.0 for this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on issue #6: Remove committed `node_modules` from platforms
erisu commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420291667 For https://github.com/apache/cordova-ios/pull/388, conflicts needs to be resolved and should be OK for merging since I last reviewed it. Would like a second opinion. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
alan-grixti commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420289617 Hi, yes. I have ran into that too. However could not pin point an exact trigger. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed issue #5: Add Node 10 & Drop Node 4 Support
dpogue closed issue #5: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova/issues/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-osx] branch master updated: Add Node 10 & Drop Node 4 Support
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git
The following commit(s) were added to refs/heads/master by this push:
new ffcf496 Add Node 10 & Drop Node 4 Support
ffcf496 is described below
commit ffcf496bb2c3382523c217220a50fcbf690b0ee7
Author: エリス
AuthorDate: Tue Sep 11 16:54:35 2018 +0900
Add Node 10 & Drop Node 4 Support
---
.travis.yml | 18 --
package.json | 3 +++
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index b151b0b..c912dd7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,5 +1,19 @@
language: objective-c
sudo: false
+
+env:
+ matrix:
+- TRAVIS_NODE_VERSION: '6'
+- TRAVIS_NODE_VERSION: '8'
+- TRAVIS_NODE_VERSION: '10'
+
+before_install:
+ - nvm install $TRAVIS_NODE_VERSION
+
install:
-- npm install
-script: "npm test"
\ No newline at end of file
+ - npm install
+
+script:
+ - node --version
+ - npm --version
+ - npm test
diff --git a/package.json b/package.json
index 0e2dd06..cc16d1a 100644
--- a/package.json
+++ b/package.json
@@ -54,5 +54,8 @@
"nodeunit": "^0.8.7",
"tmp": "^0.0.26",
"uncrustify": "^0.6.1"
+ },
+ "engines": {
+"node": ">=6.0.0"
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #53: Add Node 10 & Drop Node 4 Support
dpogue closed pull request #53: Add Node 10 & Drop Node 4 Support
URL: https://github.com/apache/cordova-osx/pull/53
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index b151b0b0..c912dd7b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,5 +1,19 @@
language: objective-c
sudo: false
+
+env:
+ matrix:
+- TRAVIS_NODE_VERSION: '6'
+- TRAVIS_NODE_VERSION: '8'
+- TRAVIS_NODE_VERSION: '10'
+
+before_install:
+ - nvm install $TRAVIS_NODE_VERSION
+
install:
-- npm install
-script: "npm test"
\ No newline at end of file
+ - npm install
+
+script:
+ - node --version
+ - npm --version
+ - npm test
diff --git a/package.json b/package.json
index 0e2dd069..cc16d1a6 100644
--- a/package.json
+++ b/package.json
@@ -54,5 +54,8 @@
"nodeunit": "^0.8.7",
"tmp": "^0.0.26",
"uncrustify": "^0.6.1"
+ },
+ "engines": {
+"node": ">=6.0.0"
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #58: CB-14073 browser: Drop Node 4, Added Node 10
dpogue closed pull request #58: CB-14073 browser: Drop Node 4, Added Node 10
URL: https://github.com/apache/cordova-browser/pull/58
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 0690709..caf4bbc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,13 +1,15 @@
language: node_js
sudo: false
+
node_js:
- - "4"
- "6"
- "8"
+ - "10"
+
install:
- npm install
+
script:
- node --version
- npm --version
- npm test
-
diff --git a/appveyor.yml b/appveyor.yml
index 9a6d5a4..73d3e54 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -22,9 +22,9 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
+ - nodejs_version: "10"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/package.json b/package.json
index 358b382..5a31c91 100644
--- a/package.json
+++ b/package.json
@@ -61,7 +61,7 @@
],
"license": "Apache-2.0",
"engines": {
-"node": ">=4.0.0"
+"node": ">=6.0.0"
},
"engineStrict": true
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-browser] branch master updated: CB-14073 browser: Drop Node 4, Added Node 10
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-browser.git
The following commit(s) were added to refs/heads/master by this push:
new ffdc001 CB-14073 browser: Drop Node 4, Added Node 10
ffdc001 is described below
commit ffdc001f943baf5aff70cd51a50c852ec7539ff8
Author: エリス
AuthorDate: Tue Sep 11 16:18:10 2018 +0900
CB-14073 browser: Drop Node 4, Added Node 10
---
.travis.yml | 6 --
appveyor.yml | 2 +-
package.json | 2 +-
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 0690709..caf4bbc 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,13 +1,15 @@
language: node_js
sudo: false
+
node_js:
- - "4"
- "6"
- "8"
+ - "10"
+
install:
- npm install
+
script:
- node --version
- npm --version
- npm test
-
diff --git a/appveyor.yml b/appveyor.yml
index 9a6d5a4..73d3e54 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -22,9 +22,9 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
+ - nodejs_version: "10"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/package.json b/package.json
index 358b382..5a31c91 100644
--- a/package.json
+++ b/package.json
@@ -61,7 +61,7 @@
],
"license": "Apache-2.0",
"engines": {
-"node": ">=4.0.0"
+"node": ">=6.0.0"
},
"engineStrict": true
}
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support
codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-serve] branch master updated: CB-14069: Drop Node 4, Add Node 10 Support
This is an automated email from the ASF dual-hosted git repository.
dpogue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-serve.git
The following commit(s) were added to refs/heads/master by this push:
new 9708785 CB-14069: Drop Node 4, Add Node 10 Support
9708785 is described below
commit 970878550aac5169ad22a363f41137847a459da3
Author: エリス
AuthorDate: Tue Sep 11 17:22:59 2018 +0900
CB-14069: Drop Node 4, Add Node 10 Support
---
.travis.yml | 5 -
appveyor.yml | 2 +-
package.json | 4 ++--
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 53f19a8..347cec9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,11 +2,14 @@ language: node_js
sudo: false
git:
depth: 10
+
node_js:
- - "4"
- "6"
- "8"
+ - "10"
+
install:
- "npm install"
+
script:
- "npm test"
diff --git a/appveyor.yml b/appveyor.yml
index ffe5194..31fb26c 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -3,9 +3,9 @@
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
+ - nodejs_version: "10"
install:
- ps: Install-Product node $env:nodejs_version
diff --git a/package.json b/package.json
index 62bdc57..6034e33 100644
--- a/package.json
+++ b/package.json
@@ -42,7 +42,7 @@
"rewire": "^2.5.2"
},
"engines": {
-"node": ">=4.0.0",
-"npm": ">= 2.5.1"
+"node": ">= 6",
+"npm": ">= 3"
}
}
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io commented on issue #441: CB-14089: (android) Add Kotlin support
codecov-io commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support
codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-js] 01/01: Merge pull request #168 from erisu/CB-14071
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git commit 284c1b1a710682ece82784a6f99725ebdd2acf4c Merge: 9e8e1b7 d046b85 Author: Darryl Pogue AuthorDate: Tue Sep 11 07:05:07 2018 -0700 Merge pull request #168 from erisu/CB-14071 CB-14071: Drop Node 4 Support .travis.yml | 1 - appveyor.yml | 1 - package.json | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] dpogue closed pull request #168: CB-14071: Drop Node 4 Support
dpogue closed pull request #168: CB-14071: Drop Node 4 Support
URL: https://github.com/apache/cordova-js/pull/168
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index c42cb96b..6dee84f3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,7 +4,6 @@ git:
depth: 10
node_js:
- - "4"
- "6"
- "8"
- "10"
diff --git a/appveyor.yml b/appveyor.yml
index ba492617..a6f74dee 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -2,7 +2,6 @@
# http://www.appveyor.com/docs/appveyor-yml
environment:
matrix:
- - nodejs_version: "4"
- nodejs_version: "6"
- nodejs_version: "8"
- nodejs_version: "10"
diff --git a/package.json b/package.json
index 00edd5b4..41d1e77e 100644
--- a/package.json
+++ b/package.json
@@ -3,7 +3,7 @@
"name": "cordova-js",
"description": "Cordova JavaScript: a unified JavaScript layer for the
Cordova suite of projects enabling cross-platform native mobile development of
applications using HTML, CSS and JavaScript.",
"engines": {
-"node": ">=4.0.0"
+"node": ">=6.0.0"
},
"version": "4.2.5-dev",
"homepage": "http://cordova.apache.org;,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[cordova-js] branch master updated (9e8e1b7 -> 284c1b1)
This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git. from 9e8e1b7 readme fixes (#166) add d046b85 CB-14071: Drop Node 4 Support new 284c1b1 Merge pull request #168 from erisu/CB-14071 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .travis.yml | 1 - appveyor.yml | 1 - package.json | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs
PieterVanPoyer commented on issue #296: App freezing after opening the InAppBrowser on specific URLs / Inputs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296#issuecomment-420285229 Hello, it seems like we're experiencing the same issue. We experience it after opening the InAppBrowser. A keyboard is not necessary to freeze the app afterwards. Can you confirm that please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216679161
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
@joshchandler Sorry, the `cdvHelpers` is currently not available in the
`dependencies` scope, as I mentioned in this example.
Wrapping the apply plugin should be OK. Example:
```
if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
apply plugin: 'kotlin-android'
}
```
There is a discussion on a PR that also modifies the the same `build.gradle`
file for other features. It also had the same issue where `cdvHelpers` is not
available in the dependency scope. Adding it is as easy as adding the `apply
from: '../CordovaLib/cordova.gradle'` in the scope BUT I am waiting for any
feedback about it.
You can see the comment here:
https://github.com/apache/cordova-android/pull/438#discussion_r216195552
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] bb128b edited a comment on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast?
bb128b edited a comment on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast? URL: https://github.com/apache/cordova-plugin-network-information/issues/70#issuecomment-420283187 The way I achieved this in our project (we are using Ionic 3.x by the way) was to check the API speed using a timer in an interceptor. Depending on how long the request lasts per request is our latency for that particular request lifecycle. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] bb128b commented on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast?
bb128b commented on issue #70: How to detect latency or ping or can I detect connection if the device network is slow or fast? URL: https://github.com/apache/cordova-plugin-network-information/issues/70#issuecomment-420283187 The way I achieved this in our project (we are using Ionic 3.x by the way) was to check the API speed using a timer in an interceptor. Depending on how long the request lasts per request is our latency for that time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] alan-grixti opened a new issue #296: App freezing after opening the InAppBrowser on specific URLs
alan-grixti opened a new issue #296: App freezing after opening the InAppBrowser on specific URLs URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/296 I would like to bring to attention an issue (I believe it's a bug, could be wrong) which I've come across. I believe it is easy to reproduce, and managed to successfully reproduce it repeatedly myself on a test environment. Zip file linked bottom of issue containing the test environment. GIF showing the issue added below. In brief, the problem is that on some particular sites, whenever navigation / keyboard is triggered in the InAppBrowser window, it is causing the underlying application to freeze and unresponsive to any user actions. Environment: Cordova 8, iOS 4.5.5 and Ionic 3 Affected Platform : iOS Versions: iOS v11.4 Devices Affected: iPhone 5 up to 6S/Plus Steps to reproduce: 1. Create a blank project (Ionic, whatever flavour you prefer). 2. Add reference to the InAppBrowser plugin 3. Run use case below: - Open https://www.google.com in InAppBrowser - Locate the search bar on the page and type something. - Click / tap outside of the search bar - Close the InAppBrowser instance - App will be unresponsive  [iab-test.zip](https://github.com/apache/cordova-plugin-inappbrowser/files/2371184/iab-test.zip) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
joshchandler commented on a change in pull request #441: CB-14089: (android)
Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674985
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
Awesome, did not know this was available. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674955 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: This file is actually not unnecessary.. I'm taking it out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse commented on a change in pull request #197: Remove test instructions for browserify
raphinesse commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216656219 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios (cd mobilespec && ./cordova build && ./cordova run android) -Ensure that mobilespec creates okay via CLI and browserify: - -(cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) Review comment: This would be one of the rare cases where I'd trust the comments :wink: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on a change in pull request #197: Remove test instructions for browserify
janpio commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216655795 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios (cd mobilespec && ./cordova build && ./cordova run android) -Ensure that mobilespec creates okay via CLI and browserify: - -(cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) Review comment: I thought so too until I looked at the command which is pretty different (but I have no idea what exactly it does) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse commented on a change in pull request #197: Remove test instructions for browserify
raphinesse commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216648078 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios (cd mobilespec && ./cordova build && ./cordova run android) -Ensure that mobilespec creates okay via CLI and browserify: - -(cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) Review comment: The block directly above it reads "Ensure that mobilespec creates okay via CLI:", so I'd say we've got that covered. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on a change in pull request #197: Remove test instructions for browserify
janpio commented on a change in pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197#discussion_r216647461 ## File path: docs/tools-release-process.md ## @@ -225,10 +225,6 @@ Ensure that mobilespec creates okay via CLI: cordova-mobile-spec/createmobilespec/createmobilespec.js --android --ios (cd mobilespec && ./cordova build && ./cordova run android) -Ensure that mobilespec creates okay via CLI and browserify: - -(cd mobilespec && ./cordova prepare --browserify && ./cordova build && ./cordova run android) Review comment: should this maybe left in, just without --browserify? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new pull request #197: Remove test instructions for browserify
raphinesse opened a new pull request #197: Remove test instructions for browserify URL: https://github.com/apache/cordova-coho/pull/197 Part of https://github.com/apache/cordova/issues/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new issue #9: Purge remnants of `fetch` option support
raphinesse opened a new issue #9: Purge remnants of `fetch` option support URL: https://github.com/apache/cordova/issues/9 ## Tasks - [x] cordova-lib (https://github.com/apache/cordova-lib/pull/617, https://github.com/apache/cordova-lib/pull/624) - [ ] cordova-cli - [ ] cordova-plugman - [ ] cordova-docs - [ ] Check for any other occurences This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new issue #8: Remove `browserify` support
raphinesse opened a new issue #8: Remove `browserify` support URL: https://github.com/apache/cordova/issues/8 ## Tasks - [ ] [cordova-cli](https://github.com/apache/cordova-cli/pull/321) - [x] [cordova-lib](https://github.com/apache/cordova-lib/pull/682) - [ ] cordova-js - [ ] cordova-docs This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] janpio commented on issue #6: Remove committed `node_modules` from platforms
janpio commented on issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6#issuecomment-420203485 (Added "Cordova coho Release Process documentation" as task) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new issue #7: Drop dependency on Q, use native promises
raphinesse opened a new issue #7: Drop dependency on Q, use native promises URL: https://github.com/apache/cordova/issues/7 We have to do this top down in our dependency graph. That way, we always can release each package without risking to break any of its consumers that rely on Q instances being returned. ## Task list ### Tooling - [ ] ### Platforms *TODO* ### Plugins *TODO* This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] raphinesse opened a new issue #6: Remove committed `node_modules` from platforms
raphinesse opened a new issue #6: Remove committed `node_modules` from platforms URL: https://github.com/apache/cordova/issues/6 We don't need them anymore since CLI installs all dependencies properly now. Not having to bundle dependencies vastly simplifies adding a new dependency if you need it for a feature. Tooling and core plugins are *not* affected. # Task List - [ ] cordova-android - [ ] cordova-browser - [ ] cordova-ios - [ ] cordova-osx - [ ] cordova-window This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] alan-grixti commented on issue #272: CB-12922 (ios): fix In-app browser does not cede control
alan-grixti commented on issue #272: CB-12922 (ios): fix In-app browser does not cede control URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/272#issuecomment-420199685 Hi, I've integrated your fixes into my local version of the plugin however I am not managing to get it working. Was the issue by any chance that of when opening a keyboard in the inappbrowser and closing the browser instance, the app would just hang? Mine is giving the error `<_UIKBCompatInputView: 0x7fe250d1cd30; frame = (0 0; 0 0); layer = > returned 0 width, assuming UIViewNoIntrinsicMetric 2018-09-11 10:52:49.439194+0200` too. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] lukeinage commented on issue #53: iPhone X initial height issue
lukeinage commented on issue #53: iPhone X initial height issue URL: https://github.com/apache/cordova-plugin-wkwebview-engine/issues/53#issuecomment-420192535 @janpio Yes, that's in inappbrowser wkwebview now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu opened a new pull request #168: CB-14071: Drop Node 4 Support
erisu opened a new pull request #168: CB-14071: Drop Node 4 Support URL: https://github.com/apache/cordova-js/pull/168 ### Platforms affected none ### What does this PR do? - Drop Node 4 Support ### What testing has been done on this change? - `npm test` - https://travis-ci.org/erisu/cordova-js/builds/427091950 ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] erisu opened a new pull request #53: Add Node 10 & Drop Node 4 Support
erisu opened a new pull request #53: Add Node 10 & Drop Node 4 Support URL: https://github.com/apache/cordova-osx/pull/53 ### Platforms affected osx ### What does this PR do? - Drop Node 4 Support - Add Node 10 Support ### What testing has been done on this change? - `npm test` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
