[GitHub] adamalexander opened a new issue #342: iOS: Adding black background on PNG

[GitBox]

adamalexander opened a new issue #342: iOS: Adding black background on PNG
URL: https://github.com/apache/cordova-plugin-camera/issues/342
 
 
   Situation:
   I use the plugin, to chose a png file form my camera roll. and display it in 
an `` tag using the `FILE_URI`
   
   Expected Behaviour:
   The transparent background on the png image gets replaced with a white 
background.
   
   Actual Behaviour:
   The transparent background on the png image gets replaced with a BLACK 
background.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sgoldberg-sfdc closed pull request #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib

[GitBox]

sgoldberg-sfdc closed pull request #408: CB-14192: (ios) - Xcode 10 Framework 
Target Fix - Convert Framework to build source rather than wrap static lib
URL: https://github.com/apache/cordova-ios/pull/408
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj 
b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
index 4df32ce56..cd4ba2383 100644
--- a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
+++ b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
@@ -64,7 +64,6 @@
A3B082D41BB15CEA00D8DC35 /* CDVGestureHandler.h in Headers */ = 
{isa = PBXBuildFile; fileRef = A3B082D21BB15CEA00D8DC35 /* CDVGestureHandler.h 
*/; };
A3B082D51BB15CEA00D8DC35 /* CDVGestureHandler.m in Sources */ = 
{isa = PBXBuildFile; fileRef = A3B082D31BB15CEA00D8DC35 /* CDVGestureHandler.m 
*/; };
C0C01EB61E3911D50056E6CB /* Cordova.h in Headers */ = {isa = 
PBXBuildFile; fileRef = C0C01EB41E3911D50056E6CB /* Cordova.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
-   C0C01EBA1E39120F0056E6CB /* libCordova.a in Frameworks */ = 
{isa = PBXBuildFile; fileRef = 68A32D7114102E1C006B237C /* libCordova.a */; };
C0C01EBB1E39131A0056E6CB /* CDV.h in Headers */ = {isa = 
PBXBuildFile; fileRef = 7ED95D0F1AB9029B008C4574 /* CDV.h */; settings = 
{ATTRIBUTES = (Public, ); }; };
C0C01EBC1E39131A0056E6CB /* CDVAppDelegate.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 7ED95D101AB9029B008C4574 /* CDVAppDelegate.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
C0C01EBD1E39131A0056E6CB /* CDVAvailability.h in Headers */ = 
{isa = PBXBuildFile; fileRef = 7ED95D121AB9029B008C4574 /* CDVAvailability.h 
*/; settings = {ATTRIBUTES = (Public, ); }; };
@@ -86,19 +85,42 @@
C0C01ECD1E39131A0056E6CB /* CDVWhitelist.h in Headers */ = {isa 
= PBXBuildFile; fileRef = 7ED95D2D1AB9029B008C4574 /* CDVWhitelist.h */; 
settings = {ATTRIBUTES = (Public, ); }; };
C0C01ECE1E39131A0056E6CB /* NSDictionary+CordovaPreferences.h 
in Headers */ = {isa = PBXBuildFile; fileRef = 7ED95D311AB9029B008C4574 /* 
NSDictionary+CordovaPreferences.h */; settings = {ATTRIBUTES = (Public, ); }; };
C0C01ECF1E39131A0056E6CB /* NSMutableArray+QueueAdditions.h in 
Headers */ = {isa = PBXBuildFile; fileRef = 7ED95D331AB9029B008C4574 /* 
NSMutableArray+QueueAdditions.h */; settings = {ATTRIBUTES = (Public, ); }; };
-   C0C01ED01E3913610056E6CB /* CDVUIWebViewDelegate.h in Headers 
*/ = {isa = PBXBuildFile; fileRef = 7ED95CFE1AB9028C008C4574 /* 
CDVUIWebViewDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
+   C0D7D0AC214C827F00794B01 /* CDVAppDelegate.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D111AB9029B008C4574 /* CDVAppDelegate.m */; 
};
+   C0D7D0AD214C827F00794B01 /* CDVCommandDelegateImpl.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = 7ED95D161AB9029B008C4574 /* 
CDVCommandDelegateImpl.m */; };
+   C0D7D0AE214C827F00794B01 /* CDVCommandQueue.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D181AB9029B008C4574 /* CDVCommandQueue.m 
*/; };
+   C0D7D0AF214C827F00794B01 /* CDVConfigParser.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D1A1AB9029B008C4574 /* CDVConfigParser.m 
*/; };
+   C0D7D0B0214C827F00794B01 /* CDVInvokedUrlCommand.m in Sources 
*/ = {isa = PBXBuildFile; fileRef = 7ED95D1C1AB9029B008C4574 /* 
CDVInvokedUrlCommand.m */; };
+   C0D7D0B1214C827F00794B01 /* CDVPlugin+Resources.m in Sources */ 
= {isa = PBXBuildFile; fileRef = 7ED95D1E1AB9029B008C4574 /* 
CDVPlugin+Resources.m */; };
+   C0D7D0B2214C827F00794B01 /* CDVPlugin.m in Sources */ = {isa = 
PBXBuildFile; fileRef = 7ED95D201AB9029B008C4574 /* CDVPlugin.m */; };
+   C0D7D0B3214C827F00794B01 /* CDVPluginResult.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D221AB9029B008C4574 /* CDVPluginResult.m 
*/; };
+   C0D7D0B4214C827F00794B01 /* CDVTimer.m in Sources */ = {isa = 
PBXBuildFile; fileRef = 7ED95D251AB9029B008C4574 /* CDVTimer.m */; };
+   C0D7D0B5214C827F00794B01 /* CDVURLProtocol.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D271AB9029B008C4574 /* CDVURLProtocol.m */; 
};
+   C0D7D0B6214C827F00794B01 /* CDVUserAgentUtil.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D291AB9029B008C4574 /* CDVUserAgentUtil.m 
*/; };
+   C0D7D0B7214C827F00794B01 /* CDVViewController.m in Sources */ = 
{isa = PBXBuildFile; fileRef = 7ED95D2B1AB9029B008C4574 /* CDVViewController.m 
*/; };
+   C0D7D0B8214C827F00794B01 /* CDVWhitelist.m in Sources */ = {isa 
= PBXBuildFile; 

[GitHub] sgoldberg-sfdc commented on issue #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib

[GitBox]

sgoldberg-sfdc commented on issue #408: CB-14192: (ios) - Xcode 10 Framework 
Target Fix - Convert Framework to build source rather than wrap static lib
URL: https://github.com/apache/cordova-ios/pull/408#issuecomment-421522469
 
 
   Closing for now, more at play here than the framework target. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sgoldberg-sfdc opened a new pull request #408: CB-14192: (ios) - Xcode 10 Framework Target Fix - Convert Framework to build source rather than wrap static lib

[GitBox]

sgoldberg-sfdc opened a new pull request #408: CB-14192: (ios) - Xcode 10 
Framework Target Fix - Convert Framework to build source rather than wrap 
static lib
URL: https://github.com/apache/cordova-ios/pull/408
 
 
   -  The new build system in Xcode 10 gets confused by the static library 
header files copied to $CONFIGURATION_BUILD_DIR/include
   -  By making the framework target build the source directly we eliminate 
this issue
   -  If both targets are built, the issue will still occur
   
   
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Modifies the framework target to compile the source directly, rather than 
wrap the static library target. This avoids the issue where the static library 
header files are copied to the $CONFIGURATION_BUILD_DIR confusing the new build 
system (defaulted on in Xcode 10) resulting in duplicate definition errors. 
   
   ### What testing has been done on this change?
   Manually verified builds of both targets within xcode and via Carthage.
   
   ### Checklist
   - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [X] Added automated test coverage as appropriate for this change. (None 
required)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

dpogue commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421512169
 
 
   @sgoldberg-sfdc I poked around very briefly this afternoon, but you clearly 
understand the details of the problem better than I do.
   
   After telling Xcode to bring both the app project and the CordovaLib project 
to the recommended build settings, the new build system seemed to work fine. I 
see that it did change some stuff around Cordova.framework, but I admit to not 
totally understanding what that entails. The only changes were to xcodeproj 
files, no changes to source files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421510810
 
 
   @shazron and @dpogue , Here is the issue with the New Build System.
   
   The framework target is a wrapper on the static library. The static library 
has a copy headers build phase that is before the compilation build phase. If 
you move the copy headers phase to after the compilation phase, the new build 
system will successfully build the framework target one time (with a clean 
derived data folder). Unfortunately, subsequent builds will fail because the 
new build system is getting confused by the header files being in two places in 
the search path (project folder and CONFIGURATION_BUILD_DIR folder). There are 
several hacky solutions, but my recommendation is make the framework target a 
first class citizen, sharing the source files and compiling them as part of the 
target, rather than depending on the static library target. I can submit a PR 
on Monday.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] vwasteels edited a comment on issue #114: Not working on Android devices

[GitBox]

vwasteels edited a comment on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421491252
 
 
   Tested with Android version 6.0
   
   ```
   git clone g...@github.com:vwasteels/test-cordova-geolocation.git
   cd test-cordova-geolocation
   cordova prepare
   cordova run android --device
   ```
   
   open inspector at chrome://inspect
   console says, after 10 seconds : 
   ```
   Received Event: deviceready
   getCurrentPosition fails
   PositionError {code: 3, message: "Timeout expired"}
   ```
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] vwasteels commented on issue #114: Not working on Android devices

[GitBox]

vwasteels commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421491252
 
 
   ```
   git clone g...@github.com:vwasteels/test-cordova-geolocation.git
   cd test-cordova-geolocation
   cordova prepare
   cordova run android --device
   ```
   
   open inspector at chrome://inspect
   console says, after 10 seconds : 
   ```
   Received Event: deviceready
   getCurrentPosition fails
   PositionError {code: 3, message: "Timeout expired"}
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] davidgovea commented on issue #114: Not working on Android devices

[GitBox]

davidgovea commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421484013
 
 
   If you're experiencing this issue, make sure you are providing the `timeout` 
option to your geolocation call, e.g. `getCurrentPosition(successFn, errorFn, { 
timeout: 1 });`
   
   This way, failing devices can be handled in the same way as a user who 
declines location permissions (which your app should already do), instead of 
hanging.
   
   ---
   
   I would say it's an extremely good bet that this issue will be resolved, but 
perhaps not in the timescale that you would prefer. If the issue is highly 
urgent, I might suggest the following approaches for your consideration (ranked 
from helpful to not-so-helpful):
   
   1. Create a reproduction project as @janpio has suggested
   2. Invest some time into fixing/updating this free, open-source code
   3. Provide more testing anecdotes and +1's to this thread
   4. Find a different approach ("move on")
   5. Motivate the contributors by threatening (or even just _bluffing_) to 
"move on" 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #95: CB-14260: (android) captureImage permission denial on android 8.1

[GitBox]

janpio commented on issue #95: CB-14260: (android) captureImage permission 
denial on android 8.1
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421477008
 
 
   We still need a Cordova maintainer to merge it and cut a release. Commenting 
here won't do a thing about that. I requested reviews from 2 people that maybe 
could help, but they don't seem to have the time right now. As we are all 
volunteers, this is total understandable.
   
   Alternatively you can just install this branch of this PR or fork the plugin 
yourself and merge this branch into it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ffMathy commented on issue #95: CB-14260: (android) captureImage permission denial on android 8.1

[GitBox]

ffMathy commented on issue #95: CB-14260: (android) captureImage permission 
denial on android 8.1
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421474355
 
 
   @janpio so both @mnill and I tested, and this is insanely critical - the 
plugin is not working at all for specific target SDKs. Furthermore, per 
default, it is not working in Ionic because of this.
   
   How many tests and approvals will it need before we merge it? I can get a 
few friends to help as well maybe.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ryuheimat opened a new issue #106: navigator.notification.alert does not work in iOS

[GitBox]

ryuheimat opened a new issue #106: navigator.notification.alert does not work 
in iOS
URL: https://github.com/apache/cordova-plugin-dialogs/issues/106
 
 
   navigator.notification.alert works fine in android but not work at ios.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ffMathy commented on issue #95: CB-14260: (android) captureImage permission denial on android 8.1

[GitBox]

ffMathy commented on issue #95: CB-14260: (android) captureImage permission 
denial on android 8.1
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421467092
 
 
   Works like a charm, tested on brand new Samsung Galaxy S9.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #95: CB-14260: (android) captureImage permission denial on android 8.1

[GitBox]

janpio commented on issue #95: CB-14260: (android) captureImage permission 
denial on android 8.1
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421466627
 
 
   I won't as I don't know enough about possible side effects. If you tested 
the PR and can confirm that it works, please also approve the PR. Each "vote" 
helps a future maintainer to decide if to merge or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ffMathy commented on issue #95: CB-14260: (android) captureImage permission denial on android 8.1

[GitBox]

ffMathy commented on issue #95: CB-14260: (android) captureImage permission 
denial on android 8.1
URL: 
https://github.com/apache/cordova-plugin-media-capture/pull/95#issuecomment-421461192
 
 
   Can we merge this? It fixes a critical issue, and it has been quite a few 
days since it was approved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #105: Feature request: customize 'cancelable' in dialogs

[GitBox]

janpio commented on issue #105: Feature request: customize 'cancelable' in 
dialogs
URL: 
https://github.com/apache/cordova-plugin-dialogs/issues/105#issuecomment-421461065
 
 
   We are always open to Pull Requests adding useful functionality.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] clement9527 opened a new issue #105: Feature request: customize 'cancelable' in dialogs

[GitBox]

clement9527 opened a new issue #105: Feature request: customize 'cancelable' in 
dialogs
URL: https://github.com/apache/cordova-plugin-dialogs/issues/105
 
 
   To customize the dialog to be cancelable is supported in ReactNative: 
https://facebook.github.io/react-native/docs/alert. 
   
   Is there a plan to support that in Cordova down the road?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] fernandoocf commented on issue #114: Not working on Android devices

[GitBox]

fernandoocf commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421452581
 
 
   @janpio try to reproduce on Samsung Galaxy S7 - Android 8.0.0
   
   This is the device model that I use to test my app. You will probably get 
the same issue on this device.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #400: Why is config.xml not being merged?

[GitBox]

jcesarmobile closed issue #400: Why is config.xml not being merged?
URL: https://github.com/apache/cordova-ios/issues/400
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #400: Why is config.xml not being merged?

[GitBox]

jcesarmobile commented on issue #400: Why is config.xml not being merged?
URL: https://github.com/apache/cordova-ios/issues/400#issuecomment-421442796
 
 
   In your plugin.xml you have to add this to make the plugin install add the 
feature tags to the staging config.xml
   
   ```
   
   
   
   
   
   
   
   ```
   
   never edit the staging config.xml manually.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] cvanem commented on issue #297: Service Worker Support?

[GitBox]

cvanem commented on issue #297: Service Worker Support?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/297#issuecomment-421442314
 
 
   I should also add that this is for a hybrid app, which loads external web 
content into the inappbrowser.  I would like to avoid storing any hard assets 
in the application package.   The preferred functionality would download and 
install the service worker on the first successful web request.  After that the 
service worker would handle caching.  Any guidance on where to start?  Am I 
correct that this functionality is not currently available?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

[GitBox]

brodybits commented on issue #494: Change from CordovaWebView to SystemWebView 
in latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494#issuecomment-421441903
 
 
   > Closing this as there is a cordova-docs issue already linked.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #491: Embedding cordova application on Android native application

[GitBox]

jcesarmobile commented on issue #491: Embedding cordova application on Android 
native application
URL: https://github.com/apache/cordova-android/issues/491#issuecomment-421441401
 
 
   See my comment on https://github.com/apache/cordova-android/issues/494


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #491: Embedding cordova application on Android native application

[GitBox]

jcesarmobile closed issue #491: Embedding cordova application on Android native 
application
URL: https://github.com/apache/cordova-android/issues/491
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #498: Cordova Build minSdkVersion change to 19

[GitBox]

jcesarmobile closed issue #498: Cordova Build minSdkVersion change to 19
URL: https://github.com/apache/cordova-android/issues/498
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #498: Cordova Build minSdkVersion change to 19

[GitBox]

jcesarmobile commented on issue #498: Cordova Build minSdkVersion change to 19
URL: https://github.com/apache/cordova-android/issues/498#issuecomment-421441211
 
 
   You have to edit the root config.xml, not the config.xml in xml folder. The 
content of xml/config.xml is recreated from the root one, that's why your 
changes are lost.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

[GitBox]

jcesarmobile commented on issue #494: Change from CordovaWebView to 
SystemWebView in latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494#issuecomment-421440620
 
 
   This is not a cordova-android issue, it's a cordova-docs issue.
   The embedded workflow has been broken/undocumented for a long time, you can 
take a look at this two PRs that tried to document it, but in the end were 
closed. They both helped me to embed the webview long time ago. Also check the 
comments.
   https://github.com/apache/cordova-docs/pull/498
   https://github.com/apache/cordova-docs/pull/544
   
   Closing this as there is a cordova-docs issue already linked.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

[GitBox]

jcesarmobile closed issue #494: Change from CordovaWebView to SystemWebView in 
latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #66: explicit plist@3 dependency

[GitBox]

brodybits commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421433439
 
 
   Agreed. I raised this in a rush while rebasing changes in WIP PR #49. I just 
referenced the more descriptive comments in the original description.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #404: Cordova build iOS error: archive not found at path 'path/to/myApp.xcarchive" with Xcode 10

[GitBox]

dpogue commented on issue #404: Cordova build iOS error: archive not found at 
path 'path/to/myApp.xcarchive" with Xcode 10
URL: https://github.com/apache/cordova-ios/issues/404#issuecomment-421432733
 
 
   Thanks for raising this issue and providing logs.
   
   Currently cordova-ios isn't compatible with Xcode 10's new build system, but 
there are some [workarounds documented 
here](https://github.com/apache/cordova-ios/issues/407).
   I'll keep this issue open for us to investigate what we need to change to be 
compatible with Xcode 10, but wanted to provide that link to workarounds for 
anyone who has upgraded and is running into this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] raphinesse commented on issue #14: npm WARN deprecated hoek@2.16.3: The major version is no longer supported. Please update to 4.x or newer

[GitBox]

raphinesse commented on issue #14: npm WARN deprecated hoek@2.16.3: The major 
version is no longer supported. Please update to 4.x or newer
URL: https://github.com/apache/cordova/issues/14#issuecomment-421431621
 
 
   Already resolved in master


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] raphinesse closed issue #14: npm WARN deprecated hoek@2.16.3: The major version is no longer supported. Please update to 4.x or newer

[GitBox]

raphinesse closed issue #14: npm WARN deprecated hoek@2.16.3: The major version 
is no longer supported. Please update to 4.x or newer
URL: https://github.com/apache/cordova/issues/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Yowsifahamed opened a new issue #14: npm WARN deprecated hoek@2.16.3: The major version is no longer supported. Please update to 4.x or newer

[GitBox]

Yowsifahamed opened a new issue #14: npm WARN deprecated hoek@2.16.3: The major 
version is no longer supported. Please update to 4.x or newer
URL: https://github.com/apache/cordova/issues/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue opened a new issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

[GitBox]

dpogue opened a new issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407
 
 
   A few issues have started to come in regarding the state of Cordova projects 
on Xcode 10. This is a rough summary of the situation:
   
   Xcode 10 uses a new build system by default (previously available on an 
opt-in basis in Xcode 9). The cordova-ios project structure is not compatible 
with this new build system and results in failures.
   Officially, we do not claim to support Xcode 10.
   
   Currently the best workaround is to opt-out of the new build system:
   
   * If you're building on the command-line, you can specify 
`--buildFlag="-UseModernBuildSystem=0"`
   
   * If you're building with a build.json config file, you can add the 
following under the iOS release or debug config:
   ```json
   "buildFlag": [
 "-UseModernBuildSystem=0"
   ]
   ```
   
   We're going to investigate what's required to make cordova-ios compatible 
with the new build system, and hope to include that in the next major version 
(cordova-ios@5.0.0).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #66: explicit plist@3 dependency

[GitBox]

janpio commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421429747
 
 
   Don't worry digging for the actual reason, I was just curious how this came 
to be.
   That it _should_ be added to dependencies is not under discussion. But in my 
opinion a PR such as this should include the motivation, so we can understand 
in a year or so when we try to understand where this dependency comes from.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #13: Minimal, complete, and verifiable checkbox needed in bug reports

[GitBox]

brodybits opened a new issue #13: Minimal, complete, and verifiable checkbox 
needed in bug reports
URL: https://github.com/apache/cordova/issues/13
 
 
   Whenever someone raises an issue with a bug report, I think there should be 
a checkbox item such as:
   
   - [ ] A minimal, complete, and verifiable example of the issue is included 
as described in 
   
   We may want to add a link to a more detailed description of what is needed. 
 is an interesting start.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #66: explicit plist@3 dependency

[GitBox]

brodybits commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421423781
 
 
   > So bug before? Or where did it come from?
   
   IIRC I had to add plist to bundledDependencies on cordova-ios or cordova-osx 
(I forget which one now) for it to work with deprecated Node.js version 4. I 
would have to dig further to explain the history, cannot promise when I will 
get a chance to do this.
   
   I think it is not good for any npm package to assume any dependency will be 
automatically provided by another dependency. Too fragile and bad practice in 
general.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #49: [WIP] Major release TODO WIP

[GitBox]

brodybits commented on issue #49: [WIP] Major release TODO WIP
URL: https://github.com/apache/cordova-osx/pull/49#issuecomment-421422537
 
 
   I just moved the explicit plist@3 dependency update to #66 and rebased the 
eslint updates on 35fc603 in `master` branch. (All other changes are now in 
`master` branch). Some but not all eslint updates proposed here were 
incorporated in merged PR #61. Some other TODO items still remain.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #66: explicit plist@3 dependency

[GitBox]

janpio commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421419555
 
 
   So bug before? Or where did it come from?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #66: explicit plist@3 dependency

[GitBox]

brodybits commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421417938
 
 
   > Why?
   
   `require('plist')` is used in:
   * `bin/templates/scripts/cordova/lib/projectFile.js`
   * `bin/templates/scripts/cordova/lib/prepare.js`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #66: explicit plist@3 dependency

[GitBox]

janpio commented on issue #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66#issuecomment-421408596
 
 
   Why? It would be helpful if PRs not only contained the _what_, but also the 
_why_. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #66: explicit plist@3 dependency

[GitBox]

brodybits opened a new pull request #66: explicit plist@3 dependency
URL: https://github.com/apache/cordova-osx/pull/66
 
 
   (explicitly used)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] raphinesse edited a comment on issue #12: Use const whenever possible

[GitBox]

raphinesse edited a comment on issue #12: Use const whenever possible
URL: https://github.com/apache/cordova/issues/12#issuecomment-421402055
 
 
   Yup, I've been doing that as I go. I just haven't felt it was important 
enough to be tackled just for the sake of it. Consider that it will create 
quite some diff noise and probably merge conflicts for any open PRs.
   
   That being said, there's a tool that does these transformations for you: 
https://lebab.io/. Last time I checked it was a bit overzealous with the arrow 
functions, resulting in bad code layout. And one of the code transforms choked 
on our license header. So *if* we do this, it might be worth considering 
throwing something like `prettier` at the code to format it uniformly (and make 
sure we make `git blame` completely useless). @janpio Would love to do that, I 
hear :wink:
   
   Of course, for `var` to `const` simple search and replace should work too. 
Then step through linter errors and change these all to let. Probably gets you 
99% there with the minimal impact.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] raphinesse commented on issue #12: Use const whenever possible

[GitBox]

raphinesse commented on issue #12: Use const whenever possible
URL: https://github.com/apache/cordova/issues/12#issuecomment-421402055
 
 
   Yup, I've been doing that as I go. I just haven't felt it was important 
enough to be tackled just for the sake of it. Consider that it will create 
quite some diff noise and probably merge conflicts for any open PRs.
   
   That being said, there's a tool that does these transformations for you: 
https://lebab.io/. Last time I checked it was a bit overzealous with the arrow 
functions, resulting in bad code layout. And some transformed choked on our 
license header. So *if* we do this, it might be worth considering throwing 
something like `prettier` at the code to format it uniformly (and make sure we 
make `git blame` completely useless). @janpio Would love to do that, I hear 
:wink:
   
   Of course, for `var` to `const` simple search and replace should work too. 
Then step through linter errors and change these all to let. Probably gets you 
99% there with the minimal impact.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #65: Start 5.0.0-dev

[GitBox]

brodybits closed pull request #65: Start 5.0.0-dev
URL: https://github.com/apache/cordova-osx/pull/65
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package.json b/package.json
index e920d4af..1833f158 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cordova-osx",
-  "version": "4.1.0-dev",
+  "version": "5.0.0-dev",
   "description": "cordova-osx release",
   "main": "bin/templates/scripts/cordova/Api.js",
   "repository": {


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #64: Use const whenever possible

[GitBox]

brodybits commented on issue #64: Use const whenever possible
URL: https://github.com/apache/cordova-osx/issues/64#issuecomment-421399340
 
 
   Raised for Cordova (general) in: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #12: Use const whenever possible

[GitBox]

brodybits opened a new issue #12: Use const whenever possible
URL: https://github.com/apache/cordova/issues/12
 
 
   I think @raphinesse and others have already put a major effort into this. I 
am raising this is an explicit issue in response to 
.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch master updated: Remove Unused Dependencies & update tmp (#62)

[erisu]

This is an automated email from the ASF dual-hosted git repository.

erisu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git


The following commit(s) were added to refs/heads/master by this push:
 new 00c5f25  Remove Unused Dependencies & update tmp (#62)
00c5f25 is described below

commit 00c5f25326383934f1eb20ad29d2be585a47b6a0
Author: エリス 
AuthorDate: Sat Sep 15 00:40:44 2018 +0900

Remove Unused Dependencies & update tmp (#62)

Cherry Picks from (#49)
* package.json drop uncrustify from devDependencies
* package*.json remove coffee-script
* package*.json remove nodeunit devDep
---
 package-lock.json | 3389 +
 package.json  |5 +-
 2 files changed, 23 insertions(+), 3371 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c333c38..61bc0fd 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -103,39 +103,6 @@
   "integrity": "sha1-iYUI2iIm84DfkEcoRWhJwVAaSw0=",
   "dev": true
 },
-"asn1": {
-  "version": "0.2.4",
-  "resolved": "https://registry.npmjs.org/asn1/-/asn1-0.2.4.tgz;,
-  "integrity": 
"sha512-jxwzQpLQjSmWXgwaCZE9Nz+glAG01yF1QnWgbhGwHI5A6FRIEY6IVqtHhIepHqI7/kyEyQEagBC5mBEFlIYvdg==",
-  "dev": true,
-  "requires": {
-"safer-buffer": "~2.1.0"
-  }
-},
-"assert-plus": {
-  "version": "1.0.0",
-  "resolved": 
"https://registry.npmjs.org/assert-plus/-/assert-plus-1.0.0.tgz;,
-  "integrity": "sha1-8S4PPF13sLHN2RRpQuTpbB5N1SU=",
-  "dev": true
-},
-"asynckit": {
-  "version": "0.4.0",
-  "resolved": "https://registry.npmjs.org/asynckit/-/asynckit-0.4.0.tgz;,
-  "integrity": "sha1-x57Zf380y48robyXkLzDZkdLS3k=",
-  "dev": true
-},
-"aws-sign2": {
-  "version": "0.7.0",
-  "resolved": "https://registry.npmjs.org/aws-sign2/-/aws-sign2-0.7.0.tgz;,
-  "integrity": "sha1-tG6JCTSpWR8tL2+G1+ap8bP+dqg=",
-  "dev": true
-},
-"aws4": {
-  "version": "1.8.0",
-  "resolved": "https://registry.npmjs.org/aws4/-/aws4-1.8.0.tgz;,
-  "integrity": 
"sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==",
-  "dev": true
-},
 "babel-code-frame": {
   "version": "6.26.0",
   "resolved": 
"https://registry.npmjs.org/babel-code-frame/-/babel-code-frame-6.26.0.tgz;,
@@ -181,33 +148,11 @@
   "resolved": "https://registry.npmjs.org/base64-js/-/base64-js-1.2.0.tgz;,
   "integrity": "sha1-o5mS1yNYSBGYK+XikLtqU9hnAPE="
 },
-"bcrypt-pbkdf": {
-  "version": "1.0.2",
-  "resolved": 
"https://registry.npmjs.org/bcrypt-pbkdf/-/bcrypt-pbkdf-1.0.2.tgz;,
-  "integrity": "sha1-pDAdOJtqQ/m2f/PKEaP2Y342Dp4=",
-  "dev": true,
-  "optional": true,
-  "requires": {
-"tweetnacl": "^0.14.3"
-  }
-},
 "big-integer": {
   "version": "1.6.36",
   "resolved": 
"https://registry.npmjs.org/big-integer/-/big-integer-1.6.36.tgz;,
   "integrity": 
"sha512-t70bfa7HYEA1D9idDbmuv7YbsbVkQ+Hp+8KFSul4aE5e/i1bjCNIRYJZlA8Q8p0r9T8cF/RVvwUgRA//FydEyg=="
 },
-"bind-obj-methods": {
-  "version": "2.0.0",
-  "resolved": 
"https://registry.npmjs.org/bind-obj-methods/-/bind-obj-methods-2.0.0.tgz;,
-  "integrity": 
"sha512-3/qRXczDi2Cdbz6jE+W3IflJOutRVica8frpBn14de1mBOkzDo+6tY33kNhvkw54Kn3PzRRD2VnGbGPcTAk4sw==",
-  "dev": true
-},
-"bluebird": {
-  "version": "3.5.2",
-  "resolved": "https://registry.npmjs.org/bluebird/-/bluebird-3.5.2.tgz;,
-  "integrity": 
"sha512-dhHTWMI7kMx5whMQntl7Vr9C6BvV10lFXDAasnqnrMYhXVCzzk6IO9Fo2L75jXHT07WrOngL1WDXOp+yYS91Yg==",
-  "dev": true
-},
 "bplist-creator": {
   "version": "0.0.7",
   "resolved": 
"https://registry.npmjs.org/bplist-creator/-/bplist-creator-0.0.7.tgz;,
@@ -260,12 +205,6 @@
   "integrity": "sha1-r6uWJikQp/M8GaV3WCXGnzTjUMo=",
   "dev": true
 },
-"caseless": {
-  "version": "0.12.0",
-  "resolved": "https://registry.npmjs.org/caseless/-/caseless-0.12.0.tgz;,
-  "integrity": "sha1-G2gcIf+EAzyCZUMJBolCDRhxUdw=",
-  "dev": true
-},
 "chalk": {
   "version": "2.4.1",
   "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.1.tgz;,
@@ -309,12 +248,6 @@
   "integrity": 
"sha512-UZK3NBx2Mca+b5LsG7bY183pHWt5Y1xts4P3Pz7ENTwGVnJOUWbRb3ocjvX7hx9tq/yTAdclXm9sZ38gNuem4A==",
   "dev": true
 },
-"clean-yaml-object": {
-  "version": "0.1.0",
-  "resolved": 
"https://registry.npmjs.org/clean-yaml-object/-/clean-yaml-object-0.1.0.tgz;,
-  "integrity": "sha1-Y/sRDcLOGoTcIfbZM0h20BCui2g=",
-  "dev": true
-},
 "cli-cursor": {
   "version": "2.1.0",
   "resolved": 
"https://registry.npmjs.org/cli-cursor/-/cli-cursor-2.1.0.tgz;,
@@ -336,12 +269,6 @@
   "integrity": "sha1-bqa989hTrlTMuOR7+gvz+QMfsYQ=",
   "dev": true
 },
-"coffee-script": {
- 

[GitHub] erisu closed pull request #62: Remove Unused Dependencies & update tmp

[GitBox]

erisu closed pull request #62: Remove Unused Dependencies & update tmp
URL: https://github.com/apache/cordova-osx/pull/62
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/package-lock.json b/package-lock.json
index c333c389..61bc0fd6 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -103,39 +103,6 @@
   "integrity": "sha1-iYUI2iIm84DfkEcoRWhJwVAaSw0=",
   "dev": true
 },
-"asn1": {
-  "version": "0.2.4",
-  "resolved": "https://registry.npmjs.org/asn1/-/asn1-0.2.4.tgz;,
-  "integrity": 
"sha512-jxwzQpLQjSmWXgwaCZE9Nz+glAG01yF1QnWgbhGwHI5A6FRIEY6IVqtHhIepHqI7/kyEyQEagBC5mBEFlIYvdg==",
-  "dev": true,
-  "requires": {
-"safer-buffer": "~2.1.0"
-  }
-},
-"assert-plus": {
-  "version": "1.0.0",
-  "resolved": 
"https://registry.npmjs.org/assert-plus/-/assert-plus-1.0.0.tgz;,
-  "integrity": "sha1-8S4PPF13sLHN2RRpQuTpbB5N1SU=",
-  "dev": true
-},
-"asynckit": {
-  "version": "0.4.0",
-  "resolved": "https://registry.npmjs.org/asynckit/-/asynckit-0.4.0.tgz;,
-  "integrity": "sha1-x57Zf380y48robyXkLzDZkdLS3k=",
-  "dev": true
-},
-"aws-sign2": {
-  "version": "0.7.0",
-  "resolved": "https://registry.npmjs.org/aws-sign2/-/aws-sign2-0.7.0.tgz;,
-  "integrity": "sha1-tG6JCTSpWR8tL2+G1+ap8bP+dqg=",
-  "dev": true
-},
-"aws4": {
-  "version": "1.8.0",
-  "resolved": "https://registry.npmjs.org/aws4/-/aws4-1.8.0.tgz;,
-  "integrity": 
"sha512-ReZxvNHIOv88FlT7rxcXIIC0fPt4KZqZbOlivyWtXLt8ESx84zd3kMC6iK5jVeS2qt+g7ftS7ye4fi06X5rtRQ==",
-  "dev": true
-},
 "babel-code-frame": {
   "version": "6.26.0",
   "resolved": 
"https://registry.npmjs.org/babel-code-frame/-/babel-code-frame-6.26.0.tgz;,
@@ -181,33 +148,11 @@
   "resolved": "https://registry.npmjs.org/base64-js/-/base64-js-1.2.0.tgz;,
   "integrity": "sha1-o5mS1yNYSBGYK+XikLtqU9hnAPE="
 },
-"bcrypt-pbkdf": {
-  "version": "1.0.2",
-  "resolved": 
"https://registry.npmjs.org/bcrypt-pbkdf/-/bcrypt-pbkdf-1.0.2.tgz;,
-  "integrity": "sha1-pDAdOJtqQ/m2f/PKEaP2Y342Dp4=",
-  "dev": true,
-  "optional": true,
-  "requires": {
-"tweetnacl": "^0.14.3"
-  }
-},
 "big-integer": {
   "version": "1.6.36",
   "resolved": 
"https://registry.npmjs.org/big-integer/-/big-integer-1.6.36.tgz;,
   "integrity": 
"sha512-t70bfa7HYEA1D9idDbmuv7YbsbVkQ+Hp+8KFSul4aE5e/i1bjCNIRYJZlA8Q8p0r9T8cF/RVvwUgRA//FydEyg=="
 },
-"bind-obj-methods": {
-  "version": "2.0.0",
-  "resolved": 
"https://registry.npmjs.org/bind-obj-methods/-/bind-obj-methods-2.0.0.tgz;,
-  "integrity": 
"sha512-3/qRXczDi2Cdbz6jE+W3IflJOutRVica8frpBn14de1mBOkzDo+6tY33kNhvkw54Kn3PzRRD2VnGbGPcTAk4sw==",
-  "dev": true
-},
-"bluebird": {
-  "version": "3.5.2",
-  "resolved": "https://registry.npmjs.org/bluebird/-/bluebird-3.5.2.tgz;,
-  "integrity": 
"sha512-dhHTWMI7kMx5whMQntl7Vr9C6BvV10lFXDAasnqnrMYhXVCzzk6IO9Fo2L75jXHT07WrOngL1WDXOp+yYS91Yg==",
-  "dev": true
-},
 "bplist-creator": {
   "version": "0.0.7",
   "resolved": 
"https://registry.npmjs.org/bplist-creator/-/bplist-creator-0.0.7.tgz;,
@@ -260,12 +205,6 @@
   "integrity": "sha1-r6uWJikQp/M8GaV3WCXGnzTjUMo=",
   "dev": true
 },
-"caseless": {
-  "version": "0.12.0",
-  "resolved": "https://registry.npmjs.org/caseless/-/caseless-0.12.0.tgz;,
-  "integrity": "sha1-G2gcIf+EAzyCZUMJBolCDRhxUdw=",
-  "dev": true
-},
 "chalk": {
   "version": "2.4.1",
   "resolved": "https://registry.npmjs.org/chalk/-/chalk-2.4.1.tgz;,
@@ -309,12 +248,6 @@
   "integrity": 
"sha512-UZK3NBx2Mca+b5LsG7bY183pHWt5Y1xts4P3Pz7ENTwGVnJOUWbRb3ocjvX7hx9tq/yTAdclXm9sZ38gNuem4A==",
   "dev": true
 },
-"clean-yaml-object": {
-  "version": "0.1.0",
-  "resolved": 
"https://registry.npmjs.org/clean-yaml-object/-/clean-yaml-object-0.1.0.tgz;,
-  "integrity": "sha1-Y/sRDcLOGoTcIfbZM0h20BCui2g=",
-  "dev": true
-},
 "cli-cursor": {
   "version": "2.1.0",
   "resolved": 
"https://registry.npmjs.org/cli-cursor/-/cli-cursor-2.1.0.tgz;,
@@ -336,12 +269,6 @@
   "integrity": "sha1-bqa989hTrlTMuOR7+gvz+QMfsYQ=",
   "dev": true
 },
-"coffee-script": {
-  "version": "1.12.7",
-  "resolved": 
"https://registry.npmjs.org/coffee-script/-/coffee-script-1.12.7.tgz;,
-  "integrity": 
"sha512-fLeEhqwymYat/MpTPUjSKHVYYl0ec2mOyALEMLmzr5i1isuG+6jfI2j2d5oBO3VIzgUXgBVIcOT9uH1TFxBckw==",
-  "dev": true
-},
 "color-convert": {
   "version": "1.9.3",
   "resolved": 
"https://registry.npmjs.org/color-convert/-/color-convert-1.9.3.tgz;,
@@ -357,21 +284,6 @@
   

[cordova-contribute] branch janpio-reproduction updated (ba70054 -> b2a2171)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-reproduction
in repository https://gitbox.apache.org/repos/asf/cordova-contribute.git.


from ba70054  initial description
 add b2a2171  link in README

No new revisions were added by this update.

Summary of changes:
 README.md | 1 +
 1 file changed, 1 insertion(+)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new pull request #6: Create a minimal reproduction repository or sample

[GitBox]

janpio opened a new pull request #6: Create a minimal reproduction repository 
or sample
URL: https://github.com/apache/cordova-contribute/pull/6
 
 
   A short description why a reproduction repository is useful and what the 
exact steps are to create one.
   
   Anything missing?
   
   Please feel free to nitpick language and grammar as comments on the 
individual lines or commit to the branch yourself to fix things. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #64: Use const whenever possible

[GitBox]

brodybits opened a new issue #64: Use const whenever possible
URL: https://github.com/apache/cordova-osx/issues/64
 
 
   ref: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu commented on issue #62: Remove Unused Dependencies & update tmp

[GitBox]

erisu commented on issue #62: Remove Unused Dependencies & update tmp
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421398253
 
 
   @brodybits Thank for the review, I will go ahead and squash merge now. 
   
   Also, as I mentioned in https://github.com/apache/cordova-osx/pull/61, 
another PR will be in the pipeline soon for creating code coverage, code 
refactor (`const`, `let`, etc), and test spec organization.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-contribute] branch janpio-reproduction created (now ba70054)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-reproduction
in repository https://gitbox.apache.org/repos/asf/cordova-contribute.git.


  at ba70054  initial description

This branch includes the following new commits:

 new ba70054  initial description

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-contribute] 01/01: initial description

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-reproduction
in repository https://gitbox.apache.org/repos/asf/cordova-contribute.git

commit ba70054168199852a400c6589d906bf88dbb0363
Author: Jan Piotrowski 
AuthorDate: Fri Sep 14 17:38:03 2018 +0200

initial description
---
 create-reproduction.md | 29 +
 1 file changed, 29 insertions(+)

diff --git a/create-reproduction.md b/create-reproduction.md
new file mode 100644
index 000..0e92895
--- /dev/null
+++ b/create-reproduction.md
@@ -0,0 +1,29 @@
+# Create a minimal reproduction repository or sample
+
+When you report an issue or bug for any of the Apache Cordova packages, it is 
very helpful to create and include and link to a reproduction repository or 
sample.
+
+## Why?
+
+After you create your GitHub issue, someone from the Apache Cordova team will 
look at it and then has to decide if your issue is an actual bug or maybe 
"just" some problem in your individual code or how you use one of our 
libraries. 
+
+They will have to evaluate the described problem and confirm that it exists. 
They will only be able to do so if you supplied [enough and the correct 
information in your issue](TODO). This can be very time consuming and 
cumbersome. Even then it can be tough, because it is almost impossible to 
include all your environment information and code in an issue.
+
+If you create a reproduction repository, the maintainer will have _all_ the 
same information you have.
+
+As a side effect, it also forces you to reproduce the bug outside of your 
individual project and with a minimal set of libraries and plugins included. 
Very often this will tell you a lot of additional information about the bug 
itself, that would be hard to come by in your usual project. 
+
+Maybe you even figure out it is not an actual bug at all, but an unrelated 
problem that only manifests in your project because of other reason.
+
+## How?
+
+1. Execute the command `cordova create` to create a new project locally
+1. Create a public Git repository on e.g. GitHub or Bitbucket and initialize a 
repository with that remote in your newly created Cordova project
+1. Commit that clean and empty project to your Git repository
+1. Then add the platforms and/or plugins needed to reproduce the problem
+1. Commit the changes in the project again and include the exact commands you 
executed in the commit message
+1. Then change the code of the sample project so it triggers your problem
+1. Finally commit the reproduction code for your bug to Git and post the 
repository to your issue
+
+The Cordova maintainer then can check out your Git repository, and just run 
the commands you described to actually see and experience the bug.
+
+The repository later can also be a "test" to confirm the problem is actually 
resolved in an updated version of whatever library is faulty.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits commented on issue #62: Remove Unused Dependencies and Old Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421395350
 
 
   @erisu can you rebase it again? I just removed `tests/.jshintrc` in PR #63.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits edited a comment on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits edited a comment on issue #62: Remove Unused Dependencies and Old 
Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421392440
 
 
   Thanks @erisu for raising this one (PR #62) and #61 which seem to integrate 
some of the work I did in WIP PR #49. I am very happy that you took the 
initiative, considering that I don't have much time to work on it right now.
   
   As a general rule please feel free to do this for any WIP PRs that you see 
lying around. In case of any questions I would favor discussing within the WIP 
PR itself for best tracking. I think private chats are the worst for tracking 
of work, discussions, agreements, etc.
   
   I will approve this PR now _(I ~~will~~ **did** remove `tests/.jshintrc` in 
a separate PR)_, would probably favor a squash merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch brodybits-remove-old-jshintrc deleted (was 01dedc2)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch brodybits-remove-old-jshintrc
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git.


 was 01dedc2  Remove .jshintrc from tests

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch master updated (e0d532c -> f23057e)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git.


from e0d532c  Merge pull request #61 from erisu/eslint-improvement
 add f23057e  Remove .jshintrc from tests (#63)

No new revisions were added by this update.

Summary of changes:
 tests/.jshintrc | 11 ---
 1 file changed, 11 deletions(-)
 delete mode 100644 tests/.jshintrc


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #63: Remove .jshintrc from tests

[GitBox]

brodybits closed pull request #63: Remove .jshintrc from tests
URL: https://github.com/apache/cordova-osx/pull/63
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #63: Remove .jshintrc from tests

[GitBox]

brodybits opened a new pull request #63: Remove .jshintrc from tests
URL: https://github.com/apache/cordova-osx/pull/63
 
 
   As discussed in GH-49 and agreed with @erisu in GH-62


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits edited a comment on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits edited a comment on issue #62: Remove Unused Dependencies and Old 
Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421392440
 
 
   Thanks @erisu for raising this one (PR #62) and #61 which seem to integrate 
some of the work I did in WIP PR #49. I am very happy that you took the 
initiative, considering that I don't have much time to work on it right now.
   
   As a general rule please feel free to do this for any WIP PRs that you see 
lying around. In case of any questions I would favor discussing within the WIP 
PR itself for best tracking. I think private chats are the worst for tracking 
of work, discussions, agreements, etc.
   
   I will approve this PR now _(I will remove `tests/.jshintrc` in a separate 
PR)_, would probably favor a squash merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch brodybits-remove-old-jshintrc created (now 01dedc2)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch brodybits-remove-old-jshintrc
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git.


  at 01dedc2  Remove .jshintrc from tests

This branch includes the following new commits:

 new 01dedc2  Remove .jshintrc from tests

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] 01/01: Remove .jshintrc from tests

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-remove-old-jshintrc
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git

commit 01dedc2e219506f8786e8c5f243d1b48cb66582e
Author: Chris Brody 
AuthorDate: Fri Sep 14 11:23:09 2018 -0400

Remove .jshintrc from tests
---
 tests/.jshintrc | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/tests/.jshintrc b/tests/.jshintrc
deleted file mode 100644
index 17eae32..000
--- a/tests/.jshintrc
+++ /dev/null
@@ -1,11 +0,0 @@
-{
-"node": true
-  , "bitwise": true
-  , "undef": true
-  , "trailing": true
-  , "quotmark": true
-  , "indent": 4
-  , "unused": "vars"
-  , "latedef": "nofunc"
-  , "jasmine": true
-}


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits edited a comment on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits edited a comment on issue #62: Remove Unused Dependencies and Old 
Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421392440
 
 
   Thanks @erisu for raising this one (PR #62) and #61 which seem to integrate 
some of the work I did in WIP PR #49. I am very happy that you took the 
initiative, considering that I don't have much time to work on it right now.
   
   As a general rule please feel free to do this for any WIP PRs that you see 
lying around. In case of any questions I would favor discussing within the WIP 
PR itself for best tracking. I think private chats are the worst for tracking 
of work, discussions, agreements, etc.
   
   ~~I will approve this PR now, would probably favor a squash merge.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits commented on issue #62: Remove Unused Dependencies and Old Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421392440
 
 
   Thanks @erisu for raising this one (PR #62) and #61 which seem to integrate 
some of the work I did in WIP PR #49. I am very happy that you took the 
initiative, considering that I don't have much time to work on it right now.
   
   As a general rule please feel free to do this for any WIP PRs that you see 
lying around. In case of any questions I would favor discussing within the WIP 
PR itself for best tracking. I think private chats are the worst for tracking 
of work, discussions, agreements, etc.
   
   I will approve this PR now, would probably favor a squash merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu edited a comment on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

erisu edited a comment on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421391888
 
 
   @brodybits I am preparing a third PR and hopefully will submit tomorrow 
(JST). That will contain adding code coverage dependency, a minor folder 
structure change around test specs for better organization, and also a minor 
refactor of the test code. Refactor will cover `const`, `let`, and arrow 
functions if possible. etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu edited a comment on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

erisu edited a comment on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421391888
 
 
   @brodybits I am preparing a third PR and hopefully will submit tomorrow. 
That will contain adding code coverage dependency, a minor folder structure 
change around test specs for better organization, and also a minor refactor of 
the test code. Refactor will cover `const`, `let`, and arrow functions if 
possible. etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu commented on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

erisu commented on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421391888
 
 
   @brodybits I am preparing a third PR and hopefully will submit tomorrow. 
That will contain code coverage, a bit of a folder structure around test specs, 
and also a minor refactor of the test code. Refactor will cover `const`, `let`, 
and arrow functions if possible. etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

janpio commented on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421391594
 
 
   Create an issue in apache/cordova so this can be tracked and doesn't get 
lost in the comments of a already merged PR @brodybits 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

brodybits commented on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421390470
 
 
   P.S. A major cleanup TODO item is to use `const` whenever possible, kinda 
wish we did this to the `var` declarations that we touched in this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu commented on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

erisu commented on issue #62: Remove Unused Dependencies and Old Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421388462
 
 
   @brodybits Rebasing now and fixing the conflict.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #62: Remove Unused Dependencies and Old Files

[GitBox]

brodybits commented on issue #62: Remove Unused Dependencies and Old Files
URL: https://github.com/apache/cordova-osx/pull/62#issuecomment-421388271
 
 
   Adding reference to WIP PR #49 where these changes seem to come from


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #114: Not working on Android devices

[GitBox]

janpio edited a comment on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421387948
 
 
   Has anyone created a pure Cordova reproduction of the error yet as a Github 
repository? If not, please one of you having the issue do so (start with 
`cordova create`, commit to a Github repository) and document all the commands 
you execute and changes you do and commit each step individually so it is easy 
to follow. Then post the URL here, then it is easier for someone to reproduce.
   
   What exact versions of Android are affected?
   What exact devices are affected?
   Is the issue reproducible in an emulator?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #114: Not working on Android devices

[GitBox]

janpio commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421387948
 
 
   Has anyone created a pure Cordova reproduction of the error yet as a Github 
repository? If not, please one of you having the issue do so (start with 
`cordova create`, commit to a Github repository) and document all the commands 
you execute and changes you do. Then post the URL here, then it is easier for 
someone to reproduce.
   
   What exact versions of Android are affected?
   What exact devices are affected?
   Is the issue reproducible in an emulator?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] vwasteels commented on issue #114: Not working on Android devices

[GitBox]

vwasteels commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-421386940
 
 
   +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

janpio commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421386927
 
 
   @mlegenhausen If you have a working solution (even if it's just for you) 
please do create a PR for others to look at and use please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

brodybits commented on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421386697
 
 
   Merged in a merge commit since I think these changes should be kept separate 
in the git history.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] 01/01: Merge pull request #61 from erisu/eslint-improvement

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git

commit e0d532cf668deda37b81c93cf9f133d4545389f6
Merge: 35fc603 7f56457
Author: Chris Brody 
AuthorDate: Fri Sep 14 11:00:04 2018 -0400

Merge pull request #61 from erisu/eslint-improvement

ESLint Dependencies Update, Configure and Corrections

 .eslintignore |  3 ++-
 .eslintrc.yml |  3 ++-
 package.json  | 12 ++--
 tests/spec/.eslintrc.yml  |  2 +-
 tests/spec/cordovalib.spec.js | 19 +++
 tests/spec/create.spec.js | 27 +++
 tests/spec/platform.spec.js   | 36 ++--
 7 files changed, 55 insertions(+), 47 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch master updated (35fc603 -> e0d532c)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git.


from 35fc603  Added Travis CI OSX Image and Install cordova@latest (#59)
 add e82f725  package*.json use eslint@4 (4.19.1)
 add e6bcc0c  .eslintrc.yml add vertical spacing
 add 71fcf26  enable eslint in tests/spec
 add 1e35b89  resolve eslint issues in tests/spec
 add 57c4b19  Updated eslint ignore and npm run command
 add 7f56457  Updated eslint config and plugin dependencies
 new e0d532c  Merge pull request #61 from erisu/eslint-improvement

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .eslintignore |  3 ++-
 .eslintrc.yml |  3 ++-
 package.json  | 12 ++--
 tests/spec/.eslintrc.yml  |  2 +-
 tests/spec/cordovalib.spec.js | 19 +++
 tests/spec/create.spec.js | 27 +++
 tests/spec/platform.spec.js   | 36 ++--
 7 files changed, 55 insertions(+), 47 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #61: ESLint Dependencies Update, Configure and Corrections

[GitBox]

brodybits commented on issue #61: ESLint Dependencies Update, Configure and 
Corrections
URL: https://github.com/apache/cordova-osx/pull/61#issuecomment-421385390
 
 
   Looks good, adding reference to WIP PR #49 where I think most of these 
changes are coming from.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu opened a new pull request #62: Dependency and cleanup

[GitBox]

erisu opened a new pull request #62: Dependency and cleanup
URL: https://github.com/apache/cordova-osx/pull/62
 
 
   ### Platforms affected
   none
   
   ### What does this PR do?
   - Remove unused dependencies and old files
   
   ### What testing has been done on this change?
   - `npm test`
   - `cordova run osx`
   - `cordova build osx`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-cli] branch 8.1.x created (now 6508d45)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch 8.1.x
in repository https://gitbox.apache.org/repos/asf/cordova-cli.git.


  at 6508d45  CB-13674 Incremented package version to -dev

No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] erisu opened a new pull request #61: Eslint improvement

[GitBox]

erisu opened a new pull request #61: Eslint improvement
URL: https://github.com/apache/cordova-osx/pull/61
 
 
   ### Platforms affected
   none
   
   ### What does this PR do?
   - Upgrades eslint related dependencies
   - Updates eslint configurations
   - Fixes files that did not follow eslint configured standards
   
   ### What testing has been done on this change?
   - `npm run eslint`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

sgoldberg-sfdc commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421380720
 
 
   @mlegenhausen unfortunately that won't work with Carthage since you cannot 
provide parameters to the build command. If the workspace settings no longer 
work with the GM, we need to fix the root build issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch master updated: Update cordova-windows pattern to ~6.0.0 (#691)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git


The following commit(s) were added to refs/heads/master by this push:
 new c0fcda7  Update cordova-windows pattern to ~6.0.0 (#691)
c0fcda7 is described below

commit c0fcda7251a5416741583a31c4201a774eb069ce
Author: Chris Brody 
AuthorDate: Fri Sep 14 10:16:39 2018 -0400

Update cordova-windows pattern to ~6.0.0 (#691)
---
 src/platforms/platformsConfig.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/platforms/platformsConfig.json 
b/src/platforms/platformsConfig.json
index 70cd065..9cf1da0 100644
--- a/src/platforms/platformsConfig.json
+++ b/src/platforms/platformsConfig.json
@@ -22,7 +22,7 @@
 "windows": {
 "hostos": ["win32"],
 "url": "https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;,
-"version": "~5.0.0",
+"version": "~6.0.0",
 "apiCompatibleSince": "4.3.0",
 "deprecated": false
 },


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project 
settings to explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
 
 
   The Xcode 10 GM is avaibable.
   
   The provided pull request does not work with the GM release, but I found 
another solution. You can disable the modern buildsystem with `xcodebuild 
-UseModernBuildSystem=NO ...`.
   
   After you added the switch get another error that "your project path" is not 
a valid command. It seems that in the case of `archive` it is not possible 
anymore to supply the project folder as last parameter. So I needed to make 
`-workspace` and `-archivePath` an absolute path. The `options` for the 
`isDevice` case need to be changed to
   
   ```js
   options = [
   '-UseModernBuildSystem=NO',
   '-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' 
+ configuration.toLowerCase() + '.xcconfig'),
   '-workspace', customArgs.workspace || path.join(projectPath, projectName 
+ '.xcworkspace'),
   '-scheme', customArgs.scheme || projectName,
   '-configuration', customArgs.configuration || configuration,
   '-destination', customArgs.destination || 'generic/platform=iOS',
   '-archivePath', customArgs.archivePath || path.join(projectPath, 
projectName + '.xcarchive')
   ];
   ```
   
   Finally I removed the `projectPath` parameter from `spawn('xcodebuild', 
xcodebuildArgs)`.The build should now work as expected.
   
   Are you planing to which with `cordova-ios` to the new build systems? If not 
I can provide my fix as pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch start-8.1.x-proposal deleted (was 3be60ef)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch start-8.1.x-proposal
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


 was 3be60ef  fetch.spec: 30% shorter runtime by factoring out project 
setup (#640)

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-lib] branch 8.1.x updated (81f0a82 -> e75d18c)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch 8.1.x
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


from 81f0a82  CB-13674 Updated version and RELEASENOTES.md for release 8.0.0
 add 33ef33a  CB-13674 Incremented package version to -dev
 add fc69a0b  Added browser default engine
 add 8d4f216  Update (and remove) several dependencies
 add 9522a9c  Fix ElementTree error about unclosed XML tag
 add fd1a8a8  Fix failing test from inconsistent error format
 add 9fcf84b  Merge pull request #611 from dpogue/dependency-cleanup
 add 61395d2  CB-14065: Drop support for Node 4 and add Node 10 to CI
 add 10a4825  Merge pull request #612 from raphinesse/drop-node4
 add 52f9ac0  CB-13532: Find plugins in devDependencies
 add 9144115  improve tests using ios@4.5.4, adjusting timeout params and 
improve plugin remove sequentially
 add b42ccc6  to pass the appveyor tests, adjusting timeouts, cleaning 
event listeners and update cordova-browser to 5.0.3
 add da4b4b3  Let Jasmine handle async test results (#619)
 add 4accff4  Work around AppVeyor/Node10 issue
 add 2d26cc4  CB-14140 Add fs-extra to allow for incremental adoption
 add ac535e5  Clean up messy HooksRunner tests (#623)
 add ad534eb  Set the fetch option to true in plugman (#617)
 add 4fb0c80  restore.spec: Wait for prepare promise to resolve (#626)
 add fcce942  Fix test that was outside of an `it` call
 add 979c3d0  Simplify rewire usage in platform.remove spec
 add 60ba439  Mock out various functions that call cordova-fetch in tests
 add c8a1aa9  CB-13055 Fold all fetch options to `true`
 add b8e2c4d  Merge pull request #624 from raphinesse/fetch-nomore
 add 17f5b7f  CB-14033 Support symbolic dir links on Windows (#621)
 add c8cb3c5  Fix promise handling when removing multiple plugins (#628)
 add 6019d92  Improve plugman/uninstall.js messages (#630)
 add 3b456cd  CB-14243: change dash to underscore for save-exact key 
reference
 add 987ce2b  Merge pull request #631 from amaldonado/CB-14243
 add 270310e  Use more verbose test reporter
 add 2b4e25f  More compact jasmine helper definition
 add d382c49  Add helper to set default timeout properly
 add 944fcd7  Randomize test tmpDir to avoid caching issues
 add 72f9549  Remove obsolete ESLint comments
 add 3d6814a  DRY platform.check unit tests
 add 02d3fcc  Merge pull request #633 from 
raphinesse/minor-spec-improvements
 add faf2670  Cleanup pkgJson-restore.spec
 add ca0eb9d  pkgJson-restore.spec: Merge more describe blocks
 add 6862faa  pkgJson-restore.spec: Better names for various tests
 add ad0b0d7  Merge pull request #634 from raphinesse/cleanup-spec-restore
 add 6ccda67  Make coverage script consider e2e tests too (#637)
 add 429438e  Pin Jasmine to 3.1 to work around Promise issues (#639)
 add 08a2d44  Honest specs in pkgJson-restore.spec (#638)
 add 40e17e5  Create test projects instead of asserting them
 add ab1121a  Delete obsolete fixtures
 add 7474c89  Merge pull request #641 from raphinesse/create-not-assert
 add c396026  Avoid requireNoCache in pkgJson-restore.spec (#645)
 add bd92683  CB-14148 remove nonsense "www" platform from Cordova listing 
(#620)
 add 3dba62e  Update android platform to latest release (#646)
 add 9443f92  Cleanup pkgJson.spec (#635)
 add f8b9f6a  Avoid requireNoCache in pkgJson.spec (#647)
 add 25ce908  Fix setDefaultTimeout for beforeAll and afterAll (#648)
 add 774c4d2  Organize imports in HooksRunner.spec (#654)
 add 1d7f1ae  Fix sporadic timeout of HooksRunner test 012 (#656)
 add 9deecf7  Add test for obscure HooksRunner bug (#653)
 add 068bd28  Fix reading garbage shebang in HooksRunner.spec
 add 98c829f  Use shebang-command module to extract shebang
 add 47a3edc  Fix false alarm for long first line in HooksRunner.spec
 add 3be60ef  fetch.spec: 30% shorter runtime by factoring out project 
setup (#640)
 add 8663fd9  Start 8.1.0-dev (minor release)
 add b04669c  Partially Revert "CB-14065: Drop support for Node 4 ..."
 add 6360217  Downgrade to fs-extra@4 & move to devDependencies
 add 248059d  HooksRunner test fixes for deprecated Node.js 4 (8.1.x)
 add c55fc88  spec/helpers.js workaround for deprecated Node.js 4
 add 30fb983  spec/cordova/plugin/remove.spec.js workaround for Node.js 4
 add faeca64  pkgJson-restore.spec.js workarounds for Node.js 4
 add ae5a977  pkgJson.spec.js workarounds for Node.js 4
 add c50ec20  EXTRA pkgJson-restore.spec.js workaround for Node.js 4
 add 7b4d629  src/hooks/HooksRunner.js workarounds for Node.js 4
 add 03d644e  src/plugman/uninstall.js workaround for Node.js 4
 add e75d18c  Update cordova-windows pattern to ~6.0.0 (GH-691)

No new revisions were added by this update.

Summary of 

[cordova-lib] branch 8.1.x created (now 81f0a82)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch 8.1.x
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.


  at 81f0a82  CB-13674 Updated version and RELEASENOTES.md for release 8.0.0

No new revisions were added by this update.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

mlegenhausen edited a comment on issue #378: CB-14192: (ios) Add project 
settings to explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
 
 
   The Xcode 10 GM is avaibable.
   
   The provided pull request does not work with the GM release, but I found 
another solution. You can disable the modern buildsystem with `xcodebuild 
-UseModernBuildSystem=NO ...`.
   
   After you added the switch get another error that "your project path" is not 
a valid command. It seems that in the case of `archive` it is not possible 
anymore to supply the project folder as last parameter. So I needed to make 
`-workspace` and `-archivePath` an absolute path. The `options` for the 
`isDevice` case need to be changed to
   
   ```js
   options = [
   '-UseModernBuildSystem=NO',
   '-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' 
+ configuration.toLowerCase() + '.xcconfig'),
   '-workspace', customArgs.workspace || path.join(projectPath, projectName 
+ '.xcworkspace'),
   '-scheme', customArgs.scheme || projectName,
   '-configuration', customArgs.configuration || configuration,
   '-destination', customArgs.destination || 'generic/platform=iOS',
   '-archivePath', customArgs.archivePath || path.join(projectPath, 
projectName + '.xcarchive')
   ];
   ```
   
   Finally you need to remove the `projectPath` parameter from 
`spawn('xcodebuild', xcodebuildArgs)`.
   
   Are you planing to which with `cordova-ios` to the new build systems? If not 
I can provide my fix as pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mlegenhausen commented on issue #378: CB-14192: (ios) Add project settings to explicitly use legacy build s…

[GitBox]

mlegenhausen commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-421369394
 
 
   The Xcode 10 GM is avaibable.
   
   The provided pull request does not work with the GM release, but I found 
another solution. You can disable the modern buildsystem with `xcodebuild 
-UseModernBuildSystem=NO ...`.
   
   After you added the switch get another error that "your project path" is not 
a valid command. It seems that in the case of `archive` it is not possible 
anymore to supply the project folder as last parameter. So I needed to make 
`-workspace` and `-archivePath` an absolute path. The `options` for the 
`isDevice` case need to be changed to
   
   ```js
   options = [
   '-UseModernBuildSystem=NO',
   '-xcconfig', customArgs.xcconfig || path.join(__dirname, '..', 'build-' 
+ configuration.toLowerCase() + '.xcconfig'),
   '-workspace', customArgs.workspace || path.join(projectPath, projectName 
+ '.xcworkspace'),
   '-scheme', customArgs.scheme || projectName,
   '-configuration', customArgs.configuration || configuration,
   '-destination', customArgs.destination || 'generic/platform=iOS',
   '-archivePath', customArgs.archivePath || path.join(projectPath, 
projectName + '.xcarchive')
   ];
   ```
   
   Are you planing to which with `cordova-ios` to the new build systems? If not 
I can provide my fix as pull request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #149: CB-8497 Fix handling of file paths with # character

[GitBox]

brodybits commented on issue #149: CB-8497 Fix handling of file paths with # 
character
URL: 
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421369231
 
 
   > What about the file containing % character? it is giving me an Encoding 
error on iOS
   
   I suggest you file a new issue with this information, along with a simple 
but complete reproduction program. Bonus if you add a test case to tests, 
bigger bonus if you submit a bug fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jasvindersingh-evon edited a comment on issue #149: CB-8497 Fix handling of file paths with # character

[GitBox]

jasvindersingh-evon edited a comment on issue #149: CB-8497 Fix handling of 
file paths with # character
URL: 
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421357935
 
 
   What about the file containing % character? it is giving me an Encoding 
error on iOS


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jasvindersingh-evon commented on issue #149: CB-8497 Fix handling of file paths with # character

[GitBox]

jasvindersingh-evon commented on issue #149: CB-8497 Fix handling of file paths 
with # character
URL: 
https://github.com/apache/cordova-plugin-file/pull/149#issuecomment-421357935
 
 
   What about the file containing % character? it is giving me an Encoding 
error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

[GitBox]

janpio commented on issue #494: Change from CordovaWebView to SystemWebView in 
latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494#issuecomment-421336599
 
 
   The webview documentation seems to be outdated in general. If you figure it 
out, please make sure to create a PR fixing the documentation to match the 
actual reality. Thank you!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sandeep2244 commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

[GitBox]

sandeep2244 commented on issue #494: Change from CordovaWebView to 
SystemWebView in latest Cordova not working
URL: https://github.com/apache/cordova-android/issues/494#issuecomment-421335389
 
 
   @brodybits @janpio  
   I updated to 7.1.1  And its not working 
   
   Because of CordovaWebView is now Interface not a Class,  we cant use it so,
   ```
   
   ```
   Now changing to **SystemWebView Class** 
   
   I replaced it with 
   ```
   
   ```
   
Now Problem is ,
there is function of **SystemWebView.java (class)**
**setWebChromeClient()**
   
   
   ```
   public void setWebChromeClient(WebChromeClient client) {
   chromeClient = (SystemWebChromeClient)client;
   super.setWebChromeClient(client);
   }
   
   ```
   
   
   And I override  setWebChromeClient() in my main class(WebCall.java)
   
   **which  i  defined above in my question** 
   
   And 
   
   I got Error Regarding Class Cast Exception 
   Which i defined in my question 
   
   In Previous Version They using CordovaWebView And I checked They Dont Cast 
It 
   
   below is the function for previous  version
   
   ```
public void setWebChromeClient(CordovaChromeClient client) {
   this.chromeClient = client;
   super.setWebChromeClient(client);
   }
   ```
   
   So How to Solve it
   
   Thank You
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #174: iOS: Crash in [CDVSound startPlayingAudio:] with version 3.0.1 and 5.0.2

[GitBox]

janpio commented on issue #174: iOS: Crash in [CDVSound startPlayingAudio:] 
with version 3.0.1 and 5.0.2
URL: 
https://github.com/apache/cordova-plugin-media/issues/174#issuecomment-421334146
 
 
   Apache Cordova is an Open Source project with a very limited set of active 
volunteer maintainers. Currently the focus is on a) finishing migration of 
issues from JIRA to GitHub and adapting all the processes and rules that go 
with it (e.g. by labeling new issues etc) and b) working on releasing and 
finishing new versions of everything _but_ the plugins (CLI, platforms, other 
libraries and tooling). Several people are focusing on cleaning up the code 
base, to enable us to create more stable releases in the future quicker.
   
   If you have a good understanding of your issue for this plugin and might be 
able to create a PR, please go ahead and do so! I personally won't be able to 
review it as I don't do Obj-C, but at least something is there and the day will 
come when we will be able to look at the plugin PRs and issues with some more 
effort as well. We of course can't just merge stuff without people reviewing 
the PRs and making sure they actually improve the situation. Unfortunately 
quite often one issue is fixed, while 5 others are created ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sjkummer commented on issue #174: iOS: Crash in [CDVSound startPlayingAudio:] with version 3.0.1 and 5.0.2

[GitBox]

sjkummer commented on issue #174: iOS: Crash in [CDVSound startPlayingAudio:] 
with version 3.0.1 and 5.0.2
URL: 
https://github.com/apache/cordova-plugin-media/issues/174#issuecomment-421332205
 
 
   @janpio : Is there a change that this bug is going to be fixed? As far as I 
can see, there is no more active development, nor are PullRequests merged... 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] sjkummer edited a comment on issue #174: iOS: Crash in [CDVSound startPlayingAudio:] with version 3.0.1 and 5.0.2

[GitBox]

sjkummer edited a comment on issue #174: iOS: Crash in [CDVSound 
startPlayingAudio:] with version 3.0.1 and 5.0.2
URL: 
https://github.com/apache/cordova-plugin-media/issues/174#issuecomment-420026911
 
 
   Hi, 
   
   Unfortunately, I still got some crash reports after upgrading to version 
5.0.2
   
   I may have to add, that I am playing two files at the same time.
   
   To me, this looks like a multi threading problem. As far as I can see this 
cordova plugin is **not thread safe**, is this correct?
   
   Investigation: 
   1.  In my crash dump / stacktrace, I got multiple threads that are currently 
in `[CDVSound prepareToPlay]`
   2. [CDVSound prepareToPlay] starts with a `[self.commandDelegate 
runInBackground:^{`
   3. `runInBackground` is just a 
`dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), 
block);`
   4. The `dispatch_get_global_queue` is a **concurrent** queue, so it does not 
help for thread safety / thread sync of the executed tasks, see: 
https://developer.apple.com/documentation/dispatch/1452927-dispatch_get_global_queue
   
   Please let me know, if I am missing something 
   
   Full Log:
   
[full_crash_log_5.0.1.txt](https://github.com/apache/cordova-plugin-media/files/2368056/full_crash_log_5.0.1.txt)
   
   ```
   Exception Type:  EXC_BAD_ACCESS (SIGSEGV)
   Exception Subtype: KERN_INVALID_ADDRESS at 0x41534e57171614cb
   VM Region Info: 0x41534e57171614cb is not in any region.  Bytes after 
previous region: 4707192163435680972  
 REGION TYPE  START - END [ VSIZE] 
PRT/MAX SHRMOD  REGION DETAIL
 MALLOC_NANO (reserved) 0001d800-0001e000 [128.0M] 
rw-/rwx SM=NUL  ...(unallocated)
   --->  
 UNUSED SPACE AT END
   
   Termination Signal: Segmentation fault: 11
   Termination Reason: Namespace SIGNAL, Code 0xb
   Terminating Process: exc handler [0]
   Triggered by Thread:  14
   
   Thread 14 name:
   Thread 14 Crashed:
   0   AVFAudio 0x00018a9a880c 
AVAudioPlayerCpp::AQOutputCallbackCore(OpaqueAudioQueue*, AudioQueueBuffer*) + 
180 (AVAudioPlayerCpp.mm:1250)
   1   AVFAudio 0x00018a9a7e84 
AVAudioPlayerCpp::prepareToPlayQueue() + 224 (AVAudioPlayerCpp.mm:883)
   2   AVFAudio 0x00018a9a7e84 
AVAudioPlayerCpp::prepareToPlayQueue() + 224 (AVAudioPlayerCpp.mm:883)
   3   AVFAudio 0x00018a9a7fe0 
AVAudioPlayerCpp::playQueue(AudioTimeStamp const*) + 112 
(AVAudioPlayerCpp.mm:956)
   4   AVFAudio 0x00018a9a6760 
AVAudioPlayerCpp::play() + 80 (AVAudioPlayerCpp.mm:667)
   5   AVFAudio 0x00018a968414 -[AVAudioPlayer 
play] + 52 (AVAudioPlayer.mm:455)
   6   MYAPP0x000102b53484 __30-[CDVSound 
startPlayingAudio:]_block_invoke + 1648 (CDVSound.m:418)
   7   libdispatch.dylib0x000184904aa0 
_dispatch_call_block_and_release + 24 (init.c:994)
   8   libdispatch.dylib0x000184904a60 
_dispatch_client_callout + 16 (object.m:507)
   9   libdispatch.dylib0x000184940548 
_dispatch_queue_override_invoke$VARIANT$armv81 + 700 (inline_internal.h:2500)
   10  libdispatch.dylib0x0001849463c4 
_dispatch_root_queue_drain + 592 (inline_internal.h:2539)
   11  libdispatch.dylib0x000184946110 
_dispatch_worker_thread3 + 112 (queue.c:6092)
   12  libsystem_pthread.dylib  0x000184c37fac _pthread_wqthread + 
1176 (pthread.c:2297)
   13  libsystem_pthread.dylib  0x000184c37b08 start_wqthread + 4
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org