[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

2018-02-13 Thread GitBox
janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365446432
 
 
   Fixed by making sure the `index.html` is present (by copying from a folder 
where it exists).
   
   This is now as good as `master` but works with any Windows 10 SDK installed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org



[GitHub] janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be called in e2e tests

2018-02-13 Thread GitBox
janpio commented on issue #254: [WIP] CB-13875 add `prepare` script that can be 
called in e2e tests
URL: https://github.com/apache/cordova-windows/pull/254#issuecomment-365390984
 
 
   The missing `index.html` in the test project is causing issues now:
   
   ```
   EXEC : warning : Start page is missing on the disk. The build must go on but 
note that this will cause WACK failures. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Manifest validation error: Line 26, Column 47, Reason: 
The file name "www\index.html" declared for element 
"m:Applications/m:Application" doesn't exist in the package. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : Package creation failed. 
[C:\projects\cordova-windows\testcreate ??\CordovaApp.Phone.jsproj]
   MakeAppx : error : 0x80080204 - The specified package format is not valid: 
The package manifest is not valid. 
   ```
   
   Locally I only get the first line, but on CI the MSBuildTools version seems 
to do some additional validation.
   
   Working on a fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org