[GitHub] jcesarmobile commented on issue #278: CB-14234: (ios) Don't call handleOpenURL for system URLs
jcesarmobile commented on issue #278: CB-14234: (ios) Don't call handleOpenURL for system URLs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/278#issuecomment-415191243 Yeah, sometimes comments are good, but for so small change and being the issue and the PR linked to the commit, it's really easy to see why this was done, so no need of extra comments. Thanks for the PR! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
[GitHub] jcesarmobile commented on issue #278: CB-14234: (ios) Don't call handleOpenURL for system URLs
jcesarmobile commented on issue #278: CB-14234: (ios) Don't call handleOpenURL for system URLs URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/278#issuecomment-414835280 Looks good to me, but remove the comment, if somebody want to know why it's changed they can check the git log/blame and the commit already have the issue id, so it's easy to spot This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
