[GitHub] danbeo95 opened a new issue #187: Access to contact lists on phone it was very slow after call save Method !

[GitBox]

danbeo95 opened a new issue #187:  Access to contact lists on phone it was very 
slow after call save Method !
URL: https://github.com/apache/cordova-plugin-contacts/issues/187
 
 
Please support me ! When i call save() method to modify contact.It was 
sccucess.But i notify ,after that access to contact lists on phone it was very 
slow .How can i fix it ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

ippeiukai commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477
 
 
   I've just submitted a fix to another plugin. This one is a bit different 
because this behaviour of `source-file` is not documented, but it was working 
with `cordova-android@6` but not any more.
   
   https://github.com/vaenow/cordova-plugin-app-update/pull/119
   (Specifying a directory with many `.java` files as source-file src no longer 
working.)
   
   FYI: though not documented officially, it is a known behaviour:
   https://stackoverflow.com/q/28042385


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

ippeiukai edited a comment on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477
 
 
   I've just submitted a fix to another plugin. This one is a bit different 
because this behaviour of `source-file` is not documented, but it was working 
with `cordova-android@6` but not with `cordova-android@7`.
   
   https://github.com/vaenow/cordova-plugin-app-update/pull/119
   (Specifying a directory with many `.java` files as source-file src no longer 
working.)
   
   FYI: though not documented officially, it is a known behaviour:
   https://stackoverflow.com/q/28042385


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jeffreyvdhondel edited a comment on issue #373: Cannot take pictures on Android 8

[GitBox]

jeffreyvdhondel edited a comment on issue #373: Cannot take pictures on Android 
8
URL: 
https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439313196
 
 
   We had a problem kinda like this.
   So maybe this doesn't work for you.
   
   To fix this issue we had to edit the android manimanifest.xml.
   
   Located here:
   project/android/src/main/AndroidManifest.xml
   
   
   Add the xmlns:tools: 
   `http://schemas.android.com/apk/res/android; 
xmlns:tools="http://schemas.android.com/tools;>`
   
   Add the tools:node="remove" to the write external storage:
   ``
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio closed issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify , after that access to contact lists on phone it was very slow .How can

[GitBox]

janpio closed issue #186: Please support me ! When i call save() method to 
modify contact.It was sccucess.But i notify ,after that access to contact lists 
on phone it was very slow .How can i fix it ?
URL: https://github.com/apache/cordova-plugin-contacts/issues/186
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #186: Please support me ! When i call save() method to modify contact.It was sccucess.But i notify , after that access to contact lists on phone it was very slow .Ho

[GitBox]

janpio commented on issue #186: Please support me ! When i call save() method 
to modify contact.It was sccucess.But i notify ,after that access to contact 
lists on phone it was very slow .How can i fix it ?
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/186#issuecomment-439316261
 
 
   Please create an issue with a title _and_ description for your problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jeffreyvdhondel commented on issue #373: Cannot take pictures on Android 8

[GitBox]

jeffreyvdhondel commented on issue #373: Cannot take pictures on Android 8
URL: 
https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439313196
 
 
   To fix this issue we had to edit the android manimanifest.xml.
   
   Located here:
   project/android/src/main/AndroidManifest.xml
   
   
   Add the xmlns:tools: 
   `http://schemas.android.com/apk/res/android; 
xmlns:tools="http://schemas.android.com/tools;>`
   
   Add the tools:node="remove" to the write external storage:
   ``
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

ippeiukai edited a comment on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477
 
 
   I've just submitted a fix to another plugin. This one is a bit different 
because this behaviour of `source-file` is not documented, but it was working 
with `cordova-android@6` but not with `cordova-android@7`.
   
   https://github.com/vaenow/cordova-plugin-app-update/pull/119
   (Specifying a directory with many `.java` files as source-file src no longer 
works.)
   
   FYI: though not documented officially, it is a known behaviour:
   https://stackoverflow.com/q/28042385


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #909: update example on buildConfig

[GitBox]

janpio commented on issue #909: update example on buildConfig
URL: https://github.com/apache/cordova-docs/pull/909#issuecomment-439367136
 
 
   Why is it relevant to know here that `~` is the home directory on some 
systems? What does this have to do with buildConfig?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #563: [Fix] better support to find Home path for window

[GitBox]

janpio commented on a change in pull request #563: [Fix] better support to find 
Home path for window
URL: https://github.com/apache/cordova-android/pull/563#discussion_r234176797
 
 

 ##
 File path: bin/templates/cordova/lib/build.js
 ##
 @@ -82,7 +82,9 @@ function parseOpts (options, resolvedTarget, projectRoot) {
 if (config.android && config.android[ret.buildType]) {
 var androidInfo = config.android[ret.buildType];
 if (androidInfo.keystore && !packageArgs.keystore) {
-if (androidInfo.keystore.substr(0, 1) === '~') {
+if (androidInfo.keystore.substr(0, 1) === '~' 
+|| androidInfo.keystore.substr(0, 5) === '$HOME' 
+|| androidInfo.keystore.substr(0, 10) === '%HOMEPATH%') {
 androidInfo.keystore = process.env.HOME + 
androidInfo.keystore.substr(1);
 
 Review comment:
   This line is now broken as `androidInfo.keystore.substr(1)` removes the 
first character from the keystore string - which only works for `~`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] danbeo95 commented on issue #187: Access to contact lists on phone it was very slow after call save Method !

[GitBox]

danbeo95 commented on issue #187:  Access to contact lists on phone it was very 
slow after call save Method !
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/187#issuecomment-439339184
 
 
   @janpio can you support me ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

ippeiukai edited a comment on issue #547: Compatibility of old plugins with 
non-Java source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439331477
 
 
   I've just submitted a fix to another plugin. This one is a bit different 
because this behaviour of `source-file` is not documented, but it was working 
with `cordova-android@6` but no longer with `cordova-android@7`.
   
   https://github.com/vaenow/cordova-plugin-app-update/pull/119
   (Specifying a directory with many `.java` files as source-file src no longer 
works.)
   
   FYI: though not documented officially, it is a known behaviour:
   https://stackoverflow.com/q/28042385


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #187: Access to contact lists on phone it was very slow after call save Method !

[GitBox]

janpio commented on issue #187:  Access to contact lists on phone it was very 
slow after call save Method !
URL: 
https://github.com/apache/cordova-plugin-contacts/issues/187#issuecomment-439343999
 
 
   No. (Don't mention people to pull them into your issue. If someone wants to 
respond, they will.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] hiepxanh opened a new pull request #563: [Fix] better support to find Home path for window

[GitBox]

hiepxanh opened a new pull request #563: [Fix] better support to find Home path 
for window
URL: https://github.com/apache/cordova-android/pull/563
 
 
   ### Platforms affected
   Android, ios, Browser
   
   ### What does this PR do?
   I struggeling with home path every time changing build computer or transfer 
code to my teammate computer. the `build.json` config does not find home path 
on window with "command line" or "power shell". there is no tutorial about 
this. I have to go to build file to know that there is `~` equivalent with 
`$HOME` and `%HOMEPATH%` on window.
   I think it is feature?
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] hiepxanh opened a new pull request #909: update example on buildConfig

[GitBox]

hiepxanh opened a new pull request #909: update example on buildConfig
URL: https://github.com/apache/cordova-docs/pull/909
 
 
   ### Platforms affected
   Android
   
   ### What does this PR do?
   There is no tutorial or any example on google or the docs. I dont event know 
that `~` can relate to `HOME` path. It take me 5 hours to searching, and 
finally I have to go to source code to read and find out that can help me. I 
hope on small change can help people working on multi device can easy locate 
that home path to point to `.android` folder more easy.
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [ ] Commit message follows the format: "GH-3232: (android) Fix bug with 
resolving file paths", where GH- is the GitHub issue ID & "android" is the 
platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

janpio edited a comment on issue #119: Getting location with high accuracy 
taking time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439368130
 
 
   "same problem" as who? Original poster said that "Getting location with high 
accuracy taking time more than 4 mins " - what you posted took 15 seconds from 
the timestamps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

janpio commented on issue #119: Getting location with high accuracy taking time 
more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439368130
 
 
   "same problem" as who? Original poster said that "Getting location with high 
accuracy taking time more than 4 mins " - what you posted took 15 seconds.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #563: [Fix] better support to find Home path for window

[GitBox]

janpio edited a comment on issue #563: [Fix] better support to find Home path 
for window
URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439368754
 
 
   Hm, first time I see this. Is the `~` behavior documented anywhere? Where 
did you learn that you can do it this way?
   
   Also: Isn't the code here currently already exactly for making it possible 
to use `~` on Windows, where this isn't supported out of the box?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #563: [Fix] better support to find Home path for window

[GitBox]

janpio commented on issue #563: [Fix] better support to find Home path for 
window
URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439368754
 
 
   Hm, first time I see this. Is the `~` behavior documented anywhere? Where 
did you learn that you can do it this way?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] easywasdev opened a new issue #376: UIImagePickerController cancel handling incorrect for iOS11+

[GitBox]

easywasdev opened a new issue #376: UIImagePickerController cancel handling 
incorrect for iOS11+
URL: https://github.com/apache/cordova-plugin-camera/issues/376
 
 
   The way the plugin handles the user cancelling the UIImagePickerController 
is not correct for iOS11+. From iOS 11 Apple no longer requires the user's 
explicit permission to show UIImagePickerController:
   
   > Accessing images using UIImagePickerViewController no longer requires 
explicit permission, though accessing the photo library through other APIs 
does. The changes to the photo library permission model is detailed in the 
WWDC17 sessions What's New in Photos and Privacy and Your Apps.
   
   From https://forums.developer.apple.com/thread/86974#271938
   See https://developer.apple.com/videos/play/wwdc2017-505/?time=252
   
   Currently, `imagePickerControllerDidCancel` returns an error ("has no access 
to assets") if `picker.sourceType != UIImagePickerControllerSourceTypeCamera && 
[ALAssetsLibrary authorizationStatus] != ALAuthorizationStatusAuthorized`. In 
iOS11+ this will never be true. `[ALAssetsLibrary authorizationStatus]` returns 
`ALAuthorizationStatusNotDetermined` because permission is never requested. So 
returning the permission denied error is incorrect. The code remains correct 
from iOS 10 and below.
   
   I will submit a pull request with a suggested solution to this problem.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

carliblaz commented on issue #119: Getting location with high accuracy taking 
time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439351124
 
 
   Well I have the same problem, if I check the logs:
   
   11-16 11:28:17.404  3420 21768 I GCoreUlr: No valid location reports to store
   11-16 11:28:18.365 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:23.382 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:28.418 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:32.525  3420 19568 I GCoreUlr: Filtering location: Location[g 
45.XX,13.XX acc=3 et=+22h11m35s905ms alt=68.50113677978516 
vel=0.07393644 mock {Bundle[{mockLocation=true}]}]
   
   But Response is not OK :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] yaro08 commented on issue #342: Client digital certificate authentication doesn't work

[GitBox]

yaro08 commented on issue #342: Client digital certificate authentication 
doesn't work
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/342#issuecomment-439368909
 
 
   If someone have this same problem:
   I achieved to solve this issue using this plugin with CordovaView (target 
option: "_system") for open browser with parameter uri redirect, And for back 
to the app I used deeplinks plugin.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

carliblaz commented on issue #119: Getting location with high accuracy taking 
time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439374624
 
 
   Ye it took 15s for triggering error with no response, there is one missing 
line there, when successfully get location:
   
   11-16 13:04:38.453  3420  6966 I GCoreUlr: Successfully inserted 1 locations


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] carliblaz edited a comment on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

carliblaz edited a comment on issue #119: Getting location with high accuracy 
taking time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439351124
 
 
   Well I have the same problem, if I check the logs:
   
   11-16 11:28:17.404  3420 21768 I GCoreUlr: No valid location reports to store
   11-16 11:28:18.365 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:23.382 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:28.418 20227 20554 D GeolocationPlugin: We are entering execute
   11-16 11:28:32.525  3420 19568 I GCoreUlr: Filtering location: Location[g 
45.XX,13.XX acc=3 et=+22h11m35s905ms alt=68.50113677978516 
vel=0.07393644 mock {Bundle[{mockLocation=true}]}]
   11-16 13:04:38.453 3420 6966 I GCoreUlr: Successfully inserted 1 locations
   
   But Response is not OK :(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439377526
 
 
   Oh right, there it is in white font. But it overlays the webview on my app, 
is this expected? Don't see that in your screenshots of the original app.
   
   
![screenshot_20181116-132208](https://user-images.githubusercontent.com/183673/48621088-b6769a80-e9a2-11e8-822f-9fb725c2e078.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] carliblaz commented on issue #119: Getting location with high accuracy taking time more than 4 mins

[GitBox]

carliblaz commented on issue #119: Getting location with high accuracy taking 
time more than 4 mins 
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/119#issuecomment-439377641
 
 
   Another example:
   
   11-16 13:22:49.058 17763 17858 D GeolocationPlugin: We are entering execute
   11-16 13:22:54.077 17763 17858 D GeolocationPlugin: We are entering execute
   11-16 13:22:59.101 17763 17858 D GeolocationPlugin: We are entering execute
   11-16 13:23:02.264  3420 11768 I GCoreUlr: Filtering location: Location[g 
45.XX,13.XX acc=1 et=+1d0h6m5s663ms alt=67.32038879394531 vel=0.4008691 
mock {Bundle[{mockLocation=true}]}]
   11-16 13:23:02.264  3420 11768 I GCoreUlr: No valid location reports to store
   11-16 13:23:04.122 17763 17858 D GeolocationPlugin: We are entering execute


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

[GitBox]

BuddyLReno commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439400072
 
 
   @janpio updated! Sorry about that!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] gurolayanlar commented on issue #305: 'loadstop' event stopped working in iOS 12.0

[GitBox]

gurolayanlar commented on issue #305: 'loadstop' event stopped working in iOS 
12.0
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/305#issuecomment-439400829
 
 
   I have same problem, is there solved problem?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439404536
 
 
   Yeah that's expected because I've enabled screen overlay ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #197: Add durationUpdate callback

[GitBox]

janpio commented on a change in pull request #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234244621
 
 

 ##
 File path: www/Media.js
 ##
 @@ -35,16 +35,22 @@ var mediaObjects = {};
  * @param errorCallback The callback to be called if there is an error.
  *  errorCallback(int errorCode) - OPTIONAL
  * @param statusCallbackThe callback to be called when media status 
has changed.
- *  statusCallback(int statusCode) - OPTIONAL
 
 Review comment:
   Thanks - that's why we do reviews :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] theoafactor commented on issue #373: Cannot take pictures on Android 8

[GitBox]

theoafactor commented on issue #373: Cannot take pictures on Android 8
URL: 
https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439479882
 
 
   @jeffreyvdhondel thanks but this does not work still..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback

[GitBox]

BuddyLReno commented on a change in pull request #197: Add durationUpdate 
callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234239840
 
 

 ##
 File path: www/Media.js
 ##
 @@ -35,16 +35,22 @@ var mediaObjects = {};
  * @param errorCallback The callback to be called if there is an error.
  *  errorCallback(int errorCode) - OPTIONAL
  * @param statusCallbackThe callback to be called when media status 
has changed.
- *  statusCallback(int statusCode) - OPTIONAL
 
 Review comment:
   ah that was a mistake!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

ippeiukai commented on issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47#issuecomment-439433236
 
 
   @brodybits Thank you for following up. 
   
   To me, it is a strange situation. `source-file` is meant for specifying 
source code files, such as .java for android. But specifying a directory of 
.java files no longer works and found to be an undocumented behaviour. 
Meanwhile cordova-android is working hard to patch the cases for 
not-so-source-code files being specified as `source-file`.
   I feel keeping everything, documented or not, makes more sense for now. But 
in the long run, cordova itself may want to improve the definition of what are 
source code files and what are not. Perhaps before the next major release?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

[GitBox]

brodybits commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439447665
 
 
   I just put the changes in almost the same order as they appear in master and 
removed "[WIP]" from the title, think it should be merged now. Any objections?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439470466
 
 
   Since, I've used StatusBar.overlaysWebView(true); , The Statusbar just 
overlays on top of the page. The page has a blank top to blend with the status 
bar :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

brodybits commented on issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47#issuecomment-439435990
 
 
   > Keeping and documenting is probably "easier" here
   
   In that case I think we should fix it for Android as well.
   
   > there might be a unlimited number of plugins out there using it
   
   I would agree at a theoretical level. But considering that it was not 
documented, and we did not see so many reports due to the breakage on Android, 
I would expect the number of plugins using this feature to be very limited.
   
   I just added the **bug** label.
   
   > But in the long run, cordova itself may want to improve the definition of 
what are source code files and what are not.
   
   Definitely, and I would like to discuss that in another new issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

janpio commented on issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47#issuecomment-439469305
 
 
   +1 for fix and document then


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #555: 7.1.3 patch updates

[GitBox]

janpio commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439471150
 
 
   Maybe silly question, but what would be a way to compare `master` and this 
branch to see if the cherry-picked commits make sense and nothing is missing 
etc?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

janpio commented on issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47#issuecomment-439428984
 
 
   Keeping and documenting is probably "easier" here as there might be a 
unlimited number of plugins out there using it, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #67: CB-12024: Browser platform support

[GitBox]

janpio commented on issue #67: CB-12024: Browser platform support
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-439442071
 
 
   @dudeofawesome Could you have a look at my questions, I couldn't get this to 
work. Otherwise we would have to treat this PR as abandoned, which would be a 
shame.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #555: 7.1.3 patch updates

[GitBox]

janpio edited a comment on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439471150
 
 
   Maybe silly question, but what would be a way to compare `master` and this 
branch to see if the cherry-picked commits make sense and nothing is missing 
etc?
   
   Second question: With 18 commits, wouldn't it make more sense to make this 
7.2.0? Is this still just a patch release with so much content?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin hides the input 
when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439479450
 
 
   yeah exactly!
   yeah if I don't use Statusbar overlay even with the plugin added, it doesn't 
break!
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] BuddyLReno commented on a change in pull request #197: Add durationUpdate callback

[GitBox]

BuddyLReno commented on a change in pull request #197: Add durationUpdate 
callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234240286
 
 

 ##
 File path: www/Media.js
 ##
 @@ -35,16 +35,22 @@ var mediaObjects = {};
  * @param errorCallback The callback to be called if there is an error.
  *  errorCallback(int errorCode) - OPTIONAL
  * @param statusCallbackThe callback to be called when media status 
has changed.
- *  statusCallback(int statusCode) - OPTIONAL
 
 Review comment:
   Fixed!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

[GitBox]

BuddyLReno commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439426503
 
 
   Yes, I can elaborate.
   
   In the newer versions of android, after about five minutes of background 
activity, android shuts down the web container that is running the app. So when 
you try to use a background task to query for the duration with a `setTimeout` 
as is described in the docs, that setTimeout never actually runs.  This occurs 
even if you use a plugin like cordova-plugin-background-mode.
   
   What I mean by subscribing, is basically just attaching a callback to allow 
the native code to run the callback when the audio player assigns duration. By 
doing this, you always get a real duration and don't have to worry about 
getting a "-1" duration as it only reports the duration after the audio player 
actually initializes and has the real duration. This removes the need to query 
for duration with a setTimeout, which prevents the situation above from 
happening. 
   
   Does that help?
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #555: 7.1.3 patch updates

[GitBox]

jcesarmobile commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439476178
 
 
   No, because master have a lot more fixes that won't go into 7.1.3, so you 
can't directly compare
   
   Also no to 7.2.0, this is supposedly a patch, and doing a minor bump will 
prevent the cli from getting this version that patches some bugs we caused in 
previous release
   
   Will review later tonight 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #555: 7.1.3 patch updates

[GitBox]

brodybits commented on issue #555: 7.1.3 patch updates
URL: https://github.com/apache/cordova-android/pull/555#issuecomment-439484841
 
 
   I just updated the changes as follows:
   * moved a couple gradle updates to the end
   * added number of original PR on master where it was not present
   
   I also updated the description to list the changes in the same order as they 
appear in this PR.
   
   I hope this makes it easier to check what changes are in this PR. Thanks 
@jcesarmobile for your efforts to check the changes in both branches.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio edited a comment on issue #110: Cordova Status Bar Plugin hides the 
input when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439438487
 
 
   Understood.
   
   ---
   
   The following answers: What is going on here?
   
   I duplicated the app so I have one with plugin (and the bug), and one 
without. Then I remote debugged both using Chrome:
   
   With plugin, no matter if I am in the input or not I have this 
representation of the Webview in devtools:
   
![image](https://user-images.githubusercontent.com/183673/48632011-247d8a80-e9c0-11e8-8e0a-4c4a9c74da24.png)
   
   Without the plugin, I have two different states:
   
![image](https://user-images.githubusercontent.com/183673/48632047-34956a00-e9c0-11e8-8ce7-d7cac7cf5550.png)
   (Note that this is also a few pixels less high - as the toolbar is not 
applied onto the webview and thus is not part of this screenshot)
   But as soon as I have the cursor in the input and the keyboard pops up:
   
![image](https://user-images.githubusercontent.com/183673/48632069-48d96700-e9c0-11e8-9fab-e13189d4cd0e.png)
   
   This tells me that with the plugin, the webview is not really resized when 
the keyboard appears but stays the same size, making the input field disappear 
behind the keyboard.
   
   Next question: Why?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439438487
 
 
   Got it.
   
   ---
   
   The following answers: What is going on here?
   
   I duplicated the app so I have one with plugin (and the bug), and one 
without. Then I remote debugged both using Chrome:
   
   With plugin, no matter if I am in the input or not I have this 
representation of the Webview in devtools:
   
![image](https://user-images.githubusercontent.com/183673/48632011-247d8a80-e9c0-11e8-8e0a-4c4a9c74da24.png)
   
   Without the plugin, I have two different states:
   
![image](https://user-images.githubusercontent.com/183673/48632047-34956a00-e9c0-11e8-8ce7-d7cac7cf5550.png)
   (Note that this is also a few pixels less high - as the toolbar is not 
applied onto the webview and thus is not part of this screenshot)
   But as soon as I have the cursor in the input and the keyboard pops up:
   
![image](https://user-images.githubusercontent.com/183673/48632069-48d96700-e9c0-11e8-9fab-e13189d4cd0e.png)
   
   This tells me that with the plugin, the webview is not really resized when 
the keyboard appears but stays the same size, making the input field disappear 
behind the keyboard.
   
   Next question: Why?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439441478
 
 
   Ok, this got me thinking: Is it really the presence of the plugin causing 
the behavior or is it actually the usage of some specific functionality?
   
   I changed the code in `onDeviceReady` to read:
   ```
   //StatusBar.overlaysWebView(true);  
   //StatusBar.styleBlackTranslucent();
   StatusBar.backgroundColorByName("red");
   ```
   Now I have a red statusbar, and the input field is still visible above the 
keyboard.
   
   Conclusion: The presence of the plugin is not the problem, the usage of 
specific features of it might cause this.
   
   ---
   
   My guess would have been `StatusBar.overlaysWebView(true);`, but your 
screenshot @tharunkumar0 does show a statusbar in the screenshot with the bug. 
Can you explain? What exactly are you using of the plugin in your original app?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin (with 
`StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439508422
 
 
   Ok, so using `StatusBar.overlaysWebView(true)` makes the webview not shrink 
when the keyboard appears. That sounds like a bug.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dmonaldo commented on issue #306: InApp browser not support in iPhone X devices

[GitBox]

dmonaldo commented on issue #306: InApp browser not support in iPhone X devices
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/306#issuecomment-439515603
 
 
   I'm also experiencing this issue. Are there any plans to fix this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] itsonit commented on issue #114: Not working on Android devices

[GitBox]

itsonit commented on issue #114: Not working on Android devices
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/114#issuecomment-439513362
 
 
   @terminaltor ty for charing. 1st Test set with several android devices works 
well. 2nd Test will follow..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #111: Status bar don't overlay web view in Ionic

[GitBox]

janpio commented on issue #111: Status bar don't overlay web view in Ionic
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/111#issuecomment-439508084
 
 
   What plugin version are you using?
   What iOS version are you testing on?
   Did you remote debug the problem and inspect the code to see if the webview 
is actually full size? (See instructions at 
https://ionic.zone/debug/remote-debug-your-app#ios)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] BuddyLReno commented on issue #197: Add durationUpdate callback

[GitBox]

BuddyLReno commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439523985
 
 
   Great! I'm getting ready to leave the office but I'll update the README 
later tonight after the kids go to bed.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brunojs02 opened a new issue #111: Status bar don't overlay web view in Ionic

[GitBox]

brunojs02 opened a new issue #111: Status bar don't overlay web view in Ionic
URL: https://github.com/apache/cordova-plugin-statusbar/issues/111
 
 
   Ionic: 3.20.0
   Cordova: 8.0.0
   Cordova-ios: 4.5.5
   
   Configurations:
   StatusBar.overlaysWebView(true);
   
   I want the status bar overlay web view, but for some reason, my status is 
setting to white.
   
   Result: [image](https://imgur.com/a/KIMFkiy)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

janpio commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439523084
 
 
   Ok, so 
https://github.com/apache/cordova-plugin-inappbrowser#inappbrowserclose does 
not actually work but leave the InAppBrowser window that was opened, open? 
   
   It would be awesome if one of you both could create a reproduction app with 
`cordova create`, implement the minimal code needed to show the problem and put 
it on GitHub.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439547110
 
 
   sure, go at it, doesn't work: 
   
   ```
   /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements.  See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership.  The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License.  You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied.  See the License for the
* specific language governing permissions and limitations
* under the License.
*/
   var app = {
   // Application Constructor
   initialize: function() {
   document.addEventListener('deviceready', 
this.onDeviceReady.bind(this), false);
   },
   
   // deviceready Event Handler
   //
   // Bind any cordova events here. Common events are:
   // 'pause', 'resume', etc.
   onDeviceReady: function() {
   this.receivedEvent('deviceready');
   },
   
   // Update DOM on a Received Event
   receivedEvent: function(id) {
   var parentElement = document.getElementById(id);
   var listeningElement = parentElement.querySelector('.listening');
   var receivedElement = parentElement.querySelector('.received');
   
   listeningElement.setAttribute('style', 'display:none;');
   receivedElement.setAttribute('style', 'display:block;');
   
   console.log('Received Event: ' + id);
   
   setTimeout(() => test(), 3000);
   }
   
   
   };
   test = function () {
   var ref = cordova.InAppBrowser.open('https://www.google.com', '_system');
   setTimeout(() => ref.close(), 3000);
   }
   app.initialize();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #197: Add durationUpdate callback

[GitBox]

janpio commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439521793
 
 
   Ok, so https://github.com/apache/cordova-plugin-media#quick-example-2 
doesn't actually work that well any more and one should use this new callback 
param instead on Android, correct?
   
   If so, best add this as an "Android Quirk" under the `getDuration` example 
in the README to make sure it gets noticed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #197: Add durationUpdate callback

[GitBox]

janpio edited a comment on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439521793
 
 
   I very much hoe so:
   I understood that 
https://github.com/apache/cordova-plugin-media#quick-example-2 doesn't actually 
work that well any more and one should use this new callback param instead on 
Android, correct?
   
   If so, best add this as an "Android Quirk" under the `getDuration` example 
in the README to make sure it gets noticed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439551334
 
 
   i also created a rep for you, please forgive me if i added too many files in 
there, i really have no idea about cordova in particular and it doesn't have a 
built in gitignore file: [replink](https://github.com/heidji/inappbrowsertest)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] AutoAlert commented on issue #373: Cannot take pictures on Android 8

[GitBox]

AutoAlert commented on issue #373: Cannot take pictures on Android 8
URL: 
https://github.com/apache/cordova-plugin-camera/issues/373#issuecomment-439537809
 
 
   Hi @jeffreyvdhondel thanks for the response. I tried your suggestion but 
unfortunately it still does not work, still the same error.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

brodybits opened a new issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47
 
 
   Triggered by @ippeiukai in 
:
   
   > [...] behaviour of `source-file` is not documented, [...] it was working 
with `cordova-android@6` but no longer with `cordova-android@7`.
   > 
   > 
[vaenow/cordova-plugin-app-update#119](https://github.com/vaenow/cordova-plugin-app-update/pull/119)
   > (Specifying a directory with many `.java` files as source-file src no 
longer works.)
   > 
   > FYI: though not documented officially, it is a known behaviour:
   > https://stackoverflow.com/q/28042385
   
   The behavior to copy entire directory contents of a  element in 
case of a directory in the `src` attribute is undocumented. It is now working 
on cordova-ios@latest, cordova-osx@latest, and cordova-android@6 but not 
cordova-android@latest. (Source files would be put into incorrect subdirectory 
on cordova-android@latest.) But there are a couple issues with this 
undocumented feature on iOS and macOS ("osx"):
   * this feature does not work with header files
   * not possible to specify build flags per source file
   
   I can think of the following possible solutions:
   * explicitly remove this undocumented behavior
   * fix the behavior on cordova-android and document it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] IonicOnCouch commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

[GitBox]

IonicOnCouch commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support
URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-439429729
 
 
   @nagthgr8 Did you find a solution for the problem? I have the same Error...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with `StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears

[GitBox]

tharunkumar0 commented on issue #110: Cordova Status Bar Plugin (with 
`StatusBar.overlaysWebView(true)`) hides the input when the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439589299
 
 
   Yeah!! in iOS, it shrinks a little but still the input is not visible!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

heidji commented on issue #347: How to trigger custom URL scheme calls in an 
IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561306
 
 
   i honestly don't care how the browser is called or what it looks like, as 
long as it can call custom URL schemes and i can close it after then alles ist 
gut 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

janpio commented on issue #347: How to trigger custom URL scheme calls in an 
IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561039
 
 
   I took the liberty to rewrite your feature request into a question on how to 
make this work. Please check if this still represents what you want to do, then 
I can maybe give you some input. (Please open an additional issue for the 
feature request that was here - a short "I want close to work with _system" or 
similar should be enough, link to the other two issues for context.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] keithdmoore commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

keithdmoore commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439561574
 
 
   @janpio I am using ‘_blank’ and the close method leaves the inappbrowser 
running.  It’s hidden but it’s still running.  Having these running will cause 
memory issues


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] keithdmoore edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

[GitBox]

keithdmoore edited a comment on issue #290: InAppBrowser will not destroy 
WebView when invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439566001
 
 
   @janpio that’s pretty close to what I was seeing.  It’s been awhile since I 
looked into this issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439558045
 
 
   @janpio okay thanks, will open an issue for my use case


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji opened a new issue #347: Request: browser.close() should include URLs opened with '_system' and not only '_blank'

[GitBox]

heidji opened a new issue #347: Request: browser.close() should include URLs 
opened with '_system' and not only '_blank'
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/347
 
 
   After a lenghty discussion on 
[#290](https://github.com/apache/cordova-plugin-inappbrowser/issues/290) we 
reached the fact that as per docs, only URLs opened with **`'_blank'`** enjoy 
the capability of being closed with the **`close(`**) method: 
   
   ```
   var ref = cordova.InAppBrowser.open('https://www.google.com', '_blank');
   setTimeout(() => {
   ref.close();
   }, 2000);
   ```
   ^works!
   
   The problem is that AFAIK URLs opened with **`'_blank'`** cannot trigger 
custom URL scheme calls, meaning that if the website I just opened would try to 
call back my app using **`"myapp://"`** but would fail because that browser 
doesn't grant this capability, 
   on the other hand, URLs opened with `**'_system'**` do enjoy this 
functionality, but sadly cannot be closed after ending their task with 
**`"ref.close()"`**.
   
   The only reason I opened this bug is because IMO there is no point of having 
a **`close()`** method when the browser cannot provide feedback to the app.. 
when should the app know to close the browser? it can't even can't receive any 
kind of feedback using **`'_blank'`**.
   
   I don't think it should be about choosing being able to close the browser 
but have a useless external call or have an external call that won't close when 
it's finished.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

[GitBox]

janpio commented on issue #290: InAppBrowser will not destroy WebView when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745
 
 
   Ok, so you actually have a different "problem" than @heidji had - good that 
we moved his to new issues. I updated the title of this issue - is this correct?
   
   How did you discover that the webview is still running exactly?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

heidji commented on issue #347: How to trigger custom URL scheme calls in an 
IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439564185
 
 
   yes I suppose this could work, I will give it a go and let you know in a few 
days. it's. a bit cheating though :P


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413
 
 
   actually i was mistaken about _blank not closing, but it's because also in 
my app _blank doesn't work: the reason being that the external app having a 
callback with myapp:// scheme to return to the app, but in _blank this call 
never gets through. yes your rep works, but _blank doesn't work for me, it has 
to be an external browser with _system in order to call the custom URL scheme.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439556413
 
 
   actually i was mistaken about _blank not closing, but it's because also in 
my app _blank doesn't work: the reason being that the external http location 
having a callback with myapp:// scheme to return to the app, but in _blank this 
call never gets through. yes your rep works, but _blank doesn't work for me, it 
has to be an external browser with _system in order to call the custom URL 
scheme.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

janpio commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439557264
 
 
   @keithdmoore Did you original issue also refer to IAB using `_system`?
   
   The next step to debug this would be to see what happens on the native side 
of things - `close` seems to be handled by this code for Android: 
https://github.com/apache/cordova-plugin-inappbrowser/blob/3eadde65ab0bcd17cc2cd0231b1d8a3f68bbd5b8/src/android/InAppBrowser.java#L509-L543
   Unfortunately I am not set up for this.
   
   @heidji I understand this doesn't match your usecase - maybe open a new 
issue describing it again and asking for solutions (I might have an idea).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

[GitBox]

janpio edited a comment on issue #290: InAppBrowser will not destroy WebView 
when invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745
 
 
   Ok, so you actually have a different "problem" than @heidji had - good that 
we moved his to new issues. I updated the title of this issue - is this correct?
   
   How did you discover that the webview is still running exactly?
   
   Update: I could reproduce what you describe in Android and the Chrome dev 
tools:
   
![image](https://user-images.githubusercontent.com/183673/48652970-97a7f080-ea02-11e8-8e28-ae49ed88e0fe.png)
   Each execution of `test()` from @heidji's test repository opens a new IAB 
windows that first loads google.com and that switches to about:blank when the 
IAB windows is closed via `.close`. That's not good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

[GitBox]

janpio edited a comment on issue #290: InAppBrowser will not destroy WebView 
when invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439562745
 
 
   Ok, so you actually have a different "problem" than @heidji had - good that 
we moved his to new issues. I updated the title of this issue - is this correct?
   
   How did you discover that the webview is still running exactly?
   
   Update: I could reproduce what you describe in Android and the Chrome dev 
tools:
   
![image](https://user-images.githubusercontent.com/183673/48652970-97a7f080-ea02-11e8-8e28-ae49ed88e0fe.png)
   Each execution of `test()` from @heidji's test repository opens a new IAB 
windows that first loads google.com and that switches to about:blank when the 
IAB windows is closed via `.close`. That's not good.
   Does this match what you are seeing and reported here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

janpio commented on issue #347: How to trigger custom URL scheme calls in an 
IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439564435
 
 
   It's one solution for the problem that many OAuth configurations only accept 
valid URLs with `http` or `https`. And as you can't (or: shouldn't) just start 
a webserver on the device, this workaround is used by many, many apps.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

janpio commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439552612
 
 
   Thanks, the repo is perfect.
   
   While checking it out, I had a look at the documentation. Something popped 
up at me:
   
   > The object returned from a call to `cordova.InAppBrowser.open` when the 
target is set to `'_blank'`.
   > https://github.com/apache/cordova-plugin-inappbrowser#inappbrowser
   
   Several of the methods mention that they only work with `_blank`, and the 
`.close` example also uses `_blank`.
   
   This might be the first thing to investigate.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520
 
 
   @janpio actually the behavior of _blank isn't useful to me, it opens inside 
the app itself and doesn't close either..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji edited a comment on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji edited a comment on issue #290: InAppBrowser will not close when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439553520
 
 
   @janpio actually the behavior of _blank isn't useful to me, it opens inside 
the app itself and doesn't close either..
   i mean it uses the app as a browser


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] ippeiukai commented on issue #47: Fix or remove undocumented plugin directory source-file behavior

[GitBox]

ippeiukai commented on issue #47: Fix or remove undocumented plugin directory 
source-file behavior
URL: https://github.com/apache/cordova/issues/47#issuecomment-439555481
 
 
   > > Keeping and documenting is probably "easier" here
   > 
   > In that case I think we should fix it for Android as well.
   
   @brodybits Should I file a bug issue for this on cordova-android? Or this is 
included in the scope of apache/cordova-android#547 ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

janpio commented on issue #347: How to trigger custom URL scheme calls in an 
IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561958
 
 
   I assume this means that my description of your usecase is still correct ;)
   
   So:
   
   You can react to specific URLs being opened in the IAB window in your code. 
Take this snippet as an example:
   
   ```
 const browser = window.cordova.InAppBrowser.open(
 url,
 "_blank",
 "location=yes,clearsessioncache=yes,clearcache=yes"
 );
 browser.addEventListener("loadstart", (event) => {
   if ((event.url).indexOf("http://localhost/callback;) === 0) {
   
 browser.removeEventListener("exit", (event) => {});
 browser.close();
   
 // Here is some code that extracts a param from the full 
`event.url`
   }
 });
 browser.addEventListener("exit", function(evt) {
   reject("Sign in flow was canceled");
 });
   ```
   
   Instead of `http://localhost/callback` you could probably look for 
`myapp://`, then have a deeper look at the URL and handle the deeplink yourself.
   
   Of course this only works if `myapp://` is actually your app. If it is a 
third party app, you would have to execute some code here that really opens 
`myapp://` externally somehow - maybe via `_system` of the IAB now.
   
   Could this work for you?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] keithdmoore commented on issue #290: InAppBrowser will not destroy WebView when invoking ref.close()

[GitBox]

keithdmoore commented on issue #290: InAppBrowser will not destroy WebView when 
invoking ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439566001
 
 
   @panpio that’s pretty close to what I was seeing.  It’s been awhile since I 
looked into this issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] heidji commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

heidji commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439552895
 
 
   i also suspected something similar, i think i can live with _blank :D


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #290: InAppBrowser will not close when invoking ref.close()

[GitBox]

janpio commented on issue #290: InAppBrowser will not close when invoking 
ref.close()
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/290#issuecomment-439554830
 
 
   I can reproduce the behaviour you describe in the unchanged app.
   
   After adding some debugging and changing to `_blank` the IAB opens and 
closes automatically. I pushed it to my fork: 
https://github.com/janpio/inappbrowsertest/tree/blank Can you confirm the IAB 
windows closing after a few seconds?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #347: How to trigger custom URL scheme calls in an IAB window opened with _blank?

[GitBox]

janpio edited a comment on issue #347: How to trigger custom URL scheme calls 
in an IAB window opened with _blank?
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/347#issuecomment-439561039
 
 
   I took the liberty to rewrite your feature request into a question on how to 
make this work. Please check if this still represents what you want to do, then 
I can maybe give you some input. 
   
   (Please open an additional issue for the feature request that was here - a 
short "I want close to work with _system" or similar should be enough, link to 
the other two issues for context.)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #197: Add durationUpdate callback

[GitBox]

janpio commented on issue #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#issuecomment-439422019
 
 
   (Thanks for the updates on the text, I cleaned up the comments a bit by 
hiding.)
   
   Interesting change. I understand both parts of what you wrote:
   
   > This particular change helps deal with the fact that Android shuts down 
webapps in the background after a few minutes.
   
   > You can subscribe to this callback and let the audio player report the 
duration to you when it's available instead of querying for it.
   
   But to be honest I don't really get how those are connected. Can you 
elaborate maybe?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #197: Add durationUpdate callback

[GitBox]

janpio commented on a change in pull request #197: Add durationUpdate callback
URL: 
https://github.com/apache/cordova-plugin-media/pull/197#discussion_r234237200
 
 

 ##
 File path: www/Media.js
 ##
 @@ -35,16 +35,22 @@ var mediaObjects = {};
  * @param errorCallback The callback to be called if there is an error.
  *  errorCallback(int errorCode) - OPTIONAL
  * @param statusCallbackThe callback to be called when media status 
has changed.
- *  statusCallback(int statusCode) - OPTIONAL
 
 Review comment:
   This line should probably not be moved down, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

[GitBox]

brodybits commented on issue #547: Compatibility of old plugins with non-Java 
source-file entries
URL: https://github.com/apache/cordova-android/issues/547#issuecomment-439421666
 
 
   > So trying to fix this is definitely a patch
   
   @jcesarmobile I see your point now. I will update PR #555 for the patch 
release.
   
   > [...] behaviour of `source-file` is not documented, [...] it was working 
with `cordova-android@6` but no longer with `cordova-android@7`.
   
   @ippeiukai thanks for reporting, I just raised 
 with the information and would 
like to continue discussion there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #110: Cordova Status Bar Plugin hides the input when the keyboard appears

[GitBox]

janpio commented on issue #110: Cordova Status Bar Plugin hides the input when 
the keyboard appears
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/110#issuecomment-439472320
 
 
   Sorry, I don't understand. Did you move the app top bar down a bit so it 
looks normal?
   If so, can you confirm the broken behaviour is gone as soon as the statusbar 
does not overlay the webview any more?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org