[GitHub] janpio opened a new issue #215: Tests: Control testing fileserver from plugin tests, not other tools running the tests

[GitBox]

janpio opened a new issue #215: Tests: Control testing fileserver from plugin 
tests, not other tools running the tests
URL: https://github.com/apache/cordova-plugin-file-transfer/issues/215
 
 
   Currently paramedic includes code to install and control the file server 
that is needed for these tests here to succeed: 
https://github.com/apache/cordova-paramedic/blob/ff6b2fa00b2e5b11907f2e7d0296f7b35feb4a04/lib/LocalServer.js#L78-L112
 This code should live here, not with paramedic, so the testing also works 
outside the context of paramedic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #576: Improve target-dir restriction for detecting new android project…

[GitBox]

janpio commented on issue #576: Improve target-dir restriction for detecting 
new android project…
URL: https://github.com/apache/cordova-android/pull/576#issuecomment-441984356
 
 
   That should have been fixed with 7.1.4 which was release quickly after this 
bug was discovered.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #112: how to get statusbar height

[GitBox]

janpio commented on issue #112: how to get statusbar height
URL: 
https://github.com/apache/cordova-plugin-statusbar/issues/112#issuecomment-441985224
 
 
   No, this is not one of the supported methods: 
https://github.com/apache/cordova-plugin-statusbar#methods
   
   Why do you need this functionality?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new issue #590: Upgrade `cover` to use `nyc` instead of `istanbul`

[GitBox]

janpio opened a new issue #590: Upgrade `cover` to use `nyc` instead of 
`istanbul`
URL: https://github.com/apache/cordova-android/issues/590
 
 
   Currently:
   ```
"cover": "istanbul cover --root bin --print detail jasmine -- 
--config=spec/unit/jasmine.json",
   ```
   
   Should also use `nyc` as `cordova-ios` does.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] gandhirajan opened a new issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

[GitBox]

gandhirajan opened a new issue #159: mobile-spec project creation fails with 
error "Cannot find module 'cordova-common'"
URL: https://github.com/apache/cordova-mobile-spec/issues/159
 
 
   mobile-spec project creation fails with the error "Error: Cannot find module 
'cordova-common'" when trying to execute the command - "node 
./cordova-mobile-spec/createmobilespec/createmobilespec.js --android 
--forceplugins"
   
   If I try adding cordova-common module in mobile-spec project manually and 
try executing the platform add command using - 
"root_folder\cordova-cli\bin\cordova.cmd platform add 
"root_folder\cordova-android" --verbose" , platform addition is successfully. 
   
   Not sure how to bring in cordova-common module installed as dependency while 
creating mobile-spec project


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] Jule- closed pull request #576: Improve target-dir restriction for detecting new android project…

[GitBox]

Jule- closed pull request #576: Improve target-dir restriction for detecting 
new android project…
URL: https://github.com/apache/cordova-android/pull/576
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/pluginHandlers.js 
b/bin/templates/cordova/lib/pluginHandlers.js
index f5be4b49d..240e6e4d8 100644
--- a/bin/templates/cordova/lib/pluginHandlers.js
+++ b/bin/templates/cordova/lib/pluginHandlers.js
@@ -318,28 +318,39 @@ function generateAttributeError (attribute, element, id) {
 }
 
 function getInstallDestination (obj) {
-var APP_MAIN_PREFIX = 'app/src/main';
+const APP_MAIN_PREFIX = 'app/src/main';
+const PATH_SEPARATOR = '/';
 
-if (obj.targetDir.startsWith('app')) {
+const appReg = new RegExp(`^app\\${PATH_SEPARATOR}?`);
+const libsReg = new RegExp(`^libs\\${PATH_SEPARATOR}?`);
+const srcReg = new RegExp(`^src\\${PATH_SEPARATOR}?`);
+const srcMainReg = new 
RegExp(`^src\\${PATH_SEPARATOR}main\\${PATH_SEPARATOR}?`);
+
+if (appReg.test(obj.targetDir)) {
 // If any source file is using the new app directory structure,
 // don't penalize it
 return path.join(obj.targetDir, path.basename(obj.src));
-} else if (obj.src.endsWith('.java')) {
-return path.join(APP_MAIN_PREFIX, 'java', obj.targetDir.substring(4), 
path.basename(obj.src));
-} else if (obj.src.endsWith('.aidl')) {
-return path.join(APP_MAIN_PREFIX, 'aidl', obj.targetDir.substring(4), 
path.basename(obj.src));
-} else if (obj.targetDir.includes('libs')) {
-if (obj.src.endsWith('.so')) {
-return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.substring(5), path.basename(obj.src));
-} else {
+} else {
+// plugin ignores the new app directory structure (DEPRECATED)
+if (obj.src.endsWith('.java')) {
+return path.join(APP_MAIN_PREFIX, 'java', 
obj.targetDir.replace(srcReg, ''),
+path.basename(obj.src));
+} else if (obj.src.endsWith('.aidl')) {
+return path.join(APP_MAIN_PREFIX, 'aidl', 
obj.targetDir.replace(srcReg, ''),
+path.basename(obj.src));
+} else if (libsReg.test(obj.targetDir)) {
+if (obj.src.endsWith('.so')) {
+return path.join(APP_MAIN_PREFIX, 'jniLibs', 
obj.targetDir.replace(libsReg, ''),
+path.basename(obj.src));
+} else {
+return path.join('app', obj.targetDir, path.basename(obj.src));
+}
+} else if (srcMainReg.test(obj.targetDir)) {
 return path.join('app', obj.targetDir, path.basename(obj.src));
 }
-} else if (obj.targetDir.includes('src/main')) {
-return path.join('app', obj.targetDir, path.basename(obj.src));
-} else {
+
 // For all other source files not using the new app directory 
structure,
 // add 'app/src/main' to the targetDir
 return path.join(APP_MAIN_PREFIX, obj.targetDir, 
path.basename(obj.src));
 }
-
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] nilsd commented on issue #69: GH-68 (ios): Support for disabling 3D Touch link previews

[GitBox]

nilsd commented on issue #69: GH-68 (ios): Support for disabling 3D Touch link 
previews
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/69#issuecomment-442006376
 
 
   @janpio Might be useful but I don't have time to implement it right now. I 
may submit another PR to add that feature soon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] OmgKevin opened a new issue #466: Plugin error not found for architecture x86_64

[GitBox]

OmgKevin opened a new issue #466: Plugin error not found for architecture x86_64
URL: https://github.com/apache/cordova-ios/issues/466
 
 
   How can I add support for architecture x86_64 settings in plugin.xml?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] fracon commented on issue #327: Image as base64 to style background-image:url() issue

[GitBox]

fracon commented on issue #327: Image as base64 to style background-image:url() 
issue
URL: 
https://github.com/apache/cordova-plugin-camera/issues/327#issuecomment-442027803
 
 
   Hey guys after spent a few days trying to find out why we our app's camera 
didn't work well in iOS we realize yesterday (November, 26) that we are facing 
exactly the same problem reported by @MichaelSamteladze. After spent some 
minutes searching for ocurrencies i found this bug reported and some others 
threads with people reporting problems with camera but without know that is the 
exactly problem so as @MichaelSamteladze said i think fix this bug could save a 
lot of time and stress from other developers. 
   
   As information, we are using the 4.0.3 plugin version.
   
   @MichaelSamteladze thanks for the workaround.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #466: Plugin error not found for architecture x86_64

[GitBox]

janpio commented on issue #466: Plugin error not found for architecture x86_64
URL: https://github.com/apache/cordova-ios/issues/466#issuecomment-442030431
 
 
   What are you talking about?
   What plugin? What command did you execute?
   What version of everything that is concerned?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #69: GH-68 (ios): Support for disabling 3D Touch link previews

[GitBox]

janpio commented on issue #69: GH-68 (ios): Support for disabling 3D Touch link 
previews
URL: 
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/69#issuecomment-442031822
 
 
   Awesome.
   
   Can someone else please use this branch to test this new feature so it is 
tested by multiple people?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio edited a comment on issue #576: Improve target-dir restriction for detecting new android project…

[GitBox]

janpio edited a comment on issue #576: Improve target-dir restriction for 
detecting new android project…
URL: https://github.com/apache/cordova-android/pull/576#issuecomment-441984356
 
 
   > It is blocking for me and I think for everyone who will try to get last 
cordova-android release 7.1.x and use plugins from @katzer who is an involved 
Cordova plugin developer. His plugins are declared in appPlant... 
   
   That should have been fixed with 7.1.4 which was released quickly after this 
bug was discovered.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442032642
 
 
   Did you post this problem at the `cordova-plugin-intercom` plugin repository 
as an issue already? They couldn't help you fix a problem with their plugin?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

[GitBox]

janpio commented on issue #159: mobile-spec project creation fails with error 
"Cannot find module 'cordova-common'"
URL: 
https://github.com/apache/cordova-mobile-spec/issues/159#issuecomment-442033152
 
 
   How did you setup your Cordova folders with all the checkouts before running 
this command?
   What does "try addinv cordova-common mobile in mobile-spec project manually" 
mean?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442034905
 
 
   Did some research for you:
   
   ```
   C:\Projects\throwaway
   λ cordova create intercomCordovaTest
   Creating a new cordova project.
   
   C:\Projects\throwaway
   λ cd intercomCordovaTest\
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova platform add android
   Using cordova-fetch for cordova-android@~7.1.1
   Adding android project...
   Creating Cordova project for the Android platform:
   Path: platforms\android
   Package: io.cordova.hellocordova
   Name: HelloCordova
   Activity: MainActivity
   Android target: android-27
   Android project created with cordova-android@7.1.4
   Android Studio project detected
   Android Studio project detected
   Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
project
   Installing "cordova-plugin-whitelist" for android
   
  This plugin is only applicable for versions of 
cordova-android greater than 4.0. If you have a previous platform version, you 
do *not* need this plugin since the whitelist will be built in.
   
   Adding cordova-plugin-whitelist to package.json
   Saved plugin info for "cordova-plugin-whitelist" to config.xml
   --save flag or autosave detected
   Saving android@~7.1.4 into config.xml file ...
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova run android
   Android Studio project detected
   ANDROID_HOME=C:\Android
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_121
   studio
   Starting a Gradle Daemon (subsequent builds will be faster)
   
   BUILD SUCCESSFUL in 26s
   1 actionable task: 1 executed
   Subproject Path: CordovaLib
   Subproject Path: app
   Starting a Gradle Daemon (subsequent builds will be faster)
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_8lwuaffh4nuckb10dixq4su2o.run(C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build.gradle:148)
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl
   :CordovaLib:compileDebugRenderscript
   :CordovaLib:checkDebugManifest
   :CordovaLib:generateDebugBuildConfig
   :CordovaLib:prepareLintJar
   :CordovaLib:generateDebugResValues
   :CordovaLib:generateDebugResources
   :CordovaLib:packageDebugResources
   :CordovaLib:platformAttrExtractor
   :CordovaLib:processDebugManifest
   :CordovaLib:javaPreCompileDebug
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild
   :app:compileDebugAidl
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript
   :app:checkDebugManifest
   :app:generateDebugBuildConfig
   :app:prepareLintJar
   :app:generateDebugResValues
   :app:generateDebugResources
   :app:mergeDebugResources
   :app:createDebugCompatibleScreenManifests
   :app:processDebugManifest
   :app:splitsDiscoveryTaskDebug
   :app:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugShaders
   :CordovaLib:processDebugResources
   :CordovaLib:generateDebugSources
   :CordovaLib:compileDebugJavaWithJavacNote: Some input files use or override 
a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug
   :app:processDebugResources
   :app:generateDebugSources
   :app:javaPreCompileDebug
   :app:compileDebugJavaWithJavac
   :app:compileDebugSources
   :CordovaLib:compileDebugShaders
   :CordovaLib:generateDebugAssets
   :CordovaLib:mergeDebugAssets
   :app:mergeDebugShaders
   :app:compileDebugShaders
   :app:generateDebugAssets
   :app:mergeDebugAssets
   :app:transformClassesWithStackFramesFixerForDebug
   :app:transformClassesWithDesugarForDebug
   :app:transformClassesWithDexBuilderForDebug
   :app:transformDexArchiveWithExternalLibsDexMergerForDebug
   :app:transformDexArchiveWithDexMergerForDebug
   :CordovaLib:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugJniLibFolders
   :CordovaLib:transformNativeLibsWithMergeJniLibsForDebug
   :CordovaLib:transformNativeLibsWithIntermediateJniLibsForDebug
   :app:mergeDebugJniLibFolders
   :app:transformNativeLibsWithMergeJniLibsForDebug
   :app:processDebugJavaRes NO-SOURCE
   :app:transformResourcesWithMergeJavaResForDebug
   :app:validateSigningDebug
   :app:packageDebug
   :app:assembleDebug
   :app:cdvBuildDebug
   
   BUILD SUCCESSFUL in 1m 4s
   46 actionable tasks: 46 executed
   Built the following apk(s):
   
C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build\outputs\apk\debug\app-debug.apk
   ANDROID_HOME=C:\Android
   JAV

[GitHub] janpio edited a comment on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio edited a comment on issue #591: Cordova-plugin-intercom crashing build 
at :app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442034905
 
 
   Did some research for you:
   
   ```
   C:\Projects\throwaway
   λ cordova create intercomCordovaTest
   Creating a new cordova project.
   
   C:\Projects\throwaway
   λ cd intercomCordovaTest\
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova platform add android
   Using cordova-fetch for cordova-android@~7.1.1
   Adding android project...
   Creating Cordova project for the Android platform:
   Path: platforms\android
   Package: io.cordova.hellocordova
   Name: HelloCordova
   Activity: MainActivity
   Android target: android-27
   Android project created with cordova-android@7.1.4
   Android Studio project detected
   Android Studio project detected
   Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
project
   Installing "cordova-plugin-whitelist" for android
   
  This plugin is only applicable for versions of 
cordova-android greater than 4.0. If you have a previous platform version, you 
do *not* need this plugin since the whitelist will be built in.
   
   Adding cordova-plugin-whitelist to package.json
   Saved plugin info for "cordova-plugin-whitelist" to config.xml
   --save flag or autosave detected
   Saving android@~7.1.4 into config.xml file ...
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova run android
   Android Studio project detected
   ANDROID_HOME=C:\Android
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_121
   studio
   Starting a Gradle Daemon (subsequent builds will be faster)
   
   BUILD SUCCESSFUL in 26s
   1 actionable task: 1 executed
   Subproject Path: CordovaLib
   Subproject Path: app
   Starting a Gradle Daemon (subsequent builds will be faster)
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_8lwuaffh4nuckb10dixq4su2o.run(C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build.gradle:148)
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl
   :CordovaLib:compileDebugRenderscript
   :CordovaLib:checkDebugManifest
   :CordovaLib:generateDebugBuildConfig
   :CordovaLib:prepareLintJar
   :CordovaLib:generateDebugResValues
   :CordovaLib:generateDebugResources
   :CordovaLib:packageDebugResources
   :CordovaLib:platformAttrExtractor
   :CordovaLib:processDebugManifest
   :CordovaLib:javaPreCompileDebug
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild
   :app:compileDebugAidl
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript
   :app:checkDebugManifest
   :app:generateDebugBuildConfig
   :app:prepareLintJar
   :app:generateDebugResValues
   :app:generateDebugResources
   :app:mergeDebugResources
   :app:createDebugCompatibleScreenManifests
   :app:processDebugManifest
   :app:splitsDiscoveryTaskDebug
   :app:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugShaders
   :CordovaLib:processDebugResources
   :CordovaLib:generateDebugSources
   :CordovaLib:compileDebugJavaWithJavacNote: Some input files use or override 
a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug
   :app:processDebugResources
   :app:generateDebugSources
   :app:javaPreCompileDebug
   :app:compileDebugJavaWithJavac
   :app:compileDebugSources
   :CordovaLib:compileDebugShaders
   :CordovaLib:generateDebugAssets
   :CordovaLib:mergeDebugAssets
   :app:mergeDebugShaders
   :app:compileDebugShaders
   :app:generateDebugAssets
   :app:mergeDebugAssets
   :app:transformClassesWithStackFramesFixerForDebug
   :app:transformClassesWithDesugarForDebug
   :app:transformClassesWithDexBuilderForDebug
   :app:transformDexArchiveWithExternalLibsDexMergerForDebug
   :app:transformDexArchiveWithDexMergerForDebug
   :CordovaLib:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugJniLibFolders
   :CordovaLib:transformNativeLibsWithMergeJniLibsForDebug
   :CordovaLib:transformNativeLibsWithIntermediateJniLibsForDebug
   :app:mergeDebugJniLibFolders
   :app:transformNativeLibsWithMergeJniLibsForDebug
   :app:processDebugJavaRes NO-SOURCE
   :app:transformResourcesWithMergeJavaResForDebug
   :app:validateSigningDebug
   :app:packageDebug
   :app:assembleDebug
   :app:cdvBuildDebug
   
   BUILD SUCCESSFUL in 1m 4s
   46 actionable tasks: 46 executed
   Built the following apk(s):
   
C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build\outputs\apk\debug\app-debug.apk
   ANDROID_HOME=C:\Android

[GitHub] janpio edited a comment on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio edited a comment on issue #591: Cordova-plugin-intercom crashing build 
at :app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442034905
 
 
   Did some research for you:
   
   ```
   C:\Projects\throwaway
   λ cordova create intercomCordovaTest
   Creating a new cordova project.
   
   C:\Projects\throwaway
   λ cd intercomCordovaTest\
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova platform add android
   Using cordova-fetch for cordova-android@~7.1.1
   Adding android project...
   Creating Cordova project for the Android platform:
   Path: platforms\android
   Package: io.cordova.hellocordova
   Name: HelloCordova
   Activity: MainActivity
   Android target: android-27
   Android project created with cordova-android@7.1.4
   Android Studio project detected
   Android Studio project detected
   Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
project
   Installing "cordova-plugin-whitelist" for android
   
  This plugin is only applicable for versions of 
cordova-android greater than 4.0. If you have a previous platform version, you 
do *not* need this plugin since the whitelist will be built in.
   
   Adding cordova-plugin-whitelist to package.json
   Saved plugin info for "cordova-plugin-whitelist" to config.xml
   --save flag or autosave detected
   Saving android@~7.1.4 into config.xml file ...
   
   C:\Projects\throwaway\intercomCordovaTest  (helloworld@1.0.0)
   λ cordova run android
   Android Studio project detected
   ANDROID_HOME=C:\Android
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_121
   studio
   Starting a Gradle Daemon (subsequent builds will be faster)
   
   BUILD SUCCESSFUL in 26s
   1 actionable task: 1 executed
   Subproject Path: CordovaLib
   Subproject Path: app
   Starting a Gradle Daemon (subsequent builds will be faster)
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_8lwuaffh4nuckb10dixq4su2o.run(C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build.gradle:148)
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl
   :CordovaLib:compileDebugRenderscript
   :CordovaLib:checkDebugManifest
   :CordovaLib:generateDebugBuildConfig
   :CordovaLib:prepareLintJar
   :CordovaLib:generateDebugResValues
   :CordovaLib:generateDebugResources
   :CordovaLib:packageDebugResources
   :CordovaLib:platformAttrExtractor
   :CordovaLib:processDebugManifest
   :CordovaLib:javaPreCompileDebug
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild
   :app:compileDebugAidl
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript
   :app:checkDebugManifest
   :app:generateDebugBuildConfig
   :app:prepareLintJar
   :app:generateDebugResValues
   :app:generateDebugResources
   :app:mergeDebugResources
   :app:createDebugCompatibleScreenManifests
   :app:processDebugManifest
   :app:splitsDiscoveryTaskDebug
   :app:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugShaders
   :CordovaLib:processDebugResources
   :CordovaLib:generateDebugSources
   :CordovaLib:compileDebugJavaWithJavacNote: Some input files use or override 
a deprecated API.
   Note: Recompile with -Xlint:deprecation for details.
   
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug
   :app:processDebugResources
   :app:generateDebugSources
   :app:javaPreCompileDebug
   :app:compileDebugJavaWithJavac
   :app:compileDebugSources
   :CordovaLib:compileDebugShaders
   :CordovaLib:generateDebugAssets
   :CordovaLib:mergeDebugAssets
   :app:mergeDebugShaders
   :app:compileDebugShaders
   :app:generateDebugAssets
   :app:mergeDebugAssets
   :app:transformClassesWithStackFramesFixerForDebug
   :app:transformClassesWithDesugarForDebug
   :app:transformClassesWithDexBuilderForDebug
   :app:transformDexArchiveWithExternalLibsDexMergerForDebug
   :app:transformDexArchiveWithDexMergerForDebug
   :CordovaLib:compileDebugNdk NO-SOURCE
   :CordovaLib:mergeDebugJniLibFolders
   :CordovaLib:transformNativeLibsWithMergeJniLibsForDebug
   :CordovaLib:transformNativeLibsWithIntermediateJniLibsForDebug
   :app:mergeDebugJniLibFolders
   :app:transformNativeLibsWithMergeJniLibsForDebug
   :app:processDebugJavaRes NO-SOURCE
   :app:transformResourcesWithMergeJavaResForDebug
   :app:validateSigningDebug
   :app:packageDebug
   :app:assembleDebug
   :app:cdvBuildDebug
   
   BUILD SUCCESSFUL in 1m 4s
   46 actionable tasks: 46 executed
   Built the following apk(s):
   
C:\Projects\throwaway\intercomCordovaTest\platforms\android\app\build\outputs\apk\debug\app-debug.apk
   ANDROID_HOME=C:\Android

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442036757
 
 
   Is there a known good combination of cordova-android and plugin versions 
that does work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442047809
 
 
   Hi @janpio, thanks for looking into it. I contacted the company too and they 
should be looking into it. However, in their defense, the plugin was working 
until a couple of days ago. I started encountering the issue around 16th 
November, give and take a day or too. Used to work with the latest cordova and 
and plugin version up till then, I believe being Cordova 8, cordova-android 
7.1.1 and and plugin version 6.1.0.
   
   Re your error being different, the difference is induced when adding the  
cordova-android-support-gradle-release plugin and forcing a dependency of 
support libraries version 27 and upwards.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] mayurala opened a new issue #33: How can i use the CSP for WKWebView

[GitBox]

mayurala opened a new issue #33: How can i use the CSP for WKWebView
URL: https://github.com/apache/cordova-plugin-whitelist/issues/33
 
 
   Can I resolve the CORS issue of WKWebView through whitelist? I have seen a 
certain post where developers have resolved it though CSP or whitelist plugin 
but I am not able to figure out the way to resolve the issue. It would be a 
great help if someone share the solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442053808
 
 
   > I started encountering the issue around 16th November, give and take a day 
or too. Used to work with the latest cordova and and plugin version up till 
then, I believe being Cordova 8, cordova-android 7.1.1 and and plugin version 
6.1.0.
   
   `cordova-android` 7.1.2 was release November 5th - which could possibly 
match your observation. Will look into 7.1.1.
   
   > Re your error being different, the difference is induced when adding the 
cordova-android-support-gradle-release plugin and forcing a dependency of 
support libraries version 27 and upwards.
   
   Can you confirm you get the same error as me without that plugin?
   Or is it actually required for the plugin to work?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #33: How can i use the CSP for WKWebView

[GitBox]

janpio commented on issue #33: How can i use the CSP for WKWebView
URL: 
https://github.com/apache/cordova-plugin-whitelist/issues/33#issuecomment-442054249
 
 
   Please share the post you are talking about.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile closed issue #121: Askin permission when need

[GitBox]

jcesarmobile closed issue #121: Askin permission when need
URL: https://github.com/apache/cordova-plugin-geolocation/issues/121
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] jcesarmobile commented on issue #121: Askin permission when need

[GitBox]

jcesarmobile commented on issue #121: Askin permission when need
URL: 
https://github.com/apache/cordova-plugin-geolocation/issues/121#issuecomment-442055519
 
 
   It should ask when you call the code to get location.
   So as you didn't show your code I'll assume you call it when the app 
initially load and that's why it asks.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] alan-grixti edited a comment on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti edited a comment on issue #591: Cordova-plugin-intercom crashing 
build at :app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442058353
 
 
   > .Can you confirm you get the same error as me without that plugin?
   
   I confirm the error is identical. Posted stacktrace without the plugin below 
   
   > Or is it actually required for the plugin to work?
   
   It is not necessary in this scenario. However, in my main application there 
are plugins introducing dependencies to versions of the support libraries which 
are quite outdated. Hence I had to introduce the plugin to iron dependencies 
out.
   
   ```
   C:\Development\intercom-test>ionic cordova build android
   > ionic-app-scripts build --target cordova --platform android
   [14:26:16]  ionic-app-scripts 3.2.0
   [14:26:16]  build dev started ...
   [14:26:16]  clean started ...
   [14:26:16]  clean finished in 6 ms
   [14:26:16]  copy started ...
   [14:26:16]  deeplinks started ...
   [14:26:16]  deeplinks finished in 23 ms
   [14:26:16]  transpile started ...
   [14:26:20]  transpile finished in 3.79 s
   [14:26:20]  preprocess started ...
   [14:26:20]  preprocess finished in less than 1 ms
   [14:26:20]  webpack started ...
   [14:26:20]  copy finished in 4.04 s
   [14:26:24]  webpack finished in 3.90 s
   [14:26:24]  sass started ...
   [14:26:25]  sass finished in 1.17 s
   [14:26:25]  postprocess started ...
   [14:26:25]  postprocess finished in 7 ms
   [14:26:25]  lint started ...
   [14:26:25]  build dev finished in 9.10 s
   [14:26:28]  lint finished in 2.85 s
   > cordova build android
   Android Studio project detected
   ANDROID_HOME=C:\Users\alan.grixti\AppData\Local\Android\sdk
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_131
   studio
   Subproject Path: CordovaLib
   Subproject Path: app
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   Configuration 'compile' in project ':app' is deprecated. Use 
'implementation' instead.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_56r979vp6x5np7jg8v5k3j1t7.run(C:\Development\intercom-test\platforms\android\app\build.gradle:150)
   Could not find google-services.json while looking in [src/nullnull/debug, 
src/debug/nullnull, src/nullnull, src/debug, src/nullnullDebug]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Could not find google-services.json while looking in [src/nullnull/release, 
src/release/nullnull, src/nullnull, src/release, src/nullnullRelease]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-v4:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-media-compat:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl UP-TO-DATE
   :CordovaLib:compileDebugRenderscript UP-TO-DATE
   :CordovaLib:checkDebugManifest UP-TO-DATE
   :CordovaLib:generateDebugBuildConfig UP-TO-DATE
   :CordovaLib:prepareLintJar UP-TO-DATE
   :CordovaLib:generateDebugResValues UP-TO-DATE
   :CordovaLib:generateDebugResources UP-TO-DATE
   :CordovaLib:packageDebugResources UP-TO-DATE
   :CordovaLib:platformAttrExtractor UP-TO-DATE
   :CordovaLib:processDebugManifest UP-TO-DATE
   :CordovaLib:processDebugResources UP-TO-DATE
   :CordovaLib:generateDebugSources UP-TO-DATE
   :CordovaLib:javaPreCompileDebug UP-TO-DATE
   :CordovaLib:compileDebugJavaWithJavac UP-TO-DATE
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug 
UP-TO-DATE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild UP-TO-DATE
   :app:compileDebugAidl UP-TO-DATE
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript UP-TO-DATE
   :app:checkDebugManifest UP-TO-DATE
   :app:generateDebugBuildConfig UP-TO-DATE
   :app:prepareLintJar UP-TO-DATE
   :app:generateDebugResValues UP-TO-DATE
   :app:generateDebugResources UP-TO-DATE
   :app:processDebugGoogleServices
   Parsing json file: 
C:\Development\intercom-test\platforms\android\app\google-services.json
   :app:mergeDebugResources UP-TO-DATE
   :app:createDebugCompatibleScreenManifests UP-TO-DATE
   :app:processDebugManifest UP-TO-DATE
   :app:splitsDiscoveryTaskDebug UP-TO-DATE
   
C:\Users\alan.grixti\.gradle\caches\transforms-1\files-1.1\appcompat-v7-28.0.0.aar\781a7646a099cfab576de3a8299207a

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442058353
 
 
   > .Can you confirm you get the same error as me without that plugin?
   I confirm the error is identical. Posted stacktrace without the plugin below 
   
   > Or is it actually required for the plugin to work?
   It is not necessary in this scenario. However, in my main application there 
are plugins introducing dependencies to versions of the support libraries which 
are quite outdated. Hence I had to introduce the plugin to iron dependencies 
out.
   
   ```
   C:\Development\intercom-test>ionic cordova build android
   > ionic-app-scripts build --target cordova --platform android
   [14:26:16]  ionic-app-scripts 3.2.0
   [14:26:16]  build dev started ...
   [14:26:16]  clean started ...
   [14:26:16]  clean finished in 6 ms
   [14:26:16]  copy started ...
   [14:26:16]  deeplinks started ...
   [14:26:16]  deeplinks finished in 23 ms
   [14:26:16]  transpile started ...
   [14:26:20]  transpile finished in 3.79 s
   [14:26:20]  preprocess started ...
   [14:26:20]  preprocess finished in less than 1 ms
   [14:26:20]  webpack started ...
   [14:26:20]  copy finished in 4.04 s
   [14:26:24]  webpack finished in 3.90 s
   [14:26:24]  sass started ...
   [14:26:25]  sass finished in 1.17 s
   [14:26:25]  postprocess started ...
   [14:26:25]  postprocess finished in 7 ms
   [14:26:25]  lint started ...
   [14:26:25]  build dev finished in 9.10 s
   [14:26:28]  lint finished in 2.85 s
   > cordova build android
   Android Studio project detected
   ANDROID_HOME=C:\Users\alan.grixti\AppData\Local\Android\sdk
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_131
   studio
   Subproject Path: CordovaLib
   Subproject Path: app
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   Configuration 'compile' in project ':app' is deprecated. Use 
'implementation' instead.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_56r979vp6x5np7jg8v5k3j1t7.run(C:\Development\intercom-test\platforms\android\app\build.gradle:150)
   Could not find google-services.json while looking in [src/nullnull/debug, 
src/debug/nullnull, src/nullnull, src/debug, src/nullnullDebug]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Could not find google-services.json while looking in [src/nullnull/release, 
src/release/nullnull, src/nullnull, src/release, src/nullnullRelease]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-v4:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-media-compat:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl UP-TO-DATE
   :CordovaLib:compileDebugRenderscript UP-TO-DATE
   :CordovaLib:checkDebugManifest UP-TO-DATE
   :CordovaLib:generateDebugBuildConfig UP-TO-DATE
   :CordovaLib:prepareLintJar UP-TO-DATE
   :CordovaLib:generateDebugResValues UP-TO-DATE
   :CordovaLib:generateDebugResources UP-TO-DATE
   :CordovaLib:packageDebugResources UP-TO-DATE
   :CordovaLib:platformAttrExtractor UP-TO-DATE
   :CordovaLib:processDebugManifest UP-TO-DATE
   :CordovaLib:processDebugResources UP-TO-DATE
   :CordovaLib:generateDebugSources UP-TO-DATE
   :CordovaLib:javaPreCompileDebug UP-TO-DATE
   :CordovaLib:compileDebugJavaWithJavac UP-TO-DATE
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug 
UP-TO-DATE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild UP-TO-DATE
   :app:compileDebugAidl UP-TO-DATE
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript UP-TO-DATE
   :app:checkDebugManifest UP-TO-DATE
   :app:generateDebugBuildConfig UP-TO-DATE
   :app:prepareLintJar UP-TO-DATE
   :app:generateDebugResValues UP-TO-DATE
   :app:generateDebugResources UP-TO-DATE
   :app:processDebugGoogleServices
   Parsing json file: 
C:\Development\intercom-test\platforms\android\app\google-services.json
   :app:mergeDebugResources UP-TO-DATE
   :app:createDebugCompatibleScreenManifests UP-TO-DATE
   :app:processDebugManifest UP-TO-DATE
   :app:splitsDiscoveryTaskDebug UP-TO-DATE
   
C:\Users\alan.grixti\.gradle\caches\transforms-1\files-1.1\appcompat-v7-28.0.0.aar\781a7646a099cfab576de3a8299207af\res\values-v2

[GitHub] alan-grixti edited a comment on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti edited a comment on issue #591: Cordova-plugin-intercom crashing 
build at :app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442058353
 
 
   > .Can you confirm you get the same error as me without that plugin?
   
   I confirm the error is identical. Posted stacktrace without the plugin below 
   
   > Or is it actually required for the plugin to work?
   
   It is not necessary in this scenario. However, in my main application there 
are plugins introducing dependencies to versions of the support libraries which 
are quite outdated. Hence I had to introduce the plugin to iron different 
dependencies out.
   
   ```
   C:\Development\intercom-test>ionic cordova build android
   > ionic-app-scripts build --target cordova --platform android
   [14:26:16]  ionic-app-scripts 3.2.0
   [14:26:16]  build dev started ...
   [14:26:16]  clean started ...
   [14:26:16]  clean finished in 6 ms
   [14:26:16]  copy started ...
   [14:26:16]  deeplinks started ...
   [14:26:16]  deeplinks finished in 23 ms
   [14:26:16]  transpile started ...
   [14:26:20]  transpile finished in 3.79 s
   [14:26:20]  preprocess started ...
   [14:26:20]  preprocess finished in less than 1 ms
   [14:26:20]  webpack started ...
   [14:26:20]  copy finished in 4.04 s
   [14:26:24]  webpack finished in 3.90 s
   [14:26:24]  sass started ...
   [14:26:25]  sass finished in 1.17 s
   [14:26:25]  postprocess started ...
   [14:26:25]  postprocess finished in 7 ms
   [14:26:25]  lint started ...
   [14:26:25]  build dev finished in 9.10 s
   [14:26:28]  lint finished in 2.85 s
   > cordova build android
   Android Studio project detected
   ANDROID_HOME=C:\Users\alan.grixti\AppData\Local\Android\sdk
   JAVA_HOME=C:\Program Files\Java\jdk1.8.0_131
   studio
   Subproject Path: CordovaLib
   Subproject Path: app
   publishNonDefault is deprecated and has no effect anymore. All variants are 
now published.
   Configuration 'compile' in project ':app' is deprecated. Use 
'implementation' instead.
   The Task.leftShift(Closure) method has been deprecated and is scheduled to 
be removed in Gradle 5.0. Please use Task.doLast(Action) instead.
   at 
build_56r979vp6x5np7jg8v5k3j1t7.run(C:\Development\intercom-test\platforms\android\app\build.gradle:150)
   Could not find google-services.json while looking in [src/nullnull/debug, 
src/debug/nullnull, src/nullnull, src/debug, src/nullnullDebug]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Could not find google-services.json while looking in [src/nullnull/release, 
src/release/nullnull, src/nullnull, src/release, src/nullnullRelease]
   registerResGeneratingTask is deprecated, use 
registerGeneratedFolders(FileCollection)
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-v4:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   Intercom Android Error:  Build config compile has dependency: 
com.android.support:support-media-compat:26.1.0
   The Intercom SDK requires version 27.x or higher of this dependency.
   Check your plugins to see if any of them are bringing in this dependency
   :CordovaLib:preBuild UP-TO-DATE
   :CordovaLib:preDebugBuild UP-TO-DATE
   :CordovaLib:compileDebugAidl UP-TO-DATE
   :CordovaLib:compileDebugRenderscript UP-TO-DATE
   :CordovaLib:checkDebugManifest UP-TO-DATE
   :CordovaLib:generateDebugBuildConfig UP-TO-DATE
   :CordovaLib:prepareLintJar UP-TO-DATE
   :CordovaLib:generateDebugResValues UP-TO-DATE
   :CordovaLib:generateDebugResources UP-TO-DATE
   :CordovaLib:packageDebugResources UP-TO-DATE
   :CordovaLib:platformAttrExtractor UP-TO-DATE
   :CordovaLib:processDebugManifest UP-TO-DATE
   :CordovaLib:processDebugResources UP-TO-DATE
   :CordovaLib:generateDebugSources UP-TO-DATE
   :CordovaLib:javaPreCompileDebug UP-TO-DATE
   :CordovaLib:compileDebugJavaWithJavac UP-TO-DATE
   :CordovaLib:processDebugJavaRes NO-SOURCE
   :CordovaLib:transformClassesAndResourcesWithPrepareIntermediateJarsForDebug 
UP-TO-DATE
   :app:preBuild UP-TO-DATE
   :app:preDebugBuild UP-TO-DATE
   :app:compileDebugAidl UP-TO-DATE
   :CordovaLib:packageDebugRenderscript NO-SOURCE
   :app:compileDebugRenderscript UP-TO-DATE
   :app:checkDebugManifest UP-TO-DATE
   :app:generateDebugBuildConfig UP-TO-DATE
   :app:prepareLintJar UP-TO-DATE
   :app:generateDebugResValues UP-TO-DATE
   :app:generateDebugResources UP-TO-DATE
   :app:processDebugGoogleServices
   Parsing json file: 
C:\Development\intercom-test\platforms\android\app\google-services.json
   :app:mergeDebugResources UP-TO-DATE
   :app:createDebugCompatibleScreenManifests UP-TO-DATE
   :app:processDebugManifest UP-TO-DATE
   :app:splitsDiscoveryTaskDebug UP-TO-DATE
   
C:\Users\alan.grixti\.gradle\caches\transforms-1\files-1.1\appcompat-v7-28.0.0.aar\781a7646a099cfab576de

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442068882
 
 
   Hm, I can't build with 7.1.1 and the plugin as well, same errors.
   
   Maybe something to do with Android tooling?
   
   
https://stackoverflow.com/questions/49280632/error9-5-error-resource-androidattr-dialogcornerradius-not-found
 possibly?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #588: 7.1.4 defaults to android-27

[GitBox]

brodybits commented on issue #588: 7.1.4 defaults to android-27
URL: https://github.com/apache/cordova-android/issues/588#issuecomment-442079692
 
 
   @maurocolella what you see in `build.gradle` are *default* values. You 
should see the correct values in the `uses-sdk` element in 
`platforms/android/app/src/main/AndroidManifest.xml`.
   
   When I tried with the recommended preferences along with 
`cordova-plugin-crosswalk-webview`, I got 
`platforms/android/app/src/main/AndroidManifest.xml` with the correct values:
   
   ```xml
   
   ```
   
   In case you continue to see an issue a demo project would be really helpful.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442089059
 
 
   Technically it could be it I presume. However that is something completely 
related to the plugin right? I went through the plugins and intercom itself has 
`v27.+`. That should not resort to `v28` of the library right? As described 
[here](https://github.com/dpa99c/cordova-android-support-gradle-release), they 
should stick to the most recent release of v27, being `27.1.0`, not skipping to 
the next version.  The interesting thing is that the build tools still requests 
some things out of `v28` of the support libraries. It's as if the latest 
version is being retrieved 
   
   For reference, please see the below gradle definitions
   
   ```
   dependencies {
   classpath 'com.android.tools.build:gradle:2.3.+'
   if (pushType == 'fcm') {
   classpath 'com.google.gms:google-services:3.2.0'
   }
   }
   ```
   ```
   def safeVersions = [
   "com.android.support:support-v4": "27.+"
   ]
   ```
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] boynet opened a new issue #356: documenting the custom schemes handling

[GitBox]

boynet opened a new issue #356: documenting the custom schemes handling
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/356
 
 
   I am not native english so I cant create a pr for this, but we need to 
documente the lastest changes in custom schemes handling 
(https://github.com/apache/cordova-plugin-inappbrowser/pull/263 and 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274)
   
   the things to document:
   for example to allow whatsapp custom scheme and twitter
   + add new config.xml preference with the custom schemes you want to support:
   ```
   `
   ```
   + add event listeners customscheme:
   ```
   inAppBrowserRef..addEventListener('customscheme', function (event) {
   //do whatever you want here like:
window.open(event.url, "_system");
   });
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

janpio commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442093094
 
 
   Yep, that's where I am out: I never understood that gradle dependency 
version stuff, sorry. 
   
   But if it happens with a vanilla Cordova project (create with `cordova 
create`) and all recent platform versions (that used to work with the plugin!) 
it has to be something in the other variables, and the Android SDK / tools are 
the most probably one. Intercom should be able to reproduce the issue quickly 
as well this way and hopefully understand better what the error message refers 
to.
   
   It definitely has nothing to do with `cordova-android` though, unless it 
uncovered a previously undetected bug ;) 
   
   My advise: Post this on StackOverflow (with the vanilla Cordova app, not 
your Ionic app) and try to get Intercom to help. Good luck, please report back 
when it is solved somehow 💯 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #356: documenting the custom schemes handling

[GitBox]

janpio commented on issue #356: documenting the custom schemes handling
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/issues/356#issuecomment-442093692
 
 
   Thanks @boynet, seems like a reasonable thing to do. Where would you put 
those in the README/documentation? Feel free to open a new PR even with 
imperfect English, we can iterate on the wording with suggestions and comments!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at :app:transformClassesWithDesugarForDebug

[GitBox]

alan-grixti commented on issue #591: Cordova-plugin-intercom crashing build at 
:app:transformClassesWithDesugarForDebug
URL: https://github.com/apache/cordova-android/issues/591#issuecomment-442102839
 
 
   Thanks a lot @janpio . Yes sure, with great pleasure. Will let you guys know 
whatever the outcome is :) :D


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #588: 7.1.4 defaults to android-27

[GitBox]

dpogue commented on issue #588: 7.1.4 defaults to android-27
URL: https://github.com/apache/cordova-android/issues/588#issuecomment-442117295
 
 
   I'll just note here that Cordova-Android 7.x is not compatible with the 
Android API 28 build tools, so you might run into issues trying to target them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #72: npm test fixes

[GitBox]

brodybits opened a new pull request #72: npm test fixes
URL: https://github.com/apache/cordova-osx/pull/72
 
 
   * add test:objc to npm test script
   * test:coverage separated from npm test script to npm cover script
   * separate npm run cover step in .travis.yml
   
   (more consistent with cordova-ios)
   
   Travis CI is passing for these changes on my fork 
()
   
   part of "set up CI" (#71)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #73: More verbose test reporter

[GitBox]

brodybits opened a new pull request #73: More verbose test reporter
URL: https://github.com/apache/cordova-osx/pull/73
 
 
   thanks to @raphinesse 
()
   
   Travis CI passes for these changes in my own fork 
().


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-plugin-vibration] branch janpio-remove_translations created (now eb7cc63)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-remove_translations
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git.


  at eb7cc63  remove outdated translations of README

This branch includes the following new commits:

 new eb7cc63  remove outdated translations of README

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-plugin-vibration] 01/01: remove outdated translations of README

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-remove_translations
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git

commit eb7cc6357880a7c0162660a319d4ba0780138f72
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 17:57:42 2018 +0100

remove outdated translations of README
---
 doc/de/README.md | 190 ---
 doc/de/index.md  | 184 -
 doc/es/README.md | 189 --
 doc/es/index.md  | 165 ---
 doc/fr/README.md | 171 -
 doc/fr/index.md  | 165 ---
 doc/it/README.md | 190 ---
 doc/it/index.md  | 184 -
 doc/ja/README.md | 190 ---
 doc/ja/index.md  | 184 -
 doc/ko/README.md | 190 ---
 doc/ko/index.md  | 184 -
 doc/pl/README.md | 190 ---
 doc/pl/index.md  | 184 -
 doc/ru/index.md  | 170 -
 doc/zh/README.md | 190 ---
 doc/zh/index.md  | 184 -
 17 files changed, 3104 deletions(-)

diff --git a/doc/de/README.md b/doc/de/README.md
deleted file mode 100644
index 42340eb..000
--- a/doc/de/README.md
+++ /dev/null
@@ -1,190 +0,0 @@
-
-
-# cordova-plugin-vibration
-
-[![Build 
Status](https://travis-ci.org/apache/cordova-plugin-vibration.svg)](https://travis-ci.org/apache/cordova-plugin-vibration)
-
-Dieses Plugin richtet mit dem W3C Vibration Spezifikation 
http://www.w3.org/TR/vibration/
-
-Dieses Plugin bietet eine Möglichkeit, das Gerät zu vibrieren.
-
-Dieses Plugin definiert globale Objekte einschließlich `navigator.vibrate`.
-
-Obwohl im globalen Gültigkeitsbereich, sind sie nicht bis nach dem 
`deviceready`-Ereignis.
-
-document.addEventListener("deviceready", onDeviceReady, false);
-function onDeviceReady() {
-console.log(navigator.vibrate);
-}
-
-
-## Installation
-
-cordova plugin add cordova-plugin-vibration
-
-
-## Unterstützte Plattformen
-
-navigator.vibrate,  
-navigator.notification.vibrate - Amazon Fire OS - Android - BlackBerry 10 - 
Firefox OS - iOS - Windows Phone 7 and 8 - Windows (Windows Phone 8.1 devices 
only)
-
-navigator.notification.vibrateWithPattern  
-navigator.notification.cancelVibration - Android - Windows Phone 8 - Windows 
(Windows Phone 8.1 devices only)
-
-## vibrieren (empfohlen)
-
-Diese Funktion hat drei verschiedene Funktionalitäten, die auf der Grundlage 
von an sie übergebenen Parameter.
-
-### Standard vibrieren
-
-Vibriert das Gerät für einen bestimmten Zeitraum.
-
-navigator.vibrate(time)
-
-
-oder
-
-navigator.vibrate([time])
-
-
--**time**: Millisekunden das Gerät vibriert. *(Anzahl)*
-
- Beispiel
-
-// Vibrate for 3 seconds
-navigator.vibrate(3000);
-
-// Vibrate for 3 seconds
-navigator.vibrate([3000]);
-
-
- iOS Macken
-
-  * **Zeit**: ignoriert die angegebene Zeit und für eine voreingestellte Zeit 
vibriert.
-
-navigator.vibrate(3000); // 3000 is ignored
-
- Windows und Blackberry-Kniffe
-
-  * **Zeit**: Max. Zeit 5000ms (5 s) und min Zeit ist 1ms
-
-navigator.vibrate(8000); // will be truncated to 5000
-
-### Vibrieren Sie mit einem Muster (Android und Windows nur)
-
-Vibriert das Gerät mit einem vorgegebenen Muster
-
-navigator.vibrate(pattern);   
-
-
-  * **Muster**: Folge von Dauer (in Millisekunden) für den ein-oder 
Ausschalten der Vibrator. *(Array von Zahlen)*
-
- Beispiel
-
-// Vibrate for 1 second
-// Wait for 1 second
-// Vibrate for 3 seconds
-// Wait for 1 second
-// Vibrate for 5 seconds
-navigator.vibrate([1000, 1000, 3000, 1000, 5000]);
-
-
- Windows Phone 8 Macken
-
-  * vibrate(Pattern) fällt zurück vibrieren auf mit Standarddauer
-
- Windows-Eigenheiten
-
-  * vibrate(Pattern) fällt zurück vibrieren auf mit Standarddauer
-
-### "Abbrechen" Vibration (nicht in iOS unterstützt)
-
-Sofort bricht alle derzeit ausgeführten Schwingungen.
-
-navigator.vibrate(0)
-
-
-oder
-
-navigator.vibrate([])
-
-
-oder
-
-navigator.vibrate([0])
-
-
-Übergabe eines Parameters 0, wird ein leeres Array, oder ein Array mit einem 
Element der Wert 0 auftretender Schwingungen abbrechen.
-
-## *Notification.Vibrate (veraltet)
-
-Vibriert das Gerät für einen bestimmten Zeitrau

[GitHub] gandhirajan commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

[GitBox]

gandhirajan commented on issue #159: mobile-spec project creation fails with 
error "Cannot find module 'cordova-common'"
URL: 
https://github.com/apache/cordova-mobile-spec/issues/159#issuecomment-442135183
 
 
   @janpio I just checked out all the repos to a root folder using coho repo 
update. In the mobile-spec project, I did 'npm install cordova-common'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #74: Fix Travis CI on 4.0.x branch

[GitBox]

brodybits opened a new pull request #74: Fix Travis CI on 4.0.x branch
URL: https://github.com/apache/cordova-osx/pull/74
 
 
   Combination of changes needed for Travis CI to pass on 4.0.x branch
   
   needed before we enable Travis CI (#71)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #72: npm test fixes

[GitBox]

brodybits closed pull request #72: npm test fixes
URL: https://github.com/apache/cordova-osx/pull/72
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 09f5ab7d..97c8f160 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,3 +19,4 @@ script:
   - node --version
   - npm --version
   - npm test
+  - npm run cover
diff --git a/package.json b/package.json
index a65e..361247b9 100644
--- a/package.json
+++ b/package.json
@@ -15,7 +15,8 @@
 "cordova:platform"
   ],
   "scripts": {
-"test": "npm run eslint && npm run test:coverage",
+"cover": "npm run test:coverage",
+"test": "npm run eslint && npm run test:component && npm run test:objc",
 "test:objc": "jasmine  --config=tests/spec/objc.json",
 "test:component": "jasmine --config=tests/spec/component.json",
 "test:coverage": "nyc jasmine --config=tests/spec/coverage.json",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch master updated: npm test fixes (#72)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git


The following commit(s) were added to refs/heads/master by this push:
 new 5a5887f  npm test fixes (#72)
5a5887f is described below

commit 5a5887f09191fe3356a9f70cea02c338180d25a0
Author: Chris Brody 
AuthorDate: Tue Nov 27 12:09:05 2018 -0500

npm test fixes (#72)

* add test:objc to npm test script
* test:coverage separated from npm test script to npm cover script
* separate npm run cover step in .travis.yml

(more consistent with cordova-ios)
---
 .travis.yml  | 1 +
 package.json | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 09f5ab7..97c8f16 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -19,3 +19,4 @@ script:
   - node --version
   - npm --version
   - npm test
+  - npm run cover
diff --git a/package.json b/package.json
index a65..361247b 100644
--- a/package.json
+++ b/package.json
@@ -15,7 +15,8 @@
 "cordova:platform"
   ],
   "scripts": {
-"test": "npm run eslint && npm run test:coverage",
+"cover": "npm run test:coverage",
+"test": "npm run eslint && npm run test:component && npm run test:objc",
 "test:objc": "jasmine  --config=tests/spec/objc.json",
 "test:component": "jasmine --config=tests/spec/component.json",
 "test:coverage": "nyc jasmine --config=tests/spec/coverage.json",


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new pull request #69: remove outdated translations of README

[GitBox]

janpio opened a new pull request #69: remove outdated translations of README
URL: https://github.com/apache/cordova-plugin-vibration/pull/69
 
 
   remove 4 year old outdated translations


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-plugin-vibration] branch janpio-remove_translations updated (eb7cc63 -> c97e0f6)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-remove_translations
in repository https://gitbox.apache.org/repos/asf/cordova-plugin-vibration.git.


 discard eb7cc63  remove outdated translations of README
 add 46d7db8  CB-13892:(all) Remove navigator.notification
 add 06e9aa4  Merge pull request #67 from jcesarmobile/CB-13892
 add 930b91d  CB-14022: documented android quirk with vibration
 add 0b32340  CB-14030 Updated version and RELEASENOTES.md for release 
3.1.0 (via coho)
 add 6aac0d1  Set VERSION to 3.1.1-dev (via coho)
 add 8c8d701  also accept terms for android sdk `android-27`
 add cf784f5  remove JIRA link
 add b7c719b  Improve syntax highlighting in docs (#68)
 add c97e0f6  remove outdated translations of README

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (eb7cc63)
\
 N -- N -- N   refs/heads/janpio-remove_translations (c97e0f6)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 .travis.yml  |  2 +-
 README.md| 94 ++--
 RELEASENOTES.md  |  4 +++
 package.json |  2 +-
 plugin.xml   |  6 +---
 tests/plugin.xml |  2 +-
 tests/tests.js   | 77 --
 7 files changed, 58 insertions(+), 129 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #73: [WIP] More verbose test reporter

[GitBox]

brodybits commented on issue #73: [WIP] More verbose test reporter
URL: https://github.com/apache/cordova-osx/pull/73#issuecomment-442141609
 
 
   Marked [WIP] pending rebase on master, with Travis CI enabled (#71).
   
   I would like to wait until Travis CI is enabled before rebasing to get a 
green PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio opened a new issue #70: No automated tests

[GitBox]

janpio opened a new issue #70: No automated tests
URL: https://github.com/apache/cordova-plugin-vibration/issues/70
 
 
   The tests in `tests/tests.js` are all manual tests, on CI _nothing_ is 
executed as a result.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] boynet commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

[GitBox]

boynet commented on issue #263: CB-14013: (android) Change the InAppBrowser to 
allow custom schemes for oAuth
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-442143355
 
 
   I started testing it and I ran into bug, the event only working on the first 
time so a page with this simple html loaded into inAppBrowser:
   ```
   config:
   
   
   html:
   
   
   click to send
   
   
   
   event:
   inAppBrowser.addEventListener('customscheme', function (event) {
   console.log(event);
   });
   ```
   
   the first click everything is fine, the second click no longer trigger the 
event


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #71: Set up CI

[GitBox]

brodybits commented on issue #71: Set up CI
URL: https://github.com/apache/cordova-osx/issues/71#issuecomment-442144059
 
 
   Once #74 is reviewed and merged this should become an INFRA request.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #159: mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

[GitBox]

janpio commented on issue #159: mobile-spec project creation fails with error 
"Cannot find module 'cordova-common'"
URL: 
https://github.com/apache/cordova-mobile-spec/issues/159#issuecomment-442147152
 
 
   Please install a new node version (to make sure there are not more global 
tools installed), create a new "Cordova" folder, use coho to check out all 
repositories there, then create a new mobile-spec project. Report each problem 
you encounter please and document _all_ the commands you run. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on issue #263: CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

[GitBox]

janpio commented on issue #263: CB-14013: (android) Change the InAppBrowser to 
allow custom schemes for oAuth
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/263#issuecomment-442148534
 
 
   Can you please create a new issue @boynet? This will be forgotten here, just 
link to the PR in your description for context. Thanks for taking the time to 
report this!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 04/04: better docs for externalServerUrl

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 5e2d055c6fef39fc788d0fd43c3d5c255d88a271
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:01:54 2018 +0100

better docs for externalServerUrl
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index cf4a6d1..1a66e25 100644
--- a/README.md
+++ b/README.md
@@ -121,7 +121,7 @@ cordova-paramedic --platform ios --plugin 
cordova-plugin-inappbrowser --justbuil
 
  `--externalServerUrl` (optional)
 
-Useful when testing on real device (`--device` parameter) so that tests 
results from device could be posted back to paramedic server.
+Useful when testing on real device (`--target` or `--device` parameter) so 
that tests results from device could be posted back to paramedic server. 
Caution: You have to include the 
 
 ```
 cordova-paramedic --platform ios --plugin cordova-plugin-inappbrowser 
--externalServerUrl http://10.0.8.254


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] branch janpio-readme created (now 5e2d055)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git.


  at 5e2d055  better docs for externalServerUrl

This branch includes the following new commits:

 new 0be1866  Improve readme (WIP)
 new 51cef2b  better intro
 new 2c951df  more steps of what it does
 new 5e2d055  better docs for externalServerUrl

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 02/04: better intro

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 51cef2babf327b6f7d06dda29892186e46d274ee
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:01:31 2018 +0100

better intro
---
 README.md | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/README.md b/README.md
index e251c0f..9cbaadf 100644
--- a/README.md
+++ b/README.md
@@ -3,12 +3,11 @@
 
 > Paramedic • _noun_ provides advanced levels of care at the point of illness 
 > or injury, including out of hospital treatment, and diagnostic services
 
-
 # Cordova Paramedic (Test Automation)
 
-`cordova-paramedic` is a tool to automate testing of Cordova plugins.
+`cordova-paramedic` is a tool to automate execution of Cordova plugins tests 
(via 
[`cordova-plugin-test-framework`](https://github.com/apache/cordova-plugin-test-framework)).
 
-You can use Paramedic to build and run a Cordova app with tests, run these 
tests on local and remote emulators (currently supported providers: [Sauce 
Labs](https://saucelabs.com/)) and report the results. It can be used on a 
local or on a Continuous Integration environment.
+You can use Paramedic to build and run a Cordova app with plugin tests, run 
these tests on local and remote emulators (currently supported providers: 
[Sauce Labs](https://saucelabs.com/)) and report the results. It can be used on 
a local or on a Continuous Integration environment.
 
 It is currently used to automatically run all plugin tests on CI.
 


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 03/04: more steps of what it does

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 2c951dfc2587f2e1015e96328576a2fb465f1093
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:01:42 2018 +0100

more steps of what it does
---
 README.md | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 9cbaadf..cf4a6d1 100644
--- a/README.md
+++ b/README.md
@@ -38,8 +38,10 @@ A typical Paramedic run will:
 1. Add the platform to be tested with `cordova platform add ...`
 1. Confirm the requirements for that platform are met with `cordova 
requirements ...`
 1. Start a local "medic" server
-1. Start a local Android emulator or use a running one (`--target` param)
-1. 
+1. Start a local Android emulator or use a connected device (`--target` param)
+1. Start the app on the device (`cordova run ...`)
+1. Run the tests
+1. Wait for the results to be posted back
 
 
 If running for Sauce Labs:


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 01/04: Improve readme (WIP)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-readme
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 0be186698ec34fe4054d908f7f0b6bfc56498e01
Author: Jan Piotrowski 
AuthorDate: Sat Nov 24 18:37:22 2018 +0100

Improve readme (WIP)
---
 README.md | 97 ---
 1 file changed, 74 insertions(+), 23 deletions(-)

diff --git a/README.md b/README.md
index 50b522b..e251c0f 100644
--- a/README.md
+++ b/README.md
@@ -1,36 +1,90 @@
-# cordova-paramedic
+[![Build 
Status](https://travis-ci.org/apache/cordova-paramedic.svg?branch=master)](https://travis-ci.org/apache/cordova-paramedic)
+[![Build 
status](https://ci.appveyor.com/api/projects/status/iufmfjo0j0dd4c1w?svg=true)](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-paramedic)
 
 > Paramedic • _noun_ provides advanced levels of care at the point of illness 
 > or injury, including out of hospital treatment, and diagnostic services
 
-[![Build 
Status](https://travis-ci.org/apache/cordova-paramedic.svg?branch=master)](https://travis-ci.org/apache/cordova-paramedic)
-[![Build 
status](https://ci.appveyor.com/api/projects/status/iufmfjo0j0dd4c1w?svg=true)](https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-paramedic)
 
-Runs cordova medic/buildbot tests locally.
+# Cordova Paramedic (Test Automation)
+
+`cordova-paramedic` is a tool to automate testing of Cordova plugins.
+
+You can use Paramedic to build and run a Cordova app with tests, run these 
tests on local and remote emulators (currently supported providers: [Sauce 
Labs](https://saucelabs.com/)) and report the results. It can be used on a 
local or on a Continuous Integration environment.
+
+It is currently used to automatically run all plugin tests on CI.
 
 See this [workshop instructions for more 
explanation](https://kerrishotts.github.io/pgday/workshops/2017/campp/testing.html#cordova-paramedic).
 
+TODO paramedic server!?
+
 ## Supported Cordova Platforms
 
 - Android
 - iOS
-- Windows (Windows 8.1, Windows 10 UWP phone,tablet,desktop)
+- Windows Phone 8
+- Windows (Windows 8.1, Windows Phone 8.1, Windows 10 Tablet/PC)
 - Browser
 - OSX
 
-# Installation
+## What?
+
+A typical Paramedic run will:
+
+1. Create a temporary Cordova project with `cordova create`
+1. Install various plugins with `cordova plugin add ...`:
+- the plugin to be tested (e.g. `cordova-plugin-inappbrowser`)
+- the tests of this plugin (e.g. `cordova-plugin-inappbrowser\tests`)
+- `cordova-plugin-test-framework` (from npm)
+- local `paramedic-plugin`
+1. Update the app start page to the test page at `cdvtests/index.html` 
(provided by `cordova-plugin-test-framework` and the plugin tests)
+1. Add the platform to be tested with `cordova platform add ...`
+1. Confirm the requirements for that platform are met with `cordova 
requirements ...`
+1. Start a local "medic" server
+1. Start a local Android emulator or use a running one (`--target` param)
+1. 
+
+
+If running for Sauce Labs:
+- Step 7 is skipped, remote emulators will be used
+- 
+
+```
+$ cordova create C:\Users\Jan\AppData\Local\Temp\tmp-50936Js2WU3pm4Qn6 
--no-telemetry --no-update-notifier
+$ cordova plugin add 
C:\Users\Jan\AppData\Local\Temp\tmp-50936Js2WU3pm4Qn6\plugins\cordova-plugin-inappbrowser\tests
 --no-telemetry --no-update-notifier
+$ cordova plugins --no-telemetry --no-update-notifier
+cordova-paramedic: installing cordova-plugin-test-framework --no-telemetry 
--no-update-notifier
+$ cordova plugin add cordova-plugin-test-framework --no-telemetry 
--no-update-notifier
+$ cordova platform add android --no-telemetry --no-update-notifier
+
+
+local-server: scanning ports from 7008 to 7208
+local-server: port 7030 is available
+local-server: starting local medic server
+cordova-paramedic: writing medic log url to project http://10.0.2.2:7030
+Start running tests at 5:33:13 PM
+cordova-paramedic: Choosing Target for Android
+cordova-paramedic: Starting an Android emulator
 
-``` $npm install cordova-paramedic ```
 
-# Usage
 
-Paramedic parameters could be passed via command line arguments or via 
separate configuration file:
+## Installation
+
+```
+npm install -g cordova-paramedic
+// or
+git clone https://github.com/apache/cordova-paramedic
+// when cloning, you have to replace all `cordova-paramedic` occurencey below 
with `cordova-paramedic/main.js`
+```
+
+## Usage
+
+Paramedic parameters can be passed via command line arguments or via separate 
configuration file:
 
 ```
 cordova-paramedic --platform PLATFORM --plugin PATH 
 cordova-paramedic --config ./sample-config/.paramedic.config.js
 ```
 
-## Command Line Interface
+### Command Line Interface
 
  `--platform` (required)
 
@@ -45,7 +99,7 @@ cordova-paramedic --platform 
ios@https://github.com/apache/cordova-ios.git#4.1.0
 
  `--plugin` (required)
 
-Specifies test plugin, you may specify multipl

[cordova-paramedic] 05/05: gitignore package-lock.json

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 9a617d6add19ecaf5d2bebedfe5295323c1e7ffb
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:08:28 2018 +0100

gitignore package-lock.json
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 900c1cd..57529f2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,3 +5,4 @@ npm-debug.log
 tmp/
 node_modules/
 .vscode/
+package-lock.json


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 01/05: 0.6.0-dev

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 1e699a4a2cfc44c844be13cd68febd7681831a06
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:07:29 2018 +0100

0.6.0-dev
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index ae23186..5b9fda4 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "cordova-paramedic",
-  "version": "0.5.0",
   "license": "Apache 2.0",
+  "version": "0.6.0-dev",
   "description": "Use medic to test a cordova plugin locally",
   "main": "paramedic.js",
   "bin": {


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 04/05: output where logfiles are written to

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit aea5e1ef53f851106f8194669ecd36d7bef92b0d
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:07:58 2018 +0100

output where logfiles are written to
---
 lib/ParamedicLog.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/ParamedicLog.js b/lib/ParamedicLog.js
index 1f33173..0cb159b 100644
--- a/lib/ParamedicLog.js
+++ b/lib/ParamedicLog.js
@@ -93,6 +93,7 @@ ParamedicLog.prototype.generateLogs = function (logCommand) {
 
 try {
 fs.writeFileSync(logFile, result.output);
+logger.info('Logfiles written to ' + logFile);
 } catch (ex) {
 logger.error('Cannot write the log results to the file. ' + ex);
 }


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 02/05: fix license

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 0baf75db31adb8639540a14f9576807f095b8be7
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:07:38 2018 +0100

fix license
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 5b9fda4..f32ccae 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "cordova-paramedic",
-  "license": "Apache 2.0",
   "version": "0.6.0-dev",
+  "license": "Apache-2.0",
   "description": "Use medic to test a cordova plugin locally",
   "main": "paramedic.js",
   "bin": {


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] 03/05: replace author

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git

commit 3819786acbc8b63a02dd1811f31073dbad814ddc
Author: Jan Piotrowski 
AuthorDate: Tue Nov 27 19:07:45 2018 +0100

replace author
---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index f32ccae..778982c 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
 "medic",
 "test"
   ],
-  "author": "Jesse MacFadyen",
+  "author": "Apache Software Foundation",
   "dependencies": {
 "cordova-common": "^1.1.0",
 "expect-telnet": "^0.5.2",


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-paramedic] branch janpio-misc updated (8efb65d -> 9a617d6)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-misc
in repository https://gitbox.apache.org/repos/asf/cordova-paramedic.git.


from 8efb65d  some comments what the script is doing
 new 1e699a4  0.6.0-dev
 new 0baf75d  fix license
 new 3819786  replace author
 new aea5e1e  output where logfiles are written to
 new 9a617d6  gitignore package-lock.json

The 5 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore  | 1 +
 lib/ParamedicLog.js | 1 +
 package.json| 6 +++---
 3 files changed, 5 insertions(+), 3 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio closed pull request #148: remove deprecated platforms

[GitBox]

janpio closed pull request #148: remove deprecated platforms
URL: https://github.com/apache/cordova-mobile-spec/pull/148
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-mobile-spec] branch janpio-remove_deprecated deleted (was 4b32bc0)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-remove_deprecated
in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git.


 was 4b32bc0  remove deprecated platforms

The revisions that were on this branch are still contained in
other references; therefore, this change does not discard any commits
from the repository.


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-mobile-spec] branch master updated (e4b0a23 -> 8f8304f)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git.


from e4b0a23  known quirks&issues in createmobilespec/README.md (#147)
 add 8f8304f  remove deprecated platforms (#148)

No new revisions were added by this update.

Summary of changes:
 createmobilespec/createmobilespec.js | 25 -
 1 file changed, 4 insertions(+), 21 deletions(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-osx] branch 4.0.x updated: .travis.yml fixes for 4.0.x branch (#74)

[brodybits]

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch 4.0.x
in repository https://gitbox.apache.org/repos/asf/cordova-osx.git


The following commit(s) were added to refs/heads/4.0.x by this push:
 new b967c2a  .travis.yml fixes for 4.0.x branch (#74)
b967c2a is described below

commit b967c2a0f08dc28ce205cb280cdb1fd70fcb2364
Author: Chris Brody 
AuthorDate: Tue Nov 27 13:28:12 2018 -0500

.travis.yml fixes for 4.0.x branch (#74)

* Add Node 10 ... (.travis.yml fixes for Node.js 6, 8, and 10) (#53)
* Added Travis CI OSX Image and Install cordova@latest (#59)
* .travis.yml cover deprecated Node.js 4 (4.0.x branch *only*)

Co-authored-by: エリス 
Co-authored-by: Christopher J. Brody 
---
 .travis.yml | 21 +++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index b151b0b..b23439c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,5 +1,22 @@
 language: objective-c
+osx_image: xcode9.4
 sudo: false
+
+env:
+  matrix:
+- TRAVIS_NODE_VERSION: '4'
+- TRAVIS_NODE_VERSION: '6'
+- TRAVIS_NODE_VERSION: '8'
+- TRAVIS_NODE_VERSION: '10'
+
+before_install:
+  - nvm install $TRAVIS_NODE_VERSION
+
 install:
-- npm install
-script: "npm test"
\ No newline at end of file
+  - npm install -g cordova@latest
+  - npm install
+
+script:
+  - node --version
+  - npm --version
+  - npm test


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits closed pull request #74: Fix Travis CI on 4.0.x branch

[GitBox]

brodybits closed pull request #74: Fix Travis CI on 4.0.x branch
URL: https://github.com/apache/cordova-osx/pull/74
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index b151b0b0..b23439cf 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,5 +1,22 @@
 language: objective-c
+osx_image: xcode9.4
 sudo: false
+
+env:
+  matrix:
+- TRAVIS_NODE_VERSION: '4'
+- TRAVIS_NODE_VERSION: '6'
+- TRAVIS_NODE_VERSION: '8'
+- TRAVIS_NODE_VERSION: '10'
+
+before_install:
+  - nvm install $TRAVIS_NODE_VERSION
+
 install:
-- npm install
-script: "npm test"
\ No newline at end of file
+  - npm install -g cordova@latest
+  - npm install
+
+script:
+  - node --version
+  - npm --version
+  - npm test


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #211: Remove deprecated repos from repo-update

[GitBox]

brodybits opened a new issue #211: Remove deprecated repos from repo-update
URL: https://github.com/apache/cordova-coho/issues/211
 
 
   For example: remove references to `amazon-fireos`, `bada`, `blackberry`, 
`ubuntu`, `firefoxos`, `qt`, `tizen`, `webos`, `wp8` platforms from sources 
such as:
   - `src/platform-release.js`
   - `src/repo-update.js`
   - `src/repoutil.js`
   - `src/versionutil.js`
   - `test/flagutil.test.js`
   
   Need to investigate if any other packages may be deprecated.
   
   related: 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236806921
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -489,31 +495,32 @@ if (argv.plugman) {
 } else {
 // Create the project using "cordova create"
 myDelete(cli_project_dir);
-console.log("Creating project mobilespec...");
-shelljs.exec(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
+console.log("### Creating project mobilespec...");
+executeShellCommand(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
 shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'), 
path.join(projectDirName, 'config.xml'));
 
 // Config.json file ---> linked to local libraries
 pushd(cli_project_dir);
 
 // Executing platform Add
-console.log("Adding platforms...");
+console.log("### Adding platforms...");
 [].concat(platforms).forEach(function (platform) {
-console.log("Adding Platform: " + platform);
+console.log("### Adding Platform: " + platform);
 var platformArg;
 if (argv.global) {
 platformArg = platform;
 } else {
 platformArg = 
join_paths([top_dir].concat(platform_layout[platform].bin));
 if (!fs.existsSync(platformArg)) {
-couldNotFind(platformArg, platform);
+couldNotFind(platform, platform);
 
 Review comment:
   ```suggestion
   couldNotFind(platform);
   ```
   
   2nd argument is not needed if same as the first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236807686
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -71,7 +71,12 @@ function pluginAdd(pluginName, searchPath, extraFlags) {
 if (extraFlags) {
 command += extraFlags;
 }
-shelljs.exec(command);
+executeShellCommand(command);
+}
+
+function executeShellCommand(command) {
+console.log('$ ' + command);
+return shelljs.exec(command);
 
 Review comment:
   ```suggestion
   shelljs.exec(command);
   ```
   
   I _think_ returning the result of `shelljs.exec()` call would be useless.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236810474
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -130,7 +135,7 @@ var top_dir = process.cwd() + path.sep,
.boolean("windows").describe("windows", "Add Windows 
(universal) platform.")
.boolean("wp8").describe("wp8", "Add Windows Phone 8 
platform.")
.boolean("firefoxos").describe("firefoxos", "Add FirefoxOS 
platform.")
-   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.")
+   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.") // TODO Why 
would one want to do that?
 
 Review comment:
   I think this question should be sent to , does not 
belong here.
   
   My understanding is that `plugman` came before the more fancy Cordova CLI, 
and some people may not want to use the more advanced Cordova CLI. And I am now 
starting to wonder if developers could use plugman to add plugins when 
embedding Cordova in an existing mobile app?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236811746
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -153,11 +158,11 @@ var top_dir = process.cwd() + path.sep,
.boolean("linkplatforms").describe("linkplatforms", "Use 
the --link flag when running `cordova platform add`.\n")
.boolean("link").describe("link", "Alias for --linkplugins 
--linkplatforms.\n")
.boolean("browserify").describe("browserify", "Use the 
--browserify flag when running `cordova plugin add`.\n")
-   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n")
-   .boolean("cprplugins").describe("cprplugins", "Adds a bunch 
of known-to-be-popular plugins from Cordova Plugin Regsitry.\n")
-   .boolean("plugregplugins").describe("cprplugins", "Adds a 
bunch of known-to-be-popular plugins from PlugReg (that are not on the CPR).\n")
-   .boolean("thirdpartyplugins").describe("thirdpartyplugins", 
"Alias for --telerikplugins --cprplugins --plugregplugins.\n")
-   .string("webview").describe("webview", "Use 
--webview=crosswalk to install the crosswalk plugin")
+   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n") // 
TODO
 
 Review comment:
   I think these can be removed, would favor we do this in a separate PR for 
clean separation of review & discussion.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236812441
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -227,6 +232,7 @@ var DEFAULT_PLUGINS = [
 'cordova-plugin-statusbar',
 'cordova-plugin-vibration',
 'cordova-plugin-whitelist',
+// TODO check if all are listed
 
 Review comment:
   I would raise a new issue to track this TODO item.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new issue #171: Cleanup third-party plugins

[GitBox]

brodybits opened a new issue #171: Cleanup third-party plugins
URL: https://github.com/apache/cordova-mobile-spec/issues/171
 
 
   in 

   
   Some things I can think of right now:
   * plugins commented out would likely be outdated
   * `CORDOVA_REGISTRY_PLUGINS` looks like it comes from an old registry
   * `TELERIK_VERIFIED_PLUGINS` may have some outdated plugins
   * `PLUGREG_PLUGINS` has a single plugin by myself that is definitely outdated


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #172: mac osx platform cleanup

[GitBox]

brodybits opened a new pull request #172: mac osx platform cleanup
URL: https://github.com/apache/cordova-mobile-spec/pull/172
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #172: mac osx platform cleanup

[GitBox]

brodybits commented on issue #172: mac osx platform cleanup
URL: 
https://github.com/apache/cordova-mobile-spec/pull/172#issuecomment-442190060
 
 
   from review of PR #153


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #171: Cleanup third-party plugins

[GitBox]

brodybits commented on issue #171: Cleanup third-party plugins
URL: 
https://github.com/apache/cordova-mobile-spec/issues/171#issuecomment-442190171
 
 
   from review of #153


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] michaelpeterlee removed a comment on issue #275: iOS > Remove > Code 5

[GitBox]

michaelpeterlee removed a comment on issue #275: iOS > Remove > Code 5
URL: 
https://github.com/apache/cordova-plugin-file/issues/275#issuecomment-441875853
 
 
   Code review likely mutations in this Cordova project and not a fault with 
cordova-plugin-file. Will confirm tomorrow. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits opened a new pull request #173: [WIP] Remove browserify flag support - NOT TESTED

[GitBox]

brodybits opened a new pull request #173: [WIP] Remove browserify flag support 
- NOT TESTED
URL: https://github.com/apache/cordova-mobile-spec/pull/173
 
 
   Chore to resolve a TODO in PR #153.
   
   - [ ] Will be tested when I test some other proposed changes
   
   /cc @janpio


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236820695
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -303,7 +309,7 @@ var cli = argv.global ? "cordova" : cli_local_bin;
 
 var projectDirName = argv._[0] || "mobilespec";
 var cli_project_dir = path.join(top_dir, projectDirName);
-var browserifyFlag = argv.browserify ? ' --browserify' : '';
+var browserifyFlag = argv.browserify ? ' --browserify' : ''; // TODO
 
 Review comment:
   I just raised PR #153 to resolve this TODO item.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on issue #152: fix location of key and build-extra.gradle for cordova-anroid 7.x

[GitBox]

brodybits commented on issue #152: fix location of key and build-extra.gradle 
for cordova-anroid 7.x
URL: 
https://github.com/apache/cordova-mobile-spec/pull/152#issuecomment-442195948
 
 
   Looks good, I would like to test it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236824165
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -489,31 +495,32 @@ if (argv.plugman) {
 } else {
 // Create the project using "cordova create"
 myDelete(cli_project_dir);
-console.log("Creating project mobilespec...");
-shelljs.exec(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
+console.log("### Creating project mobilespec...");
+executeShellCommand(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
 shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'), 
path.join(projectDirName, 'config.xml'));
 
 // Config.json file ---> linked to local libraries
 pushd(cli_project_dir);
 
 // Executing platform Add
-console.log("Adding platforms...");
+console.log("### Adding platforms...");
 [].concat(platforms).forEach(function (platform) {
-console.log("Adding Platform: " + platform);
+console.log("### Adding Platform: " + platform);
 var platformArg;
 if (argv.global) {
 platformArg = platform;
 } else {
 platformArg = 
join_paths([top_dir].concat(platform_layout[platform].bin));
 if (!fs.existsSync(platformArg)) {
-couldNotFind(platformArg, platform);
+couldNotFind(platform, platform);
 platforms = platforms.filter(function (p) { return p != 
platform; });
 return;
 }
 }
 console.log("platformArg: " + cli + " " + platformArg);
 var linkPlatformsFlag = (argv.link || argv.linkplatforms) ? ' --link' 
: '';
-shelljs.exec(cli + ' platform add "' + platformArg + '" --verbose' + 
linkPlatformsFlag);
+executeShellCommand(cli + ' platform add "' + platformArg + '" 
--verbose' + linkPlatformsFlag);
+// TODO
 
 Review comment:
   This TODO item resolved by PR #152 (which is currently awaiting review)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236824165
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -489,31 +495,32 @@ if (argv.plugman) {
 } else {
 // Create the project using "cordova create"
 myDelete(cli_project_dir);
-console.log("Creating project mobilespec...");
-shelljs.exec(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
+console.log("### Creating project mobilespec...");
+executeShellCommand(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
 shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'), 
path.join(projectDirName, 'config.xml'));
 
 // Config.json file ---> linked to local libraries
 pushd(cli_project_dir);
 
 // Executing platform Add
-console.log("Adding platforms...");
+console.log("### Adding platforms...");
 [].concat(platforms).forEach(function (platform) {
-console.log("Adding Platform: " + platform);
+console.log("### Adding Platform: " + platform);
 var platformArg;
 if (argv.global) {
 platformArg = platform;
 } else {
 platformArg = 
join_paths([top_dir].concat(platform_layout[platform].bin));
 if (!fs.existsSync(platformArg)) {
-couldNotFind(platformArg, platform);
+couldNotFind(platform, platform);
 platforms = platforms.filter(function (p) { return p != 
platform; });
 return;
 }
 }
 console.log("platformArg: " + cli + " " + platformArg);
 var linkPlatformsFlag = (argv.link || argv.linkplatforms) ? ' --link' 
: '';
-shelljs.exec(cli + ' platform add "' + platformArg + '" --verbose' + 
linkPlatformsFlag);
+executeShellCommand(cli + ' platform add "' + platformArg + '" 
--verbose' + linkPlatformsFlag);
+// TODO
 
 Review comment:
   This TODO item resolved in PR #152 (which is currently awaiting review)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236828277
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -424,7 +430,7 @@ if (!argv.skiplink) {
 // so they actually get tested instead of downloading the last 
published
 // one from the npm registry. Fail if they are not.
 console.log("You are on master branch of tools, checking npm links");
-verifyNpmLinkOf("cordova-js", "cordova-lib");
+//verifyNpmLinkOf("cordova-js", "cordova-lib"); TODO cordova-js is not 
a dependency of cordova-lib (any more?)
 
 Review comment:
   I raised PR #174 to remove this line along with some other lines related to 
cordova-js. No need for TODO item here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236827965
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -413,7 +419,7 @@ function verifyNpmLinkOf(linkedModule, installedModule) {
 }
 
 if (!argv.skiplink) {
-console.log("Checking if you are using master branch of tools");
+console.log("Checking if you are using master branch of tools (js, lib, 
plugman, cli)");
 
 Review comment:
   I think we have no need to actually check js, added a commit to PR #174 to 
update this message there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236825443
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -404,7 +410,7 @@ function verifyNpmLinkOf(linkedModule, installedModule) {
 if (fs.existsSync(linkedPath)) {
 var myStat = fs.lstatSync(linkedPath);
 if (!myStat.isSymbolicLink()) {
-throw new Error('Module ' + linkedModule + ' installed in ' + 
installedModule + ' is not npm-linked. I recommend you run "coho npm-link".');
+throw new Error('Module ' + linkedModule + ' installed in ' + 
installedModule + ' is not npm-linked. I recommend you run "coho npm-link".'); 
// TODO angleichen an andere commands
 
 Review comment:
   ??


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] brodybits commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

brodybits commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236829175
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -153,11 +158,11 @@ var top_dir = process.cwd() + path.sep,
.boolean("linkplatforms").describe("linkplatforms", "Use 
the --link flag when running `cordova platform add`.\n")
.boolean("link").describe("link", "Alias for --linkplugins 
--linkplatforms.\n")
.boolean("browserify").describe("browserify", "Use the 
--browserify flag when running `cordova plugin add`.\n")
-   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n")
-   .boolean("cprplugins").describe("cprplugins", "Adds a bunch 
of known-to-be-popular plugins from Cordova Plugin Regsitry.\n")
-   .boolean("plugregplugins").describe("cprplugins", "Adds a 
bunch of known-to-be-popular plugins from PlugReg (that are not on the CPR).\n")
-   .boolean("thirdpartyplugins").describe("thirdpartyplugins", 
"Alias for --telerikplugins --cprplugins --plugregplugins.\n")
-   .string("webview").describe("webview", "Use 
--webview=crosswalk to install the crosswalk plugin")
+   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n") // 
TODO
 
 Review comment:
   I meant do not remove these items in this PR. I raised #171 to cleanup 
third-party plugin stuff, which should be done in a separate PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] nprail commented on issue #448: CB-13685 android: Adaptive Icon Support

[GitBox]

nprail commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-442208713
 
 
   Has this been released yet? If not, when will it be? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support

[GitBox]

dpogue commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-442213195
 
 
   It is not released yet, it will be included in the next major version. We 
can't/won't commit to any particular timeline for that next major, but we are 
working on it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-mobile-spec] branch janpio-improve_script updated (3e30f76 -> 34597ab)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-improve_script
in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git.


from 3e30f76  better console.log
 add 34597ab  Update createmobilespec/createmobilespec.js

No new revisions were added by this update.

Summary of changes:
 createmobilespec/createmobilespec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236857654
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -489,31 +495,32 @@ if (argv.plugman) {
 } else {
 // Create the project using "cordova create"
 myDelete(cli_project_dir);
-console.log("Creating project mobilespec...");
-shelljs.exec(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
+console.log("### Creating project mobilespec...");
+executeShellCommand(cli + " create " + projectDirName + " 
org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" 
+ path.sep + "www");
 shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'), 
path.join(projectDirName, 'config.xml'));
 
 // Config.json file ---> linked to local libraries
 pushd(cli_project_dir);
 
 // Executing platform Add
-console.log("Adding platforms...");
+console.log("### Adding platforms...");
 [].concat(platforms).forEach(function (platform) {
-console.log("Adding Platform: " + platform);
+console.log("### Adding Platform: " + platform);
 var platformArg;
 if (argv.global) {
 platformArg = platform;
 } else {
 platformArg = 
join_paths([top_dir].concat(platform_layout[platform].bin));
 if (!fs.existsSync(platformArg)) {
-couldNotFind(platformArg, platform);
+couldNotFind(platform, platform);
 platforms = platforms.filter(function (p) { return p != 
platform; });
 return;
 }
 }
 console.log("platformArg: " + cli + " " + platformArg);
 var linkPlatformsFlag = (argv.link || argv.linkplatforms) ? ' --link' 
: '';
-shelljs.exec(cli + ' platform add "' + platformArg + '" --verbose' + 
linkPlatformsFlag);
+executeShellCommand(cli + ' platform add "' + platformArg + '" 
--verbose' + linkPlatformsFlag);
+// TODO
 
 Review comment:
   ```suggestion
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-mobile-spec] branch janpio-improve_script updated (34597ab -> 62ac397)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-improve_script
in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git.


from 34597ab  Update createmobilespec/createmobilespec.js
 add 62ac397  Update createmobilespec/createmobilespec.js

No new revisions were added by this update.

Summary of changes:
 createmobilespec/createmobilespec.js | 1 -
 1 file changed, 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236858889
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -130,7 +135,7 @@ var top_dir = process.cwd() + path.sep,
.boolean("windows").describe("windows", "Add Windows 
(universal) platform.")
.boolean("wp8").describe("wp8", "Add Windows Phone 8 
platform.")
.boolean("firefoxos").describe("firefoxos", "Add FirefoxOS 
platform.")
-   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.")
+   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.") // TODO Why 
would one want to do that?
 
 Review comment:
   Yeah, my understanging on what `plugman` is and how it works (and how it 
relates to the other plugman call thing in tooling (lib I think it was)) is a 
moving target as well. 
   
   I currently think it is to `cordova plugin add` as `cordova platform add` is 
to the platform `create` scripts. 
   
   But we should really discuss this and see if someone else knows more - and 
then update the docs (and see where it pops up in all the tools and pieces (and 
maybe remove it there depending on our results)).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236860234
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -71,7 +71,12 @@ function pluginAdd(pluginName, searchPath, extraFlags) {
 if (extraFlags) {
 command += extraFlags;
 }
-shelljs.exec(command);
+executeShellCommand(command);
+}
+
+function executeShellCommand(command) {
+console.log('$ ' + command);
+return shelljs.exec(command);
 
 Review comment:
   
https://github.com/apache/cordova-mobile-spec/blob/3e30f761c342bb93378686f67f8707437d7a1b7b/createmobilespec/createmobilespec.js#L691
 uses the return value.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236860505
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -130,7 +135,7 @@ var top_dir = process.cwd() + path.sep,
.boolean("windows").describe("windows", "Add Windows 
(universal) platform.")
.boolean("wp8").describe("wp8", "Add Windows Phone 8 
platform.")
.boolean("firefoxos").describe("firefoxos", "Add FirefoxOS 
platform.")
-   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.")
+   .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.") // TODO Why 
would one want to do that?
 
 Review comment:
   ```suggestion
  .boolean("plugman").describe("plugman", "Use 
{platform}/bin/create and plugman directly instead of the CLI.")
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[cordova-mobile-spec] branch janpio-improve_script updated (62ac397 -> 34b84ed)

[janpio]

This is an automated email from the ASF dual-hosted git repository.

janpio pushed a change to branch janpio-improve_script
in repository https://gitbox.apache.org/repos/asf/cordova-mobile-spec.git.


from 62ac397  Update createmobilespec/createmobilespec.js
 add 34b84ed  Update createmobilespec/createmobilespec.js

No new revisions were added by this update.

Summary of changes:
 createmobilespec/createmobilespec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861171
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -153,11 +158,11 @@ var top_dir = process.cwd() + path.sep,
.boolean("linkplatforms").describe("linkplatforms", "Use 
the --link flag when running `cordova platform add`.\n")
.boolean("link").describe("link", "Alias for --linkplugins 
--linkplatforms.\n")
.boolean("browserify").describe("browserify", "Use the 
--browserify flag when running `cordova plugin add`.\n")
-   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n")
-   .boolean("cprplugins").describe("cprplugins", "Adds a bunch 
of known-to-be-popular plugins from Cordova Plugin Regsitry.\n")
-   .boolean("plugregplugins").describe("cprplugins", "Adds a 
bunch of known-to-be-popular plugins from PlugReg (that are not on the CPR).\n")
-   .boolean("thirdpartyplugins").describe("thirdpartyplugins", 
"Alias for --telerikplugins --cprplugins --plugregplugins.\n")
-   .string("webview").describe("webview", "Use 
--webview=crosswalk to install the crosswalk plugin")
+   .boolean("telerikplugins").describe("telerikplugins", "Adds 
a bunch of known-to-be-popular plugins from Telerik-Verified-Plugins.\n") // 
TODO
 
 Review comment:
   Yep, as this stuff is clearly broken I added the TODOs here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861324
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -227,6 +232,7 @@ var DEFAULT_PLUGINS = [
 'cordova-plugin-statusbar',
 'cordova-plugin-vibration',
 'cordova-plugin-whitelist',
+// TODO check if all are listed
 
 Review comment:
   Feel free to do so.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861655
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -303,7 +309,7 @@ var cli = argv.global ? "cordova" : cli_local_bin;
 
 var projectDirName = argv._[0] || "mobilespec";
 var cli_project_dir = path.join(top_dir, projectDirName);
-var browserifyFlag = argv.browserify ? ' --browserify' : '';
+var browserifyFlag = argv.browserify ? ' --browserify' : ''; // TODO
 
 Review comment:
   This is PR #153. You probably meant #173?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

[GitHub] janpio commented on a change in pull request #153: Improve createmobilespec/createmobilespec.js

[GitBox]

janpio commented on a change in pull request #153: Improve 
createmobilespec/createmobilespec.js
URL: 
https://github.com/apache/cordova-mobile-spec/pull/153#discussion_r236861860
 
 

 ##
 File path: createmobilespec/createmobilespec.js
 ##
 @@ -404,7 +410,7 @@ function verifyNpmLinkOf(linkedModule, installedModule) {
 if (fs.existsSync(linkedPath)) {
 var myStat = fs.lstatSync(linkedPath);
 if (!myStat.isSymbolicLink()) {
-throw new Error('Module ' + linkedModule + ' installed in ' + 
installedModule + ' is not npm-linked. I recommend you run "coho npm-link".');
+throw new Error('Module ' + linkedModule + ' installed in ' + 
installedModule + ' is not npm-linked. I recommend you run "coho npm-link".'); 
// TODO angleichen an andere commands
 
 Review comment:
   ```suggestion
   throw new Error('Module ' + linkedModule + ' installed in ' + 
installedModule + ' is not npm-linked. I recommend you run "coho npm-link".');
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org