Re: [I] Remove HexView [daffodil-vscode]
stricklandrbls commented on issue #905: URL: https://github.com/apache/daffodil-vscode/issues/905#issuecomment-1851024517 @lrbarber @shanedell @scholarsmate @nlewis05 - After meeting w/ @nlewis05 & @lrbarber this afternoon, I had a better understanding of the data flow of the dfdl debugging and where the data editor might fit in that. After some digging, I was able to simply send messages from the dfdl custom debug events and have them be received on the data editor side.  In this screen shot I'm just using the `searchResult` highlight to indicate the `bytePos1b` of the dfdl debugger message. There will definitely be some data editor / omega editor refactoring to be done but this example shows that communication between the two panels doesn't have to go as low level as defining specific web sockets between them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DAFFODIL-2699) CLI test return code is 0 even if specified test is not found
[
https://issues.apache.org/jira/browse/DAFFODIL-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Interrante resolved DAFFODIL-2699.
---
Resolution: Fixed
Fixed in commit c58434c0b6b7017861ec8f385e8a5f98496423d7
> CLI test return code is 0 even if specified test is not found
> -
>
> Key: DAFFODIL-2699
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2699
> Project: Daffodil
> Issue Type: Bug
> Components: CLI, TDML Runner
>Affects Versions: 3.3.0
>Reporter: Mike Beckerle
>Assignee: Peter Katlic
>Priority: Minor
> Labels: Beginner
>
>
> There is no test named nameDOB_test2, but this is what happened
> {code:java}
> daffodil test -iii -r test/nameDOB2.tdml nameDOB_test2
> Total: 0, Pass: 0, Fail: 0, Not Found: 0
> $ echo $?
> 0{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DAFFODIL-2699) CLI test return code is 0 even if specified test is not found
[
https://issues.apache.org/jira/browse/DAFFODIL-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Interrante updated DAFFODIL-2699:
--
Fix Version/s: 3.7.0
> CLI test return code is 0 even if specified test is not found
> -
>
> Key: DAFFODIL-2699
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2699
> Project: Daffodil
> Issue Type: Bug
> Components: CLI, TDML Runner
>Affects Versions: 3.3.0
>Reporter: Mike Beckerle
>Assignee: Peter Katlic
>Priority: Minor
> Labels: Beginner
> Fix For: 3.7.0
>
>
>
> There is no test named nameDOB_test2, but this is what happened
> {code:java}
> daffodil test -iii -r test/nameDOB2.tdml nameDOB_test2
> Total: 0, Pass: 0, Fail: 0, Not Found: 0
> $ echo $?
> 0{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] Revisit layout of launch wizard [daffodil-vscode]
nlewis05 commented on issue #846: URL: https://github.com/apache/daffodil-vscode/issues/846#issuecomment-1850967076 #653 may coincide with this layout revision as we might want to add the configuration mentioned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(daffodil) branch main updated: Return FAIL if tests are not found
This is an automated email from the ASF dual-hosted git repository.
jinterrante pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/daffodil.git
The following commit(s) were added to refs/heads/main by this push:
new c58434c0b Return FAIL if tests are not found
c58434c0b is described below
commit c58434c0b6b7017861ec8f385e8a5f98496423d7
Author: 200019465
AuthorDate: Mon Dec 11 15:48:07 2023 -0500
Return FAIL if tests are not found
Include specified test names in test list even if not found in
test file in order to print names of tests not found. Return
FAIL if any tests fail or are not found.
DAFFODIL-2699
Main.scala: Include all test names for listing even if not
found, update return code logic to check for any tests
failing or not found.
TestCLItdml.scala: Update expected exit codes based on new
return code logic, note that test_CLI_Tdml_Listing_negativeTest01
now returns FAIL due to tests not found.
---
daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala | 7 +--
.../test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala
b/daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala
index b30db8871..3e9477b3a 100644
--- a/daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala
+++ b/daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala
@@ -1609,7 +1609,10 @@ class Main(
val matches = tdmlRunner.testCases.filter(testCase =>
regex.pattern.matcher(testCase.tcName).matches,
)
- matches.map(testCase => (testCase.tcName, Some(testCase)))
+ matches match {
+case m if !m.isEmpty => m.map(testCase =>
(testCase.tcName, Some(testCase)))
+case _ => Seq((testName, None))
+ }
} else {
List((testName, tdmlRunner.testCases.find(_.tcName ==
testName)))
}
@@ -1729,7 +1732,7 @@ class Main(
),
)
- if (fail == 0) ExitCode.Success else ExitCode.TestError
+ if (fail == 0 && notfound == 0) ExitCode.Success else
ExitCode.TestError
}
}
diff --git
a/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala
b/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala
index 649677ff9..5d99d9a63 100644
---
a/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala
+++
b/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala
@@ -32,7 +32,7 @@ class TestCLItdml {
runCLI(args"test $tdml escape_entry1 escape_entry2-11 escape_entry1-5
escape_entry4_3") {
cli =>
cli.expect("Total: 4, Pass: 2, Fail: 0, Not Found: 2")
-}(ExitCode.Success)
+}(ExitCode.TestError)
}
@Test def test_CLI_Tdml_Listing_execRegex01(): Unit = {
Re: [PR] Return FAIL if tests are not found [daffodil]
tuxji merged PR #1130: URL: https://github.com/apache/daffodil/pull/1130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Replace glob package [daffodil-vscode]
nlewis05 commented on issue #492: URL: https://github.com/apache/daffodil-vscode/issues/492#issuecomment-1850959869 > am not sure how much this is needed. After looking over some things, glob seems to only be used by us for some scripting stuff. So it shouldn't be getting packaged in our releases. Would it be possible to document those unexpected errors in this ticket? If they seem to be specific to this package, then we can close the issue with those errors documented, and if they are because of something else within the extension, then at least we have that documented somewhere and investigate further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Return FAIL if tests are not found [daffodil]
tuxji commented on code in PR #1130: URL: https://github.com/apache/daffodil/pull/1130#discussion_r1423139193 ## daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala: ## @@ -1729,7 +1732,7 @@ class Main( ), ) - if (fail == 0) ExitCode.Success else ExitCode.TestError + if (pass > 0 && fail == 0 && notfound == 0) ExitCode.Success else ExitCode.TestError Review Comment: OK, agreed that pass > 0 can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DAFFODIL-2753) Remove numbers from CLI integration test names
[ https://issues.apache.org/jira/browse/DAFFODIL-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence updated DAFFODIL-2753: - Fix Version/s: 3.7.0 > Remove numbers from CLI integration test names > -- > > Key: DAFFODIL-2753 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2753 > Project: Daffodil > Issue Type: Improvement > Components: Clean Ups >Reporter: Steve Lawrence >Assignee: Peter Katlic >Priority: Trivial > Labels: beginner > Fix For: 3.7.0 > > > Many of the integration tests include a seemingly random number (e.g. > test_3677_CLI_Parsing_elementFormDefault_qualified). These numbers actually > come from an old requirements document that no longer exists or is > maintained, and so just causes confusion about what they might mean. We > should just remove these numbers to avoid potential confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (DAFFODIL-2753) Remove numbers from CLI integration test names
[ https://issues.apache.org/jira/browse/DAFFODIL-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Katlic resolved DAFFODIL-2753. Resolution: Fixed Addressed by commit e05dfc8dcd8748aad23deb4e3159b6130cd97830. > Remove numbers from CLI integration test names > -- > > Key: DAFFODIL-2753 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2753 > Project: Daffodil > Issue Type: Improvement > Components: Clean Ups >Reporter: Steve Lawrence >Assignee: Peter Katlic >Priority: Trivial > Labels: beginner > > Many of the integration tests include a seemingly random number (e.g. > test_3677_CLI_Parsing_elementFormDefault_qualified). These numbers actually > come from an old requirements document that no longer exists or is > maintained, and so just causes confusion about what they might mean. We > should just remove these numbers to avoid potential confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (DAFFODIL-2753) Remove numbers from CLI integration test names
[ https://issues.apache.org/jira/browse/DAFFODIL-2753 ] Peter Katlic deleted comment on DAFFODIL-2753: was (Author: JIRAUSER298282): Addressed by commit e05dfc8dcd8748aad23deb4e3159b6130cd97830. > Remove numbers from CLI integration test names > -- > > Key: DAFFODIL-2753 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2753 > Project: Daffodil > Issue Type: Improvement > Components: Clean Ups >Reporter: Steve Lawrence >Assignee: Peter Katlic >Priority: Trivial > Labels: beginner > > Many of the integration tests include a seemingly random number (e.g. > test_3677_CLI_Parsing_elementFormDefault_qualified). These numbers actually > come from an old requirements document that no longer exists or is > maintained, and so just causes confusion about what they might mean. We > should just remove these numbers to avoid potential confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DAFFODIL-2753) Remove numbers from CLI integration test names
[ https://issues.apache.org/jira/browse/DAFFODIL-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795505#comment-17795505 ] Peter Katlic commented on DAFFODIL-2753: Addressed by commit e05dfc8dcd8748aad23deb4e3159b6130cd97830. > Remove numbers from CLI integration test names > -- > > Key: DAFFODIL-2753 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2753 > Project: Daffodil > Issue Type: Improvement > Components: Clean Ups >Reporter: Steve Lawrence >Assignee: Peter Katlic >Priority: Trivial > Labels: beginner > > Many of the integration tests include a seemingly random number (e.g. > test_3677_CLI_Parsing_elementFormDefault_qualified). These numbers actually > come from an old requirements document that no longer exists or is > maintained, and so just causes confusion about what they might mean. We > should just remove these numbers to avoid potential confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Remove numbers from CLI integration test names [daffodil]
tuxji merged PR #1128: URL: https://github.com/apache/daffodil/pull/1128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
(daffodil) branch main updated: Remove numbers from CLI integration test names
This is an automated email from the ASF dual-hosted git repository.
jinterrante pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/daffodil.git
The following commit(s) were added to refs/heads/main by this push:
new e05dfc8dc Remove numbers from CLI integration test names
e05dfc8dc is described below
commit e05dfc8dcd8748aad23deb4e3159b6130cd97830
Author: 200019465
AuthorDate: Mon Dec 11 14:32:36 2023 -0500
Remove numbers from CLI integration test names
DAFFODIL-2753
TestCLIDebugger.scala: remove numbers from test names.
TestCLIParsing.scala: remove numbers from test names.
TestCLIPerformance.scala: remove numbers from test names.
TestCLISaveParser.scala: remove numbers from test names.
TestCLItdml.scala: remove numbers from test names.
TestCLIUnparsing.scala: remove numbers from test names.
---
.../daffodil/cli/cliTest/TestCLIParsing.scala | 108 ++---
.../daffodil/cli/cliTest/TestCLIPerformance.scala | 30 +++---
.../daffodil/cli/cliTest/TestCLISaveParser.scala | 34 +++
.../daffodil/cli/cliTest/TestCLIUnparsing.scala| 62 ++--
.../apache/daffodil/cli/cliTest/TestCLItdml.scala | 18 ++--
.../apache/daffodil/cliTest/TestCLIDebugger.scala | 50 +-
6 files changed, 151 insertions(+), 151 deletions(-)
diff --git
a/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLIParsing.scala
b/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLIParsing.scala
index 3c3dbb3ac..d11a8c518 100644
---
a/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLIParsing.scala
+++
b/daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLIParsing.scala
@@ -34,7 +34,7 @@ class TestCLIParsing {
}(ExitCode.Success)
}
- @Test def test_3677_CLI_Parsing_elementFormDefault_qualified(): Unit = {
+ @Test def test_CLI_Parsing_elementFormDefault_qualified(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section00/general/elementFormDefaultQualified.dfdl.xsd",
)
@@ -45,7 +45,7 @@ class TestCLIParsing {
}(ExitCode.LeftOverData)
}
- @Test def test_3678_CLI_Parsing_elementFormDefault_unqualified(): Unit = {
+ @Test def test_CLI_Parsing_elementFormDefault_unqualified(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section00/general/elementFormDefaultUnqualified.dfdl.xsd",
)
@@ -56,7 +56,7 @@ class TestCLIParsing {
}(ExitCode.LeftOverData)
}
- @Test def test_2358_CLI_Parsing_SimpleParse_stdOut_extVars(): Unit = {
+ @Test def test_CLI_Parsing_SimpleParse_stdOut_extVars(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section07/external_variables/external_variables.dfdl.xsd",
)
@@ -71,7 +71,7 @@ class TestCLIParsing {
}(ExitCode.Success)
}
- @Test def test_3507_CLI_Parsing_SimpleParse_SaveParser_extVars(): Unit = {
+ @Test def test_CLI_Parsing_SimpleParse_SaveParser_extVars(): Unit = {
withTempFile { parser =>
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section07/external_variables/external_variables.dfdl.xsd",
@@ -98,7 +98,7 @@ class TestCLIParsing {
}
}
- @Test def test_2360_CLI_Parsing_SimpleParse_stdOut_extVars2(): Unit = {
+ @Test def test_CLI_Parsing_SimpleParse_stdOut_extVars2(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section07/external_variables/external_variables.dfdl.xsd",
)
@@ -114,7 +114,7 @@ class TestCLIParsing {
}(ExitCode.LeftOverData)
}
- @Test def test_3506_CLI_Parsing_SimpleParse_extVars2(): Unit = {
+ @Test def test_CLI_Parsing_SimpleParse_extVars2(): Unit = {
withTempFile { parser =>
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section07/external_variables/external_variables.dfdl.xsd",
@@ -150,7 +150,7 @@ class TestCLIParsing {
}(ExitCode.BadExternalVariable)
}
- @Test def test_3227_CLI_Parsing_SimpleParse_DFDL1197_fix(): Unit = {
+ @Test def test_CLI_Parsing_SimpleParse_DFDL1197_fix(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section12/delimiter_properties/testOptionalInfix.dfdl.xsd",
)
@@ -161,7 +161,7 @@ class TestCLIParsing {
}(ExitCode.LeftOverData)
}
- @Test def test_1593_CLI_Parsing_MultifileSchema_noGlobalElem(): Unit = {
+ @Test def test_CLI_Parsing_MultifileSchema_noGlobalElem(): Unit = {
val schema = path(
"daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/multi_base_21.dfdl.xsd",
)
@@ -181,7 +181,7 @@ class TestCLIParsing {
// TDML tests do not verify this part of expected infosets. This is one test
// verifies the expected output. If this test fails, it likely means we've
//
Re: [PR] Return FAIL if tests are not found [daffodil]
stevedlawrence commented on code in PR #1130: URL: https://github.com/apache/daffodil/pull/1130#discussion_r1423130618 ## daffodil-cli/src/main/scala/org/apache/daffodil/cli/Main.scala: ## @@ -1729,7 +1732,7 @@ class Main( ), ) - if (fail == 0) ExitCode.Success else ExitCode.TestError + if (pass > 0 && fail == 0 && notfound == 0) ExitCode.Success else ExitCode.TestError Review Comment: Should we remove the `pass > 0` condition? I'm thinking of an an edge case where a tdml file has no tests defined and a user runs `daffodil test no_tests.tdml`. If we require `pass > 0` to be considered a success, then that command would exit with failure even though nothing technically failed. Maybe there's an argument that running no tests should be a failure? But using SBT as an example, running a test suite with no tests is considered a success. Maybe there are other counter examples? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove numbers from CLI integration test names [daffodil]
tuxji commented on code in PR #1128:
URL: https://github.com/apache/daffodil/pull/1128#discussion_r1423119194
##
daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLIParsing.scala:
##
@@ -220,7 +220,7 @@ class TestCLIParsing {
}(ExitCode.Success)
}
- @Test def test_1317_IBMCompatibility_ABC_test_ibm_abc_cli(): Unit = {
+ @Test def test_IBMCompatibility_ABC_test_ibm_abc_cli(): Unit = {
Review Comment:
Could rename to `test_CLI_IBMCompatibility_ABC_test_ibm_abc` to be more
similar to rest of test case names, any disagreement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Return FAIL if tests are not found [daffodil]
pkatlic opened a new pull request, #1130: URL: https://github.com/apache/daffodil/pull/1130 Include specified test names in test list even if not found in test file in order to print names of tests not found. Return FAIL if no tests pass or any tests fail or are not found. DAFFODIL-2699 Main.scala: Include all test names for listing even if not found, update return code logic to check for no passing tests and any tests failing or not found. TestCLItdml.scala: Update expected exit codes based on new return code logic, note that test_CLI_Tdml_Listing_negativeTest01 now returns FAIL due to tests not found and test_CLI_catch_TestNotCompatible now returns FAIL due to no passing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (DAFFODIL-2699) CLI test return code is 0 even if specified test is not found
[
https://issues.apache.org/jira/browse/DAFFODIL-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Katlic reassigned DAFFODIL-2699:
--
Assignee: Peter Katlic
> CLI test return code is 0 even if specified test is not found
> -
>
> Key: DAFFODIL-2699
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2699
> Project: Daffodil
> Issue Type: Bug
> Components: CLI, TDML Runner
>Affects Versions: 3.3.0
>Reporter: Mike Beckerle
>Assignee: Peter Katlic
>Priority: Minor
> Labels: Beginner
>
>
> There is no test named nameDOB_test2, but this is what happened
> {code:java}
> daffodil test -iii -r test/nameDOB2.tdml nameDOB_test2
> Total: 0, Pass: 0, Fail: 0, Not Found: 0
> $ echo $?
> 0{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Remove numbers from CLI integration test names [daffodil]
pkatlic commented on code in PR #1128:
URL: https://github.com/apache/daffodil/pull/1128#discussion_r1423090476
##
daffodil-test-integration/src/test/scala/org/apache/daffodil/cliTest/TestCLIDebugger.scala:
##
@@ -86,7 +86,7 @@ class TestCLIDebugger {
}
}
- @Test def test_3385_CLI_Debugger_invalidExpressions(): Unit = {
Review Comment:
Updated these names as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Remove numbers from CLI integration test names [daffodil]
stevedlawrence commented on code in PR #1128:
URL: https://github.com/apache/daffodil/pull/1128#discussion_r1423041165
##
daffodil-test-integration/src/test/scala/org/apache/daffodil/cliTest/TestCLIDebugger.scala:
##
@@ -86,7 +86,7 @@ class TestCLIDebugger {
}
}
- @Test def test_3385_CLI_Debugger_invalidExpressions(): Unit = {
Review Comment:
Many of the tests in `daffodil-cli/src/test/scala/...` also have these
unnecessary and confusing numbers. Could you remove those as part of this PR as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Remove numbers from CLI integration test names [daffodil]
pkatlic opened a new pull request, #1128: URL: https://github.com/apache/daffodil/pull/1128 DAFFODIL-2753 Remove numbers froM CLI integration test names TestCLIDebugger.scala: remove numbers from test names -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (DAFFODIL-2753) Remove numbers from CLI integration test names
[ https://issues.apache.org/jira/browse/DAFFODIL-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Katlic reassigned DAFFODIL-2753: -- Assignee: Peter Katlic > Remove numbers from CLI integration test names > -- > > Key: DAFFODIL-2753 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2753 > Project: Daffodil > Issue Type: Improvement > Components: Clean Ups >Reporter: Steve Lawrence >Assignee: Peter Katlic >Priority: Trivial > Labels: beginner > > Many of the integration tests include a seemingly random number (e.g. > test_3677_CLI_Parsing_elementFormDefault_qualified). These numbers actually > come from an old requirements document that no longer exists or is > maintained, and so just causes confusion about what they might mean. We > should just remove these numbers to avoid potential confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [I] Handling navigation of a schema within the jar file [daffodil-vscode]
lrbarber commented on issue #844: URL: https://github.com/apache/daffodil-vscode/issues/844#issuecomment-1850501803 Info I got some time ago from Mike Beckerle that might be helpful: ``` ethernetIP is another schema you get from Github DFDLSchemas on the web. You have to 'sbt publishLocal' that one, (might as well 'sbt test' to be sure it works first) That will create the jar needed and then in PCAP, 'sbt update' will create a temp lib_managed directory with that jar in it within the PCAP project tree. My launch.json put the two of these schema projects as side-by-side peer directories so that one can put ".." relative path steps that refer to eithernetIP schema files from the PCAP project. The daffodilDebugClasspath needs both a file reference to ethernetIP.dfdl.xsd, and the jar on it, in that order. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DAFFODIL-2823) time zone "z" specifier does not work properly
[ https://issues.apache.org/jira/browse/DAFFODIL-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence resolved DAFFODIL-2823. -- Resolution: Not A Problem > time zone "z" specifier does not work properly > -- > > Key: DAFFODIL-2823 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2823 > Project: Daffodil > Issue Type: Bug > Components: Back End >Affects Versions: 3.4.0 >Reporter: Mike Beckerle >Priority: Minor > Fix For: 3.5.0 > > > The time zone string "EST" is parsed by calendarPattern charater "z", and > becomes ISO standard "-05:00" on parse, but "GMT-5" on unparse. > This happens despite dfdl:calendarLanguge="en_US". That is, the problem is > that the unparse should produce "EST", but does not. > The locale is needed to implement "z" time zone format because some of these > 3-letter timezone specifiers are ambiguous, so the locale must be known to > disambiguate them when parsing. > For example CST can be "Central Standard Time" (North America), "Cuba > Standard Time" or "China Standard Time", and is widely used for "Central > Standard Time" (Australia) according to > [https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations] > So when parsing "z" one must use the locale. When unparsing it's not so > ambiguous, but Daffodil doesn't appear to use the locale information. > Per the ICU documentation here: > [https://icu.unicode.org/design/formatting/timezone/icu-4-8-time-zone-names] > The "z" needs locale information, and several of the other specifiers also > need it. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DAFFODIL-2823) time zone "z" specifier does not work properly
[ https://issues.apache.org/jira/browse/DAFFODIL-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Lawrence closed DAFFODIL-2823. > time zone "z" specifier does not work properly > -- > > Key: DAFFODIL-2823 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2823 > Project: Daffodil > Issue Type: Bug > Components: Back End >Affects Versions: 3.4.0 >Reporter: Mike Beckerle >Priority: Minor > Fix For: 3.5.0 > > > The time zone string "EST" is parsed by calendarPattern charater "z", and > becomes ISO standard "-05:00" on parse, but "GMT-5" on unparse. > This happens despite dfdl:calendarLanguge="en_US". That is, the problem is > that the unparse should produce "EST", but does not. > The locale is needed to implement "z" time zone format because some of these > 3-letter timezone specifiers are ambiguous, so the locale must be known to > disambiguate them when parsing. > For example CST can be "Central Standard Time" (North America), "Cuba > Standard Time" or "China Standard Time", and is widely used for "Central > Standard Time" (Australia) according to > [https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations] > So when parsing "z" one must use the locale. When unparsing it's not so > ambiguous, but Daffodil doesn't appear to use the locale information. > Per the ICU documentation here: > [https://icu.unicode.org/design/formatting/timezone/icu-4-8-time-zone-names] > The "z" needs locale information, and several of the other specifiers also > need it. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DAFFODIL-2823) time zone "z" specifier does not work properly
[ https://issues.apache.org/jira/browse/DAFFODIL-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795393#comment-17795393 ] Steve Lawrence commented on DAFFODIL-2823: -- The new API is the addition of the "getIanaID" function: https://unicode-org.github.io/icu-docs/apidoc/dev/icu4j/com/ibm/icu/util/TimeZone.html#getIanaID-java.lang.String- This just uses a newer database for getting a canonical timezone ID, and doesn't help the issue of picking the right timezone from a UTF offset (which mentioned above is hard because there isn't really a "right" timezone. Reclosing this as "Not a Problem" since this new API doesn't provide a solution to this issue, and this is just how things work. > time zone "z" specifier does not work properly > -- > > Key: DAFFODIL-2823 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2823 > Project: Daffodil > Issue Type: Bug > Components: Back End >Affects Versions: 3.4.0 >Reporter: Mike Beckerle >Priority: Minor > Fix For: 3.5.0 > > > The time zone string "EST" is parsed by calendarPattern charater "z", and > becomes ISO standard "-05:00" on parse, but "GMT-5" on unparse. > This happens despite dfdl:calendarLanguge="en_US". That is, the problem is > that the unparse should produce "EST", but does not. > The locale is needed to implement "z" time zone format because some of these > 3-letter timezone specifiers are ambiguous, so the locale must be known to > disambiguate them when parsing. > For example CST can be "Central Standard Time" (North America), "Cuba > Standard Time" or "China Standard Time", and is widely used for "Central > Standard Time" (Australia) according to > [https://en.wikipedia.org/wiki/List_of_time_zone_abbreviations] > So when parsing "z" one must use the locale. When unparsing it's not so > ambiguous, but Daffodil doesn't appear to use the locale information. > Per the ICU documentation here: > [https://icu.unicode.org/design/formatting/timezone/icu-4-8-time-zone-names] > The "z" needs locale information, and several of the other specifiers also > need it. > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DAFFODIL-2856) Configure SonarCloud scan run on Java 17
[
https://issues.apache.org/jira/browse/DAFFODIL-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson closed DAFFODIL-2856.
---
Resolution: Fixed
> Configure SonarCloud scan run on Java 17
>
>
> Key: DAFFODIL-2856
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2856
> Project: Daffodil
> Issue Type: Bug
> Components: Infrastructure
>Reporter: Steve Lawrence
>Assignee: Peter Katlic
>Priority: Critical
> Fix For: 3.7.0
>
>
> Received an email with the following from SonarCloud:
> {quote}
> Starting from the 15th of November 2023, SonarCloud will no longer accept
> scans executed using Java 11. This decision has been made to ensure the
> platform's compatibility with the latest technologies and to provide you with
> an enhanced experience.
> To continue benefiting from SonarCloud's advanced features and analysis
> capabilities, we strongly encourage you to migrate your runtime environment
> for the analysis to Java 17 as soon as possible.{quote}
> We should update our github action to run on our Java 17 matrix instead of
> Java 11:
> https://github.com/apache/daffodil/blob/main/.github/workflows/main.yml#L88-L95
> Marking as critical since this will happen fairly soon, and we don't want
> builds to start breaking.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DAFFODIL-2856) Configure SonarCloud scan run on Java 17
[
https://issues.apache.org/jira/browse/DAFFODIL-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson updated DAFFODIL-2856:
Fix Version/s: 3.7.0
> Configure SonarCloud scan run on Java 17
>
>
> Key: DAFFODIL-2856
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2856
> Project: Daffodil
> Issue Type: Bug
> Components: Infrastructure
>Reporter: Steve Lawrence
>Assignee: Peter Katlic
>Priority: Critical
> Fix For: 3.7.0
>
>
> Received an email with the following from SonarCloud:
> {quote}
> Starting from the 15th of November 2023, SonarCloud will no longer accept
> scans executed using Java 11. This decision has been made to ensure the
> platform's compatibility with the latest technologies and to provide you with
> an enhanced experience.
> To continue benefiting from SonarCloud's advanced features and analysis
> capabilities, we strongly encourage you to migrate your runtime environment
> for the analysis to Java 17 as soon as possible.{quote}
> We should update our github action to run on our Java 17 matrix instead of
> Java 11:
> https://github.com/apache/daffodil/blob/main/.github/workflows/main.yml#L88-L95
> Marking as critical since this will happen fairly soon, and we don't want
> builds to start breaking.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (DAFFODIL-2856) Configure SonarCloud scan run on Java 17
[
https://issues.apache.org/jira/browse/DAFFODIL-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson reopened DAFFODIL-2856:
-
Reopening to update Fix Version to 3.7.0.
> Configure SonarCloud scan run on Java 17
>
>
> Key: DAFFODIL-2856
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2856
> Project: Daffodil
> Issue Type: Bug
> Components: Infrastructure
>Reporter: Steve Lawrence
>Assignee: Peter Katlic
>Priority: Critical
>
> Received an email with the following from SonarCloud:
> {quote}
> Starting from the 15th of November 2023, SonarCloud will no longer accept
> scans executed using Java 11. This decision has been made to ensure the
> platform's compatibility with the latest technologies and to provide you with
> an enhanced experience.
> To continue benefiting from SonarCloud's advanced features and analysis
> capabilities, we strongly encourage you to migrate your runtime environment
> for the analysis to Java 17 as soon as possible.{quote}
> We should update our github action to run on our Java 17 matrix instead of
> Java 11:
> https://github.com/apache/daffodil/blob/main/.github/workflows/main.yml#L88-L95
> Marking as critical since this will happen fairly soon, and we don't want
> builds to start breaking.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (DAFFODIL-2865) Give codegen-c somewhat limited dfdl:assert support
[
https://issues.apache.org/jira/browse/DAFFODIL-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson closed DAFFODIL-2865.
---
Verified the specified commit (commit b4eaa46c0c6b17b9be7f94772a2e37ae817801f0)
is included in the latest pull from the daffodil repository.
Verified, via review, changes identified in the commit comment were
implemented.
Verified the affected daffodil subproject sbt test suites executed successfully
including the modified and added tests.
> Give codegen-c somewhat limited dfdl:assert support
> ---
>
> Key: DAFFODIL-2865
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2865
> Project: Daffodil
> Issue Type: Improvement
> Components: Back End C-Generator
>Affects Versions: 3.7.0
>Reporter: John Interrante
>Assignee: John Interrante
>Priority: Minor
> Fix For: 3.7.0
>
>
> On the basis that a little support is better than none, allow codegen-c to
> generate C code for a limited subset of dfdl:assert expressions. The use
> case is to allow generated code to validate or reject messages using
> dfdl:assert expressions as well as ranges and enumerations. The dfdl:assert
> support is limited to replacing "../foo/x" and "." with the appropriate
> pointers and replacing DFDL named operators ("eq") with C-compatible
> operators ("==") using find and replace operators. In the long term, a
> better approach would be to add methods to the compiled expression classes to
> generate C code directly from the compiled expressions with fuller
> understanding of what the parts of the expressions represent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
