[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3068: Select and drag dag

2020-06-29 Thread GitBox


break60 commented on pull request #3068:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3068#issuecomment-651555913


   very good, front end +1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3068: Select and drag dag

2020-06-29 Thread GitBox


break60 commented on pull request #3068:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3068#issuecomment-651506875


   > > > Good job,
   > > > We should commit an issue before we do this work. Can you commit a new 
feature issue about your work and link this PR to that issue?
   > > 
   > > 
   > > thx, get it. it's my first time to create PR. I will recheck my code 
these days, then commit a new feature issue.
   > 
   > done
   
   I don’t see your associated issue, please give an issue to describe this 
function, and then connect to this pr



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3068: Select and drag dag

2020-06-28 Thread GitBox


break60 commented on pull request #3068:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3068#issuecomment-650873371


   Please don't change the code style of dag.vue page, otherwise I don't know 
what you changed



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org