Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
github-actions[bot] commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-2065525844 This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
github-actions[bot] closed issue #15599: [Improvement] Refactoring Code For Better Comprehension URL: https://github.com/apache/dolphinscheduler/issues/15599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
github-actions[bot] commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-2048638815 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
EricGao888 commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-1987735495 > @EricGao888 seems like i do not have write access to this repo. Due to this I am unable to push my feature branch for this issue. Could you help here Hi @akshitk20 , you don't need direct write access to this repo to contribute. You could submit a PR and maintainers will review it and then help merge it. FYI: https://github.com/sevntu-checkstyle/sevntu.checkstyle/wiki/Development-workflow-with-Git:-Fork,-Branching,-Commits,-and-Pull-Request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
akshitk20 commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-1986898023 @EricGao888 seems like i do not have write access to this repo. Due to this I am unable to push my feature branch for this issue. Could you help here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
EricGao888 commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-1975943894 > Is it only for a specific package, or all of them? We could do it iteratively, with priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
pinkfloyds commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-1975934702 I can't agree more with your advice ,really need refactoring code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
stonelion commented on issue #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599#issuecomment-1958754911 Is it only for a specific package, or all of them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] [Improvement] Refactoring Code For Better Comprehension [dolphinscheduler]
EricGao888 opened a new issue, #15599: URL: https://github.com/apache/dolphinscheduler/issues/15599 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement. ### Description Currently some parts of code are poorly constructed, leading to difficult comprehension, trouble of testing and maintenance. With an IntelliJ plugin, `metrics reloaded`, we could get the complexity of methods in this project.  If the cognitive complexity of a method is more than 30, basically we treat it as incomprehensible, untestable and unmaintainable. We would like to have these methods refactored and achieve a significant decrease in complexity, maybe 50% or more. Any help will be appreciated : ) https://plugins.jetbrains.com/plugin/93-metricsreloaded https://www.hatica.io/blog/code-complexity/ ### Are you willing to submit a PR? - [ ] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
