Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
niyanchun commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-2117123413 our production environment meet this problem, When 3.2.2 release？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
ruanwenjun commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1961184403 Thanks for fixing this Bug? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
DaZuiZui commented on code in PR #15619:
URL:
https://github.com/apache/dolphinscheduler/pull/15619#discussion_r1500301902
##
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java:
##
@@ -75,4 +77,15 @@ public static PageInfo of(IPage iPage) {
public static PageInfo of(Integer currentPage, Integer pageSize) {
return new PageInfo<>(currentPage, pageSize);
}
+
+public Integer getTotalPage() {
Review Comment:
I have submitted PR
https://github.com/apache/dolphinscheduler/pull/15620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
SbloodyS commented on code in PR #15619:
URL:
https://github.com/apache/dolphinscheduler/pull/15619#discussion_r1500290123
##
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java:
##
@@ -75,4 +77,15 @@ public static PageInfo of(IPage iPage) {
public static PageInfo of(Integer currentPage, Integer pageSize) {
return new PageInfo<>(currentPage, pageSize);
}
+
+public Integer getTotalPage() {
Review Comment:
> @DaZuiZui The original code is from a previously deleted section
[#15181](https://github.com/apache/dolphinscheduler/pull/15181/files#diff-c367978011e1fa572823ec7cec246f9a21ad88699ef9c764ee39e9c96d23914b).
But your suggestions are better, there is no reason not to optimize, you are
welcome to create a PR❤️.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
Gallardot commented on code in PR #15619:
URL:
https://github.com/apache/dolphinscheduler/pull/15619#discussion_r1500289526
##
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java:
##
@@ -75,4 +77,15 @@ public static PageInfo of(IPage iPage) {
public static PageInfo of(Integer currentPage, Integer pageSize) {
return new PageInfo<>(currentPage, pageSize);
}
+
+public Integer getTotalPage() {
Review Comment:
@DaZuiZui
The original code is from a previously deleted section
[#15181](https://github.com/apache/dolphinscheduler/pull/15181/files#diff-c367978011e1fa572823ec7cec246f9a21ad88699ef9c764ee39e9c96d23914b).
But your suggestions are better, there is no reason not to optimize, you are
welcome to create a PR❤️.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
DaZuiZui commented on code in PR #15619:
URL:
https://github.com/apache/dolphinscheduler/pull/15619#discussion_r1500280514
##
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/PageInfo.java:
##
@@ -75,4 +77,15 @@ public static PageInfo of(IPage iPage) {
public static PageInfo of(Integer currentPage, Integer pageSize) {
return new PageInfo<>(currentPage, pageSize);
}
+
+public Integer getTotalPage() {
Review Comment:
This seems to achieve the same function, and is simpler
this.totalPage = Math.ceil(this.total / this.pageSize);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
SbloodyS merged PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
Gallardot commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960769275 > Did you mean #15181? Yes, #15181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
SbloodyS commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960765470 cc @ruanwenjun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
SbloodyS commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960763351 Did you mean #15181? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
SbloodyS commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960761080 #https://github.com/apache/dolphinscheduler/pull/15148 is closed. Which deleted some code by mistake? @Gallardot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
sonarcloud[bot] commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960710213 ## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler=15619) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=15619=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler=15619=false=true)  [73.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=15619=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=15619=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler=15619) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
sonarcloud[bot] commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960709752 ## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler=15619) **Quality Gate passed** Issues  [1 New issue](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=15619=false=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler=15619=false=true)  [73.3% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=15619=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=15619=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler=15619) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Bug][API] list paging missing totalpage [dolphinscheduler]
codecov-commenter commented on PR #15619: URL: https://github.com/apache/dolphinscheduler/pull/15619#issuecomment-1960706313 ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report Attention: Patch coverage is `57.14286%` with `3 lines` in your changes are missing coverage. Please review. > Project coverage is 38.53%. Comparing base [(`24ff70d`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/24ff70dc88dd56112100bb4c8ebad3cfd0da2e18?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`c494c74`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > :exclamation: Current head c494c74 differs from pull request most recent head 2d59ec9. Consider uploading reports for the commit 2d59ec9 to get more accurate results | [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Patch % | Lines | |---|---|---| | [...rg/apache/dolphinscheduler/api/utils/PageInfo.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1BhZ2VJbmZvLmphdmE=) | 57.14% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) | Additional details and impacted files ```diff @@Coverage Diff@@ ##dev #15619 +/- ## = Coverage 38.53% 38.53% - Complexity 4783 4784+1 = Files 1316 1316 Lines 4503645007 -29 Branches 4821 4800 -21 = - Hits 1735417343 -11 + Misses2579225772 -20 - Partials 1890 1892+2 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15619?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
