Re: [PR] Fix out parameter may loss [dolphinscheduler]
caishunfeng merged PR #15617: URL: https://github.com/apache/dolphinscheduler/pull/15617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix out parameter may loss [dolphinscheduler]
sonarcloud[bot] commented on PR #15617: URL: https://github.com/apache/dolphinscheduler/pull/15617#issuecomment-1959353370 ## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15617) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15617&resolved=false&inNewCodePeriod=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15617&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15617&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15617&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15617) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix out parameter may loss [dolphinscheduler]
sonarcloud[bot] commented on PR #15617: URL: https://github.com/apache/dolphinscheduler/pull/15617#issuecomment-1959351675 ## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15617) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15617&resolved=false&inNewCodePeriod=true) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15617&resolved=false&inNewCodePeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15617&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15617&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15617) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix out parameter may loss [dolphinscheduler]
codecov-commenter commented on PR #15617: URL: https://github.com/apache/dolphinscheduler/pull/15617#issuecomment-1959342595 ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: `4 lines` in your changes are missing coverage. Please review. > Comparison is base [(`2b4c1e0`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/2b4c1e06b67977dfed87fec0a528a1f9b75308d1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.58% compared to head [(`d4b074e`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 38.58%. > :exclamation: Current head d4b074e differs from pull request most recent head 8ce72a9. Consider uploading reports for the commit 8ce72a9 to get more accurate results | [Files](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...plugin/task/api/parameters/AbstractParameters.java](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kb2xwaGluc2NoZWR1bGVyL3BsdWdpbi90YXNrL2FwaS9wYXJhbWV0ZXJzL0Fic3RyYWN0UGFyYW1ldGVycy5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ##dev #15617 +/- ## - Coverage 38.58% 38.58% -0.01% + Complexity 4784 4783 -1 Files 1312 1312 Lines 4497844981 +3 Branches 4819 4820 +1 - Hits 1735517354 -1 - Misses2573325736 +3 - Partials 1890 1891 +1 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15617?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dolphinscheduler.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
