[PR] [fix](regression)Change analyze_timeout to global. (#28587) [doris]
Jibing-Li opened a new pull request, #28636: URL: https://github.com/apache/doris/pull/28636 Fix hive statistics regression case. analyze_timeout is a global session variable. backport https://github.com/apache/doris/pull/28587 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](write)use more efficient string_compare from doris [doris-thirdparty]
qidaye opened a new pull request, #155: URL: https://github.com/apache/doris-thirdparty/pull/155 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0](fe ut) make colcoate test wait time longer (#26999) [doris]
yujun777 commented on PR #28628: URL: https://github.com/apache/doris/pull/28628#issuecomment-1862281660 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](block) fix be core while mutable block merge may cause different row size between columns in origin block [doris]
caiconghui commented on PR #27943: URL: https://github.com/apache/doris/pull/27943#issuecomment-1862281367 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][execturo]support query schedule policy [doris]
github-actions[bot] commented on PR #28443: URL: https://github.com/apache/doris/pull/28443#issuecomment-1862279522 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][execturo]support query schedule policy [doris]
github-actions[bot] commented on PR #28443: URL: https://github.com/apache/doris/pull/28443#issuecomment-1862281058 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][execturo]support query schedule policy [doris]
github-actions[bot] commented on PR #28443: URL: https://github.com/apache/doris/pull/28443#issuecomment-1862280989 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [chore] Add bvar for meta operations of BE [doris]
dataroaring merged PR #28374: URL: https://github.com/apache/doris/pull/28374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [chore] Add bvar for meta operations of BE (#28374)
This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 95073053bc2 [chore] Add bvar for meta operations of BE (#28374)
95073053bc2 is described below
commit 95073053bc28be8a696fd4781cafc0f746f00a51
Author: Gavin Chou
AuthorDate: Tue Dec 19 15:54:19 2023 +0800
[chore] Add bvar for meta operations of BE (#28374)
---
be/src/olap/olap_meta.cpp | 35 ---
be/src/util/doris_metrics.cpp | 15 ---
be/src/util/doris_metrics.h | 5 -
3 files changed, 12 insertions(+), 43 deletions(-)
diff --git a/be/src/olap/olap_meta.cpp b/be/src/olap/olap_meta.cpp
index f393d4a2629..58a5123993a 100644
--- a/be/src/olap/olap_meta.cpp
+++ b/be/src/olap/olap_meta.cpp
@@ -17,6 +17,7 @@
#include "olap/olap_meta.h"
+#include
#include
#include
#include
@@ -56,6 +57,10 @@ using namespace ErrorCode;
const std::string META_POSTFIX = "/meta";
const size_t PREFIX_LENGTH = 4;
+bvar::LatencyRecorder g_meta_put_latency("meta_put");
+bvar::LatencyRecorder g_meta_get_latency("meta_get");
+bvar::LatencyRecorder g_meta_remove_latency("meta_remove");
+
OlapMeta::OlapMeta(const std::string& root_path) : _root_path(root_path) {}
OlapMeta::~OlapMeta() = default;
@@ -117,7 +122,6 @@ Status OlapMeta::init() {
}
Status OlapMeta::get(const int column_family_index, const std::string& key,
std::string* value) {
-DorisMetrics::instance()->meta_read_request_total->increment(1);
auto& handle = _handles[column_family_index];
int64_t duration_ns = 0;
rocksdb::Status s;
@@ -125,7 +129,7 @@ Status OlapMeta::get(const int column_family_index, const
std::string& key, std:
SCOPED_RAW_TIMER(_ns);
s = _db->Get(ReadOptions(), handle.get(), rocksdb::Slice(key), value);
}
-
DorisMetrics::instance()->meta_read_request_duration_us->increment(duration_ns
/ 1000);
+g_meta_get_latency << (duration_ns / 1000);
if (s.IsNotFound()) {
return Status::Error("OlapMeta::get meet not found
key");
} else if (!s.ok()) {
@@ -137,7 +141,6 @@ Status OlapMeta::get(const int column_family_index, const
std::string& key, std:
bool OlapMeta::key_may_exist(const int column_family_index, const std::string&
key,
std::string* value) {
-DorisMetrics::instance()->meta_read_request_total->increment(1);
auto& handle = _handles[column_family_index];
int64_t duration_ns = 0;
bool is_exist = false;
@@ -145,15 +148,13 @@ bool OlapMeta::key_may_exist(const int
column_family_index, const std::string& k
SCOPED_RAW_TIMER(_ns);
is_exist = _db->KeyMayExist(ReadOptions(), handle.get(),
rocksdb::Slice(key), value);
}
-
DorisMetrics::instance()->meta_read_request_duration_us->increment(duration_ns
/ 1000);
+g_meta_get_latency << (duration_ns / 1000);
return is_exist;
}
Status OlapMeta::put(const int column_family_index, const std::string& key,
const std::string& value) {
-DorisMetrics::instance()->meta_write_request_total->increment(1);
-
// log all params
VLOG_DEBUG << "column_family_index: " << column_family_index << ", key: "
<< key
<< ", value: " << value;
@@ -162,9 +163,7 @@ Status OlapMeta::put(const int column_family_index, const
std::string& key,
rocksdb::Status s;
{
int64_t duration_ns = 0;
-Defer defer([&] {
-
DorisMetrics::instance()->meta_write_request_duration_us->increment(duration_ns
/ 1000);
-});
+Defer defer([&] { g_meta_put_latency << (duration_ns / 1000); });
SCOPED_RAW_TIMER(_ns);
WriteOptions write_options;
@@ -180,15 +179,11 @@ Status OlapMeta::put(const int column_family_index, const
std::string& key,
}
Status OlapMeta::put(const int column_family_index, const
std::vector& entries) {
-DorisMetrics::instance()->meta_write_request_total->increment(1);
-
auto* handle = _handles[column_family_index].get();
rocksdb::Status s;
{
int64_t duration_ns = 0;
-Defer defer([&] {
-
DorisMetrics::instance()->meta_write_request_duration_us->increment(duration_ns
/ 1000);
-});
+Defer defer([&] { g_meta_put_latency << (duration_ns / 1000); });
SCOPED_RAW_TIMER(_ns);
// construct write batch
@@ -212,14 +207,10 @@ Status OlapMeta::put(const int column_family_index, const
std::vectormeta_write_request_total->increment(1);
-
rocksdb::Status s;
{
int64_t duration_ns = 0;
-Defer defer([&] {
-
DorisMetrics::instance()->meta_write_request_duration_us->increment(duration_ns
/ 1000);
-});
+Defer defer([&] { g_meta_put_latency << (duration_ns / 1000); });
SCOPED_RAW_TIMER(_ns);
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
doris-robot commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862277951 TeamCity be ut coverage result: Function Coverage: 36.49% (8534/23388) Line Coverage: 28.63% (69383/242364) Region Coverage: 27.64% (35895/129879) Branch Coverage: 24.36% (18332/75256) Coverage Report: http://coverage.selectdb-in.cc/coverage/cd6269a1ef16d55625dad428aafcb582596e230f_cd6269a1ef16d55625dad428aafcb582596e230f/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](regression)Change analyze_timeout to global. [doris]
morningman merged PR #28587: URL: https://github.com/apache/doris/pull/28587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated: [fix](regression)Change analyze_timeout to global. (#28587)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 64ebdb27778 [fix](regression)Change analyze_timeout to global.
(#28587)
64ebdb27778 is described below
commit 64ebdb2777822f0cf561da3dc353b2f95c005913
Author: Jibing-Li <64681310+jibing...@users.noreply.github.com>
AuthorDate: Tue Dec 19 15:52:38 2023 +0800
[fix](regression)Change analyze_timeout to global. (#28587)
Fix hive statistics regression case. analyze_timeout is a global session
variable.
---
.../external_table_p2/hive/test_hive_statistic_timeout.groovy | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
a/regression-test/suites/external_table_p2/hive/test_hive_statistic_timeout.groovy
b/regression-test/suites/external_table_p2/hive/test_hive_statistic_timeout.groovy
index 2910666c444..a3329f87712 100644
---
a/regression-test/suites/external_table_p2/hive/test_hive_statistic_timeout.groovy
+++
b/regression-test/suites/external_table_p2/hive/test_hive_statistic_timeout.groovy
@@ -15,7 +15,7 @@
// specific language governing permissions and limitations
// under the License.
-suite("test_hive_statistic_timeout",
"p2,external,hive,external_remote,external_remote_hive") {
+suite("test_hive_statistic_timeout",
"p2,external,hive,external_remote,external_remote_hive, nonConcurrent") {
String enabled = context.config.otherConfigs.get("enableExternalHiveTest")
if (enabled != null && enabled.equalsIgnoreCase("true")) {
String extHiveHmsHost =
context.config.otherConfigs.get("extHiveHmsHost")
@@ -32,11 +32,13 @@ suite("test_hive_statistic_timeout",
"p2,external,hive,external_remote,external_
logger.info("catalog " + catalog_name + " created")
sql """use ${catalog_name}.tpch_1000_parquet"""
-sql """set analyze_timeout=1"""
+sql """set global analyze_timeout=1"""
try {
sql """analyze table part (p_partkey, p_container, p_type,
p_retailprice) with sync with full;"""
} catch (Exception e) {
assertTrue(e.getMessage().contains("Cancelled"));
+} finally {
+sql """set global analyze_timeout=43200"""
}
sql """drop catalog ${catalog_name}""";
}
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](regression)Change analyze_timeout to global. [doris]
github-actions[bot] commented on PR #28587: URL: https://github.com/apache/doris/pull/28587#issuecomment-1862274586 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] [doris]
doris-robot commented on PR #28632: URL: https://github.com/apache/doris/pull/28632#issuecomment-1862273206 TeamCity be ut coverage result: Function Coverage: 36.48% (8534/23392) Line Coverage: 28.63% (69383/242364) Region Coverage: 27.65% (35903/129869) Branch Coverage: 24.37% (18337/75256) Coverage Report: http://coverage.selectdb-in.cc/coverage/f527015589f9c0c3e40692e8643fb4d021dac0a0_f527015589f9c0c3e40692e8643fb4d021dac0a0/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) Cast estimation [doris]
englefly commented on PR #28166: URL: https://github.com/apache/doris/pull/28166#issuecomment-1862271992 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature][execturo]support query schedule policy [doris]
wangbo commented on PR #28443: URL: https://github.com/apache/doris/pull/28443#issuecomment-1862272056 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhance](broker) add inputstream expire scheduled checker to avoid memory leak for broker scan [doris]
WinkerDu commented on PR #28589: URL: https://github.com/apache/doris/pull/28589#issuecomment-1862270574 @morningman @chenlinzhong @luozenglin Please take a review, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](datalake) Add BucketShuffleJoin support for bucketed hive tables [doris]
morningman commented on PR #27784: URL: https://github.com/apache/doris/pull/27784#issuecomment-1862270218 Sorry for the late review, I will keep on to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (a1049148809 -> 372a2e20f9f)
This is an automated email from the ASF dual-hosted git repository. englefly pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a1049148809 [feature](mtmv)create mtmv support refresh_partition_num (#28566) add 372a2e20f9f [fix](Nereids) stats estimation of lessThan #28444 No new revisions were added by this update. Summary of changes: .../main/java/org/apache/doris/nereids/stats/FilterEstimation.java| 4 .../src/main/java/org/apache/doris/statistics/StatisticRange.java | 4 2 files changed, 8 insertions(+) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhance](broker) add inputstream expire scheduled checker to avoid memory leak for broker scan [doris]
WinkerDu commented on PR #28589: URL: https://github.com/apache/doris/pull/28589#issuecomment-1862269097 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](meta) update killed query state [doris]
morningman commented on PR #25917: URL: https://github.com/apache/doris/pull/25917#issuecomment-1862269038 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) stats estimation of lessThan [doris]
englefly merged PR #28444: URL: https://github.com/apache/doris/pull/28444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](statistics)Fix drop stats fail silently bug. [doris]
Jibing-Li commented on PR #28635: URL: https://github.com/apache/doris/pull/28635#issuecomment-1862268481 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](Nereids) elimite join by foereign key [doris]
XieJiann commented on PR #28486: URL: https://github.com/apache/doris/pull/28486#issuecomment-1862268793 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](metadata) show full columns support for external tables [doris]
morningman commented on code in PR #28173:
URL: https://github.com/apache/doris/pull/28173#discussion_r1431026118
##
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowColumnStmt.java:
##
@@ -98,8 +106,14 @@ public void analyze(Analyzer analyzer) throws
AnalysisException {
tableName.setDb(db);
}
tableName.analyze(analyzer);
-// disallow external catalog
-Util.prohibitExternalCatalog(tableName.getCtl(),
this.getClass().getSimpleName());
+
+if (!Env.getCurrentEnv().getAccessManager()
Review Comment:
Better to use this method `public boolean checkTblPriv(UserIdentity
currentUser, String ctl, String db, String tbl, PrivPredicate wanted)` to and
pass all `catalog`, `database` and `table` info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick-2.0](regression) change compound predicate regression case name to make it more clear [doris]
github-actions[bot] commented on PR #28630: URL: https://github.com/apache/doris/pull/28630#issuecomment-1862266149 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](statistics)Fix drop stats fail silently bug. [doris]
Jibing-Li opened a new pull request, #28635: URL: https://github.com/apache/doris/pull/28635 Drop stats use IN predicate to filter the column stats to delete. The default length of IN predicate is 1024, drop table stats with more than 1024 columns may fail. This pr is to split the delete sql based on the IN predicate length. ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick-2.0](regression) change compound predicate regression case name to make it more clear [doris]
github-actions[bot] commented on PR #28630: URL: https://github.com/apache/doris/pull/28630#issuecomment-1862266114 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] 对启用merge-on-write表进行高并发插入的场合，频发发生E-3115异常。 [doris]
polarbearmx commented on issue #28634: URL: https://github.com/apache/doris/issues/28634#issuecomment-1862265182 已经是生产环境了，升级风险太高了，不太敢跨大版本升级。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feat](Nereids) support outer join and aggregate bitmap rewrite by mv [doris]
seawinde commented on PR #28596: URL: https://github.com/apache/doris/pull/28596#issuecomment-1862264649 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](task-assignment) use consistent hash as default task assigner and cache the consistent hash ring [doris]
github-actions[bot] commented on PR #28522: URL: https://github.com/apache/doris/pull/28522#issuecomment-1862260420 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] 对启用merge-on-write表进行高并发插入的场合，频发发生E-3115异常。 [doris]
LemonLiTree commented on issue #28634: URL: https://github.com/apache/doris/issues/28634#issuecomment-1862258599 方便升级到2.0.3 试试不 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ut](stats) Added tests for JDBC analysis tasks [doris]
github-actions[bot] commented on PR #28591: URL: https://github.com/apache/doris/pull/28591#issuecomment-1862255433 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ut](stats) Added tests for JDBC analysis tasks [doris]
github-actions[bot] commented on PR #28591: URL: https://github.com/apache/doris/pull/28591#issuecomment-1862255397 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[I] [Bug] 对启用merge-on-write表进行高并发插入的场合，频发发生E-3115异常。 [doris]
polarbearmx opened a new issue, #28634:
URL: https://github.com/apache/doris/issues/28634
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/doris/issues?q=is%3Aissue) and found no
similar issues.
### Version
1.2.3
### What's Wrong?
对merge-on-write表进行频发插入的情况下，频发发生【E-3115】发布版本不连续的异常。
fe的DatabaseTransactionMgr.commitTransaction方法中，通过writeLock保护TransactionState对获取table的Partition的nextVersion。
但是，后面的updateCatalogAfterCommited方法对Partition的nextVersion自增的操作并没有在writeLock保护范围内。
第一个线程没有修改Partition.nextVersion就释放了锁，所以，第二个线程进入加锁区域获取Partition的nextVersion时，第一个线程可能没有完成Partition.nextVersion的自增；两个线程发往BE的publish_req中包含相同的Partition.extVersion。
DatabaseTransactionMgr.commitTransaction==
transactionState.beforeStateTransform(TransactionStatus.COMMITTED);
// transaction state transform
boolean txnOperated = false;
writeLock();
try {
if (is2PC) {
unprotectedCommitTransaction2PC(transactionState, db);
} else {
unprotectedCommitTransaction(transactionState,
errorReplicaIds,
tableToPartition, totalInvolvedBackends, db);
}
txnOperated = true;
} finally {
writeUnlock();
// after state transform
transactionState.afterStateTransform(TransactionStatus.COMMITTED, txnOperated);
}
// update nextVersion because of the failure of persistent
transaction resulting in error version
updateCatalogAfterCommitted(transactionState, db);
be的EnginePublishVersionTask::finish时，线程1的版本被正常发布后，线程2永远不满足对merge-on-write的publish版本连续性判断。
=
if (tablet_state == TabletState::TABLET_RUNNING &&
version.first != max_version.second + 1) {
VLOG_NOTICE << "uniq key with merge-on-write version not
continuous, current "
"max "
"version="
<< max_version.second << ",
publish_version=" << version.first
<< " tablet_id=" << tablet->tablet_id();
// If a tablet migrates out and back, the previously
failed
// publish task may retry on the new tablet, so check
// whether the version exists. if not exist, then set
// publish failed
if (!tablet->check_version_exist(version)) {
add_error_tablet_id(tablet_info.tablet_id);
res =
Status::Error();
}
continue;
}
日志===
W1021 12:53:16.891216 391149 task_worker_pool.cpp:723] failed to publish
version|signature=247156074|transaction_id=247156074|error_tablets_num=4|error=[E-3115]
I1021 12:53:16.891402 391144 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.891413 391144 task_worker_pool.cpp:723] failed to publish
version|signature=247156709|transaction_id=247156709|error_tablets_num=18|error=[E-3115]
I1021 12:53:16.892107 391147 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.892119 391147 task_worker_pool.cpp:723] failed to publish
version|signature=247155948|transaction_id=247155948|error_tablets_num=16|error=[E-3115]
I1021 12:53:16.892413 391149 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.892421 391149 task_worker_pool.cpp:723] failed to publish
version|signature=247181244|transaction_id=247181244|error_tablets_num=12|error=[E-3115]
I1021 12:53:16.892585 391143 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.892601 391143 task_worker_pool.cpp:723] failed to publish
version|signature=247156698|transaction_id=247156698|error_tablets_num=18|error=[E-3115]
I1021 12:53:16.892611 391144 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.892628 391144 task_worker_pool.cpp:723] failed to publish
version|signature=247156081|transaction_id=247156081|error_tablets_num=15|error=[E-3115]
I1021 12:53:16.892690 391149 task_worker_pool.cpp:693] task elapsed 11
seconds since it is inserted to queue, it is timeout
W1021 12:53:16.892696 391149 task_worker_pool.cpp:723] failed to publish
version|signature=247157824|transaction_id=247157824|error_tablets_num=5|error=[E-3115]
I1021 12:53:16.893534 391148
Re: [PR] [ut](stats) Added tests for HMS analysis tasks [doris]
morningman commented on PR #28583: URL: https://github.com/apache/doris/pull/28583#issuecomment-1862254745 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ut](stats) Added tests for HMS analysis tasks [doris]
github-actions[bot] commented on PR #28583: URL: https://github.com/apache/doris/pull/28583#issuecomment-1862254681 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ut](stats) Added tests for HMS analysis tasks [doris]
github-actions[bot] commented on PR #28583: URL: https://github.com/apache/doris/pull/28583#issuecomment-1862254645 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [ut](stats) Added tests for JDBC analysis tasks [doris]
morningman commented on PR #28591: URL: https://github.com/apache/doris/pull/28591#issuecomment-1862254650 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0](http) add show_table_data http api [doris]
nextdreamblue commented on PR #28633: URL: https://github.com/apache/doris/pull/28633#issuecomment-1862250139 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](expr) Support kill query by query_id [doris]
nanfeng1999 commented on PR #28530: URL: https://github.com/apache/doris/pull/28530#issuecomment-1862249822 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [I] [Bug] JDBC OutOfMemoryError: Java heap space [doris]
Raven88 commented on issue #16538: URL: https://github.com/apache/doris/issues/16538#issuecomment-1862250492 Any update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] [doris]
github-actions[bot] commented on PR #28632: URL: https://github.com/apache/doris/pull/28632#issuecomment-1862250468 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](profilev2) using dst_id in pipelinex profile to be same as non pipeline rename some function names [doris]
doris-robot commented on PR #28626: URL: https://github.com/apache/doris/pull/28626#issuecomment-1862249512 TeamCity be ut coverage result: Function Coverage: 36.48% (8532/23387) Line Coverage: 28.62% (69365/242340) Region Coverage: 27.64% (35888/129857) Branch Coverage: 24.36% (18328/75250) Coverage Report: http://coverage.selectdb-in.cc/coverage/297c515b54c3d1ce313572404e8f54ac2cb549a8_297c515b54c3d1ce313572404e8f54ac2cb549a8/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement](http) add show_table_data http api (#28380) [doris]
nextdreamblue opened a new pull request, #28633: URL: https://github.com/apache/doris/pull/28633 In some cases, users need to get the data size of single replica of a table, and evaluate certain actions based on this, such as estimating the precise backup size. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] [doris]
Mryange commented on PR #28632: URL: https://github.com/apache/doris/pull/28632#issuecomment-1862242420 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [only test] [doris]
Mryange opened a new pull request, #28632: URL: https://github.com/apache/doris/pull/28632 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [improvement](http) add show_table_data http api (#28380) [doris]
nextdreamblue opened a new pull request, #28631: URL: https://github.com/apache/doris/pull/28631 In some cases, users need to get the data size of single replica of a table, and evaluate certain actions based on this, such as estimating the precise backup size. ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) compaction should catch exception when vertical block reader read next block [doris]
doris-robot commented on PR #28625: URL: https://github.com/apache/doris/pull/28625#issuecomment-1862240165 TeamCity be ut coverage result: Function Coverage: 36.49% (8534/23387) Line Coverage: 28.63% (69374/242341) Region Coverage: 27.64% (35891/129866) Branch Coverage: 24.36% (18331/75252) Coverage Report: http://coverage.selectdb-in.cc/coverage/8db4f2660ccaf2db1e504b6b819285a1e0dfb8bb_8db4f2660ccaf2db1e504b6b819285a1e0dfb8bb/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](limit) cancel running fragments when query with limit is finished [doris]
doris-robot commented on PR #28384: URL: https://github.com/apache/doris/pull/28384#issuecomment-1862239969 TeamCity be ut coverage result: Function Coverage: 36.48% (8533/23391) Line Coverage: 28.63% (69398/242368) Region Coverage: 27.64% (35900/129889) Branch Coverage: 24.36% (18339/75274) Coverage Report: http://coverage.selectdb-in.cc/coverage/2c8893d499b0fffb299e202dd1b75f49687f5665_2c8893d499b0fffb299e202dd1b75f49687f5665/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [only test] [doris]
doris-robot commented on PR #28622: URL: https://github.com/apache/doris/pull/28622#issuecomment-1862239466 TeamCity be ut coverage result: Function Coverage: 36.49% (8534/23389) Line Coverage: 28.62% (69353/242345) Region Coverage: 27.64% (35899/129861) Branch Coverage: 24.36% (18331/75252) Coverage Report: http://coverage.selectdb-in.cc/coverage/46cde955406cc610b63bbd175346e758c9ab56ad_46cde955406cc610b63bbd175346e758c9ab56ad/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Comment out some exceptions with partition equal to … [doris]
doris-robot commented on PR #28614: URL: https://github.com/apache/doris/pull/28614#issuecomment-1862239392 TeamCity be ut coverage result: Function Coverage: 37.82% (7995/21139) Line Coverage: 29.50% (64922/220079) Region Coverage: 28.98% (33412/115288) Branch Coverage: 24.86% (17149/68988) Coverage Report: http://coverage.selectdb-in.cc/coverage/fd119aaba3141b24ba69fcbd26956c7d0506ef2a_fd119aaba3141b24ba69fcbd26956c7d0506ef2a/report/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)after creating a materialized view, if other operations fail, roll back [doris]
github-actions[bot] commented on PR #28621: URL: https://github.com/apache/doris/pull/28621#issuecomment-1862238609 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)after creating a materialized view, if other operations fail, roll back [doris]
github-actions[bot] commented on PR #28621: URL: https://github.com/apache/doris/pull/28621#issuecomment-1862238542 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)after creating a materialized view, if other operations fail, roll back [doris]
zddr commented on PR #28621: URL: https://github.com/apache/doris/pull/28621#issuecomment-1862237195 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick-2.0](regression) change compound predicate regression case name to make it more clear [doris]
airborne12 commented on PR #28630: URL: https://github.com/apache/doris/pull/28630#issuecomment-186223 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)after creating a materialized view, if other operations fail, roll back [doris]
morningman commented on code in PR #28621:
URL: https://github.com/apache/doris/pull/28621#discussion_r1431003688
##
fe/fe-core/src/main/java/org/apache/doris/mtmv/MTMVUtil.java:
##
@@ -470,7 +470,7 @@ private static boolean isSync(long visibleVersionTime,
Set tables
try {
table = getTable(baseTableInfo);
} catch (AnalysisException e) {
-e.printStackTrace();
+LOG.warn("get table failed, " + baseTableInfo);
Review Comment:
```suggestion
LOG.warn("get table failed, {}", baseTableInfo, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Pick-2.0](regression) change compound predicate regression case name to make it more clear [doris]
airborne12 opened a new pull request, #28630: URL: https://github.com/apache/doris/pull/28630 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)after creating a materialized view, if other operations fail, roll back [doris]
zddr commented on PR #28621: URL: https://github.com/apache/doris/pull/28621#issuecomment-1862234485 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Error while running github feature from .asf.yaml in doris!
An error occurred while running github feature in .asf.yaml!: You can only have a maximum of 10 external triage collaborators, please contact vp-in...@apache.org to request an exception. - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
qidaye commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862232675 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (b142ade69e4 -> a1049148809)
This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from b142ade69e4 [refactor](renamefile) rename some files according to the class names (#28606) add a1049148809 [feature](mtmv)create mtmv support refresh_partition_num (#28566) No new revisions were added by this update. Summary of changes: .../main/java/org/apache/doris/catalog/MTMV.java | 9 ++ .../org/apache/doris/common/proc/TableProcDir.java | 2 +- .../apache/doris/common/util/PropertyAnalyzer.java | 1 + .../apache/doris/datasource/InternalCatalog.java | 3 +- .../apache/doris/job/extensions/mtmv/MTMVTask.java | 144 ++--- .../main/java/org/apache/doris/mtmv/MTMVUtil.java | 10 +- .../plans/commands/info/AlterMTMVPropertyInfo.java | 11 ++ .../trees/plans/commands/info/CreateMTMVInfo.java | 16 ++- 8 files changed, 141 insertions(+), 55 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)create mtmv support refresh_partition_num [doris]
morningman merged PR #28566: URL: https://github.com/apache/doris/pull/28566 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stream load)add test case and doc for arrow type of stream load [doris]
github-actions[bot] commented on PR #28098: URL: https://github.com/apache/doris/pull/28098#issuecomment-1862230842 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
github-actions[bot] commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862230541 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](Export) Fix BE core when the `columns` attribute of `export` parquet is specified as an asterisk [doris]
BePPPower commented on PR #28627: URL: https://github.com/apache/doris/pull/28627#issuecomment-1862230257 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [test](ut) added UT cases for show broker stmt [doris]
Nitin-Kashyap opened a new pull request, #28629: URL: https://github.com/apache/doris/pull/28629 ## Proposed changes UT cases added for Show Broker Stmt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive) add support for `quoteChar` and `seperatorChar` for hive [doris]
github-actions[bot] commented on PR #28613: URL: https://github.com/apache/doris/pull/28613#issuecomment-1862229706 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](hive) add support for `quoteChar` and `seperatorChar` for hive [doris]
github-actions[bot] commented on PR #28613: URL: https://github.com/apache/doris/pull/28613#issuecomment-1862229675 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [branch-2.0](fe ut) make colcoate test wait time longer (#26999) [doris]
yujun777 opened a new pull request, #28628: URL: https://github.com/apache/doris/pull/28628 pick: #26999 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [branch-2.0](fe ut) make colcoate test wait time longer (#26999) [doris]
yujun777 commented on PR #28628: URL: https://github.com/apache/doris/pull/28628#issuecomment-1862228016 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Fix](Export) Fix BE core when the `columns` attribute of `export` parquet is specified as an asterisk [doris]
BePPPower opened a new pull request, #28627: URL: https://github.com/apache/doris/pull/28627 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
qidaye commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862224208 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](profilev2) using dst_id in pipelinex profile to be same as non pipeline rename some function names [doris]
github-actions[bot] commented on PR #28626: URL: https://github.com/apache/doris/pull/28626#issuecomment-1862224050 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv)add more test case [doris]
zddr commented on PR #27650: URL: https://github.com/apache/doris/pull/27650#issuecomment-1862221127 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](profilev2) using dst_id in pipelinex profile to be same as non pipeline rename some function names [doris]
yiguolei commented on PR #28626: URL: https://github.com/apache/doris/pull/28626#issuecomment-1862220884 run clickbench -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refactor](profile) using dst_id in pipelinex profile to be same as non pipeline; rename some function names [doris]
yiguolei commented on PR #28626: URL: https://github.com/apache/doris/pull/28626#issuecomment-1862217662 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [refactor](profile) using dst_id in pipelinex profile to be same as non pipeline; rename some function names [doris]
yiguolei opened a new pull request, #28626: URL: https://github.com/apache/doris/pull/28626 ## Proposed changes   ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](partition) Comment out some exceptions with partition equal to … [doris]
dataroaring commented on PR #28614: URL: https://github.com/apache/doris/pull/28614#issuecomment-1862216465 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-2.0 updated: [Bug](join) fix wrong result on left anti mark join #28586
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.0 by this push:
new 59eb67b7b5b [Bug](join) fix wrong result on left anti mark join #28586
59eb67b7b5b is described below
commit 59eb67b7b5b7bc5b5ec63c1fcf939ab07e1b2674
Author: Pxl
AuthorDate: Tue Dec 19 14:51:53 2023 +0800
[Bug](join) fix wrong result on left anti mark join #28586
---
be/src/vec/exec/join/process_hash_table_probe_impl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/vec/exec/join/process_hash_table_probe_impl.h
b/be/src/vec/exec/join/process_hash_table_probe_impl.h
index dee0f806a82..8edd21d835b 100644
--- a/be/src/vec/exec/join/process_hash_table_probe_impl.h
+++ b/be/src/vec/exec/join/process_hash_table_probe_impl.h
@@ -293,7 +293,7 @@ Status
ProcessHashTableProbe::do_process(HashTableType& hash_table_c
++current_offset;
bool null_result =
(need_null_map_for_probe &&
(*null_map)[probe_index]) ||
-(!find_result.is_found() &&
_join_node->_has_null_in_build_side);
+(find_result.is_found() &&
_join_node->_has_null_in_build_side);
if (null_result) {
mark_column->insert_null();
} else {
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](join) fix wrong result on left anti mark join [doris]
yiguolei merged PR #28586: URL: https://github.com/apache/doris/pull/28586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](stream load)add test case and doc for arrow type of stream load [doris]
wuwenchi commented on PR #28098: URL: https://github.com/apache/doris/pull/28098#issuecomment-1862216224 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) make STRLEFT and STRRIGHT and SUBSTR function DEPEND_ON_ARGUMENT [doris]
HappenLee commented on PR #28352: URL: https://github.com/apache/doris/pull/28352#issuecomment-1862212517 should add version to get different function and keep old function to make update no cause error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](writer) add null document API to optimize index empty doc (… [doris-thirdparty]
qidaye merged PR #154: URL: https://github.com/apache/doris-thirdparty/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-thirdparty) branch clucene-2.0 updated: [feature](writer) add null document API to optimize index empty doc (#153) (#154)
This is an automated email from the ASF dual-hosted git repository.
jianliangqi pushed a commit to branch clucene-2.0
in repository https://gitbox.apache.org/repos/asf/doris-thirdparty.git
The following commit(s) were added to refs/heads/clucene-2.0 by this push:
new bd2829ea [feature](writer) add null document API to optimize index
empty doc (#153) (#154)
bd2829ea is described below
commit bd2829eabb5e8f8b20daaadc7e68662dda7103ce
Author: qiye
AuthorDate: Tue Dec 19 14:47:03 2023 +0800
[feature](writer) add null document API to optimize index empty doc (#153)
(#154)
---
src/core/CLucene/index/IndexWriter.cpp | 5 +
src/core/CLucene/index/IndexWriter.h | 4
src/core/CLucene/index/SDocumentWriter.cpp | 9 +
src/core/CLucene/index/SDocumentWriter.h | 4
src/core/CLucene/index/_DocumentsWriter.h | 1 +
5 files changed, 23 insertions(+)
diff --git a/src/core/CLucene/index/IndexWriter.cpp
b/src/core/CLucene/index/IndexWriter.cpp
index bb4139ff..71cf4f2c 100644
--- a/src/core/CLucene/index/IndexWriter.cpp
+++ b/src/core/CLucene/index/IndexWriter.cpp
@@ -727,6 +727,11 @@ void IndexWriter::addDocument(Document *doc, Analyzer *an)
{
}
}
+void IndexWriter::addNullDocument(Document *doc) {
+ensureOpen();
+docWriter->addNullDocument(doc);
+}
+
void IndexWriter::deleteDocuments(Term *term) {
ensureOpen();
try {
diff --git a/src/core/CLucene/index/IndexWriter.h
b/src/core/CLucene/index/IndexWriter.h
index 7dbf2b12..719ce0e5 100644
--- a/src/core/CLucene/index/IndexWriter.h
+++ b/src/core/CLucene/index/IndexWriter.h
@@ -1014,6 +1014,10 @@ public:
void addDocument(CL_NS(document)::Document* doc, CL_NS(analysis)::Analyzer*
analyzer=NULL);
//void addDocument(CL_NS(document)::Document* doc,
CL_NS(analysis)::SAnalyzer* sanalyzer);
+ /**
+ * Add a empty document to the index.
+ */
+ void addNullDocument(CL_NS(document)::Document* doc);
/**
* Expert: asks the mergePolicy whether any merges are
diff --git a/src/core/CLucene/index/SDocumentWriter.cpp
b/src/core/CLucene/index/SDocumentWriter.cpp
index c76b31fb..446c0dc3 100644
--- a/src/core/CLucene/index/SDocumentWriter.cpp
+++ b/src/core/CLucene/index/SDocumentWriter.cpp
@@ -851,6 +851,15 @@ bool SDocumentsWriter::updateDocument(Document *doc,
Analyzer *sanalyzer) {
return state->doFlushAfter;
}
+template
+bool SDocumentsWriter::updateNullDocument(Document *doc) {
+ThreadState *state = getThreadState(doc);
+if (nextWriteDocID == state->docID) {
+nextWriteDocID++;
+}
+return true;
+}
+
template<>
TCHAR *SDocumentsWriter::getSCharBlock() {
const size_t size = freeSCharBlocks.size();
diff --git a/src/core/CLucene/index/SDocumentWriter.h
b/src/core/CLucene/index/SDocumentWriter.h
index 7e250be3..342089a7 100644
--- a/src/core/CLucene/index/SDocumentWriter.h
+++ b/src/core/CLucene/index/SDocumentWriter.h
@@ -685,7 +685,11 @@ public:
bool addDocument(CL_NS(document)::Document *doc, CL_NS(analysis)::Analyzer
*sanalyzer) override {
return updateDocument(doc, sanalyzer);
}
+bool addNullDocument(CL_NS(document)::Document *doc) override {
+return updateNullDocument(doc);
+}
bool updateDocument(CL_NS(document)::Document *doc,
CL_NS(analysis)::Analyzer *sanalyzer);
+bool updateNullDocument(CL_NS(document)::Document *doc);
ThreadState *getThreadState(CL_NS(document)::Document *doc);
T *getSCharBlock();
void recycleSCharBlocks(CL_NS(util)::ArrayBase , int32_t
start, int32_t numBlocks);
diff --git a/src/core/CLucene/index/_DocumentsWriter.h
b/src/core/CLucene/index/_DocumentsWriter.h
index 0af73e53..585d0595 100644
--- a/src/core/CLucene/index/_DocumentsWriter.h
+++ b/src/core/CLucene/index/_DocumentsWriter.h
@@ -85,6 +85,7 @@ public:
virtual void abort(AbortException *ae) = 0;
virtual bool addDocument(document::Document *doc, analysis::Analyzer
*analyzer) = 0;
virtual bool updateDocument(Term* t, CL_NS(document)::Document* doc,
CL_NS(analysis)::Analyzer* analyzer) = 0;
+virtual bool addNullDocument(CL_NS(document)::Document *doc) = 0;
virtual const std::vector *abortedFiles() = 0;
virtual bool bufferDeleteTerm(Term *term) = 0;
virtual bool pauseAllThreads() = 0;
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](variant) fix topn two phase read slot lost paths info [doris]
github-actions[bot] commented on PR #28618: URL: https://github.com/apache/doris/pull/28618#issuecomment-1862207590 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](variant) fix topn two phase read slot lost paths info [doris]
github-actions[bot] commented on PR #28618: URL: https://github.com/apache/doris/pull/28618#issuecomment-1862207565 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](join) fix wrong result on left anti mark join [doris]
github-actions[bot] commented on PR #28586: URL: https://github.com/apache/doris/pull/28586#issuecomment-1862205333 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Bug](join) fix wrong result on left anti mark join [doris]
github-actions[bot] commented on PR #28586: URL: https://github.com/apache/doris/pull/28586#issuecomment-1862205296 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) compaction should catch exception when vertical block reader read next block [doris]
github-actions[bot] commented on PR #28625: URL: https://github.com/apache/doris/pull/28625#issuecomment-1862203931 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](expr) Support kill query by query_id [doris]
nanfeng1999 commented on PR #28530: URL: https://github.com/apache/doris/pull/28530#issuecomment-1862201624 run pipelinex_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [performance](Nereids): avoid use getStringValue() in getTimeFormatter [doris]
xiaokang commented on PR #28582: URL: https://github.com/apache/doris/pull/28582#issuecomment-1862201924 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
github-actions[bot] commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862199607 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](variant) pick alive replica and backend for command desc [doris]
github-actions[bot] commented on PR #28620: URL: https://github.com/apache/doris/pull/28620#issuecomment-1862200117 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](inverted index) add ignore_above property to prevent long s… [doris]
github-actions[bot] commented on PR #28585: URL: https://github.com/apache/doris/pull/28585#issuecomment-1862199572 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](variant) pick alive replica and backend for command desc [doris]
github-actions[bot] commented on PR #28620: URL: https://github.com/apache/doris/pull/28620#issuecomment-1862198745 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](compaction) compaction should catch exception when vertical block reader read next block [doris]
hust-hhb commented on PR #28625: URL: https://github.com/apache/doris/pull/28625#issuecomment-1862198169 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
