[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1950: Refactor txn manager methods
chaoyli commented on a change in pull request #1950: Refactor txn manager
methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333824806
##
File path: be/src/olap/txn_manager.cpp
##
@@ -122,7 +149,7 @@ OLAPStatus TxnManager::prepare_txn(
OLAPStatus TxnManager::commit_txn(
OlapMeta* meta, TPartitionId partition_id, TTransactionId transaction_id,
TTabletId tablet_id, SchemaHash schema_hash, TabletUid tablet_uid,
-const PUniqueId& load_id, RowsetSharedPtr rowset_ptr, bool is_recovery) {
+const PUniqueId& load_id, RowsetSharedPtr& rowset_ptr, bool is_recovery) {
Review comment:
const RowsetSharedPtr&
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1950: Refactor txn manager methods
chaoyli commented on a change in pull request #1950: Refactor txn manager
methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333825032
##
File path: be/src/olap/txn_manager.cpp
##
@@ -76,6 +76,33 @@ TxnManager::TxnManager() {
}
}
+OLAPStatus TxnManager::prepare_txn(TPartitionId partition_id, const
TabletSharedPtr& tablet, TTransactionId transaction_id,
Review comment:
1. May two prepare_txn() merged into one mothod?
2. partition_id can also get from tablet.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1950: Refactor txn manager methods
chaoyli commented on a change in pull request #1950: Refactor txn manager
methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333824839
##
File path: be/src/olap/txn_manager.cpp
##
@@ -211,7 +238,7 @@ OLAPStatus TxnManager::commit_txn(
// remove a txn from txn manager
OLAPStatus TxnManager::publish_txn(OlapMeta* meta, TPartitionId partition_id,
TTransactionId transaction_id,
TTabletId tablet_id, SchemaHash
schema_hash, TabletUid tablet_uid,
- Version& version, VersionHash&
version_hash) {
+ const Version& version, VersionHash
version_hash) {
pair key(partition_id, transaction_id);
Review comment:
const VersionHash&
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1950: Refactor txn manager methods
chaoyli commented on a change in pull request #1950: Refactor txn manager
methods
URL: https://github.com/apache/incubator-doris/pull/1950#discussion_r333824873
##
File path: be/src/olap/txn_manager.h
##
@@ -80,14 +97,14 @@ class TxnManager {
OLAPStatus commit_txn(OlapMeta* meta, TPartitionId partition_id,
TTransactionId transaction_id,
TTabletId tablet_id, SchemaHash schema_hash,
TabletUid tablet_uid,
- const PUniqueId& load_id, RowsetSharedPtr
rowset_ptr,
+ const PUniqueId& load_id, RowsetSharedPtr&
rowset_ptr,
bool is_recovery);
// remove a txn from txn manager
// not persist rowset meta because
OLAPStatus publish_txn(OlapMeta* meta, TPartitionId partition_id,
TTransactionId transaction_id,
TTabletId tablet_id, SchemaHash schema_hash,
TabletUid tablet_uid,
- Version& version, VersionHash& version_hash);
+ const Version& version, VersionHash version_hash);
Review comment:
const VersionHash&
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
