[GitHub] [incubator-doris] imay commented on a change in pull request #1948: Add object type

[GitBox]

imay commented on a change in pull request #1948: Add object type
URL: https://github.com/apache/incubator-doris/pull/1948#discussion_r333428334
 
 

 ##
 File path: gensrc/proto/segment_v2.proto
 ##
 @@ -53,6 +53,7 @@ enum EncodingTypePB {
 RLE = 4;
 DICT_ENCODING = 5;
 BIT_SHUFFLE = 6;
+BINARY_PLAIN_ENCODING = 7;
 
 Review comment:
   Better to add some comment about difference between PLAIN_ENCODING and 
BINARY_PLAIN_ENCODING.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

[GitHub] [incubator-doris] imay commented on a change in pull request #1948: Add object type

[GitBox]

imay commented on a change in pull request #1948: Add object type
URL: https://github.com/apache/incubator-doris/pull/1948#discussion_r333454949
 
 

 ##
 File path: fe/src/main/jflex/sql_scanner.flex
 ##
 @@ -218,6 +218,7 @@ import org.apache.doris.common.util.SqlUtils;
 keywordMap.put("not", new Integer(SqlParserSymbols.KW_NOT));
 keywordMap.put("null", new Integer(SqlParserSymbols.KW_NULL));
 keywordMap.put("nulls", new Integer(SqlParserSymbols.KW_NULLS));
+keywordMap.put("object", new Integer(SqlParserSymbols.KW_OBJECT));
 
 Review comment:
   Do we need to expose OBJECT to Doris USER? I think we should expose 
specified type to user, such as HLL, GEO_SHAPE, BITMAP?
   How about adding attribute for column to identify what specified type it is? 
Such as OBJECT("hll"), OBJECT("bitmap")?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org