[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework
between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r355824192
##
File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java
##
@@ -379,6 +384,14 @@ public boolean getForwardToMaster() {
return forwardToMaster;
}
+public void setDefaultRowsetType(String defaultRowsetType) {
Review comment:
`setDefaultRowsetType` and `getDefaultRowsetType` are both unused, remove
them
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247 URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r355824871 ## File path: fe/src/main/java/org/apache/doris/qe/SessionVariable.java ## @@ -213,6 +214,10 @@ @VariableMgr.VarAttr(name = LOAD_MEM_LIMIT) private long loadMemLimit = 0L; +// the flags passed to Backends Review comment: defaultRowsetType is only used to represent the storage format. NOT the heartbeat flag. Change the comment. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247 URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r355176510 ## File path: fe/src/main/java/org/apache/doris/qe/GlobalVariable.java ## @@ -56,6 +56,10 @@ @VariableMgr.VarAttr(name = "query_cache_size") private static long queryCacheSize = 1048576; +// the flags passed to Backends +@VariableMgr.VarAttr(name = "is_set_default_rowset_to_beta") +public static boolean isSetDefaultRowsetToBeta = false; Review comment: Why not use variable like `set default_rowset_type = "alpha[beta]"` ? If we add another rowset type in future, should we add a new variable named `isSetDefaultRowsetToGamma`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework
between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353042239
##
File path: fe/src/main/java/org/apache/doris/analysis/SetVar.java
##
@@ -128,6 +127,17 @@ else if (result instanceof IntLiteral) {
result = new
IntLiteral(SqlModeHelper.encode(sqlMode).toString(), Type.BIGINT);
}
}
+if (variable.equalsIgnoreCase(GlobalVariable.HEARTBEAT_FLAGS)) {
Review comment:
The way of analyzing variables has been changed.
You'd better wait this PR merged and change it to that way:
https://github.com/apache/incubator-doris/pull/2355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework
between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353040483
##
File path: be/src/olap/schema_change.cpp
##
@@ -1123,6 +1123,9 @@ bool SchemaChangeWithSorting::_internal_sorting(const
vector& row_blo
context.partition_id = new_tablet->partition_id();
context.tablet_schema_hash = new_tablet->schema_hash();
context.rowset_type = new_rowset_type;
+if (StorageEngine::instance()->set_default_rowset_type_to_beta()) {
Review comment:
I think we need a framework to set this rowset_type, instead of setting this
at each time the RowsetWriterContext created.
Or it is very easy to miss some places.
Maybe in `RowsetWriterContext`'s constructor?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247 URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353042740 ## File path: fe/src/main/java/org/apache/doris/qe/GlobalVariable.java ## @@ -56,6 +56,11 @@ @VariableMgr.VarAttr(name = "query_cache_size") private static long queryCacheSize = 1048576; +public static final String HEARTBEAT_FLAGS = "heartbeat_flags"; Review comment: `public static final String HEARTBEAT_FLAGS = "heartbeat_flags";` move this line to the above, with other variables' name declaration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
morningman commented on a change in pull request #2364: add a control framework
between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353038861
##
File path: be/src/olap/heartbeat_flags_helper.h
##
@@ -0,0 +1,57 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include
+#include
+#include
+
+namespace doris {
+
+class HeartbeatFlagsHelper {
Review comment:
Add comment to this class to explain what is this class for and how to use
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
