Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-08 Thread via GitHub


github-actions[bot] commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2042150193

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-08 Thread via GitHub


dataroaring merged PR #33350:
URL: https://github.com/apache/doris/pull/33350


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-08 Thread via GitHub


doris-robot commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2041929121

   TeamCity be ut coverage result:
Function Coverage: 35.62% (/24954) 
Line Coverage: 27.35% (72982/266872)
Region Coverage: 26.51% (37722/142285)
Branch Coverage: 23.33% (19226/82402)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/77707474a67d3b1237d0e7aeb85d2079e35d28cd_77707474a67d3b1237d0e7aeb85d2079e35d28cd/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


yujun777 commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2041883143

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


github-actions[bot] commented on code in PR #33350:
URL: https://github.com/apache/doris/pull/33350#discussion_r1555234362


##
be/src/util/debug_points.h:
##
@@ -17,6 +17,7 @@
 
 #pragma once
 
+#include 
 #include 
 #include 

Review Comment:
   warning: 'boost/lexical_cast.hpp' file not found [clang-diagnostic-error]
   ```cpp
   #include 
^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


github-actions[bot] commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2041878073

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


yujun777 commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2041876202

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


doris-robot commented on PR #33350:
URL: https://github.com/apache/doris/pull/33350#issuecomment-2041876151

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [feature](debug point) Add handler to debug point [doris]

2024-04-07 Thread via GitHub


yujun777 opened a new pull request, #33350:
URL: https://github.com/apache/doris/pull/33350

   Can use handler to exchange local variable between the base code and inject 
code.
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org