Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-06 Thread via GitHub


zy-kkk merged PR #33227:
URL: https://github.com/apache/doris/pull/33227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-06 Thread via GitHub


github-actions[bot] commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2041290887

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035201538

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit 78bd4bf27aaeff9226849adb91135c4d9a93df12 with 
default session variables
   Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
   Stream load orc:  58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:   16.1 seconds inserted 1000 Rows, about 621K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035196202

   
   
   ClickBench: Total hot run time: 30.17 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 78bd4bf27aaeff9226849adb91135c4d9a93df12, 
data reload: false
   
   query1   0.040.040.03
   query2   0.080.040.04
   query3   0.230.040.04
   query4   1.690.070.07
   query5   0.490.480.50
   query6   1.130.650.66
   query7   0.020.010.01
   query8   0.050.030.04
   query9   0.550.510.51
   query10  0.570.580.56
   query11  0.160.120.12
   query12  0.140.120.12
   query13  0.600.590.59
   query14  0.770.790.79
   query15  0.850.840.85
   query16  0.360.360.35
   query17  0.990.991.02
   query18  0.250.240.28
   query19  1.831.711.75
   query20  0.020.010.02
   query21  15.42   0.630.63
   query22  4.345.531.82
   query23  17.99   1.221.23
   query24  1.560.220.19
   query25  0.170.080.07
   query26  0.270.160.16
   query27  0.080.070.07
   query28  13.79   0.970.96
   query29  12.54   3.303.23
   query30  0.260.060.06
   query31  2.850.390.39
   query32  3.300.480.48
   query33  2.842.892.89
   query34  15.50   4.394.35
   query35  4.424.414.39
   query36  0.680.470.47
   query37  0.180.150.16
   query38  0.160.140.14
   query39  0.040.040.04
   query40  0.170.140.14
   query41  0.100.050.05
   query42  0.060.050.05
   query43  0.040.040.04
   Total cold run time: 107.58 s
   Total hot run time: 30.17 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035185965

   
   
   TPC-DS: Total hot run time: 181732 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 78bd4bf27aaeff9226849adb91135c4d9a93df12, 
data reload: false
   
   query1   1211112911191119
   query2   6303188918851885
   query3   6678204 201 201
   query4   24475   21489   21454   21454
   query5   4203396 400 396
   query6   266 179 177 177
   query7   4604298 292 292
   query8   224 177 170 170
   query9   8448221322282213
   query10  444 240 234 234
   query11  15100   14571   14468   14468
   query12  143 103 86  86
   query13  1645389 379 379
   query14  8440684668286828
   query15  207 181 180 180
   query16  6779260 261 260
   query17  1009572 571 571
   query18  1852300 285 285
   query19  195 158 155 155
   query20  95  93  92  92
   query21  194 130 128 128
   query22  4966493848044804
   query23  33419   32953   32672   32672
   query24  11262   316531823165
   query25  703 411 452 411
   query26  1855165 159 159
   query27  3277365 377 365
   query28  7493186818611861
   query29  1299589 588 588
   query30  304 178 171 171
   query31  975 729 744 729
   query32  92  53  56  53
   query33  628 234 235 234
   query34  1236519 516 516
   query35  839 714 733 714
   query36  997 861 891 861
   query37  265 75  72  72
   query38  3727367236023602
   query39  1619157715961577
   query40  240 127 126 126
   query41  44  44  44  44
   query42  115 99  108 99
   query43  481 416 434 416
   query44  1173731 723 723
   query45  293 290 286 286
   query46  1125833 778 778
   query47  1965186218821862
   query48  372 296 308 296
   query49  978 371 368 368
   query50  829 402 415 402
   query51  6906672067046704
   query52  104 96  90  90
   query53  358 300 299 299
   query54  286 246 230 230
   query55  81  80  78  78
   query56  249 242 240 240
   query57  1271118712201187
   query58  246 218 226 218
   query59  2760254223572357
   query60  265 240 242 240
   query61  109 106 109 106
   query62  666 457 452 452
   query63  302 283 281 281
   query64  5894327032473247
   query65  3069302530603025
   query66  1350342 320 320
   query67  16273   15041   14818   14818
   query68  9276576 565 565
   query69  596 326 298 298
   query70  1440106610501050
   query71  514 266 264 264
   query72  6601259024112411
   query73  1596318 325 318
   query74  6767628063736280
   query75  3890227423012274
   query76  6267116212301162
   query77  647 247 237 237
   query78  10884   10166   10074   10074
   query79  12479   540 528 528
   query80  1660418 408 408
   query81  496 244 237 237
   query82  406 94  92  92
   query83  208 163 164 163
   query84  266 93  83  83
   query85  991 285 276 276
   query86  358 313 303 303
   query87  3691349934783478
   query88  4391227422682268
   query89  553 369 364 364
   query90  2029182 179 179
   query91  135 100 108 100
   query92  60  47  47  47
   query93  6688537 531 531
   query94  1251182 182 182
   query95  434 308 311 308
   query96  615 275 272 272
   query97  2722252225032503
   query98  260 215 209 209
   query99  1217853 849 849
   Total cold run time: 304663 ms
   Total hot run time: 181732 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to 

Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035162160

   
   
   TPC-H: Total hot run time: 38364 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 78bd4bf27aaeff9226849adb91135c4d9a93df12, 
data reload: false
   
   -- Round 1 --
   q1   17641   418441214121
   q2   2010191 182 182
   q3   10474   116413321164
   q4   10217   808 929 808
   q5   7462296928962896
   q6   218 134 131 131
   q7   1079610 581 581
   q8   9394201619911991
   q9   6727617961616161
   q10  8458350134843484
   q11  426 242 243 242
   q12  377 204 203 203
   q13  17776   291529252915
   q14  265 235 237 235
   q15  511 482 477 477
   q16  504 392 366 366
   q17  944 889 879 879
   q18  7237658063656365
   q19  1792153015171517
   q20  573 321 315 315
   q21  3434308030383038
   q22  373 293 295 293
   Total cold run time: 107892 ms
   Total hot run time: 38364 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4154412341234123
   q2   326 219 234 219
   q3   2940295829332933
   q4   1843182618591826
   q5   5192518251785178
   q6   208 124 125 124
   q7   177617831776
   q8   3192326332763263
   q9   8443845184218421
   q10  3726389239733892
   q11  562 451 463 451
   q12  751 588 596 588
   q13  16922   310731453107
   q14  310 278 305 278
   q15  535 489 477 477
   q16  492 428 421 421
   q17  1756172017291720
   q18  8167779675547554
   q19  1708166516711665
   q20  2018184618591846
   q21  5072497848034803
   q22  495 438 433 433
   Total cold run time: 71034 ms
   Total hot run time: 55098 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035148714

   TeamCity be ut coverage result:
Function Coverage: 35.64% (8882/24922) 
Line Coverage: 27.37% (72925/266411)
Region Coverage: 26.55% (37708/142019)
Branch Coverage: 23.35% (19215/82280)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/78bd4bf27aaeff9226849adb91135c4d9a93df12_78bd4bf27aaeff9226849adb91135c4d9a93df12/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


github-actions[bot] commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035102571

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


zy-kkk commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2035093852

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034169851

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit c6ff442967eed53de2abfdff58d41663f8d144ea with 
default session variables
   Stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
   Stream load orc:  59 seconds loaded 1101869774 Bytes, about 17 MB/s
   Stream load parquet:  31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:   16.2 seconds inserted 1000 Rows, about 617K 
ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034164121

   
   
   ClickBench: Total hot run time: 29.88 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c6ff442967eed53de2abfdff58d41663f8d144ea, 
data reload: false
   
   query1   0.040.040.03
   query2   0.080.040.04
   query3   0.240.040.04
   query4   1.680.070.07
   query5   0.490.480.50
   query6   1.140.650.66
   query7   0.020.010.00
   query8   0.050.040.04
   query9   0.550.500.50
   query10  0.580.560.55
   query11  0.150.110.11
   query12  0.130.120.11
   query13  0.600.600.59
   query14  0.770.790.78
   query15  0.870.840.84
   query16  0.360.350.36
   query17  1.021.030.97
   query18  0.260.250.26
   query19  1.821.741.75
   query20  0.010.000.00
   query21  15.43   0.760.76
   query22  3.484.511.42
   query23  17.40   1.251.18
   query24  1.460.220.23
   query25  0.120.090.08
   query26  0.280.170.19
   query27  0.090.090.07
   query28  13.76   0.960.94
   query29  12.66   3.303.32
   query30  0.260.060.06
   query31  2.880.390.38
   query32  3.280.480.47
   query33  2.882.892.88
   query34  15.52   4.334.35
   query35  4.344.364.39
   query36  0.670.470.48
   query37  0.190.170.17
   query38  0.170.160.16
   query39  0.050.050.03
   query40  0.170.150.15
   query41  0.090.050.05
   query42  0.060.050.05
   query43  0.050.050.04
   Total cold run time: 106.15 s
   Total hot run time: 29.88 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034153570

   
   
   TPC-DS: Total hot run time: 182096 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c6ff442967eed53de2abfdff58d41663f8d144ea, 
data reload: false
   
   query1   1212110811171108
   query2   6467195919291929
   query3   6670205 212 205
   query4   24678   21503   21446   21446
   query5   4154406 399 399
   query6   283 183 184 183
   query7   4601310 296 296
   query8   230 181 182 181
   query9   8461222422182218
   query10  587 257 255 255
   query11  14862   14542   14416   14416
   query12  150 100 101 100
   query13  1646379 395 379
   query14  8794689568536853
   query15  208 179 176 176
   query16  6791268 270 268
   query17  1001591 577 577
   query18  1802281 279 279
   query19  201 157 156 156
   query20  95  92  92  92
   query21  197 131 121 121
   query22  5123493449624934
   query23  33575   32440   32743   32440
   query24  12658   320331323132
   query25  684 395 409 395
   query26  1931161 170 161
   query27  3019328 326 326
   query28  6784184618181818
   query29  1122588 597 588
   query30  314 167 172 167
   query31  993 729 731 729
   query32  96  61  60  60
   query33  713 258 258 258
   query34  1053492 494 492
   query35  815 702 710 702
   query36  997 873 854 854
   query37  234 82  79  79
   query38  3546339333813381
   query39  1563151815411518
   query40  301 139 140 139
   query41  48  47  46  46
   query42  118 105 106 105
   query43  427 401 400 400
   query44  1090718 705 705
   query45  282 248 260 248
   query46  1070804 770 770
   query47  1889182618271826
   query48  389 313 302 302
   query49  1177375 393 375
   query50  794 385 383 383
   query51  6725660965996599
   query52  108 95  96  95
   query53  351 288 286 286
   query54  336 235 243 235
   query55  97  82  79  79
   query56  249 229 227 227
   query57  1227115111061106
   query58  246 221 225 221
   query59  2481234022472247
   query60  274 237 240 237
   query61  110 107 122 107
   query62  686 447 452 447
   query63  323 284 288 284
   query64  6590343234543432
   query65  3096300130283001
   query66  1459331 332 331
   query67  15483   14985   14950   14950
   query68  7669565 579 565
   query69  552 340 336 336
   query70  1199109310881088
   query71  499 285 278 278
   query72  6367259723952395
   query73  797 320 326 320
   query74  6652636764086367
   query75  3367231322952295
   query76  4755110812051108
   query77  619 257 262 257
   query78  11065   10085   10247   10085
   query79  11041   533 545 533
   query80  1890420 435 420
   query81  502 255 242 242
   query82  569 104 107 104
   query83  219 163 162 162
   query84  279 87  88  87
   query85  1338324 282 282
   query86  374 280 305 280
   query87  3652347534373437
   query88  3951228422882284
   query89  564 380 379 379
   query90  1976181 177 177
   query91  133 103 101 101
   query92  67  51  51  51
   query93  7195542 543 542
   query94  1296194 194 194
   query95  1096109310951093
   query96  618 275 272 272
   query97  2702247824732473
   query98  240 216 206 206
   query99  1298834 829 829
   Total cold run time: 300277 ms
   Total hot run time: 182096 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to 

Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034125028

   
   
   TPC-H: Total hot run time: 38897 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c6ff442967eed53de2abfdff58d41663f8d144ea, 
data reload: false
   
   -- Round 1 --
   q1   18119   423541714171
   q2   2398195 188 188
   q3   11277   126214481262
   q4   10838   948 1048948
   q5   7584297529312931
   q6   215 133 133 133
   q7   1089606 616 606
   q8   9401206520282028
   q9   6750620061326132
   q10  8407351535813515
   q11  410 229 229 229
   q12  382 214 214 214
   q13  17779   291529102910
   q14  271 237 249 237
   q15  534 492 478 478
   q16  507 379 372 372
   q17  969 904 880 880
   q18  7561642564566425
   q19  1611153215281528
   q20  603 308 311 308
   q21  3545311031063106
   q22  352 296 297 296
   Total cold run time: 110602 ms
   Total hot run time: 38897 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4047404840464046
   q2   329 218 227 218
   q3   2938295029672950
   q4   1875187118331833
   q5   5254520952005200
   q6   207 124 123 123
   q7   2242180818161808
   q8   3229327932783278
   q9   8512846084958460
   q10  3775380338303803
   q11  538 455 456 455
   q12  734 562 557 557
   q13  16835   289728812881
   q14  308 259 263 259
   q15  511 482 480 480
   q16  459 405 396 396
   q17  1733167316871673
   q18  7643727673767276
   q19  1635162916331629
   q20  1953171817161716
   q21  5020464647184646
   q22  487 422 428 422
   Total cold run time: 70264 ms
   Total hot run time: 54109 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034122472

   TeamCity be ut coverage result:
Function Coverage: 35.65% (8882/24915) 
Line Coverage: 27.37% (72902/266351)
Region Coverage: 26.54% (37693/142018)
Branch Coverage: 23.34% (19207/82286)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/c6ff442967eed53de2abfdff58d41663f8d144ea_c6ff442967eed53de2abfdff58d41663f8d144ea/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


github-actions[bot] commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034097812

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


github-actions[bot] commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034097660

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


github-actions[bot] commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034089409

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


zy-kkk commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034073193

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


doris-robot commented on PR #33227:
URL: https://github.com/apache/doris/pull/33227#issuecomment-2034071018

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your 
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to 
[doris-website](https://github.com/apache/doris-website).
   See [Doris 
Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



[PR] [improvement](serde) Handle NaN values in number for MySQL result write [doris]

2024-04-03 Thread via GitHub


zy-kkk opened a new pull request, #33227:
URL: https://github.com/apache/doris/pull/33227

   ## Proposed changes
   
   Issue Number: close #xxx
   
   
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org