Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
starocean999 merged PR #34475: URL: https://github.com/apache/doris/pull/34475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099955287 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit c2118a67caa9b79d8f42cf38d7503c985905319c with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.4 seconds inserted 1000 Rows, about 467K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099949151 ClickBench: Total hot run time: 30.46 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit c2118a67caa9b79d8f42cf38d7503c985905319c, data reload: false query1 0.030.020.02 query2 0.070.020.03 query3 0.250.040.05 query4 1.780.070.06 query5 0.530.530.52 query6 1.240.630.62 query7 0.010.010.01 query8 0.030.030.02 query9 0.540.470.47 query10 0.550.520.54 query11 0.120.080.09 query12 0.110.090.09 query13 0.620.610.62 query14 0.780.790.78 query15 0.780.770.76 query16 0.390.370.36 query17 1.001.000.96 query18 0.230.250.24 query19 1.901.851.84 query20 0.010.010.02 query21 15.47 0.540.56 query22 2.042.181.32 query23 16.86 1.090.96 query24 7.941.461.01 query25 0.400.090.04 query26 0.880.150.14 query27 0.040.030.04 query28 4.810.740.78 query29 12.60 2.282.34 query30 0.600.520.51 query31 2.810.390.37 query32 3.400.500.49 query33 3.053.103.05 query34 15.24 4.824.82 query35 4.884.864.86 query36 1.041.021.02 query37 0.060.050.04 query38 0.040.020.02 query39 0.020.020.01 query40 0.160.140.14 query41 0.070.010.01 query42 0.020.010.01 query43 0.020.020.02 Total cold run time: 103.42 s Total hot run time: 30.46 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099938717 TPC-DS: Total hot run time: 202612 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit c2118a67caa9b79d8f42cf38d7503c985905319c, data reload: false query1 924 393 369 369 query2 6524274627352735 query3 6915205 198 198 query4 19939 18003 17854 17854 query5 19736 652964856485 query6 287 221 235 221 query7 4150311 316 311 query8 242 256 219 219 query9 3081265925892589 query10 415 290 299 290 query11 11271 10702 10717 10702 query12 122 72 77 72 query13 5573697 690 690 query14 17747 13301 13411 13301 query15 377 227 229 227 query16 6473270 260 260 query17 17201474874 874 query18 2306405 400 400 query19 210 145 155 145 query20 79 80 80 80 query21 193 91 91 91 query22 5254499850204998 query23 32732 32014 31873 31873 query24 6935646464356435 query25 521 415 425 415 query26 538 161 159 159 query27 1872294 301 294 query28 6198241423502350 query29 2999262526762625 query30 238 161 162 161 query31 918 728 750 728 query32 67 64 62 62 query33 401 250 254 250 query34 856 477 479 477 query35 1156933 964 933 query36 1313104711371047 query37 88 58 60 58 query38 3052292529452925 query39 1356131013331310 query40 206 95 93 93 query41 41 43 37 37 query42 83 84 82 82 query43 776 662 759 662 query44 1124739 739 739 query45 244 233 224 224 query46 1231966 969 966 query47 1769166816381638 query48 1006707 703 703 query49 615 372 370 370 query50 863 637 629 629 query51 4744463846724638 query52 87 86 87 86 query53 448 320 318 318 query54 2654243124202420 query55 92 87 81 81 query56 224 215 206 206 query57 1206112710511051 query58 203 212 210 210 query59 4222409940564056 query60 217 188 209 188 query61 89 84 84 84 query62 831 492 464 464 query63 476 347 343 343 query64 2538147614691469 query65 3631360435393539 query66 822 383 382 382 query67 15849 15141 15393 15141 query68 9620650 648 648 query69 592 354 351 351 query70 1745142313761376 query71 417 313 313 313 query72 6497343234413432 query73 730 328 325 325 query74 6368588358905883 query75 5312366337553663 query76 6048113612071136 query77 1017260 253 253 query78 12946 11886 11660 11660 query79 8210644 632 632 query80 1401382 389 382 query81 495 238 229 229 query82 1571100 97 97 query83 178 131 129 129 query84 255 69 71 69 query85 850 297 297 297 query86 342 310 297 297 query87 3171306130103010 query88 4842233323132313 query89 392 273 276 273 query90 1943210 205 205 query91 165 132 164 132 query92 57 56 52 52 query93 6332565 609 565 query94 691 202 203 202 query95 104810351035 query96 645 332 321 321 query97 6599642063526352 query98 195 176 164 164 query99 2843784 953 784 Total cold run time: 314649 ms Total hot run time: 202612 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099917390 TPC-H: Total hot run time: 50259 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit c2118a67caa9b79d8f42cf38d7503c985905319c, data reload: false -- Round 1 -- q1 17560 440942774277 q2 2023157 144 144 q3 10266 188119081881 q4 10106 125313401253 q5 8512396139423942 q6 238 128 127 127 q7 2032159115991591 q8 9253273027172717 q9 11031 11529 10886 10886 q10 8592348235303482 q11 415 249 251 249 q12 468 300 305 300 q13 18366 397040053970 q14 358 327 318 318 q15 514 470 458 458 q16 695 575 586 575 q17 1139956 953 953 q18 7281679168366791 q19 1720159815571557 q20 557 305 305 305 q21 4432413340974097 q22 490 386 399 386 Total cold run time: 116048 ms Total hot run time: 50259 ms - Round 2, with runtime_filter_mode=off - q1 4306427543034275 q2 323 224 227 224 q3 4161417541314131 q4 2734272127352721 q5 7187714571847145 q6 239 120 117 117 q7 3292282528722825 q8 4331442544454425 q9 17393 17046 17069 17046 q10 4259423442464234 q11 737 654 647 647 q12 1032863 869 863 q13 4468371636973697 q14 452 421 423 421 q15 499 466 449 449 q16 724 674 680 674 q17 3793383138433831 q18 8818870387808703 q19 1710169516011601 q20 2359214721372137 q21 8486841584848415 q22 1005935 931 931 Total cold run time: 82308 ms Total hot run time: 79512 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
starocean999 commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099885470 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099780946 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit f86c90764700fc205c99d8650fd9122eae680e37 with default session variables Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.6 seconds inserted 1000 Rows, about 462K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099778193 ClickBench: Total hot run time: 31.15 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f86c90764700fc205c99d8650fd9122eae680e37, data reload: false query1 0.020.020.02 query2 0.070.020.02 query3 0.250.040.04 query4 1.800.060.06 query5 0.530.520.51 query6 1.290.620.63 query7 0.010.020.01 query8 0.030.020.03 query9 0.530.500.48 query10 0.540.520.53 query11 0.110.090.09 query12 0.110.090.10 query13 0.620.600.61 query14 0.770.780.80 query15 0.780.770.77 query16 0.360.380.36 query17 0.960.971.00 query18 0.220.270.22 query19 1.941.881.78 query20 0.020.010.01 query21 15.51 0.550.54 query22 1.961.711.76 query23 17.36 1.110.94 query24 5.251.481.37 query25 0.340.140.04 query26 0.610.150.16 query27 0.040.050.03 query28 7.720.720.69 query29 12.75 2.362.37 query30 0.620.530.53 query31 2.810.400.37 query32 3.350.500.50 query33 3.063.083.05 query34 15.29 4.784.79 query35 4.844.864.84 query36 1.061.051.03 query37 0.060.050.04 query38 0.030.020.02 query39 0.020.020.01 query40 0.160.140.14 query41 0.070.020.01 query42 0.030.010.02 query43 0.020.020.02 Total cold run time: 103.92 s Total hot run time: 31.15 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099773400 TPC-DS: Total hot run time: 203526 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f86c90764700fc205c99d8650fd9122eae680e37, data reload: false query1 921 388 376 376 query2 6531285228792852 query3 6924203 202 202 query4 20438 18175 17910 17910 query5 19723 651664786478 query6 281 219 233 219 query7 4173300 300 300 query8 256 248 245 245 query9 3123270226132613 query10 415 292 302 292 query11 11309 10738 10801 10738 query12 122 84 80 80 query13 5578694 684 684 query14 17731 13610 13165 13165 query15 363 230 222 222 query16 6458283 263 263 query17 17391454883 883 query18 2306407 415 407 query19 209 144 158 144 query20 79 78 82 78 query21 188 90 98 90 query22 5248516351055105 query23 32799 31854 31906 31854 query24 6958644964716449 query25 494 426 413 413 query26 522 161 157 157 query27 1906295 297 295 query28 6170238523242324 query29 2954286126642664 query30 250 163 168 163 query31 921 768 755 755 query32 72 61 63 61 query33 381 260 237 237 query34 865 471 486 471 query35 1131923 944 923 query36 1337128911321132 query37 91 63 58 58 query38 3075297629082908 query39 1382132113351321 query40 202 92 93 92 query41 38 36 36 36 query42 88 87 87 87 query43 678 726 655 655 query44 1123736 733 733 query45 243 229 233 229 query46 1241947 953 947 query47 1759194916581658 query48 1022705 703 703 query49 633 360 372 360 query50 854 587 598 587 query51 4706469547084695 query52 95 77 90 77 query53 443 316 319 316 query54 2660243124302430 query55 91 85 77 77 query56 246 201 211 201 query57 1336114310871087 query58 206 187 207 187 query59 4333379438723794 query60 199 198 206 198 query61 88 91 83 83 query62 856 502 468 468 query63 474 338 340 338 query64 2513145614441444 query65 3625354935313531 query66 780 367 383 367 query67 16920 16073 15549 15549 query68 8717659 652 652 query69 591 339 346 339 query70 1529149716041497 query71 421 318 325 318 query72 6528343533893389 query73 731 327 328 327 query74 6439582759555827 query75 4970368336903683 query76 5018112012121120 query77 689 263 251 251 query78 12629 13066 11999 11999 query79 9279642 680 642 query80 786 390 401 390 query81 508 241 227 227 query82 297 101 97 97 query83 164 134 129 129 query84 258 70 69 69 query85 762 290 290 290 query86 338 288 296 288 query87 3267305330483048 query88 4700233123272327 query89 438 294 283 283 query90 1908220 209 209 query91 163 135 133 133 query92 59 57 51 51 query93 3940587 585 585 query94 700 209 208 208 query95 1133106710421042 query96 648 324 339 324 query97 6498632863956328 query98 185 180 174 174 query99 2890820 872 820 Total cold run time: 310058 ms Total hot run time: 203526 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
doris-robot commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099759949 TPC-H: Total hot run time: 49843 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f86c90764700fc205c99d8650fd9122eae680e37, data reload: false -- Round 1 -- q1 18008 463746134613 q2 2471170 151 151 q3 11082 191519751915 q4 10103 123713011237 q5 8425393238953895 q6 234 127 124 124 q7 2032163615971597 q8 9326272727032703 q9 10655 10177 10350 10177 q10 8612352734973497 q11 433 241 252 241 q12 467 300 300 300 q13 18372 397540163975 q14 354 336 336 336 q15 521 457 460 457 q16 695 569 574 569 q17 1122929 971 929 q18 7242677069346770 q19 1753157315591559 q20 524 318 299 299 q21 4421418741134113 q22 497 386 395 386 Total cold run time: 117349 ms Total hot run time: 49843 ms - Round 2, with runtime_filter_mode=off - q1 4343425642914256 q2 323 224 221 221 q3 4153417241454145 q4 2756273327382733 q5 7184708970567056 q6 235 121 121 121 q7 3238283028452830 q8 4352445044984450 q9 16898 16630 16836 16630 q10 4246426642384238 q11 790 696 692 692 q12 1050860 865 860 q13 7580372137453721 q14 447 417 419 417 q15 525 468 468 468 q16 737 682 678 678 q17 3936389438053805 q18 8728872588778725 q19 1700168816481648 q20 2369213020992099 q21 8456843084528430 q22 1069959 916 916 Total cold run time: 85115 ms Total hot run time: 79139 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
starocean999 commented on PR #34475: URL: https://github.com/apache/doris/pull/34475#issuecomment-2099740830 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
morrySnow merged PR #27006: URL: https://github.com/apache/doris/pull/27006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
XieJiann commented on code in PR #27006:
URL: https://github.com/apache/doris/pull/27006#discussion_r1405587597
##
fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java:
##
@@ -1060,7 +1060,13 @@ public static ScalarType getAssignmentCompatibleType(
if (t1.type == PrimitiveType.STRING || t2.type ==
PrimitiveType.STRING) {
return createStringType();
}
-return createVarcharType(Math.max(t1.len, t2.len));
+int minLength = Math.min(t1.len, t2.len);
+if (minLength < 0) {
+// If < 0 which means max length, use firstly
+return createVarcharType(minLength);
+}
Review Comment:
```suggestion
if (t1.len < 0 ｜｜ t2.len < 0) {
// If < 0 which means max length, use firstly
return createVarcharType(minLength);
}
```
##
fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java:
##
@@ -1060,7 +1060,13 @@ public static ScalarType getAssignmentCompatibleType(
if (t1.type == PrimitiveType.STRING || t2.type ==
PrimitiveType.STRING) {
return createStringType();
}
-return createVarcharType(Math.max(t1.len, t2.len));
+int minLength = Math.min(t1.len, t2.len);
+if (minLength < 0) {
+// If < 0 which means max length, use firstly
+return createVarcharType(minLength);
+}
Review Comment:
```suggestion
if (t1.len < 0 ｜｜ t2.len < 0) {
// If < 0 which means max length, use firstly
return createVarcharType(minLength);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
github-actions[bot] commented on PR #27006: URL: https://github.com/apache/doris/pull/27006#issuecomment-1827067296 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support where, group by, having, order by clause without from clause in query statement [doris]
github-actions[bot] commented on PR #27006: URL: https://github.com/apache/doris/pull/27006#issuecomment-1827067274 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
