[GitHub] [druid] bananaaggle commented on pull request #10710: fix web-console show json bug
bananaaggle commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-756582449 > @bananaaggle Thanks for this fix - can you please add a test that catches parsing these large numbers in the web-console so that future refactorings don't accidentally break this functionality. Thanks! > > EDIT - tagged the wrong user initially I'm not very familiar with console, can you give me some information for creating test about this PR? Like which direct I can refer to for creating test or other hints? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] bananaaggle commented on pull request #10710: fix web-console show json bug
bananaaggle commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-755929310 @vogievetsky I change code follow your suggestion. And I check all places JSON.stringify used and replace it if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [druid] bananaaggle commented on pull request #10710: fix web-console show json bug
bananaaggle commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-752190765 Hi, I want to know this merge failure. Can anyone help me ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
