maytasm commented on issue #9889: URL: https://github.com/apache/druid/issues/9889#issuecomment-631919882
@yuanlihan I am thinking that the segment will have to satisfy both conditions to be eligible for the kill task. The new `druid.coordinator.kill.fromLastModified` offers additional safety to prevent accidental killing of segments. If the user does not want the `druid.coordinator.kill.fromLastModified` and want the existing behavior then they can simply set druid.coordinator.kill.fromLastModified to 0. Basically, this ignores druid.coordinator.kill.fromLastModified and only requires segment to satisfy `druid.coordinator.kill.durationToRetain`. The benefit of `druid.coordinator.kill.fromLastModified` is for old segments that might have been dropped accidentally from incorrectly configured rules (usually rules are set for intervals of many months). For example, you might have a dropForever rule before a load rule (instead of the other way around). Those segments may be older than `druid.coordinator.kill.durationToRetain` but will not be kill due to `druid.coordinator.kill.fromLastModified` safety net. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
