[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-542450809 @leventov inspection failure from ` SeekableStreamSupervisor.java (4) 175: TaskGroup() Optional used as type for parameter 'minimumMessageTime' ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-537292221 @leventov looks like a code inspection issue, which is not related to this PR. verified the code I don't see any duplicate code. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-535793321 @leventov fixed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-535237459 @leventov "Inspections: pull requests (Druid) — TeamCity build failed" is not related to PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-534863961 @leventov made changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-533846781 @leventov thanks for the review, made changes based your suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-533739524 @leventov can you please review this also. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field
SandishKumarHN commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-533247091 @ccaominh Thanks for quick comments changed, please review now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
