[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups
ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342775228 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol } ``` +> If using JDBC, you will need to add your database's client JAR files to the extension's directory. +> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/, and for Postgres, from +> https://jdbc.postgresql.org/download.html or from the `extensions/postgresql-metadata-storage/`. +> Copy or symlink the downloaded file to +> `extensions/lookups-cached-global` under the distribution root directory. Review comment: I believe the directory should be `extensions/druid-lookups-cached-global`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups
ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342773224 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol } ``` +> If using JDBC, you will need to add your database's client JAR files to the extension's directory. +> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/, and for Postgres, from +> https://jdbc.postgresql.org/download.html or from the `extensions/postgresql-metadata-storage/`. Review comment: Typo: from the `extensions/postgresql-metadata-storage/` -> the `extensions/postgresql-metadata-storage/` directory. Or: from the `extensions/postgresql-metadata-storage/` -> from `extensions/postgresql-metadata-storage/` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
