[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550024263 >though maybe it should be since there is a NOTICE file, https://github.com/apache/thrift/blob/master/NOTICE. Responding to myself, but I don't think we need to worry about updating `licenses.yaml` in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550019038 >This PR will make Travis failed because it's not updating licences.yaml. It actually might not, the old version doesn't appear to be in `licenses.yaml`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550018795 >Why is this a development blocker? The old version of `scrooge-maven-plugin` uses a super old forked version of libthrift for some reason that isn't on maven central, and seems to have recently stopped working for teamcity and lgtm CI checks, meaning no PRs are passing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
