[GitHub] [incubator-druid] jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0
URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550073283
 
 
   The LGTM is failing with the same error even after I restarted once. Since 
TeamCity looks fine, I think it's an issue with LGTM (maybe it's caching 
something). I'll merge this PR shortly and will see other builds succeed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org



[GitHub] [incubator-druid] jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0
URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550010108
 
 
   +1 after CI.
   
   LGTM and Teamcity are failing because of the missing libthrift-0.5.0-1 jar. 
I think we can solve this by simply updating the version of 
`scrooge-maven-plugin` which is using that versino of libthrift.
   
   This PR will make Travis failed because it's not updating `licences.yaml`. I 
will raise a PR to fix that shortly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org