[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
surekhasaharan commented on a change in pull request #8864: add sequenceName
and currentCheckPoint for backwards compatibility
URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r347736029
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java
##
@@ -68,13 +69,32 @@ public Integer getTaskGroupId()
}
// For backwards compatibility
- @Deprecated
@JsonProperty
- public SeekableStreamDataSourceMetadata getPreviousCheckPoint()
+ private SeekableStreamDataSourceMetadata getPreviousCheckPoint()
{
return checkpointMetadata;
}
+ // For backwards compatibility
+ @JsonProperty
+ private SeekableStreamDataSourceMetadata getCurrentCheckPoint()
+ {
+return checkpointMetadata;
+ }
+
+ /**
+ * Returning a dummy value so the objects from older versions still work
Review comment:
This method is to add the missing property (`sequenceName`) in newer
serialized JSON. So the task fails on older middlemanager since it requires
this property, I think it doesn't matter what value is returned here, as long
as the property is present since the value is not really used in any production
code. But i guess the javadoc can be updated to say it's for rolling updates.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
surekhasaharan commented on a change in pull request #8864: add sequenceName
and currentCheckPoint for backwards compatibility
URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r347730328
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java
##
@@ -68,13 +69,32 @@ public Integer getTaskGroupId()
}
// For backwards compatibility
- @Deprecated
@JsonProperty
- public SeekableStreamDataSourceMetadata getPreviousCheckPoint()
+ private SeekableStreamDataSourceMetadata getPreviousCheckPoint()
{
return checkpointMetadata;
}
+ // For backwards compatibility
+ @JsonProperty
+ private SeekableStreamDataSourceMetadata getCurrentCheckPoint()
+ {
+return checkpointMetadata;
+ }
+
+ /**
+ * Returning a dummy value so the objects from older versions still work
+ * with current version
+ * TODO : this should be removed in the next release
Review comment:
sounds good, i guess X should be 0.15 or earlier
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346625981 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java ## @@ -75,6 +75,28 @@ public SeekableStreamDataSourceMetadata getPreviousCheckPoint() return checkpointMetadata; } + // For backwards compatibility Review comment: Added a serde test for kafka This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346486462 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java ## @@ -75,6 +75,28 @@ public SeekableStreamDataSourceMetadata getPreviousCheckPoint() return checkpointMetadata; } + // For backwards compatibility Review comment: yeah, was trying to add a serde test for `CheckPointDataSourceMetadataAction`, but wasn't easy to construct an object because of abstract `SeekableStreamDataSourceMetadata` in this package. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
