[GitHub] clintropolis commented on a change in pull request #6158: Make time-related variables more readable
clintropolis commented on a change in pull request #6158: Make time-related
variables more readable
URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r209802009
##
File path: common/src/main/java/io/druid/common/config/Log4jShutdown.java
##
@@ -28,11 +28,12 @@
import javax.annotation.concurrent.GuardedBy;
import java.util.Queue;
import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
public class Log4jShutdown implements ShutdownCallbackRegistry, LifeCycle
{
- private static final long SHUTDOWN_WAIT_TIMEOUT = 6;
+ private static final long SHUTDOWN_WAIT_TIMEOUT =
TimeUnit.MINUTES.toMillis(1);
Review comment:
Oops, I didn't mean just this variable, I meant all of the ones that were
changed. Sorry for the confusion!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] clintropolis commented on a change in pull request #6158: Make time-related variables more readable
clintropolis commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r209742177 ## File path: indexing-service/src/main/java/io/druid/indexing/overlord/TaskQueue.java ## @@ -290,7 +291,7 @@ public String apply(Task task) } // awaitNanos because management may become necessary without this condition signalling, // due to e.g. tasks becoming ready when other folks mess with the TaskLockbox. -managementMayBeNecessary.awaitNanos(600L /* 60 seconds */); +managementMayBeNecessary.awaitNanos(TimeUnit.SECONDS.toNanos(60)); Review comment: Might be nice to pull this out into a constant if you're feeling motivated This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
