[incubator-echarts] branch master updated: Fix lint
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 88a22eb Fix lint
new 7d9e04b Merge pull request #12134 from susiwen8/lint
88a22eb is described below
commit 88a22eb340228b0a77ed71178ab7702899d18123
Author: susiwen8
AuthorDate: Thu Feb 6 21:51:34 2020 +0800
Fix lint
---
src/layout/barGrid.js | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/layout/barGrid.js b/src/layout/barGrid.js
index e7947eb..e44b1f8 100644
--- a/src/layout/barGrid.js
+++ b/src/layout/barGrid.js
@@ -527,9 +527,11 @@ export var largeLayout = {
coord = cartesian.dataToPoint(valuePair, null, coord);
// Data index might not be in order, depends on
`progressiveChunkMode`.
-largeBackgroundPoints[pointsOffset] = valueAxisHorizontal ?
coordLayout.x + coordLayout.width : coord[0];
+largeBackgroundPoints[pointsOffset] = valueAxisHorizontal
+? coordLayout.x + coordLayout.width : coord[0];
largePoints[pointsOffset++] = coord[0];
-largeBackgroundPoints[pointsOffset] = valueAxisHorizontal ?
coord[1] : coordLayout.y + coordLayout.height;
+largeBackgroundPoints[pointsOffset] = valueAxisHorizontal
+? coord[1] : coordLayout.y + coordLayout.height;
largePoints[pointsOffset++] = coord[1];
largeDataIndices[idxOffset++] = dataIndex;
}
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12134: Fix lint
pissang merged pull request #12134: Fix lint URL: https://github.com/apache/incubator-echarts/pull/12134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12134: Fix lint
echarts-bot[bot] commented on issue #12134: Fix lint URL: https://github.com/apache/incubator-echarts/pull/12134#issuecomment-583942062 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12129: x-axis label disappears for 'time' series
Ovilia commented on issue #12129: x-axis label disappears for 'time' series URL: https://github.com/apache/incubator-echarts/issues/12129#issuecomment-583938586 If you want the axis to be empty for the second series, you can listen to [legendunselected](https://echarts.apache.org/en/api.html#events.legendunselected) event and call `setOption` to set the xAxis to be empty. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12129: x-axis label disappears for 'time' series
Ovilia commented on issue #12129: x-axis label disappears for 'time' series URL: https://github.com/apache/incubator-echarts/issues/12129#issuecomment-583938325 I'm afraid this is not a bug. The second series doesn't own the category data, so when hidden, the axis label is still there. While for the first series, value/time/log axis is updated on series change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #12131: log 轴堆叠问题
Ovilia commented on issue #12131: log 轴堆叠问题 URL: https://github.com/apache/incubator-echarts/issues/12131#issuecomment-583937691 @fanyongfeng 好的，了解了 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] mglimmerveen commented on issue #11589: Is it possible to put the y-axis both left and right?
mglimmerveen commented on issue #11589: Is it possible to put the y-axis both left and right? URL: https://github.com/apache/incubator-echarts/issues/11589#issuecomment-583866887 I'm sorry, I kind of forgot about this. Nevertheless, I still do not understand why you would want me to duplicate an entire series, and then set it to show: false. It makes the code ugly, less descriptive and (most probably) also perform much less. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12136: Graph lines are truncated
pissang commented on issue #12136: Graph lines are truncated URL: https://github.com/apache/incubator-echarts/issues/12136#issuecomment-583826385 Hi @wilcorrea You can set [filterMode](https://echarts.apache.org/en/option.html#dataZoom-slider.filterMode) to 'none' https://user-images.githubusercontent.com/841551/74100089-e0971800-4b65-11ea-8a06-3f169a6ecfd5.png;> This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12127: Would like to know which version added the data index to data value of Boxplot tooltip
echarts-bot[bot] commented on issue #12127: Would like to know which version added the data index to data value of Boxplot tooltip URL: https://github.com/apache/incubator-echarts/issues/12127#issuecomment-583826043 @tanjianyong Please provide a demo for the issue either with https://jsfiddle.net/ovilia/n6xc4df3/ or https://gallery.echartsjs.com/editor.html. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12130: Bar chart null value
pissang commented on issue #12130: Bar chart null value URL: https://github.com/apache/incubator-echarts/issues/12130#issuecomment-583825910 `null` data will be ignored in echarts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12132: an error in the tutorial document of VisualMap/inRange
pissang commented on issue #12132: an error in the tutorial document of VisualMap/inRange URL: https://github.com/apache/incubator-echarts/issues/12132#issuecomment-583825778 Yes, I believe your calculation is right. It's a mistake in the documentation. Would you mind making a pull request to fix it? The doc repo is in the https://github.com/apache/incubator-echarts-doc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on issue #12132: an error in the tutorial document of VisualMap/inRange
pissang edited a comment on issue #12132: an error in the tutorial document of VisualMap/inRange URL: https://github.com/apache/incubator-echarts/issues/12132#issuecomment-583825778 Yes, I believe your calculation is right. It's a mistake in the documentation. Would you mind making a pull request to fix it? The doc repo is https://github.com/apache/incubator-echarts-doc . Thanks a lot! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12128: Add support for width for Bar series graph
pissang commented on issue #12128: Add support for width for Bar series graph URL: https://github.com/apache/incubator-echarts/issues/12128#issuecomment-583825338 Hi @sreetamdas Bar is used on top of [grid](https://echarts.apache.org/en/option.html#grid.width) component. And you can use width/height/left/right/top/bottom layout properties in the [grid](https://echarts.apache.org/en/option.html#grid.width) component to control the padding. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12138: scatter在地图中的颜色和设置的颜色不符
echarts-bot[bot] commented on issue #12138: scatter在地图中的颜色和设置的颜色不符 URL: https://github.com/apache/incubator-echarts/issues/12138#issuecomment-583822430 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] AN-535 opened a new issue #12138: scatter在地图中的颜色和设置的颜色不符
AN-535 opened a new issue #12138: scatter在地图中的颜色和设置的颜色不符 URL: https://github.com/apache/incubator-echarts/issues/12138 ### Version 4.3.0 ### Reproduction link [https://gallery.echartsjs.com/editor.html?c=xUhovyiwR=1](https://gallery.echartsjs.com/editor.html?c=xUhovyiwR=1) ### Steps to reproduce 直接打开 ### What is expected? scatter颜色为自己设置的颜色 ### What is actually happening? scatter颜色不对 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
