[GitHub] [incubator-echarts] easonyq commented on a change in pull request #13084: fix(bar): showBackground bug when update with no previous background elements
easonyq commented on a change in pull request #13084:
URL:
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466163292
##
File path: src/chart/bar/BarView.js
##
@@ -135,20 +135,25 @@ export default echarts.extendChartView({
var bgEls = [];
var oldBgEls = this._backgroundEls || [];
+var createBackground = dataIndex => {
Review comment:
Already changed to normal function in commit 2
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #13084: fix 13009
Ovilia commented on a change in pull request #13084:
URL:
https://github.com/apache/incubator-echarts/pull/13084#discussion_r466158871
##
File path: src/chart/bar/BarView.js
##
@@ -135,20 +135,25 @@ export default echarts.extendChartView({
var bgEls = [];
var oldBgEls = this._backgroundEls || [];
+var createBackground = dataIndex => {
Review comment:
Arrow functions are not allowed in ECharts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] easonyq opened a new pull request #13084: fix 13009
easonyq opened a new pull request #13084: URL: https://github.com/apache/incubator-echarts/pull/13084 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Fix 13009 ### Fixed issues Switch 'options -> series -> showBackground' from `false` to `true` will no longer throw exceptions. (something like calling `useStyle` from undefined, more detailed described in #13009 ) ## Details ### Before: What was the problem? Switch 'options -> series -> showBackground' from `false` to `true` will throw exceptions. ### After: How is it fixed in this PR? Switch 'options -> series -> showBackground' from `false` to `true` works well. ## Usage ### Are there any API changes? - [ ] The API has been changed. No ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [x] Please squash the commits into a single one when merge. ### Other information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] mzilong opened a new issue #13083: tree图，设置节点与节点之间连线的颜色，lineStyle对所有子节点的线都设置了，无法对可以独立每条线分开设置？
mzilong opened a new issue #13083: URL: https://github.com/apache/incubator-echarts/issues/13083 tree图，设置节点与节点之间连线的颜色，lineStyle对所有子节点的线都设置了，无法对可以独立每条线分开设置？[https://blog.csdn.net/wusefengye/article/details/79110195](url)类似这个文章的需求 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13083: tree图，设置节点与节点之间连线的颜色，lineStyle对所有子节点的线都设置了，无法对可以独立每条线分开设置？
echarts-bot[bot] commented on issue #13083: URL: https://github.com/apache/incubator-echarts/issues/13083#issuecomment-669711168 This issue is not created using [issue template](https://ecomfe.github.io/echarts-issue-helper/) so I'm going to close it. Sorry for this, but it helps save our maintainers' time so that more developers get helped. Feel free to create another issue using the issue template. If you think you have already made your point clear without the template, or your problem cannot be covered by it, you may re-open this issue again. 这个 issue 未使用 [issue 模板](https://ecomfe.github.io/echarts-issue-helper/?lang=zh-cn) 创建，所以我将关闭此 issue。 为此带来的麻烦我深表歉意，但是请理解这是为了节约社区维护者的时间，以更高效地服务社区的开发者群体。 如果您愿意，可以请使用 issue 模板重新创建 issue。 如果你认为虽然没有使用模板，但你已经提供了复现问题的充分描述，或者你的问题无法使用模板表达，也可以重新 open 这个 issue。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #13061: 配置项手册无内容
plainheart commented on issue #13061: URL: https://github.com/apache/incubator-echarts/issues/13061#issuecomment-669689016 @vincentzxt @wahoro 问题应该已经被解决，请再试试看验证下是否仍有问题。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] jackferrous commented on issue #13082: 使用散点图，多组散点下，散点未显示全
jackferrous commented on issue #13082: URL: https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660911  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] jackferrous commented on issue #13082: 使用散点图，多组散点下，散点未显示全
jackferrous commented on issue #13082:
URL:
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660737
{symbolSize: 20,
data:[["2020-06-16 00:02:34","-4.167E-3","2020-06-16
00:02:34"],["2020-06-16 00:07:34","-4.167E-3","2020-06-16
00:07:34"],["2020-06-16 00:17:34","0.01284","2020-06-16 00:17:34"],["2020-06-16
00:27:35","-4.998E-3","2020-06-16 00:27:35"],["2020-06-16
00:37:35","10.01","2020-06-16 00:37:35"],["2020-06-16
00:47:34","-4.802E-3","2020-06-16 00:47:34"],["2020-06-16
00:57:34","1.489","2020-06-16 00:57:34"],["2020-06-16
01:07:34","18.65","2020-06-16 01:07:34"],["2020-06-16
01:17:34","49.70","2020-06-16 01:17:34"],["2020-06-16
01:27:35","38.07","2020-06-16 01:27:35"],["2020-06-16
01:37:35","-2.169E-3","2020-06-16 01:37:35"],["2020-06-16
01:47:35","9.489","2020-06-16 01:47:35"],["2020-06-16
01:57:36","15.82","2020-06-16 01:57:36"],["2020-06-16
02:07:36","79.55","2020-06-16 02:07:36"],["2020-06-16
02:17:35","8.525","2020-06-16 02:17:35"],["2020-06-16
02:27:35","-4.392E-3","2020-06-16 02:27:35"],["2020-06-16
02:37:35","-4.078E-3","2020-06-16 02:37:35"],["2020-06-16
02:47:35","-3.652E-3","2
020-06-16 02:47:35"],["2020-06-16 02:57:35","-4.723E-3","2020-06-16
02:57:35"],["2020-06-16 03:07:36","-3.538E-3","2020-06-16
03:07:36"],["2020-06-16 03:17:37","-2.372E-3","2020-06-16
03:17:37"],["2020-06-16 03:27:37","3.325E-3","2020-06-16
03:27:37"],["2020-06-16 03:37:37","5.433E-3","2020-06-16
03:37:37"],["2020-06-16 03:47:36","-2.078E-4","2020-06-16
03:47:36"],["2020-06-16 03:57:36","-1.508E-3","2020-06-16
03:57:36"],["2020-06-16 04:07:36","-3.001E-3","2020-06-16
04:07:36"],["2020-06-16 04:17:36","-4.968E-3","2020-06-16
04:17:36"],["2020-06-16 04:27:36","-3.420E-3","2020-06-16
04:27:36"],["2020-06-16 04:37:36","-4.553E-3","2020-06-16
04:37:36"],["2020-06-16 04:47:38","-1.013E-3","2020-06-16
04:47:38"],["2020-06-16 04:57:38","-2.492E-3","2020-06-16
04:57:38"],["2020-06-16 05:07:38","-4.702E-3","2020-06-16
05:07:38"],["2020-06-16 05:17:37","-5.650E-4","2020-06-16
05:17:37"],["2020-06-16 05:27:37","-9.134E-4","2020-06-16
05:27:37"],["2020-06-16 05:37:37",0,"2020-06-16 05:37:37"],["
2020-06-16 05:47:37",0,"2020-06-16 05:47:37"],["2020-06-16
05:57:37","-7.177E-4","2020-06-16 05:57:37"],["2020-06-16
06:07:37","3.505E-3","2020-06-16 06:07:37"],["2020-06-16
06:17:38","0.02090","2020-06-16 06:17:38"],["2020-06-16
06:27:39","-4.808E-3","2020-06-16 06:27:39"],["2020-06-16
06:37:39","-1.098E-3","2020-06-16 06:37:39"],["2020-06-16
06:47:38","9.142","2020-06-16 06:47:38"],["2020-06-16
06:57:38","51.04","2020-06-16 06:57:38"],["2020-06-16
07:07:38","80.00","2020-06-16 07:07:38"],["2020-06-16
07:17:38","59.78","2020-06-16 07:17:38"],["2020-06-16
07:27:38","16.70","2020-06-16 07:27:38"],["2020-06-16
07:37:38","13.63","2020-06-16 07:37:38"],["2020-06-16
07:47:39","26.19","2020-06-16 07:47:39"],["2020-06-16
07:57:39","39.89","2020-06-16 07:57:39"],["2020-06-16
08:07:40","80.00","2020-06-16 08:07:40"],["2020-06-16
08:17:39","80.00","2020-06-16 08:17:39"],["2020-06-16
08:27:39","37.33","2020-06-16 08:27:39"],["2020-06-16
08:37:39","-1.989E-4","2020-06-16 08:37:39"],["2020-06-16
08:47:39","-1.431E-3","2020-06-16 08:47:39"],["2020-06-16
08:57:39","-4.993E-3","2020-06-16 08:57:39"],["2020-06-16
09:07:39","9.546","2020-06-16 09:07:39"],["2020-06-16
09:17:39","-1.883E-3","2020-06-16 09:17:39"],["2020-06-16
09:27:39","0.05711","2020-06-16 09:27:39"],["2020-06-16
09:37:39","0.04168","2020-06-16 09:37:39"],["2020-06-16
09:47:40","4.878E-3","2020-06-16 09:47:40"],["2020-06-16
09:57:40","-3.530E-4","2020-06-16 09:57:40"],["2020-06-16
10:07:40","1.889E-5","2020-06-16 10:07:40"],["2020-06-16
10:17:40","0.04921","2020-06-16 10:17:40"],["2020-06-16
10:27:40","0.09879","2020-06-16 10:27:40"],["2020-06-16
10:37:40","0.01478","2020-06-16 10:37:40"],["2020-06-16
10:47:40","0.4493","2020-06-16 10:47:40"],["2020-06-16
10:57:40","-1.046E-3","2020-06-16 10:57:40"],["2020-06-16
11:07:40","0.01021","2020-06-16 11:07:40"],["2020-06-16
11:17:40","5.882E-3","2020-06-16 11:17:40"],["2020-06-16
11:27:41","10.36","2020-06-16 11:27:41"],["2020-06-16
11:37:41","9.744","2020-06-16 11:37:
41"],["2020-06-16 11:47:41","25.68","2020-06-16 11:47:41"],["2020-06-16
11:57:41","24.48","2020-06-16 11:57:41"],["2020-06-16
12:07:41","12.18","2020-06-16 12:07:41"],["2020-06-16
12:17:41","74.50","2020-06-16 12:17:41"],["2020-06-16
12:27:41","80.00","2020-06-16 12:27:41"],["2020-06-16
12:37:41","80.00","2020-06-16 12:37:41"],["2020-06-16
12:47:41","19.59","2020-06-16 12:47:41"],["2020-06-16
12:57:41","7.628","2020-06-16 12:57:41"],["2020-06-16
13:07:41","18.05","2020-06-16 13:07:41"],["2020-06-16
13:17:41","21.24","2020-06-16 13:17:41"],["2020-06-16
13:27:41","-3.767E-4","2020-06-16 13:27:41"],["2020-06-16
13:37:41","1.489E-3","2020-06-16 13:37:41"],["2020-06-16
13:47:42","-1.833E-5","2020-06-16 13:47:42"],["2020-06-16
13:57:42","4.850E-3","2020-06-16
[GitHub] [incubator-echarts] jackferrous commented on issue #13082: 使用散点图，多组散点下，散点未显示全
jackferrous commented on issue #13082:
URL:
https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660790
{symbolSize: 20,
data:[["2020-06-07 00:06:46","10.27","2020-06-07 00:06:46"],["2020-06-07
00:16:46","10.20","2020-06-07 00:16:46"],["2020-06-07
00:26:46","9.605","2020-06-07 00:26:46"],["2020-06-07
00:36:46","8.718","2020-06-07 00:36:46"],["2020-06-07
00:46:46","7.644","2020-06-07 00:46:46"],["2020-06-07
00:56:46","7.026","2020-06-07 00:56:46"],["2020-06-07
01:06:46","6.021","2020-06-07 01:06:46"],["2020-06-07
01:16:46","4.511","2020-06-07 01:16:46"],["2020-06-07
01:26:46","4.896","2020-06-07 01:26:46"],["2020-06-07
01:36:46","5.505","2020-06-07 01:36:46"],["2020-06-07
01:46:46","4.836","2020-06-07 01:46:46"],["2020-06-07
01:56:46","5.619","2020-06-07 01:56:46"],["2020-06-07
02:06:46","5.933","2020-06-07 02:06:46"],["2020-06-07
02:16:46","6.799","2020-06-07 02:16:46"],["2020-06-07
02:26:46","7.028","2020-06-07 02:26:46"],["2020-06-07
02:36:46","7.638","2020-06-07 02:36:46"],["2020-06-07
02:46:46","9.070","2020-06-07 02:46:46"],["2020-06-07
02:56:46","10.67","2020-06-07 02:56:46"],["2020-06-07 03:0
6:46","11.50","2020-06-07 03:06:46"],["2020-06-07
03:16:46","11.89","2020-06-07 03:16:46"],["2020-06-07
03:26:46","11.94","2020-06-07 03:26:46"],["2020-06-07
03:36:46","11.66","2020-06-07 03:36:46"],["2020-06-07
03:46:46","10.98","2020-06-07 03:46:46"],["2020-06-07
03:56:46","10.24","2020-06-07 03:56:46"],["2020-06-07
04:06:46","9.647","2020-06-07 04:06:46"],["2020-06-07
04:16:46","10.00","2020-06-07 04:16:46"],["2020-06-07
04:26:46","8.593","2020-06-07 04:26:46"],["2020-06-07
04:36:46","7.498","2020-06-07 04:36:46"],["2020-06-07
04:46:46","6.546","2020-06-07 04:46:46"],["2020-06-07
04:56:46","6.178","2020-06-07 04:56:46"],["2020-06-07
05:06:46","6.783","2020-06-07 05:06:46"],["2020-06-07
05:16:46","6.720","2020-06-07 05:16:46"],["2020-06-07
05:26:46","6.410","2020-06-07 05:26:46"],["2020-06-07
05:36:46","3.877","2020-06-07 05:36:46"],["2020-06-07
05:46:46","3.282","2020-06-07 05:46:46"],["2020-06-07
05:56:46","1.115","2020-06-07 05:56:46"],["2020-06-07
06:06:46","2.479","2020-06-07
06:06:46"],["2020-06-07 06:16:46","3.454","2020-06-07 06:16:46"],["2020-06-07
06:26:46","2.062","2020-06-07 06:26:46"],["2020-06-07
06:36:46","2.667","2020-06-07 06:36:46"],["2020-06-07
06:46:46","4.500","2020-06-07 06:46:46"],["2020-06-07
06:56:46","5.409","2020-06-07 06:56:46"],["2020-06-07
07:06:46","3.473","2020-06-07 07:06:46"],["2020-06-07
07:16:46","1.608","2020-06-07 07:16:46"],["2020-06-07
07:26:46","0.8650","2020-06-07 07:26:46"],["2020-06-07
07:36:46","1.942","2020-06-07 07:36:46"],["2020-06-07
07:46:46","1.528","2020-06-07 07:46:46"],["2020-06-07
07:56:46","1.985","2020-06-07 07:56:46"],["2020-06-07
08:06:46","2.576","2020-06-07 08:06:46"],["2020-06-07
08:16:46","2.487","2020-06-07 08:16:46"],["2020-06-07
08:26:46","2.457","2020-06-07 08:26:46"],["2020-06-07
08:36:46","1.353","2020-06-07 08:36:46"],["2020-06-07
08:46:46","1.070","2020-06-07 08:46:46"],["2020-06-07
08:56:46","1.585","2020-06-07 08:56:46"],["2020-06-07
09:06:46","2.360","2020-06-07 09:06:46"],["2020-06-07
09:16:46","1.402","2020-06-07 09:16:46"],["2020-06-07
09:26:46","0.8368","2020-06-07 09:26:46"],["2020-06-07
09:36:46","2.715","2020-06-07 09:36:46"],["2020-06-07
09:46:46","3.477","2020-06-07 09:46:46"],["2020-06-07
09:56:46","2.888","2020-06-07 09:56:46"],["2020-06-07
10:06:46","2.262","2020-06-07 10:06:46"],["2020-06-07
10:16:46","2.554","2020-06-07 10:16:46"],["2020-06-07
10:26:46","2.414","2020-06-07 10:26:46"],["2020-06-07
10:36:46","2.210","2020-06-07 10:36:46"],["2020-06-07
10:46:46","6.105","2020-06-07 10:46:46"],["2020-06-07
10:56:46","2.949","2020-06-07 10:56:46"],["2020-06-07
11:06:46","2.002","2020-06-07 11:06:46"],["2020-06-07
11:16:46","4.433","2020-06-07 11:16:46"],["2020-06-07
11:26:46","3.652","2020-06-07 11:26:46"],["2020-06-07
11:36:46","5.849","2020-06-07 11:36:46"],["2020-06-07
11:46:46","2.736","2020-06-07 11:46:46"],["2020-06-07
11:56:46","6.167","2020-06-07 11:56:46"],["2020-06-07
12:06:46","2.943","2020-06-07 12:06:46"],["2020-06-07 12:16:46","3.216","2020
-06-07 12:16:46"],["2020-06-07 12:26:46","3.931","2020-06-07
12:26:46"],["2020-06-07 12:36:46","3.859","2020-06-07 12:36:46"],["2020-06-07
12:46:46","3.313","2020-06-07 12:46:46"],["2020-06-07
12:56:46","3.795","2020-06-07 12:56:46"],["2020-06-07
13:06:46","5.999","2020-06-07 13:06:46"],["2020-06-07
13:16:46","4.490","2020-06-07 13:16:46"],["2020-06-07
13:26:46","5.306","2020-06-07 13:26:46"],["2020-06-07
13:36:46","3.331","2020-06-07 13:36:46"],["2020-06-07
13:46:46","5.397","2020-06-07 13:46:46"],["2020-06-07
13:56:46","4.150","2020-06-07 13:56:46"],["2020-06-07
14:06:46","2.999","2020-06-07 14:06:46"],["2020-06-07
14:16:46","2.174","2020-06-07 14:16:46"],["2020-06-07
14:26:46","2.100","2020-06-07 14:26:46"],["2020-06-07
14:36:46","4.683","2020-06-07
[GitHub] [incubator-echarts] jackferrous closed issue #13082: 使用散点图，多组散点下，散点未显示全
jackferrous closed issue #13082: URL: https://github.com/apache/incubator-echarts/issues/13082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] jackferrous opened a new issue #13082: 使用散点图，多组散点下，散点未显示全
jackferrous opened a new issue #13082: URL: https://github.com/apache/incubator-echarts/issues/13082 ### Version 5.0.0-alpha.1 ### Reproduction link [https://echarts.apache.org/examples/zh/editor.html?c=scatter-simple](https://echarts.apache.org/examples/zh/editor.html?c=scatter-simple) ### Steps to reproduce 1，打开重现链接 2，使用如下数据，点击运行（数据单独提交） ### What is expected? 正常显示散点图 ### What is actually happening? 1，多组散点图中有未显示的散点（4组散点图只显示三组或是2组或是1组） 2，散点会闪动， ` --- 有动图和原始数据 联系电话：18862180080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13082: 使用散点图，多组散点下，散点未显示全
echarts-bot[bot] commented on issue #13082: URL: https://github.com/apache/incubator-echarts/issues/13082#issuecomment-669660054 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts-bot] branch master updated: update committers
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-bot.git
The following commit(s) were added to refs/heads/master by this push:
new 0bb310e update committers
0bb310e is described below
commit 0bb310ea9085dd391e2960bae7ad365e17ce9f39
Author: Ovilia
AuthorDate: Thu Aug 6 11:00:18 2020 +0800
update committers
---
index.js | 8 +---
src/coreCommitters.js | 7 ++-
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/index.js b/index.js
index 0563fc7..542578d 100644
--- a/index.js
+++ b/index.js
@@ -1,5 +1,6 @@
const Issue = require('./src/issue');
const text = require('./src/text');
+const isCoreCommitter = require('./src/coreCommitters');
module.exports = app => {
app.on(['issues.opened'], async context => {
@@ -88,13 +89,14 @@ module.exports = app => {
});
app.on(['pull_request.opened'], async context => {
-const auth = context.payload.pull_request.author_association;
+// const auth = context.payload.pull_request.author_association;
+const isCore = isCoreCommitter(context.payload.issue.user.login);
const comment = context.github.issues.createComment(context.issue({
-body: isCommitter(auth) ? text.PR_OPENED_BY_COMMITTER :
text.PR_OPENED
+body: isCore ? text.PR_OPENED_BY_COMMITTER : text.PR_OPENED
}));
const labelList = ['PR: awaiting review'];
-if (isCommitter(auth)) {
+if (isCore) {
labelList.push('PR: author is committer');
}
const addLabel = context.github.issues.addLabels(context.issue({
diff --git a/src/coreCommitters.js b/src/coreCommitters.js
index 7fb05cb..75dcc9a 100644
--- a/src/coreCommitters.js
+++ b/src/coreCommitters.js
@@ -3,11 +3,16 @@ const committers = [
'100pah',
'Ovilia',
'deqingli',
+'Wdingding',
'susiwen8',
'cuijian-dexter',
'SnailSword',
'plainheart',
-'wf123537200'
+'wf123537200',
+'yufeng04',
+'chfw',
+'alex2wong',
+'ClemMakesApps'
];
function getCoreCommitters() {
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] chengwubin commented on issue #10824: 地图名称标签位置设置无效
chengwubin commented on issue #10824: URL: https://github.com/apache/incubator-echarts/issues/10824#issuecomment-669648904 > 地图的标签位置是不能设置的，固定显示在行政区域的位置。不太清楚需要设置 position: 'left' 的场景是什么  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: Merge pull request #13080 from apache/fix/line-symbol-rotation
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git commit 2cbf4593839a8d3368cd38d1c5a9f9de1cf687ca Merge: bd6c0f3 6a9e723 Author: Yi Shen AuthorDate: Thu Aug 6 10:05:50 2020 +0800 Merge pull request #13080 from apache/fix/line-symbol-rotation fix: recover auto rotation for line symbol. src/chart/helper/Line.js| 18 -- test/markLine-symbolRotate.html | 19 ++- 2 files changed, 26 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch release updated (bd6c0f3 -> 2cbf459)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from bd6c0f3 Merge pull request #13079 from apache/fix-graph-simple-layout-error add 6a9e723 fix: In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like when drag graph or move dataZoom). (Brought by 7c3f1896fa1fa93fc7d019f40fd4584024ca32eb #12392 ) new 2cbf459 Merge pull request #13080 from apache/fix/line-symbol-rotation The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/helper/Line.js| 18 -- test/markLine-symbolRotate.html | 19 ++- 2 files changed, 26 insertions(+), 11 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13080: fix: recover auto rotation for line symbol.
echarts-bot[bot] commented on pull request #13080: URL: https://github.com/apache/incubator-echarts/pull/13080#issuecomment-669639596 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch release updated (f375328 -> bd6c0f3)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from f375328 Merge pull request #13078 from apache/master add 089a362 fix(graph): fix null pointer error in graph simple layout new bd6c0f3 Merge pull request #13079 from apache/fix-graph-simple-layout-error The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/graph/simpleLayout.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13079: fix(graph): fix null pointer error in graph simple layout
pissang merged pull request #13079: URL: https://github.com/apache/incubator-echarts/pull/13079 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13080: fix: recover auto rotation for line symbol.
pissang merged pull request #13080: URL: https://github.com/apache/incubator-echarts/pull/13080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: Merge pull request #13079 from apache/fix-graph-simple-layout-error
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a commit to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git commit bd6c0f38082a80c18196b4b630253bf5f20e760a Merge: f375328 089a362 Author: Yi Shen AuthorDate: Thu Aug 6 10:05:19 2020 +0800 Merge pull request #13079 from apache/fix-graph-simple-layout-error fix(graph): fix null pointer error in graph simple layout src/chart/graph/simpleLayout.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13079: fix(graph): fix null pointer error in graph simple layout
echarts-bot[bot] commented on pull request #13079: URL: https://github.com/apache/incubator-echarts/pull/13079#issuecomment-669639471 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] aswjh opened a new issue #13081: les-miserables中可否为link和node增加分类,以便高量显示该类link及其连接的node
aswjh opened a new issue #13081:
URL: https://github.com/apache/incubator-echarts/issues/13081
### What problem does this feature solve?
当鼠标悬停在某link上时，高量显示该类link及其连接的node
### What does the proposed API look like?
.a:hover {xxx}
.b:hover {xxx}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13081: les-miserables中可否为link和node增加分类,以便高量显示该类link及其连接的node
echarts-bot[bot] commented on issue #13081: URL: https://github.com/apache/incubator-echarts/issues/13081#issuecomment-669628933 Hi! We've received your issue and please be patient to get responded. The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] AmitBisht14 edited a comment on issue #9246: Continue Showing Same Tooltip On Dynamic Graph (Until Mouse Moves)
AmitBisht14 edited a comment on issue #9246: URL: https://github.com/apache/incubator-echarts/issues/9246#issuecomment-669452706 In detail workaround as suggested by @adamtLICOR set `tooltip.alwaysShowContent` to false. After this you have to set the chart options which will reset tooltip property of `alwaysShowContent` thus it won't suppress hideTip dispatchAction This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] AmitBisht14 commented on issue #9246: Continue Showing Same Tooltip On Dynamic Graph (Until Mouse Moves)
AmitBisht14 commented on issue #9246: URL: https://github.com/apache/incubator-echarts/issues/9246#issuecomment-669452706 In detail workaround as suggested by @adamtLICOR set tooltip.alwaysShowContent to false. After this you have to set the chart options which will reset tooltip property of alwaysShowContent thus it won't suppress hideTip dispatchAction This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13080: fix: recover auto rotation for line symbol.
echarts-bot[bot] commented on pull request #13080: URL: https://github.com/apache/incubator-echarts/pull/13080#issuecomment-669299267 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). The pull request is marked to be `PR: author is committer` because you are a committer of this project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah opened a new pull request #13080: fix: recover auto rotation for line symbol.
100pah opened a new pull request #13080: URL: https://github.com/apache/incubator-echarts/pull/13080 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like when drag graph or move dataZoom). #12392 support the feature of support user specified symbol rotation in Line.js Line.js is used by graph and markLine and might other places. But when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time. The scenario of "render at the second time" are like dragging force layout graph or move dataZoom. See the triangle below:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch fix/line-symbol-rotation created (now 6a9e723)
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a change to branch fix/line-symbol-rotation in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. at 6a9e723 fix: In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like when drag graph or move dataZoom). (Brought by 7c3f1896fa1fa93fc7d019f40fd4584024ca32eb #12392 ) This branch includes the following new commits: new 6a9e723 fix: In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like when drag graph or move dataZoom). (Brought by 7c3f1896fa1fa93fc7d019f40fd4584024ca32eb #12392 ) The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: fix: In Line.js (used by graph and markLine), when rotation is not specified by users, the "auto rotation" rule should not be broken when rendered at the second time (like w
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a commit to branch fix/line-symbol-rotation
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 6a9e7239acbc0d6162d7550c6cad7d98d681a0d7
Author: 100pah
AuthorDate: Thu Aug 6 00:28:56 2020 +0800
fix: In Line.js (used by graph and markLine), when rotation is not
specified by users, the "auto rotation" rule should not be broken when rendered
at the second time (like when drag graph or move dataZoom). (Brought by
7c3f1896fa1fa93fc7d019f40fd4584024ca32eb #12392 )
---
src/chart/helper/Line.js| 18 --
test/markLine-symbolRotate.html | 19 ++-
2 files changed, 26 insertions(+), 11 deletions(-)
diff --git a/src/chart/helper/Line.js b/src/chart/helper/Line.js
index 7824751..260fa36 100644
--- a/src/chart/helper/Line.js
+++ b/src/chart/helper/Line.js
@@ -57,8 +57,8 @@ function createSymbol(name, lineData, idx) {
);
// rotate by default if symbolRotate is not specified or NaN
-symbolPath.rotation = symbolRotate == null || isNaN(symbolRotate)
-? undefined
+symbolPath.__specifiedRotation = symbolRotate == null ||
isNaN(symbolRotate)
+? void 0
: +symbolRotate * Math.PI / 180 || 0;
symbolPath.name = name;
@@ -131,13 +131,16 @@ function updateSymbolAndLabelBeforeLineUpdate() {
// when symbol is set to be 'arrow' in markLine,
// symbolRotate value will be ignored, and compulsively use tangent
angle.
// rotate by default if symbol rotation is not specified
-if (symbolFrom.rotation == null
-|| (symbolFrom.shape && symbolFrom.shape.symbolType === 'arrow')) {
+var specifiedRotation = symbolFrom.__specifiedRotation;
+if (specifiedRotation == null) {
var tangent = line.tangentAt(0);
symbolFrom.attr('rotation', Math.PI / 2 - Math.atan2(
tangent[1], tangent[0]
));
}
+else {
+symbolFrom.attr('rotation', specifiedRotation);
+}
symbolFrom.attr('scale', [invScale * percent, invScale * percent]);
}
if (symbolTo) {
@@ -146,13 +149,16 @@ function updateSymbolAndLabelBeforeLineUpdate() {
// when symbol is set to be 'arrow' in markLine,
// symbolRotate value will be ignored, and compulsively use tangent
angle.
// rotate by default if symbol rotation is not specified
-if (symbolTo.rotation == null
-|| (symbolTo.shape && symbolTo.shape.symbolType === 'arrow')) {
+var specifiedRotation = symbolTo.__specifiedRotation;
+if (specifiedRotation == null) {
var tangent = line.tangentAt(1);
symbolTo.attr('rotation', -Math.PI / 2 - Math.atan2(
tangent[1], tangent[0]
));
}
+else {
+symbolTo.attr('rotation', specifiedRotation);
+}
symbolTo.attr('scale', [invScale * percent, invScale * percent]);
}
diff --git a/test/markLine-symbolRotate.html b/test/markLine-symbolRotate.html
index 96bd4b1..1a5afd5 100644
--- a/test/markLine-symbolRotate.html
+++ b/test/markLine-symbolRotate.html
@@ -118,6 +118,10 @@ under the License.
silent: true,
// symbol: 'triangle',
data: [
+[
+{name: 'rotation not specified', coord:
['2014-06-20', 300], symbol: 'arrow'},
+{coord: ['2014-07-18', 320], symbol:
'triangle'}
+],
{
yAxis: 50,
// symbolRotate: 0,
@@ -133,15 +137,18 @@ under the License.
yAxis: 150,
symbol: 'roundRect',
symbolRotate: 40
-}, {
+},
+{
yAxis: 200,
symbol: 'diamond',
-symbolRotate: 70
-}, {
+symbolRotate: 45
+},
+{
yAxis: 250,
symbol: 'pin',
symbolRotate: 45
-}, {
+},
+{
yAxis: 300,
symbol: 'circle',
symbolRotate: 90
@@ -162,7 +169,9 @@ under the License.
lineStyle: {
[GitHub] [incubator-echarts] pissang opened a new pull request #13079: fix(graph): fix null pointer error in graph simple layout
pissang opened a new pull request #13079: URL: https://github.com/apache/incubator-echarts/pull/13079 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Fix null pointer access caused brought in https://github.com/apache/incubator-echarts/pull/12590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13079: fix(graph): fix null pointer error in graph simple layout
echarts-bot[bot] commented on pull request #13079: URL: https://github.com/apache/incubator-echarts/pull/13079#issuecomment-669250714 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch fix-graph-simple-layout-error created (now 089a362)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch fix-graph-simple-layout-error in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. at 089a362 fix(graph): fix null pointer error in graph simple layout This branch includes the following new commits: new 089a362 fix(graph): fix null pointer error in graph simple layout The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: fix(graph): fix null pointer error in graph simple layout
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch fix-graph-simple-layout-error
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 089a3620979d2e42273db930f81c2eb215140519
Author: pissang
AuthorDate: Wed Aug 5 23:09:02 2020 +0800
fix(graph): fix null pointer error in graph simple layout
---
src/chart/graph/simpleLayout.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/chart/graph/simpleLayout.js b/src/chart/graph/simpleLayout.js
index 1cc70bd..f9439f2 100644
--- a/src/chart/graph/simpleLayout.js
+++ b/src/chart/graph/simpleLayout.js
@@ -51,7 +51,7 @@ export default function (ecModel, api) {
}
}
-simpleLayoutEdge(data.graph);
+simpleLayoutEdge(data.graph, seriesModel);
}
else if (!layout || layout === 'none') {
simpleLayout(seriesModel);
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts-doc] branch master updated: fix: build script.
This is an automated email from the ASF dual-hosted git repository.
sushuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git
The following commit(s) were added to refs/heads/master by this push:
new 308155f fix: build script.
308155f is described below
commit 308155f6cc6017fe221db87da59368c381ab6253
Author: 100pah
AuthorDate: Wed Aug 5 22:32:53 2020 +0800
fix: build script.
---
build.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/build.js b/build.js
index 10ece37..b8cc3df 100644
--- a/build.js
+++ b/build.js
@@ -256,7 +256,7 @@ function writeSingleSchemaPartioned(schema, language,
docName, format) {
const outlineBasename = `${docName}-outline.json`;
const outlineDestPath = path.resolve(config.releaseDestDir,
`${language}/documents/${docName}-parts/${outlineBasename}`);
fse.ensureDirSync(path.dirname(outlineDestPath));
-fse.outputFile(
+fse.outputFileSync(
outlineDestPath,
format ? JSON.stringify(outline, null, 2) : JSON.stringify(outline),
'utf-8'
@@ -295,7 +295,7 @@ function writeSingleSchemaPartioned(schema, language,
docName, format) {
const descDestPath = path.resolve(config.releaseDestDir,
`${language}/documents/${docName}-parts/${descBasename}`);
fse.ensureDirSync(path.dirname(descDestPath));
const content = JSON.stringify(json, null, 2);
-fse.outputFile(
+fse.outputFileSync(
descDestPath,
// format ? JSON.stringify(partDescriptions, null, 2) :
JSON.stringify(partDescriptions),
content,
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] ownedbypeli commented on issue #12833: How can i have 2 data lines at the xAxis?
ownedbypeli commented on issue #12833: URL: https://github.com/apache/incubator-echarts/issues/12833#issuecomment-669170968 @pissang Can you provide me an code example This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #13078: Create release 4.9.0 branch
100pah merged pull request #13078: URL: https://github.com/apache/incubator-echarts/pull/13078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: Merge pull request #13078 from apache/master
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a commit to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git commit f375328e75d2e0be1b0a930d7345d9f11eadba7d Merge: 3b61add 450ee94 Author: sushuang AuthorDate: Wed Aug 5 20:19:57 2020 +0800 Merge pull request #13078 from apache/master Create release 4.9.0 branch .gitattributes | 3 + .github/workflows/nodejs.yml | 4 +- .huskyrc | 5 + README.md| 2 +- extension-src/bmap/BMapCoordSys.js | 18 +- extension-src/bmap/BMapModel.js | 7 +- extension-src/bmap/BMapView.js | 26 +- package-lock.json| 242 +++ package.json | 1 + src/chart/bar/BarView.js | 27 +- src/chart/bar/PictorialBarSeries.js | 4 +- src/chart/funnel/FunnelSeries.js | 1 + src/chart/funnel/funnelLayout.js | 232 --- src/chart/graph/GraphSeries.js | 12 +- src/chart/graph/circularLayoutHelper.js | 10 +- src/chart/graph/forceLayout.js | 8 +- src/chart/graph/simpleLayoutHelper.js| 17 +- src/chart/helper/Line.js | 43 +- src/chart/helper/Symbol.js | 4 +- src/chart/helper/createGraphFromNodeEdge.js | 3 +- src/chart/helper/multipleGraphEdgeHelper.js | 229 +++ src/chart/lines/LinesSeries.js | 4 +- src/chart/map/MapSeries.js | 5 +- src/chart/radar/RadarSeries.js | 7 +- src/chart/radar/RadarView.js | 6 +- src/chart/sunburst/SunburstPiece.js | 6 +- src/chart/sunburst/SunburstSeries.js | 24 +- src/chart/themeRiver/ThemeRiverSeries.js | 48 +-- src/chart/tree/TreeSeries.js | 2 +- src/chart/tree/TreeView.js | 6 +- src/chart/treemap/TreemapSeries.js | 14 +- src/chart/treemap/treemapLayout.js | 4 +- src/chart/treemap/treemapVisual.js | 33 +- src/component/axisPointer/axisTrigger.js | 2 +- src/component/legend/ScrollableLegendView.js | 2 +- src/component/marker/MarkAreaView.js | 68 ++- src/component/marker/MarkLineView.js | 4 +- src/component/marker/MarkPointView.js| 8 +- src/component/marker/MarkerModel.js | 5 +- src/component/timeline/SliderTimelineView.js | 11 +- src/component/title.js | 4 +- src/component/toolbox/feature/DataView.js| 28 +- src/component/toolbox/feature/DataZoom.js| 12 +- src/component/toolbox/feature/SaveAsImage.js | 3 +- src/component/tooltip/TooltipContent.js | 43 +- src/component/tooltip/TooltipRichContent.js | 61 ++- src/component/tooltip/TooltipView.js | 8 +- src/component/visualMap/VisualMapModel.js| 2 +- src/coord/axisDefault.js | 2 +- src/coord/axisHelper.js | 4 +- src/coord/geo/GeoModel.js| 9 +- src/data/Graph.js| 5 - src/data/List.js | 2 +- src/data/Tree.js | 36 +- src/layout/barPolar.js | 6 +- src/processor/dataSample.js | 2 +- src/stream/Scheduler.js | 2 +- src/visual/VisualMapping.js | 2 +- test/axisLabel.html | 11 +- test/bar-polar-stack.html| 218 ++ test/bmap-mapOptions.html| 530 test/bmap2.html | 592 +++ test/data/aqi/aqi-beijing.json | 1 + test/dataZoom-toolbox.html | 8 +- test/dataset-charts.html | 36 +- test/funnel.html | 11 +- test/geo-labelFormatter.html | 364 test/graph-mulitple-edges.html | 357 test/lines-mergeOption.html | 103 + test/markArea.html | 21 +- test/markLine-symbolRotate.html | 178 test/markPoint.html | 11 +- test/pie-dataView.html | 122 ++ test/radar.html | 9 +- test/sunburst-visualMap.html | 24 +- test/themeRiver3.html| 154 +++ test/timeline-dynamic-series.html| 136 +++--- test/tooltip-rich.html | 14 +- test/tooltip-textStyle.html | 455 test/tooltip-windowResize.html | 383 + test/tree-image2.html
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13078: Create release 4.9.0 branch
echarts-bot[bot] commented on pull request #13078: URL: https://github.com/apache/incubator-echarts/pull/13078#issuecomment-669160542 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch release updated (3b61add -> f375328)
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a change to branch release in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 3b61add Merge pull request #12574 from apache/release-dev add 6026bd3 Merge pull request #2 from apache/master add e15eaf0 Merge pull request #3 from apache/master add 09aaafe Merge pull request #4 from apache/master add 82bb413 Merge pull request #5 from apache/master add c3dc1cb feat(package.json): add husky pre-commit task to keep the code style consistent add 79919e7 Merge pull request #12526 from wf123537200/add-husky add 5c245bc Merge pull request #6 from apache/master add 0a757f2 fix(tooltip): added dispose method for rich tooltip, close apache#12607. add 1b02954 Merge pull request #12608 from plainheart/fix-12607 add baa6ea6 fix(bmap): tweak BMapView.js, no need to import `clone` from zrender and it can be fetched from echarts object. (#12568) add 4e5c6f7 saveAsImage function, use document.defaultView instead of window (#12643) add 7b5c5e2 fix(markArea): hide labels when markArea is not inside grid #12591 add 2dac208 test(markArea): add test case for #12591 add f62503d fix(markArea): call axis.containData #12591 add 31aaec0 docs: fix the spell error add 36754fc Merge pull request #12674 from clChenLiang/master add 695375d fix(line): fix `symbolRotate` for `markLine` does not work. close apache#12388. add f949aeb fix(line): rotate by default if `symbolRotate` in `markLine` is not specified or NaN. add d4fb12a test(markLine): remove useless variables. add 7c3f189 Merge pull request #12392 from plainheart/fix-12388 add bb1d16e Merge pull request #12707 from apache/release add 184d935 fix(polor): polar bar negative clipping #12109 (#12418) add 9b793bc fix(markPoint): symbolRotate for markPoint does not work. add 19711a2 Merge pull request #12737 from plainheart/fix-12731 add 9a9d829 fix(sunburst): enables label formatter in levels #12223 add 15ee064 refactor(tree): remove level in tree data #12223 add 0a98ffb fix(treemap): remove levelItemStyles #12223 add dc3f7bd fix: fix treemap levels color does not work, which was brought by 55bd42dca1b7bb240895ea44396160acaa77694d in 4.8.0. Fix #12747. add 32a2c0c Merge pull request #12742 from apache/fix-12223 add cb9f6dc Merge pull request #7 from apache/master add 5ed2c9b Merge branch 'master' of https://github.com/apache/incubator-echarts add 0cb49f7 fix(bmap): remove Object.keys belongs to ES5. add 32961f6 Merge pull request #12780 from plainheart/fix-es5-in-bmap-extension add 40a6279 fix(radar): symbolRotate does not work for radar series. add 3bb072c Merge pull request #12695 from plainheart/fix-radar-symbolRotate add ad25fe5 Update comments to not use defualt add 5c1a5fb Merge pull request #12828 from xmatthias/replace_defualt_comments add a060cef Merge branch 'master' of https://github.com/apache/incubator-echarts into fix-geo-label-formatter add 17689f1 fix(geo): label formatter in geo works incorrectly, tweaks apache#10666 & apache#8612. add 1c39dbe fix(geo): use var but not literal. add 940b872 fix(geo): added default value for label status. add 300f75d Merge pull request #12762 from plainheart/fix-geo-label-formatter add d11b53e fix(tree): the symbols of image type do not display at the first rendering. close apache#12279. add df815b3 fix(tree): optimize code. add 6176bd2 fix(tree): tweak access way to the type of symbolEl. add 48d54d8 fix(tree): fix invalid opacity configuration for symbolPath. add 8631f27 Merge pull request #12367 from plainheart/fix-12279 add e73aab0 fix(title): incorrect redirect when sublink is clicked. add 6f78c0d Merge pull request #12842 from apache/fix-12841 add a9653ea ci: run on pr opened or synchronized add 4a84425 fix: #12812 add 1b0e756 docs(tooltip): fix the spell error add 1f31de3 Merge pull request #12834 from liulinboyi/fix-12812 add 1f90f1e feat(graph): graph support multiple edges, for #6811 add b2856b2 feat(graph): graph support mutil edge, for #6811 add d9c5d2f fix(tree): code rebuild follow the review suggest add 32a7062 fix(tree): code rebuild follow the review suggest #2 add 754bf60 fix(tree): code rebuild follow the review suggest #2 add 68eff58 fix(tree): code rebuild follow the review suggest #3 add eadceff fix(tree): code rebuild follow the review suggest #3 add a02f3f2 fix(tree): code rebuild follow the review suggest #4 add 601aa05 fix(tree): code rebuild follow the review suggest #5, add even test add fd25c1a fix(tree): code rebuild follow the review suggest #6 add baae12e Merge pull request #12590 from
[GitHub] [incubator-echarts] AmitBisht14 edited a comment on issue #9246: Continue Showing Same Tooltip On Dynamic Graph (Until Mouse Moves)
AmitBisht14 edited a comment on issue #9246: URL: https://github.com/apache/incubator-echarts/issues/9246#issuecomment-669148165 Is there any fix or workaround? I am also stuck with `tooltip.alwaysShowContent` solution suggested by @Ovilia but as @adamtLICOR said it blocks the hideTip action from getting dispatched. Thus looking for a discrete solution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] AmitBisht14 commented on issue #9246: Continue Showing Same Tooltip On Dynamic Graph (Until Mouse Moves)
AmitBisht14 commented on issue #9246: URL: https://github.com/apache/incubator-echarts/issues/9246#issuecomment-669148165 Is there any fix or workaround? I am also stuck with tooltip.alwaysShowContent solution suggested by @Ovilia but as @adamtLICOR said it blocks the hideTip action from getting dispatched. Thus looking for a discrete solution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] AmitBisht14 edited a comment on issue #9246: Continue Showing Same Tooltip On Dynamic Graph (Until Mouse Moves)
AmitBisht14 edited a comment on issue #9246: URL: https://github.com/apache/incubator-echarts/issues/9246#issuecomment-669148165 Is there any fix or workaround? I am also stuck with t`ooltip.alwaysShowContent` solution suggested by @Ovilia but as @adamtLICOR said it blocks the hideTip action from getting dispatched. Thus looking for a discrete solution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liyangyangi closed issue #12920: 希望直角坐标系新增单位字段显示在轴的顶部
liyangyangi closed issue #12920: URL: https://github.com/apache/incubator-echarts/issues/12920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #13049: On sunburst chart hand cursor shows clickable for already drilled down item - echarts-for-react
Ovilia commented on issue #13049: URL: https://github.com/apache/incubator-echarts/issues/13049#issuecomment-669134945 I don't think this is a bug. Hand cursor is used on all series items like this [bar example](https://echarts.apache.org/examples/en/editor.html?c=bar-background) which does not have drill down function. But if you wish to make a change, you should listen to mouseover event and check if this can drill down. See [events tutorial](https://echarts.apache.org/en/tutorial.html#Events%20and%20Actions%20in%20ECharts) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13077: Connect Functionality is not working for toolbox Options
echarts-bot[bot] commented on issue #13077: URL: https://github.com/apache/incubator-echarts/issues/13077#issuecomment-669131872 @JinyJose Please provide a demo for the issue either with https://codepen.io/Ovilia/pen/dyYWXWM or https://gallery.echartsjs.com/editor.html. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #13077: Connect Functionality is not working for toolbox Options
Ovilia commented on issue #13077: URL: https://github.com/apache/incubator-echarts/issues/13077#issuecomment-669131822 Please provide an online demo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #13074: 请问柱状图有办法每根柱子宽度不一样吗
Ovilia commented on issue #13074: URL: https://github.com/apache/incubator-echarts/issues/13074#issuecomment-669131025 请问是什么场景需要？自定义系列里面有个类似的 https://echarts.apache.org/examples/zh/editor.html?c=custom-profit 是不是能满足需求？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on issue #13076: graph模式，只有可视局域可拖拽，空白区域无法拖拽
Ovilia commented on issue #13076: URL: https://github.com/apache/incubator-echarts/issues/13076#issuecomment-669130602 这个问题和 #9239 相似，都是在图形包围盒外部的鼠标操作不会触发事件处理，应该改进一下 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang opened a new pull request #13078: Create release 4.9.0 branch
pissang opened a new pull request #13078: URL: https://github.com/apache/incubator-echarts/pull/13078 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13078: Create release 4.9.0 branch
echarts-bot[bot] commented on pull request #13078: URL: https://github.com/apache/incubator-echarts/pull/13078#issuecomment-669110696 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts-doc] branch next updated: doc: add option and tutorial of bar-race
This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch next
in repository https://gitbox.apache.org/repos/asf/incubator-echarts-doc.git
The following commit(s) were added to refs/heads/next by this push:
new f00cd12 doc: add option and tutorial of bar-race
f00cd12 is described below
commit f00cd1203b7605356994bc97fd531411dfe56fd4
Author: Ovilia
AuthorDate: Wed Aug 5 17:47:28 2020 +0800
doc: add option and tutorial of bar-race
---
en/option/component/x-axis.md | 13 +
en/option/component/y-axis.md | 14 ++
en/tutorial/bar-race.md | 24
en/tutorial/tutorial.md | 1 +
src/style/mixin.scss | 1 +
zh/option/component/x-axis.md | 12
zh/option/component/y-axis.md | 12
zh/tutorial/bar-race.md | 24
zh/tutorial/tutorial.md | 1 +
9 files changed, 102 insertions(+)
diff --git a/en/option/component/x-axis.md b/en/option/component/x-axis.md
index e9a49f0..615dfbd 100644
--- a/en/option/component/x-axis.md
+++ b/en/option/component/x-axis.md
@@ -32,6 +32,19 @@ The first x axis in grid defaults to be on the bottom of the
grid, and the secon
Offset of x axis relative to default position. Useful when multiple x axis has
same [position](~xAxis.position) value.
+## realtimeSort = false
+
+`realtimeSort` is used to enable bar race if set to be `true`. It is only
valid if the [type](~xAxis.type) of xAxis is `'value'`.
+
+It should be used along with other options to enable bar race. Please refer to
[bar race](tutorial.html#Bar%20Race) tutorial for more details.
+
+## sortSeriesIndex = 0
+
+The index of series used to sort in bar race. Since only one series is
supported in bar race, `sortSeriesIndex` should always be `0`. It is only valid
if [realtimeSort](~xAxis.realtimeSort) is `true` and [type](~xAxis.type) is
`'value'`.
+
+It should be used along with other options to enable bar race. Please refer to
[bar race](tutorial.html#Bar%20Race) tutorial for more details.
+
+
{{ use: axis-common(
prefix='#',
componentType='xAxis',
diff --git a/en/option/component/y-axis.md b/en/option/component/y-axis.md
index 529806b..88caf49 100644
--- a/en/option/component/y-axis.md
+++ b/en/option/component/y-axis.md
@@ -30,6 +30,20 @@ The first y axis in grid defaults to be the left (`'left'`)
of the grid, and th
Offset of y axis relative to default position. Useful when multiple y axis has
same [position](~yAxis.position) value.
+
+## realtimeSort = false
+
+`realtimeSort` is used to enable bar race if set to be `true`. It is only
valid if the [type](~yAxis.type) of yAxis is `'value'`.
+
+It should be used along with other options to enable bar race. Please refer to
[bar race](tutorial.html#Bar%20Race) tutorial for more details.
+
+## sortSeriesIndex = 0
+
+The index of series used to sort in bar race. Since only one series is
supported in bar race, `sortSeriesIndex` should always be `0`. It is only valid
if [realtimeSort](~yAxis.realtimeSort) is `true` and [type](~yAxis.type) is
`'value'`.
+
+It should be used along with other options to enable bar race. Please refer to
[bar race](tutorial.html#Bar%20Race) tutorial for more details.
+
+
{{ use: axis-common(
prefix='#',
componentType='yAxis',
diff --git a/en/tutorial/bar-race.md b/en/tutorial/bar-race.md
new file mode 100644
index 000..4e12bec
--- /dev/null
+++ b/en/tutorial/bar-race.md
@@ -0,0 +1,24 @@
+{{ target: bar-race }}
+
+# Bar Race
+
+Bar race is a chart that shows changes in the ranking of data over time and it
is supported by default sinde ECharts 5.
+
+> Bar race charts usually use horizontal bars. If you want to use vertical
bars, just take the X axis and Y axis in this tutorial to the opposite.
+
+1. Set `yAxis.realtimeSort` to be `true` to enable bar race
+2. Set `yAxis.inverse` to be `true` to display longer bars at top
+3. `yAxis.animationDuration` is suggested to be set to be `300` for bar
reordering animation for the first time
+4. `yAxis.animationDurationUpdate` is suggested to be set to be `300` for bar
reordering animation for later times
+5. Set `yAxis.max` to be *n - 1* where *n* is the number of bars to be
displayed; otherwise, all bars are displayed
+6. `xAxis.max` is suggested to be set to be `'dataMax'` so that the maximum of
data is used as X maximum.
+7. If realtime label changing is required, set `series.label.valueAnimation`
to be `true`
+8. Set `animationDuration` to be `0` so that the first animation doesn't start
from 0; if you wish otherwise, set it to be the same value as
`animationDurationUpdate`
+9. `animationDurationUpdate` is suggested to be set to be `3000` for animation
update duration, which should be the same as the frequency of calling
`setOption`
+10. Call `setOption` to update data to be of next time with `setInterval` at
the frequency of `animationDurationUpdate`
+
+A full example
[GitHub] [incubator-echarts] 100pah merged pull request #12754: feat(funnel): funnel chart support orient API
100pah merged pull request #12754: URL: https://github.com/apache/incubator-echarts/pull/12754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12754: feat(funnel): funnel chart support orient API
echarts-bot[bot] commented on pull request #12754: URL: https://github.com/apache/incubator-echarts/pull/12754#issuecomment-669074762 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah merged pull request #12022: fix(themeRiver): use layer key map rather then largestLayer #11948
100pah merged pull request #12022: URL: https://github.com/apache/incubator-echarts/pull/12022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12022: fix(themeRiver): use layer key map rather then largestLayer #11948
echarts-bot[bot] commented on pull request #12022: URL: https://github.com/apache/incubator-echarts/pull/12022#issuecomment-669054211 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch master updated (8d3291e -> ab3d9e4)
This is an automated email from the ASF dual-hosted git repository. sushuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 8d3291e Merge pull request #12669 from apache/fix-12591 new e5975d0 fix(themeRiver): use layer key map rather then largestLayer #11948 new f4a8bfb chore: performance new 65d726e fix: add hasOwnProperty for robustness. new ab3d9e4 Merge pull request #12022 from Zaynex/fix-themeriver The 5960 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/themeRiver/ThemeRiverSeries.js | 48 +- test/themeRiver3.html| 154 +++ 2 files changed, 175 insertions(+), 27 deletions(-) create mode 100644 test/themeRiver3.html - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch next updated (894113d -> 6ffe4ee)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 894113d fix(bmap): disable transition animaiton in bmap roam new a253580 Optimize: disable tooltip transition at first show new 3497bd0 Merge branch 'next' into toolitip new 7f9fa7c Remove uncessary logic new 9ffd825 Coorection base CR new 24a60d4 Merge branch 'toolitip' of https://github.com/susiwen8/incubator-echarts into toolitip new 65070f1 Replace 'includes' by 'zrUtils.indexOf' new 6ffe4ee Merge pull request #13067 from susiwen8/toolitip The 6509 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/component/tooltip/TooltipHTMLContent.ts | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13067: Optimize: disable tooltip transition at first show
echarts-bot[bot] commented on pull request #13067: URL: https://github.com/apache/incubator-echarts/pull/13067#issuecomment-669036390 Congratulations! Your PR has been merged. Thanks for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #13067: Optimize: disable tooltip transition at first show
pissang merged pull request #13067: URL: https://github.com/apache/incubator-echarts/pull/13067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #13067: Optimize: disable tooltip transition at first show
susiwen8 edited a comment on pull request #13067: URL: https://github.com/apache/incubator-echarts/pull/13067#issuecomment-669033507 > Hi @susiwen8. Just a suggestion that we should use more clear commits message. For example https://www.conventionalcommits.org/en/v1.0.0-beta.4/#summary > > It's not a good style to use a very general and unclear message like "Coorection base CR" Roger that :stuck_out_tongue: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #13067: Optimize: disable tooltip transition at first show
susiwen8 commented on pull request #13067: URL: https://github.com/apache/incubator-echarts/pull/13067#issuecomment-669033507 > Hi @susiwen8. Just a suggestion that we should use more clear commits message. For example https://www.conventionalcommits.org/en/v1.0.0-beta.4/#summary > > It's not a good style to use a very general and unclear message like "Coorection base CR" Roger that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #13067: Optimize: disable tooltip transition at first show
pissang commented on pull request #13067: URL: https://github.com/apache/incubator-echarts/pull/13067#issuecomment-669028682 Hi @susiwen8. Just a suggestion that we should use more clear commits message. For example https://www.conventionalcommits.org/en/v1.0.0-beta.4/#summary It's not a good style to use a very general and unclear message like "Coorection base CR" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13067: Optimize: disable tooltip transition at first show
pissang commented on a change in pull request #13067:
URL:
https://github.com/apache/incubator-echarts/pull/13067#discussion_r465523577
##
File path: src/component/tooltip/TooltipHTMLContent.ts
##
@@ -153,7 +151,7 @@ function assembleCssText(tooltipModel:
Model) {
cssText.push('box-shadow:' + boxShadow);
// Animation transition. Do not animate when transitionDuration is 0.
// If tooltip show arrow, then disable transition
-transitionDuration
+!isFirstShow && transitionDuration
&& !(['top', 'left', 'bottom',
'right'].includes(tooltipModel.get('position') as string))
&& tooltipModel.get('trigger') !== 'item'
Review comment:
Didn't notice it before. But we should use `zrUtil.indexOf` instead of
`includes` here.
Also in the `assembleArrow` function also has `includes` usage. Which should
be changed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on a change in pull request #13067: Optimize: disable tooltip transition at first show
susiwen8 commented on a change in pull request #13067:
URL:
https://github.com/apache/incubator-echarts/pull/13067#discussion_r465501888
##
File path: src/component/tooltip/TooltipHTMLContent.ts
##
@@ -355,6 +354,7 @@ class TooltipHTMLContent {
el.style.pointerEvents = this._enterable ? 'auto' : 'none';
this._show = true;
+this._firstShow && (this._firstShow = false);
Review comment:
Force of habbit :smile
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on a change in pull request #13067: Optimize: disable tooltip transition at first show
pissang commented on a change in pull request #13067:
URL:
https://github.com/apache/incubator-echarts/pull/13067#discussion_r465497344
##
File path: src/component/tooltip/TooltipHTMLContent.ts
##
@@ -355,6 +354,7 @@ class TooltipHTMLContent {
el.style.pointerEvents = this._enterable ? 'auto' : 'none';
this._show = true;
+this._firstShow && (this._firstShow = false);
Review comment:
I think this condition is not necessary. The expression can be simply
```js
this._show = true;
this._firstShow = false;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
