[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
Ovilia commented on a change in pull request #11186: FIX #11176
xAxis.axisTick.interval appears different between echart4 and echart3.8
URL:
https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340512
##
File path: src/coord/Axis.js
##
@@ -301,12 +303,16 @@ function fixOnBandTicksCoords(axis, ticksCoords,
tickCategoryInterval, alignWith
var axisExtent = axis.getExtent();
var last;
+var diffSize;
if (ticksLen === 1) {
ticksCoords[0].coord = axisExtent[0];
last = ticksCoords[1] = {coord: axisExtent[0]};
}
else {
-var shift = (ticksCoords[1].coord - ticksCoords[0].coord);
+
+var crossLen = ticksCoords[ticksLen-1].tickValue -
ticksCoords[0].tickValue;
Review comment:
Space is required around `-`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8 URL: https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340650 ## File path: test/axis-interval.html ## @@ -338,6 +337,67 @@ [ Test time axis interval ] should not overlap when data z
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
Ovilia commented on a change in pull request #11186: FIX #11176
xAxis.axisTick.interval appears different between echart4 and echart3.8
URL:
https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340437
##
File path: src/coord/Axis.js
##
@@ -292,7 +294,7 @@ function fixExtentWithBands(extent, nTick) {
// splitLine/spliteArea should layout appropriately corresponding
// to displayed labels. (So we should not use `getBandWidth` in this
// case).
-function fixOnBandTicksCoords(axis, ticksCoords, tickCategoryInterval,
alignWithLabel, clamp) {
+function fixOnBandTicksCoords(axis, ticksCoords, tickCategoryInterval,
alignWithLabel, clamp,tickLen) {
Review comment:
Space is required before `tickLen`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
Ovilia commented on a change in pull request #11186: FIX #11176
xAxis.axisTick.interval appears different between echart4 and echart3.8
URL:
https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340414
##
File path: src/coord/Axis.js
##
@@ -198,8 +197,11 @@ Axis.prototype = {
}, this);
var alignWithLabel = tickModel.get('alignWithLabel');
+var dataExtent = this.scale.getExtent();
+var tickLen = this.scale.getTicks().length + dataExtent[0];
+
fixOnBandTicksCoords(
-this, ticksCoords, result.tickCategoryInterval, alignWithLabel,
opt.clamp
+this, ticksCoords, result.tickCategoryInterval, alignWithLabel,
opt.clamp,tickLen
Review comment:
Space is required before `tickLen`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8
Ovilia commented on a change in pull request #11186: FIX #11176 xAxis.axisTick.interval appears different between echart4 and echart3.8 URL: https://github.com/apache/incubator-echarts/pull/11186#discussion_r336340746 ## File path: test/axis-interval.html ## @@ -338,6 +337,67 @@ [ Test time axis interval ] should not overlap when data z
