[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-699704516 thanks @pissang would you like to submit a PR to the uPlot repo for the implementation improvements as well as bumping the echarts lib when the next alpha or beta of 5.0 is tagged and available via jsDelivr CDN? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695890304 thanks for the detailed reply. i agree that exceeding the local extremes is a worse outcome than a more "S" shaped creative interpolation between datapoints. overall, i hate smoothed charts since they trade data clarity for a stylistic choice. similar to stacked area/trendlines. i wish people would simply stop using these types of misleading charts. hopefully by not supporting these in uPlot i help a little to accelerate their demise :) i've tried feeding typed arrays to uPlot in the past and surprisingly did not measure a difference in performance. i'll take a closer look in a few days at your improvement to the uPlot bench, but i was surprised that typed arrays made a significant difference for you. maybe i should look into it again. out of curiosity, does echarts handle data gaps by default or is this an additional setting? in uPlot adding null-testing per-datapoint adds ~20% overhead to the bench in both, dataset min/max finding as well as path drawing. i decided it was an okay trade-off instead of bloating the code and maintaining slightly different dedicated loops for gap-less data. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695785582 > I'm not sure if you did any modification on the original Catmull-Rom Spline algorithm. i simply adjusted the algo for the uPlot demo from this gist: https://github.com/leeoniya/uPlot/blob/master/demos/line-smoothing.html#L49 i don't think the version i'm using would behave as your posted image given the very few and sparse datapoints which are visible. can you try the same dataset in the uPlot demo and see how that looks? (sorry i'm on holiday and on phone, so cannot test it for a while). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695746133 also, your smoothing does not represent the data well. take a look at using the Catmull-Rom Spline (Centripetal) algo: https://leeoniya.github.io/uPlot/demos/line-smoothing.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] leeoniya commented on pull request #13314: [5.0] [Performance] Improve large line performance. Improve line smoothing.
leeoniya commented on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695745867 wow, this is super exciting. can't wait to test this improvement on the uPlot benchmark! https://github.com/leeoniya/uPlot#performance a 10x improvement would move echarts to second place. would you mind reviewing my implementation to make sure i'm using the library correctly, and also let me know when this will be available to test in a linkable build? https://github.com/leeoniya/uPlot/blob/master/bench/ECharts.html cheers! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
