[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647934695 > Seems there are still two request changes from @plainheart @susiwen8 need to be resolved before this PR can ben merged @pissang All request changes are done. Can i fix other files spell error? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647916698 > Perhaps the `_moveTooltip` can be renamed to a more specific name like `_moveTooltipIfResized` > > Others all look good to me. Thanks for the wonderful work! @liulinboyi @plainheart Thank you for your guidance. @pissang I have fix some spell error and the _moveTooltip was renamed, Please help review, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647901046 > Perhaps the `_moveTooltip` can be renamed to a more specific name like `_moveTooltipIfResized` > > Others all look good to me. Thanks for the wonderful work! @liulinboyi @plainheart Ok, no problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647495244 > @liulinboyi Would you mind providing a test case for this? @plainheart Test case is done, Please help review, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647399422 > @liulinboyi Would you mind providing a test case for this? Let me have a try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647362101 > Finally, the same changes should be applied to `TooltipRichContent`, which will be used when [`renderMode`](https://echarts.apache.org/en/option.html#tooltip.renderMode) is `richText`. @plainheart Thank you for your guidance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647333159 > Finally, the same changes should be applied to `TooltipRichContent`, which will be used when [`renderMode`](https://echarts.apache.org/en/option.html#tooltip.renderMode) is `richText`. @plainheart All the problems are solved, Please help review, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647288842 @plainheart All the problems are solved, Please help review, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647268371 > Why hide tooltip rather than relocate it to the proper coordinate? > And I think doing it here is a bit inappropriate. @plainheart The effect is as follows，Please help review, thanks!  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] liulinboyi commented on pull request #12834: fix: #12812
liulinboyi commented on pull request #12834: URL: https://github.com/apache/incubator-echarts/pull/12834#issuecomment-647263289 > Why hide tooltip rather than relocate it to the proper coordinate? > And I think doing it here is a bit inappropriate. Let me have a try. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
