[GitHub] [incubator-echarts] pissang commented on pull request #12702: feat(datastack):stack support positive add negative, close 12699

2020-05-28 Thread GitBox


pissang commented on pull request #12702:
URL: 
https://github.com/apache/incubator-echarts/pull/12702#issuecomment-635220070


   @wf123537200 I think it can be an option related to `stack`. Like 
`stackDifferentSign`(I just think of it. Perhaps there is a better name.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org



[GitHub] [incubator-echarts] pissang commented on pull request #12702: feat(datastack):stack support positive add negative, close 12699

2020-05-27 Thread GitBox


pissang commented on pull request #12702:
URL: 
https://github.com/apache/incubator-echarts/pull/12702#issuecomment-635048349


   Thanks for the contribution @wf123537200 !
   
   Separated stacking on positive and negative values is by design.
   If necessary, we can make it configurable to support stacking positive 
values on negative values.
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org